Page MenuHomePhabricator

[Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling
Needs ReviewPublic

Authored by djtodoro on Mon, Feb 11, 3:45 AM.

Details

Summary

Handle DBG_CALLSITE and DBG_CALLSITEPARAM meta instructions through backend pipeline. It partially relies on the way DBG_VALUE is handled.

Authors: @asowda, @NikolaPrica, @djtodoro, @ivanbaev

Diff Detail

Event Timeline

djtodoro created this revision.Mon, Feb 11, 3:45 AM
djtodoro added a project: debug-info.
djtodoro added a subscriber: petarj.
bjope added a subscriber: bjope.Wed, Feb 13, 2:40 AM
djtodoro updated this revision to Diff 186612.Wed, Feb 13, 2:44 AM
  • Rename: VariableNotChanged ===> ArgumentNotModified
  • Refactor test cases
dstenb added a subscriber: dstenb.Wed, Feb 13, 3:06 AM
dstenb added inline comments.
lib/CodeGen/StackColoring.cpp
963

The iterator does seem to be invalidated here (or am I overlooking something?), so you should be able to use BB.instrs() here instead.

lib/CodeGen/StackSlotColoring.cpp
375

MBB.instrs()

dstenb added inline comments.Wed, Feb 13, 3:07 AM
lib/CodeGen/StackColoring.cpp
963

Gah, "does _not_".

djtodoro marked 2 inline comments as done.Wed, Feb 13, 4:54 AM

@dstenb Thanks for comments!

lib/CodeGen/StackColoring.cpp
963

Yes.

lib/CodeGen/StackSlotColoring.cpp
375

As well as above.

djtodoro updated this revision to Diff 186626.Wed, Feb 13, 4:55 AM
  • Use MBB.instrs()