- User Since
- Jun 10 2016, 1:55 AM (144 w, 5 d)
Mon, Mar 18
Wed, Mar 13
Move lambda expression back into assert() to avoid -Wunused-variable warning in non-assert builds.
Thu, Mar 7
Thanks for the review! I'll submit this shortly then.
Wed, Mar 6
Tue, Mar 5
Fri, Mar 1
Wed, Feb 27
Tue, Feb 26
Feb 18 2019
Feb 14 2019
Feb 13 2019
Feb 12 2019
Thanks for the reviews! Unless there are any more comments, I'm planning on merging this tomorrow or Thursday.
Feb 11 2019
Thanks for the reviews! I'm intending on landing this tomorrow.
Feb 8 2019
How should DW_OP_convert be handled when targeting DWARF versions earlier than 5? There is the GNU extension DW_OP_GNU_convert, which GDB seems to have had support for since 2011. The operation seems to be the identical to the final version that got into DWARFv5, so LLDB should be able to handle the two variants transparently. Can we emit that GNU extension (under some limitations)?
Update after comment.
Sorry for not noticing this before, but we noticed now that the test case is placed under test/CodeGen/X86/, although it is a simplifycfg test. Should it ideally be placed under test/Transforms/SimplifyCFG/?
Feb 7 2019
I have changed the patch so that it still changes the labels for non-register debug values. This is done to reduce the regressions. I have not been able to find a C program where moving a constant-described value results in false positives. I will write a PR about getting SelectionDAG to emit debug values for constant arguments directly at the start of the function, which hopefully should make it possible to remove the rest of beginFunction() without as many regressions.
Feb 6 2019
Amend comment for stashEntryDbgValues().
Feb 5 2019
Add -mtriple to RUN line.
Feb 4 2019
I have divided this into three measurements:
Feb 1 2019
Jan 31 2019
Maybe it can be good to rename the test file to either the PR number, or something that says what it verifies? The "bbi-" number refer to one Ericsson's internal issue trackers, so it maybe not very useful here
Jan 24 2019
Jan 9 2019
Jan 8 2019
This looks good to me, but I don't think I can give an official L-G-T-M.
Jan 7 2019
Dec 20 2018
Dec 17 2018
Dec 14 2018
I do not find the test file on trunk. Also, git log -- test/Transforms/Util/dbg-user-of-aext.ll in the git mirror does not yield anything, so it seems like the file has not previously existed either.
With this patch applied we don't see any issues on our end. Thanks for the help!
Dec 11 2018
Dec 10 2018
Thanks for the reviews! I'm planning on submitting this shortly then.
Dec 4 2018
Nov 26 2018
Nov 15 2018
Nov 12 2018
Add another non-metadata user of @global_arr to the test case so that the verification of the global's use-list order fails when running without this patch. Also generalize the comment in the test case.
Nov 8 2018
In the previous revision I had overlooked two things in the writers:
Nov 2 2018
Thanks for your reviews and suggestions! I'm planning on submitting this shortly.
Nov 1 2018
Does anyone more than @vsk have any thoughts on this?
Oct 31 2018
Oct 26 2018
I thought I had built up some confidence for this after a night of fuzz testing. However, first after creating this review I encountered a crash in the LL parser, which happened due to the use-list order containing too many elements with this patch.
Oct 16 2018
Sorry, I can likely not give any valuable input for this review.
Oct 15 2018
Thanks for the reviews! I'm planning on submitting this shortly.
Oct 12 2018
Move DbgValues and the findDbgValues() call closer to the use.
Oct 11 2018
Any thoughts on this?
Oct 1 2018
- Changed so that getCalledFunction() allows null valued operands.
- Rewrote the test case to a unit test.
Sep 27 2018
It would be good to change the title to reflect what is done in MCP (at least before submitting this).
Sep 26 2018
Sep 7 2018
Sep 6 2018
Thanks for the review! I'll submit this tomorrow when I have time to track the build bots.
Sep 5 2018
Removed unnecessary !dbg locations in the test. I also moved the file to test/DebugInfo/.