Page MenuHomePhabricator

dstenb (David Stenberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2016, 1:55 AM (136 w, 5 d)

Recent Activity

Wed, Jan 9

dstenb committed rL350698: [DebugInfo] Omit location list entries with empty ranges.
[DebugInfo] Omit location list entries with empty ranges
Wed, Jan 9, 2:02 AM
dstenb closed D55919: [DebugInfo] Omit location list entries with empty ranges.
Wed, Jan 9, 2:02 AM · debug-info

Tue, Jan 8

dstenb added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

This looks good to me, but I don't think I can give an official L-G-T-M.

Tue, Jan 8, 7:58 AM · debug-info
dstenb added inline comments to D55919: [DebugInfo] Omit location list entries with empty ranges.
Tue, Jan 8, 7:50 AM · debug-info

Mon, Jan 7

dstenb added inline comments to D55919: [DebugInfo] Omit location list entries with empty ranges.
Mon, Jan 7, 6:50 AM · debug-info

Dec 20 2018

dstenb created D55919: [DebugInfo] Omit location list entries with empty ranges.
Dec 20 2018, 2:51 AM · debug-info

Dec 17 2018

dstenb added inline comments to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Dec 17 2018, 1:23 AM · debug-info

Dec 14 2018

dstenb added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

I do not find the test file on trunk. Also, git log -- test/Transforms/Util/dbg-user-of-aext.ll in the git mirror does not yield anything, so it seems like the file has not previously existed either.

Is it perhaps something that is only available downstream, or am I overlooking something?

Dec 14 2018, 7:39 AM · debug-info
dstenb added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

I do not find the test file on trunk. Also, git log -- test/Transforms/Util/dbg-user-of-aext.ll in the git mirror does not yield anything, so it seems like the file has not previously existed either.

Dec 14 2018, 7:21 AM · debug-info
dstenb added a comment to D55702: [clangd] Fix memory leak in ClangdTests..

With this patch applied we don't see any issues on our end. Thanks for the help!

Dec 14 2018, 4:44 AM

Dec 11 2018

dstenb committed rL348837: [DeadArgElim] Fixes for dbg.values using dead arg/return values.
[DeadArgElim] Fixes for dbg.values using dead arg/return values
Dec 11 2018, 2:36 AM
dstenb closed D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.
Dec 11 2018, 2:36 AM · debug-info

Dec 10 2018

dstenb added a comment to D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.

Thanks for the reviews! I'm planning on submitting this shortly then.

Dec 10 2018, 11:55 PM · debug-info
dstenb created D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.
Dec 10 2018, 7:56 AM · debug-info

Dec 4 2018

dstenb added inline comments to D55227: [DebugInfo] Don't drop dbg.value's of nullptr.
Dec 4 2018, 12:18 AM

Nov 26 2018

dstenb added a comment to D53758: Handle value uses wrapped in metadata for the use-list order.

Ping.

Nov 26 2018, 12:45 AM

Nov 15 2018

dstenb added inline comments to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 15 2018, 4:16 AM · debug-info

Nov 12 2018

dstenb updated the diff for D53758: Handle value uses wrapped in metadata for the use-list order.

Add another non-metadata user of @global_arr to the test case so that the verification of the global's use-list order fails when running without this patch. Also generalize the comment in the test case.

Nov 12 2018, 3:31 AM
dstenb added inline comments to D53758: Handle value uses wrapped in metadata for the use-list order.
Nov 12 2018, 1:18 AM

Nov 8 2018

dstenb updated the diff for D53758: Handle value uses wrapped in metadata for the use-list order.

In the previous revision I had overlooked two things in the writers:

Nov 8 2018, 6:18 AM

Nov 2 2018

dstenb committed rL345966: Allow null-valued function operands in getCalledFunction().
Allow null-valued function operands in getCalledFunction()
Nov 2 2018, 4:48 AM
dstenb closed D52537: Allow null-valued function operands in getCalledFunction().
Nov 2 2018, 4:48 AM
dstenb added a comment to D52537: Allow null-valued function operands in getCalledFunction().

Thanks for your reviews and suggestions! I'm planning on submitting this shortly.

Nov 2 2018, 1:22 AM

Nov 1 2018

dstenb added a comment to D52537: Allow null-valued function operands in getCalledFunction().

Does anyone more than @vsk have any thoughts on this?

Nov 1 2018, 3:38 AM

Oct 31 2018

dstenb added a watcher for debug-info: dstenb.
Oct 31 2018, 7:22 AM

Oct 26 2018

dstenb added a comment to D53758: Handle value uses wrapped in metadata for the use-list order.

I thought I had built up some confidence for this after a night of fuzz testing. However, first after creating this review I encountered a crash in the LL parser, which happened due to the use-list order containing too many elements with this patch.

Oct 26 2018, 7:10 AM
dstenb created D53758: Handle value uses wrapped in metadata for the use-list order.
Oct 26 2018, 6:05 AM

Oct 16 2018

dstenb resigned from D50377: [LICM] Use ICFLoopSafetyInfo in LICM.

Sorry, I can likely not give any valuable input for this review.

Oct 16 2018, 5:25 AM
dstenb committed rL344589: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.
[DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop
Oct 16 2018, 1:09 AM
dstenb closed D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.
Oct 16 2018, 1:09 AM

Oct 15 2018

dstenb added a comment to D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.

Thanks for the reviews! I'm planning on submitting this shortly.

Oct 15 2018, 1:05 AM

Oct 12 2018

dstenb added inline comments to D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.
Oct 12 2018, 6:19 AM
dstenb updated the diff for D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.

Move DbgValues and the findDbgValues() call closer to the use.

Oct 12 2018, 6:12 AM

Oct 11 2018

dstenb added a comment to D52537: Allow null-valued function operands in getCalledFunction().

Any thoughts on this?

Oct 11 2018, 7:46 AM
dstenb created D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.
Oct 11 2018, 2:10 AM

Oct 1 2018

dstenb added a comment to D52537: Allow null-valued function operands in getCalledFunction().
In D52537#1246683, @vsk wrote:

As for the test, I think a unit test might work better (see unittests/IR/MetadataTest.cpp). If something about debug info or BDCE changes, the test will remain useful.

Oct 1 2018, 7:13 AM
dstenb updated the diff for D52537: Allow null-valued function operands in getCalledFunction().
  • Changed so that getCalledFunction() allows null valued operands.
  • Rewrote the test case to a unit test.
Oct 1 2018, 7:05 AM

Sep 27 2018

dstenb added a comment to D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..

It would be good to change the title to reflect what is done in MCP (at least before submitting this).

Sep 27 2018, 8:39 AM · debug-info

Sep 26 2018

dstenb created D52537: Allow null-valued function operands in getCalledFunction().
Sep 26 2018, 2:09 AM

Sep 7 2018

dstenb committed rL341659: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.
[DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV
Sep 7 2018, 6:55 AM
dstenb closed D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.
Sep 7 2018, 6:55 AM · debug-info

Sep 6 2018

dstenb added a comment to D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.

Thanks for the review! I'll submit this tomorrow when I have time to track the build bots.

Sep 6 2018, 6:41 AM · debug-info

Sep 5 2018

dstenb added inline comments to D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.
Sep 5 2018, 1:27 AM · debug-info
dstenb updated the diff for D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.

Removed unnecessary !dbg locations in the test. I also moved the file to test/DebugInfo/.

Sep 5 2018, 1:27 AM · debug-info
dstenb added a comment to D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.

The best place to do the simplification / constant-folding in the DIExpresssion is in DwarfExpression.cpp, just before it gets emitted.

Sep 5 2018, 1:22 AM · debug-info

Sep 4 2018

dstenb created D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.
Sep 4 2018, 2:03 AM · debug-info

Jul 6 2018

dstenb resigned from D48979: AMDGPU: Fix UBSan error caused by r335942.

I don't really know anything about the AMDGPU target, so I'll resign as reviewer to make that clear, but thanks for notifying me about the fix!

Jul 6 2018, 6:38 AM

Jul 5 2018

dstenb added a comment to D46365: AMDGPU: Separate R600 and GCN TableGen files.

Hi! We encountered a UBSan runtime error after this was merged. I wrote a bug report about it: https://bugs.llvm.org/show_bug.cgi?id=38071.

Jul 5 2018, 8:00 AM

Jul 2 2018

dstenb committed rL336109: [CodeGen] Make block removal order deterministic in CodeGenPrepare.
[CodeGen] Make block removal order deterministic in CodeGenPrepare
Jul 2 2018, 7:28 AM
dstenb closed D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.
Jul 2 2018, 7:28 AM
dstenb added a comment to D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.

Thanks for the reviews!

Jul 2 2018, 5:32 AM

Jun 27 2018

dstenb updated the diff for D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.

Use pop_back_val() for getting the items from the worklist.

Jun 27 2018, 1:23 AM
dstenb added inline comments to D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.
Jun 27 2018, 1:22 AM

Jun 20 2018

dstenb created D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.
Jun 20 2018, 8:06 AM

May 31 2018

dstenb committed rCTE333637: [Driver] Clean up tmp files when deleting Compilation objects.
[Driver] Clean up tmp files when deleting Compilation objects
May 31 2018, 2:10 AM
dstenb committed rL333637: [Driver] Clean up tmp files when deleting Compilation objects.
[Driver] Clean up tmp files when deleting Compilation objects
May 31 2018, 2:09 AM
dstenb committed rC333637: [Driver] Clean up tmp files when deleting Compilation objects.
[Driver] Clean up tmp files when deleting Compilation objects
May 31 2018, 2:09 AM
dstenb closed D45686: [Driver] Clean up tmp files when deleting Compilation objects.
May 31 2018, 2:09 AM

May 30 2018

dstenb added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Any more comments or concerns, or can I land this?

May 30 2018, 12:53 AM

May 29 2018

dstenb committed rC333413: Fix emission of phony dependency targets when adding extra deps.
Fix emission of phony dependency targets when adding extra deps
May 29 2018, 6:12 AM
dstenb committed rL333413: Fix emission of phony dependency targets when adding extra deps.
Fix emission of phony dependency targets when adding extra deps
May 29 2018, 6:12 AM
dstenb closed D44568: Fix emission of phony dependency targets when adding extra deps.
May 29 2018, 6:12 AM
dstenb closed D44568: Fix emission of phony dependency targets when adding extra deps.
May 29 2018, 6:12 AM
dstenb added a comment to D44568: Fix emission of phony dependency targets when adding extra deps.

Looks good to me. Just watch the build bots in case some of them are strict with warnings and require (void)AddFilename(Filename).

May 29 2018, 5:56 AM

May 28 2018

dstenb added inline comments to D44568: Fix emission of phony dependency targets when adding extra deps.
May 28 2018, 8:19 AM
dstenb updated the diff for D44568: Fix emission of phony dependency targets when adding extra deps.

Addressed vsapsai's comments.

May 28 2018, 8:17 AM
dstenb abandoned D47251: Add a lit reproducer for PR37091.

Merged into D45686.

May 28 2018, 1:34 AM
dstenb updated the diff for D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Update patch to include the clang-tools-extra test case originally added in D47251.

May 28 2018, 1:33 AM

May 25 2018

dstenb updated the diff for D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Query TheDriver.isSaveTempsEnabled() at uses instead of storing the value in the constructor.

May 25 2018, 7:25 AM
dstenb added inline comments to D45686: [Driver] Clean up tmp files when deleting Compilation objects.
May 25 2018, 6:26 AM
dstenb committed rL333274: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().
[MustExecute] Fix a debug invariant issue in isGuaranteedToExecute()
May 25 2018, 6:07 AM
dstenb closed D47197: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().
May 25 2018, 6:06 AM
dstenb updated the diff for D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Renamed SaveTempsEnabled field to KeepTempFiles.

May 25 2018, 6:02 AM
dstenb updated the diff for D45686: [Driver] Clean up tmp files when deleting Compilation objects.

I have now updated the patch so that the files are removed when deleting Compilation objects.

May 25 2018, 3:45 AM

May 24 2018

dstenb added a comment to D47197: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().

Thanks for the review! I'll submit this tomorrow when I have time for the build bots.

May 24 2018, 7:57 AM

May 23 2018

dstenb added inline comments to D45686: [Driver] Clean up tmp files when deleting Compilation objects.
May 23 2018, 7:32 AM
dstenb added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

We have added a lit reproducer for this now in clang-tools-extra: https://reviews.llvm.org/D47251.

May 23 2018, 4:23 AM
dstenb added a parent revision for D47251: Add a lit reproducer for PR37091: D45686: [Driver] Clean up tmp files when deleting Compilation objects.
May 23 2018, 4:22 AM
dstenb added a child revision for D45686: [Driver] Clean up tmp files when deleting Compilation objects: D47251: Add a lit reproducer for PR37091.
May 23 2018, 4:22 AM
dstenb created D47251: Add a lit reproducer for PR37091.
May 23 2018, 4:21 AM

May 22 2018

dstenb retitled D47197: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute() from [LICM] Fix a debug invariant issue in isGuaranteedToExecute() to [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().
May 22 2018, 11:35 PM
dstenb created D47197: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().
May 22 2018, 7:34 AM

May 18 2018

dstenb committed rL332698: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().
[SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest()
May 18 2018, 1:56 AM
dstenb closed D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().
May 18 2018, 1:56 AM
dstenb added a comment to D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().

Thanks for the reviews! I'll submit this shortly.

May 18 2018, 12:26 AM

May 17 2018

dstenb added a comment to D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().

Any more comments on this?

May 17 2018, 12:29 AM

May 10 2018

dstenb updated the diff for D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().

Addressed comments!

May 10 2018, 4:58 AM
dstenb added inline comments to D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().
May 10 2018, 3:32 AM

May 9 2018

dstenb added reviewers for D44568: Fix emission of phony dependency targets when adding extra deps: bruno, vsapsai.

@bruno, @vsapsai: I added you since you I saw that you recently reviewed, respectively delivered, D30881. That is the only DependencyFile commit since October; although, this feels a bit orthogonal from that, so feel free to remove yourselves as reviewers (and I'm sorry for adding you in that case)!

May 9 2018, 5:20 AM
dstenb added a comment to D44568: Fix emission of phony dependency targets when adding extra deps.

Ping.

May 9 2018, 4:56 AM
dstenb created D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().
May 9 2018, 4:22 AM

Apr 25 2018

dstenb added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Ping. It feels a bit nasty that the tools leave behind temporary files, so I think that it would be good to find a fix for that.

Apr 25 2018, 1:25 AM

Apr 18 2018

Herald updated subscribers of D42848: Correct dwarf unwind information in function epilogue.
Apr 18 2018, 7:39 AM

Apr 16 2018

dstenb created D45686: [Driver] Clean up tmp files when deleting Compilation objects.
Apr 16 2018, 7:17 AM
dstenb added a comment to D44568: Fix emission of phony dependency targets when adding extra deps.

Ping.

Apr 16 2018, 4:54 AM

Apr 11 2018

dstenb added a comment to D36827: Changed createTemporaryFile without FD to actually create a file..

Hi! We have encountered a regression where clang-tidy leaves behind temporary files after this change. I wrote a PR for that: https://bugs.llvm.org/show_bug.cgi?id=37091.

Apr 11 2018, 10:04 AM

Mar 28 2018

dstenb added a comment to D44774: [Driver] Allow use of -fsyntax-only together with -MJ.

Our legacy frontend does not support -MJ, so when using that frontend for code generation, we also invoke clang with -MJ, and at the same use -fsyntax-only to get the improved diagnostics that clang provides. This is idiosyncratic and probably hacky, I know, but it works well enough to for example for getting access to defines and include flags from the compilation database, and being able to run clang-tidy. So (1) does not fit our use case, unfortunately.

Mar 28 2018, 7:22 AM
dstenb added a comment to D44054: [DWARFv5] Emit file 0 to the line table..

With this change, we will emit the .file 0 directive even for -gdwarf-[234]. The directive results in an error when assembling with GAS. Should this be seen as a problem, or is it something that we accept?

Mar 28 2018, 6:25 AM · debug-info

Mar 26 2018

dstenb added a comment to D44774: [Driver] Allow use of -fsyntax-only together with -MJ.

Downstream we use -MJ in a bit of an idiosyncratic way, as we're in a transition period where we, for a subset of the code base, only use the clang frontend for diagnostics, and not for the code generation. However, if you don't think that using -fsyntax-only and -MJ makes sense in any upstream application, I'll drop from this change. I'm leaving the assertion as-is.

Mar 26 2018, 7:22 AM

Mar 22 2018

dstenb created D44774: [Driver] Allow use of -fsyntax-only together with -MJ.
Mar 22 2018, 3:19 AM