Page MenuHomePhabricator

dstenb (David Stenberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2016, 1:55 AM (199 w, 4 d)

Recent Activity

Today

dstenb added inline comments to D77639: [DebugInfo][NFC] Early-exit when analysing for single-location variables.
Tue, Apr 7, 1:03 PM · Restricted Project
dstenb accepted D77639: [DebugInfo][NFC] Early-exit when analysing for single-location variables.

Two minor nits, but otherwise this looks good to me. Thanks!

Tue, Apr 7, 9:45 AM · Restricted Project
dstenb added a comment to D77639: [DebugInfo][NFC] Early-exit when analysing for single-location variables.

Adding a nit. I'll try to take a closer look at the functionality later today.

Tue, Apr 7, 6:28 AM · Restricted Project

Fri, Mar 27

dstenb added inline comments to D76878: Implement new DW_OP_LLVM_* operations.
Fri, Mar 27, 7:03 AM · debug-info, Restricted Project

Thu, Mar 19

dstenb added a comment to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).

Yeah, sure! I can put together a mail for the mailing list today or tomorrow.

Thu, Mar 19, 10:17 AM · debug-info, Restricted Project
dstenb added a parent revision for D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation: D76423: [DebugInfo] Make base type placeholder values larger than 0.
Thu, Mar 19, 3:44 AM · Restricted Project, debug-info
dstenb updated the diff for D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation.

Rebase on top of D76423. Add a test that verifies that the operation is emitted correctly in location lists. Without D76423 this patch would simply emit a DW_OP_convert with the first base type in ExprRefedBaseTypes, rather than 0x0.

Thu, Mar 19, 3:44 AM · Restricted Project, debug-info
dstenb added a comment to D76423: [DebugInfo] Make base type placeholder values larger than 0.

This was something I overlooked when implementing D76145.

Thu, Mar 19, 3:44 AM · Restricted Project, debug-info
dstenb added a child revision for D76423: [DebugInfo] Make base type placeholder values larger than 0: D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation.
Thu, Mar 19, 3:44 AM · Restricted Project, debug-info
dstenb created D76423: [DebugInfo] Make base type placeholder values larger than 0.
Thu, Mar 19, 3:44 AM · Restricted Project, debug-info

Wed, Mar 18

dstenb committed rGa0a3a9c5a831: [DebugInfo] Fix multi-byte entry values in call site values (authored by dstenb).
[DebugInfo] Fix multi-byte entry values in call site values
Wed, Mar 18, 5:25 AM
dstenb closed D76279: [DebugInfo] Fix multi-byte entry values in call site values.
Wed, Mar 18, 5:24 AM · Restricted Project, debug-info
dstenb added a comment to D76279: [DebugInfo] Fix multi-byte entry values in call site values.

Thanks for the reviews! I'll land this shortly.

Wed, Mar 18, 3:46 AM · Restricted Project, debug-info

Tue, Mar 17

dstenb added a comment to D76279: [DebugInfo] Fix multi-byte entry values in call site values.

LGTM! Thanks!

So, this was causing the wrong call_site_value for the parameter only?

Tue, Mar 17, 8:30 AM · Restricted Project, debug-info
dstenb added a comment to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).
In D75326#1925517, @vsk wrote:

No worries, I think this is great feedback. I think we've just touched on a tricky part of the standard. Do you still have the time to start a discussion about this on the dwarf mailing list?

Tue, Mar 17, 7:25 AM · debug-info, Restricted Project
dstenb added inline comments to D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values..
Tue, Mar 17, 7:24 AM · Restricted Project, debug-info
dstenb created D76279: [DebugInfo] Fix multi-byte entry values in call site values.
Tue, Mar 17, 6:52 AM · Restricted Project, debug-info
dstenb added a comment to D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation.

Have you thought about doing this

Tue, Mar 17, 5:43 AM · Restricted Project, debug-info

Mon, Mar 16

dstenb added a comment to D76146: [DebugInfo] Use DW_OP_LLVM_convert_generic after sign/zero exts.

Mechanically LGTM to me. I'm not sure if this shouldn't be done in DwarfExpression instead.

Mon, Mar 16, 12:01 PM · Restricted Project, debug-info
dstenb committed rG02b6a3c3499f: [DebugInfo] Handle generic type DW_OP_convert ops in dsymutil (authored by dstenb).
[DebugInfo] Handle generic type DW_OP_convert ops in dsymutil
Mon, Mar 16, 4:38 AM
dstenb closed D76142: [DebugInfo] Handle generic type DW_OP_convert ops in dsymutil.
Mon, Mar 16, 4:38 AM · Restricted Project, debug-info
dstenb committed rGc93652517c81: [DebugInfo] Handle generic type DW_OP_convert ops in llvm-dwarfdump (authored by dstenb).
[DebugInfo] Handle generic type DW_OP_convert ops in llvm-dwarfdump
Mon, Mar 16, 3:55 AM
dstenb closed D76141: [DebugInfo] Handle generic type DW_OP_convert ops in llvm-dwarfdump.
Mon, Mar 16, 3:54 AM · Restricted Project, debug-info
dstenb updated the diff for D76142: [DebugInfo] Handle generic type DW_OP_convert ops in dsymutil.

Remove binary file from diff due to issues with arc patch. I'll add the file back when landing this, which I plan to do shortly.

Mon, Mar 16, 3:53 AM · Restricted Project, debug-info

Fri, Mar 13

dstenb added a comment to D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values..

Sorry for taking some extra time with that PR. This patch should fix that assertion, but we would emit invalid debug information, related to D76146, for that case.

Fri, Mar 13, 3:41 PM · Restricted Project, debug-info
dstenb added a comment to D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values..

Can you also test on the reduced test cases in https://bugs.llvm.org/show_bug.cgi?id=45181 ?

Fri, Mar 13, 3:40 PM · Restricted Project, debug-info
dstenb added a parent revision for D76146: [DebugInfo] Use DW_OP_LLVM_convert_generic after sign/zero exts: D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation.
Fri, Mar 13, 11:17 AM · Restricted Project, debug-info
dstenb added a child revision for D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation: D76146: [DebugInfo] Use DW_OP_LLVM_convert_generic after sign/zero exts.
Fri, Mar 13, 11:17 AM · Restricted Project, debug-info
dstenb created D76146: [DebugInfo] Use DW_OP_LLVM_convert_generic after sign/zero exts.
Fri, Mar 13, 11:17 AM · Restricted Project, debug-info
dstenb added a child revision for D76142: [DebugInfo] Handle generic type DW_OP_convert ops in dsymutil: D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation.
Fri, Mar 13, 10:44 AM · Restricted Project, debug-info
dstenb added a parent revision for D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation: D76142: [DebugInfo] Handle generic type DW_OP_convert ops in dsymutil.
Fri, Mar 13, 10:44 AM · Restricted Project, debug-info
dstenb created D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation.
Fri, Mar 13, 10:44 AM · Restricted Project, debug-info
dstenb added a child revision for D76141: [DebugInfo] Handle generic type DW_OP_convert ops in llvm-dwarfdump: D76142: [DebugInfo] Handle generic type DW_OP_convert ops in dsymutil.
Fri, Mar 13, 10:11 AM · Restricted Project, debug-info
dstenb added a parent revision for D76142: [DebugInfo] Handle generic type DW_OP_convert ops in dsymutil: D76141: [DebugInfo] Handle generic type DW_OP_convert ops in llvm-dwarfdump.
Fri, Mar 13, 10:11 AM · Restricted Project, debug-info
dstenb created D76142: [DebugInfo] Handle generic type DW_OP_convert ops in dsymutil.
Fri, Mar 13, 10:11 AM · Restricted Project, debug-info
dstenb created D76141: [DebugInfo] Handle generic type DW_OP_convert ops in llvm-dwarfdump.
Fri, Mar 13, 10:11 AM · Restricted Project, debug-info

Thu, Mar 12

dstenb added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

Hi,

I see another crash with this change when building gdb.

Reduced test case:
struct type *a(type *, type *, long, long);
enum b {};
static int empty_array(type *, int c) { type *d = a(__null, d, c, c - 1); }
long e;
b f() { empty_array(0, e); }

Repros with:
clang -cc1 -triple x86_64-linux-gnu -emit-obj -disable-free -mrelocation-model pic -pic-level 2 -pic-is-pie -mthread-model posix -mframe-pointer=all -mconstructor-aliases -munwind-tables -dwarf-column-info -debug-info-kind=limited -dwarf-version=4 -debugger-tuning=gdb -O2 -x c++

Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1060788

Oh, that assertion is related to D75036 which I did. I can have a look at that.

Thu, Mar 12, 3:03 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
dstenb added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

Hi,

I see another crash with this change when building gdb.

Reduced test case:
struct type *a(type *, type *, long, long);
enum b {};
static int empty_array(type *, int c) { type *d = a(__null, d, c, c - 1); }
long e;
b f() { empty_array(0, e); }

Repros with:
clang -cc1 -triple x86_64-linux-gnu -emit-obj -disable-free -mrelocation-model pic -pic-level 2 -pic-is-pie -mthread-model posix -mframe-pointer=all -mconstructor-aliases -munwind-tables -dwarf-column-info -debug-info-kind=limited -dwarf-version=4 -debugger-tuning=gdb -O2 -x c++

Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1060788

Thu, Mar 12, 3:03 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Wed, Mar 11

dstenb accepted D75974: [DebugInfo] Fix build failure on the mingw.

LGTM

Wed, Mar 11, 3:47 AM · Restricted Project, debug-info
dstenb added a comment to D75974: [DebugInfo] Fix build failure on the mingw.

Thanks, this seems like a good workaround to get rid of the assertion until D75326 has landed.

Wed, Mar 11, 2:19 AM · Restricted Project, debug-info

Mon, Mar 9

dstenb added a comment to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).
In D75326#1904157, @vsk wrote:

Sorry for the delay here.

@dstenb wrote:

When I print that in GDB 8.2.1, 0x5566 is printed instead of 0x11225566 which is the actual parameter value:

Yeah, this sounds like a debugger bug to me. The debugger should print something that indicates that the upper bits of "param" are unknown. Although, to be fair, lldb has the same bug (or it might be worse, and print out "param" as 0x00005566 -- it doesn't track the bits of a variable that are uncovered by pieces).

The DW_OP_entry_value operation at the callee expects a value to be pushed to the DWARF stack when evaluating the DW_AT_call_value at the caller. How should/would that work with composite descriptions?

Well, in lldb at least, I think the idea is that while OP_piece doesn't push anything to the stack, it changes the debugger's notion of which bits in the evaluated result are "valid". So one way this could work is: the result of evaluating the DW_AT_call_value is pushed onto the stack when evaluating DW_OP_entry_value (and if it's e.g. a 2-byte piece, so be it).

All of which sounds a little iffy to me for what appears to be a pretty uncommon case (fwiw I was able to build all of clang & LNT for x86 without hitting this).

Mon, Mar 9, 9:08 AM · debug-info, Restricted Project

Mar 4 2020

dstenb added a comment to D75270: [DebugInfo] Do not emit entry values for composite locations.
In D75270#1897102, @vsk wrote:

Fixing the assertion failure in this way sgtm. Re:

Mar 4 2020, 5:06 AM · Restricted Project, debug-info

Mar 3 2020

dstenb added a comment to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).

I dug around some in the Dwarf-discuss archive, and it seems that when working on DWARFv3 the piece operations were moved out from the "Dwarf Expressions" section to "Location Descriptions" to clarify that they don't push anything to the stack.

Mar 3 2020, 3:04 AM · debug-info, Restricted Project

Mar 2 2020

dstenb added a comment to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).
In D75326#1898465, @vsk wrote:

If OP_piece in an entry value really /is/ an issue, please confirm, and I'll update the x86 describeLoadedValue to just return 'None' for mov{8,16}ri (it doesn't seem worth it to me to do anything more complicated).

Mar 2 2020, 3:53 AM · debug-info, Restricted Project
dstenb added a comment to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).
In D75326#1898465, @vsk wrote:
In D75326#1898071, @vsk wrote:

Thank you @dstenb and @djtodoro very much for your feedback.

I think I've addressed the main issue, we now produce DW_AT_call_value (DW_OP_constu 0x840, DW_OP_stack_value, DW_OP_piece 0x2). PTAL.

I might be incorrect here, but I don't think we are allowed to use DW_OP_piece operations in DW_AT_call_value attributes, as they should be DWARF expressions? As far as I have understood it, the DW_OP_piece operation is only allowed in composite location descriptions, and you can in general not go from location descriptions to DWARF expressions, with the only (?) exception being DW_OP_entry_value operations holding register location descriptions.

(This seems a bit related to D75270, in which I stop emitting entry values around composite location descriptions, since the DWARF standard specifies that those are only allowed to hold DWARF expressions and register location descriptions.)

If I understand your reading correctly, it's that composite location descriptions are not (in general) a kind of DWARF expression.

FWIW, this doesn't line up with my understanding. DWARF5 says "a single location description" may be "a composite location description", which consists of "one or more simple location descriptions", each of which describes "one piece of the object" (2.6.1). And it says that a DWARF expression describes "how to compute a value or specify a location" (2.5). That certainly /sounds/ like a composite location can be a DWARF expression.

Mar 2 2020, 2:07 AM · debug-info, Restricted Project

Feb 28 2020

dstenb added a comment to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).
In D75326#1898071, @vsk wrote:

Thank you @dstenb and @djtodoro very much for your feedback.

I think I've addressed the main issue, we now produce DW_AT_call_value (DW_OP_constu 0x840, DW_OP_stack_value, DW_OP_piece 0x2). PTAL.

Feb 28 2020, 8:14 AM · debug-info, Restricted Project
dstenb added inline comments to D75338: [Coroutines] Use dbg.declare for frame variables.
Feb 28 2020, 4:59 AM · Restricted Project
dstenb added inline comments to D75273: [entry values] ARM: Add a describeLoadedValue override (PR45025).
Feb 28 2020, 4:13 AM · debug-info, Restricted Project
dstenb added a comment to D75270: [DebugInfo] Do not emit entry values for composite locations.

As far as I can tell GCC does not emit any
entry values / call sites in these cases, so we do not have something to
compare with, but the former seems like the more reasonable approach.

I think as well. What about GDB side? Did GDB expect something like this? I though just running GDB over such case could be interesting to see if it accepts such scenario or not (I should find some time to play with that for sure).

Feb 28 2020, 2:25 AM · Restricted Project, debug-info
dstenb added inline comments to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).
Feb 28 2020, 2:08 AM · debug-info, Restricted Project

Feb 27 2020

dstenb committed rG6d857166d218: [DebugInfo] Describe call site values for chains of expression producing instrs (authored by dstenb).
[DebugInfo] Describe call site values for chains of expression producing instrs
Feb 27 2020, 9:47 AM
dstenb committed rGff574ff291e7: [DebugInfo][NFC] Move out lambdas from collectCallSiteParameters() (authored by dstenb).
[DebugInfo][NFC] Move out lambdas from collectCallSiteParameters()
Feb 27 2020, 9:47 AM
dstenb created D75270: [DebugInfo] Do not emit entry values for composite locations.
Feb 27 2020, 9:06 AM · Restricted Project, debug-info
dstenb added a comment to D75175: [CallSiteInfo] Enable the call site info only for -g + optimizations.

One downside with this is that if you compile the compilation unit containing the caller with -O0, and the compilation unit containing the callee with optimizations enabled, it will not be possible to evaluate the entry values in the callee. However, GCC (8.3.0) seems to behave in the same way; at least for the small examples I tried.

Feb 27 2020, 8:31 AM · Restricted Project, debug-info, Restricted Project
dstenb closed D75050: [DebugInfo][NFC] Move out lambdas from collectCallSiteParameters().

Oh, it seems that I missed to specify the repository for this patch. This was pushed as:

Feb 27 2020, 5:54 AM · Restricted Project, debug-info
dstenb closed D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.

Oh, it seems that I missed to specify the repository for this patch. This was pushed as:

Feb 27 2020, 5:49 AM · Restricted Project, debug-info
dstenb set the repository for D75050: [DebugInfo][NFC] Move out lambdas from collectCallSiteParameters() to rG LLVM Github Monorepo.
Feb 27 2020, 5:37 AM · Restricted Project, debug-info
dstenb set the repository for D75036: [DebugInfo] Describe call site values for chains of expression producing instrs to rG LLVM Github Monorepo.
Feb 27 2020, 5:37 AM · Restricted Project, debug-info
dstenb accepted D74904: [CallSiteInfo] Handle bundles when updating call site info.

Does that patch make this one redundant, or can we land in the cases that this patch fixes with -O>0?

This patch fixes the problem and we need it for sure. But, the D75175 is another idea (nothing to do with this patch) to avoid production of call site info in the case of non-debug builds, which makes sense to me, since it is being used only for Debug Entry Values feature, but we can move the discussion to that patch.

Feb 27 2020, 1:18 AM · Restricted Project, debug-info

Feb 26 2020

dstenb added inline comments to D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.
Feb 26 2020, 9:51 AM · Restricted Project, debug-info
dstenb updated the diff for D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.

Address review comments.

Feb 26 2020, 9:50 AM · Restricted Project, debug-info
dstenb updated the diff for D75050: [DebugInfo][NFC] Move out lambdas from collectCallSiteParameters().

Update after review comment on child patch (use local reference variable for I.first->second).

Feb 26 2020, 9:50 AM · Restricted Project, debug-info
dstenb added inline comments to D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.
Feb 26 2020, 9:00 AM · Restricted Project, debug-info
dstenb added a comment to D74904: [CallSiteInfo] Handle bundles when updating call site info.

I see this was triggered in a case when we have not used the '-g' option at all.

When we started the work, there were thoughts the "call-site-info" could be used somewhere else, but it is not the case now. It is being used only for the Debug Entry Values feature, so I think it makes sense to avoid production (and handling though out the pipeline) of the call-site-info if not '-g' and '-O>0'.

The DWARF generation (for call-site-params) is controlled the same way as production of call-sites by looking at the DISupprogam flag AllCallsDescribed.

Something like D75175 (and then rebase reland of the D73534 on top of that).

Feb 26 2020, 8:44 AM · Restricted Project, debug-info
dstenb added a comment to D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.

This looks good to me. Thanks!

Feb 26 2020, 8:32 AM · Restricted Project, debug-info

Feb 25 2020

dstenb added inline comments to D74904: [CallSiteInfo] Handle bundles when updating call site info.
Feb 25 2020, 8:37 AM · Restricted Project, debug-info
dstenb updated the diff for D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.

Address comments.

Feb 25 2020, 8:30 AM · Restricted Project, debug-info
dstenb added inline comments to D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.
Feb 25 2020, 6:39 AM · Restricted Project, debug-info

Feb 24 2020

dstenb added inline comments to D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.
Feb 24 2020, 7:44 AM · Restricted Project, debug-info
dstenb added a parent revision for D75036: [DebugInfo] Describe call site values for chains of expression producing instrs: D75050: [DebugInfo][NFC] Move out lambdas from collectCallSiteParameters().
Feb 24 2020, 7:17 AM · Restricted Project, debug-info
dstenb added a child revision for D75050: [DebugInfo][NFC] Move out lambdas from collectCallSiteParameters(): D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.
Feb 24 2020, 7:17 AM · Restricted Project, debug-info
dstenb updated the diff for D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.

Rebase on top of refactoring commit.

Feb 24 2020, 7:17 AM · Restricted Project, debug-info
dstenb created D75050: [DebugInfo][NFC] Move out lambdas from collectCallSiteParameters().
Feb 24 2020, 7:17 AM · Restricted Project, debug-info
dstenb added inline comments to D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.
Feb 24 2020, 2:42 AM · Restricted Project, debug-info
dstenb created D75036: [DebugInfo] Describe call site values for chains of expression producing instrs.
Feb 24 2020, 2:39 AM · Restricted Project, debug-info

Feb 19 2020

dstenb added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

@dstenb No problem, we have already addressed the issue. Thanks to @vsk and @nickdesaulniers! I'll update the patch.

Feb 19 2020, 1:20 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
dstenb added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on this change. I see it's been reverted (thank you). Please cc me on the updated patch and I can help test it against the Linux kernel.

Edit: Link: https://ci.linaro.org/job/tcwg_kernel-bisect-llvm-master-arm-mainline-allyesconfig/25/artifact/artifacts/build-a82d3e8a6e67473c94a5ce6345372748e9b61718/03-build_linux/console.log

Feb 19 2020, 12:58 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Feb 14 2020

dstenb added inline comments to D73534: [DebugInfo] Enable the debug entry values feature by default.
Feb 14 2020, 7:55 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Feb 12 2020

dstenb added a comment to D73630: [InstCombine][DebugInfo] Fold constants wrapped in metadata.

I reverted this in 982944525c7706c4dee00042d5b7cf2f0d87804f. Downstream we encountered debug-invariance (different code with/without -g), which seems to be due to a pre-existing issue in GlobalOpt. I'll find a good upstream reproducer and write a PR for that.

Feb 12 2020, 6:04 AM · Restricted Project, debug-info
dstenb added inline comments to D73534: [DebugInfo] Enable the debug entry values feature by default.
Feb 12 2020, 4:05 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Feb 11 2020

dstenb added a comment to D74030: [DebugInfo] Avoid generating duplicate llvm.dbg.value.

Thanks! No further comments from me.

Feb 11 2020, 8:44 AM · Restricted Project, debug-info
dstenb added a comment to D74030: [DebugInfo] Avoid generating duplicate llvm.dbg.value.

Hi David (@dstenb), I have incorporated all your comments. I have also added you as reviewer. Kindly give your feedback.

Feb 11 2020, 12:59 AM · Restricted Project, debug-info

Feb 10 2020

dstenb committed rG982944525c77: Revert "[InstCombine][DebugInfo] Fold constants wrapped in metadata" (authored by dstenb).
Revert "[InstCombine][DebugInfo] Fold constants wrapped in metadata"
Feb 10 2020, 9:01 AM
dstenb added a comment to D73630: [InstCombine][DebugInfo] Fold constants wrapped in metadata.

I reverted this in 982944525c7706c4dee00042d5b7cf2f0d87804f. Downstream we encountered debug-invariance (different code with/without -g), which seems to be due to a pre-existing issue in GlobalOpt. I'll find a good upstream reproducer and write a PR for that.

Feb 10 2020, 9:01 AM · Restricted Project, debug-info
dstenb added a reverting change for rGb54a8ec1bcd3: [InstCombine][DebugInfo] Fold constants wrapped in metadata: rG982944525c77: Revert "[InstCombine][DebugInfo] Fold constants wrapped in metadata".
Feb 10 2020, 9:01 AM

Feb 5 2020

dstenb added inline comments to D74030: [DebugInfo] Avoid generating duplicate llvm.dbg.value.
Feb 5 2020, 3:52 AM · Restricted Project, debug-info
dstenb added inline comments to D74030: [DebugInfo] Avoid generating duplicate llvm.dbg.value.
Feb 5 2020, 3:06 AM · Restricted Project, debug-info

Jan 30 2020

dstenb committed rGb54a8ec1bcd3: [InstCombine][DebugInfo] Fold constants wrapped in metadata (authored by dstenb).
[InstCombine][DebugInfo] Fold constants wrapped in metadata
Jan 30 2020, 6:59 AM
dstenb closed D73630: [InstCombine][DebugInfo] Fold constants wrapped in metadata.
Jan 30 2020, 6:59 AM · Restricted Project, debug-info
dstenb added inline comments to D73630: [InstCombine][DebugInfo] Fold constants wrapped in metadata.
Jan 30 2020, 4:21 AM · Restricted Project, debug-info
dstenb updated the diff for D73630: [InstCombine][DebugInfo] Fold constants wrapped in metadata.

Address review comment.

Jan 30 2020, 4:21 AM · Restricted Project, debug-info

Jan 29 2020

dstenb created D73630: [InstCombine][DebugInfo] Fold constants wrapped in metadata.
Jan 29 2020, 7:58 AM · Restricted Project, debug-info
dstenb added inline comments to D73283: Handle complex DWARF expressions in combination with "complex" registers.
Jan 29 2020, 7:21 AM · Restricted Project, debug-info
dstenb added inline comments to D73283: Handle complex DWARF expressions in combination with "complex" registers.
Jan 29 2020, 2:25 AM · Restricted Project, debug-info
dstenb committed rG6a2413c43509: [ARM64] Debug info for structure argument missing DW_AT_location (authored by dstenb).
[ARM64] Debug info for structure argument missing DW_AT_location
Jan 29 2020, 2:04 AM
dstenb closed D73159: ARM64: Debug info for structure argument missing DW_AT_location.
Jan 29 2020, 2:03 AM · Restricted Project, debug-info

Jan 28 2020

dstenb added inline comments to D73283: Handle complex DWARF expressions in combination with "complex" registers.
Jan 28 2020, 8:30 AM · Restricted Project, debug-info
dstenb added a comment to D73159: ARM64: Debug info for structure argument missing DW_AT_location.

I do not have commit access.
can someone commit this?

Jan 28 2020, 6:59 AM · Restricted Project, debug-info
dstenb added inline comments to D73534: [DebugInfo] Enable the debug entry values feature by default.
Jan 28 2020, 6:13 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
dstenb added inline comments to D73534: [DebugInfo] Enable the debug entry values feature by default.
Jan 28 2020, 5:45 AM · Restricted Project, Restricted Project, Restricted Project, debug-info