dstenb (David Stenberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2016, 1:55 AM (110 w, 1 d)

Recent Activity

Fri, Jul 6

dstenb resigned from D48979: AMDGPU: Fix UBSan error caused by r335942.

I don't really know anything about the AMDGPU target, so I'll resign as reviewer to make that clear, but thanks for notifying me about the fix!

Fri, Jul 6, 6:38 AM

Thu, Jul 5

dstenb added a comment to D46365: AMDGPU: Separate R600 and GCN TableGen files.

Hi! We encountered a UBSan runtime error after this was merged. I wrote a bug report about it: https://bugs.llvm.org/show_bug.cgi?id=38071.

Thu, Jul 5, 8:00 AM

Mon, Jul 2

dstenb committed rL336109: [CodeGen] Make block removal order deterministic in CodeGenPrepare.
[CodeGen] Make block removal order deterministic in CodeGenPrepare
Mon, Jul 2, 7:28 AM
dstenb closed D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.
Mon, Jul 2, 7:28 AM
dstenb added a comment to D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.

Thanks for the reviews!

Mon, Jul 2, 5:32 AM

Wed, Jun 27

dstenb updated the diff for D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.

Use pop_back_val() for getting the items from the worklist.

Wed, Jun 27, 1:23 AM
dstenb added inline comments to D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.
Wed, Jun 27, 1:22 AM

Jun 20 2018

dstenb created D48369: [CodeGen] Make block removal order deterministic in CodeGenPrepare.
Jun 20 2018, 8:06 AM

May 31 2018

dstenb committed rCTE333637: [Driver] Clean up tmp files when deleting Compilation objects.
[Driver] Clean up tmp files when deleting Compilation objects
May 31 2018, 2:10 AM
dstenb committed rL333637: [Driver] Clean up tmp files when deleting Compilation objects.
[Driver] Clean up tmp files when deleting Compilation objects
May 31 2018, 2:09 AM
dstenb committed rC333637: [Driver] Clean up tmp files when deleting Compilation objects.
[Driver] Clean up tmp files when deleting Compilation objects
May 31 2018, 2:09 AM
dstenb closed D45686: [Driver] Clean up tmp files when deleting Compilation objects.
May 31 2018, 2:09 AM

May 30 2018

dstenb added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Any more comments or concerns, or can I land this?

May 30 2018, 12:53 AM

May 29 2018

dstenb committed rC333413: Fix emission of phony dependency targets when adding extra deps.
Fix emission of phony dependency targets when adding extra deps
May 29 2018, 6:12 AM
dstenb committed rL333413: Fix emission of phony dependency targets when adding extra deps.
Fix emission of phony dependency targets when adding extra deps
May 29 2018, 6:12 AM
dstenb closed D44568: Fix emission of phony dependency targets when adding extra deps.
May 29 2018, 6:12 AM
dstenb closed D44568: Fix emission of phony dependency targets when adding extra deps.
May 29 2018, 6:12 AM
dstenb added a comment to D44568: Fix emission of phony dependency targets when adding extra deps.

Looks good to me. Just watch the build bots in case some of them are strict with warnings and require (void)AddFilename(Filename).

May 29 2018, 5:56 AM

May 28 2018

dstenb added inline comments to D44568: Fix emission of phony dependency targets when adding extra deps.
May 28 2018, 8:19 AM
dstenb updated the diff for D44568: Fix emission of phony dependency targets when adding extra deps.

Addressed vsapsai's comments.

May 28 2018, 8:17 AM
dstenb abandoned D47251: Add a lit reproducer for PR37091.

Merged into D45686.

May 28 2018, 1:34 AM
dstenb updated the diff for D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Update patch to include the clang-tools-extra test case originally added in D47251.

May 28 2018, 1:33 AM

May 25 2018

dstenb updated the diff for D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Query TheDriver.isSaveTempsEnabled() at uses instead of storing the value in the constructor.

May 25 2018, 7:25 AM
dstenb added inline comments to D45686: [Driver] Clean up tmp files when deleting Compilation objects.
May 25 2018, 6:26 AM
dstenb committed rL333274: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().
[MustExecute] Fix a debug invariant issue in isGuaranteedToExecute()
May 25 2018, 6:07 AM
dstenb closed D47197: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().
May 25 2018, 6:06 AM
dstenb updated the diff for D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Renamed SaveTempsEnabled field to KeepTempFiles.

May 25 2018, 6:02 AM
dstenb updated the diff for D45686: [Driver] Clean up tmp files when deleting Compilation objects.

I have now updated the patch so that the files are removed when deleting Compilation objects.

May 25 2018, 3:45 AM

May 24 2018

dstenb added a comment to D47197: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().

Thanks for the review! I'll submit this tomorrow when I have time for the build bots.

May 24 2018, 7:57 AM

May 23 2018

dstenb added inline comments to D45686: [Driver] Clean up tmp files when deleting Compilation objects.
May 23 2018, 7:32 AM
dstenb added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

We have added a lit reproducer for this now in clang-tools-extra: https://reviews.llvm.org/D47251.

May 23 2018, 4:23 AM
dstenb added a dependency for D47251: Add a lit reproducer for PR37091: D45686: [Driver] Clean up tmp files when deleting Compilation objects.
May 23 2018, 4:22 AM
dstenb added a dependent revision for D45686: [Driver] Clean up tmp files when deleting Compilation objects: D47251: Add a lit reproducer for PR37091.
May 23 2018, 4:22 AM
dstenb created D47251: Add a lit reproducer for PR37091.
May 23 2018, 4:21 AM

May 22 2018

dstenb retitled D47197: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute() from [LICM] Fix a debug invariant issue in isGuaranteedToExecute() to [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().
May 22 2018, 11:35 PM
dstenb created D47197: [MustExecute] Fix a debug invariant issue in isGuaranteedToExecute().
May 22 2018, 7:34 AM

May 18 2018

dstenb committed rL332698: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().
[SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest()
May 18 2018, 1:56 AM
dstenb closed D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().
May 18 2018, 1:56 AM
dstenb added a comment to D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().

Thanks for the reviews! I'll submit this shortly.

May 18 2018, 12:26 AM

May 17 2018

dstenb added a comment to D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().

Any more comments on this?

May 17 2018, 12:29 AM

May 10 2018

dstenb updated the diff for D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().

Addressed comments!

May 10 2018, 4:58 AM
dstenb added inline comments to D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().
May 10 2018, 3:32 AM

May 9 2018

dstenb added reviewers for D44568: Fix emission of phony dependency targets when adding extra deps: bruno, vsapsai.

@bruno, @vsapsai: I added you since you I saw that you recently reviewed, respectively delivered, D30881. That is the only DependencyFile commit since October; although, this feels a bit orthogonal from that, so feel free to remove yourselves as reviewers (and I'm sorry for adding you in that case)!

May 9 2018, 5:20 AM
dstenb added a comment to D44568: Fix emission of phony dependency targets when adding extra deps.

Ping.

May 9 2018, 4:56 AM
dstenb created D46635: [SimplifyCFG] Fix a debug invariant bug in FoldBranchToCommonDest().
May 9 2018, 4:22 AM

Apr 25 2018

dstenb added a comment to D45686: [Driver] Clean up tmp files when deleting Compilation objects.

Ping. It feels a bit nasty that the tools leave behind temporary files, so I think that it would be good to find a fix for that.

Apr 25 2018, 1:25 AM

Apr 18 2018

Herald updated subscribers of D42848: Correct dwarf unwind information in function epilogue.
Apr 18 2018, 7:39 AM

Apr 16 2018

dstenb created D45686: [Driver] Clean up tmp files when deleting Compilation objects.
Apr 16 2018, 7:17 AM
dstenb added a comment to D44568: Fix emission of phony dependency targets when adding extra deps.

Ping.

Apr 16 2018, 4:54 AM

Apr 11 2018

dstenb added a comment to D36827: Changed createTemporaryFile without FD to actually create a file..

Hi! We have encountered a regression where clang-tidy leaves behind temporary files after this change. I wrote a PR for that: https://bugs.llvm.org/show_bug.cgi?id=37091.

Apr 11 2018, 10:04 AM

Mar 28 2018

dstenb added a comment to D44774: [Driver] Allow use of -fsyntax-only together with -MJ.

Our legacy frontend does not support -MJ, so when using that frontend for code generation, we also invoke clang with -MJ, and at the same use -fsyntax-only to get the improved diagnostics that clang provides. This is idiosyncratic and probably hacky, I know, but it works well enough to for example for getting access to defines and include flags from the compilation database, and being able to run clang-tidy. So (1) does not fit our use case, unfortunately.

Mar 28 2018, 7:22 AM
dstenb added a comment to D44054: [DWARFv5] Emit file 0 to the line table..

With this change, we will emit the .file 0 directive even for -gdwarf-[234]. The directive results in an error when assembling with GAS. Should this be seen as a problem, or is it something that we accept?

Mar 28 2018, 6:25 AM · debug-info

Mar 26 2018

dstenb added a comment to D44774: [Driver] Allow use of -fsyntax-only together with -MJ.

Downstream we use -MJ in a bit of an idiosyncratic way, as we're in a transition period where we, for a subset of the code base, only use the clang frontend for diagnostics, and not for the code generation. However, if you don't think that using -fsyntax-only and -MJ makes sense in any upstream application, I'll drop from this change. I'm leaving the assertion as-is.

Mar 26 2018, 7:22 AM

Mar 22 2018

dstenb created D44774: [Driver] Allow use of -fsyntax-only together with -MJ.
Mar 22 2018, 3:19 AM

Mar 16 2018

dstenb added a comment to D44568: Fix emission of phony dependency targets when adding extra deps.

A small caveat with this patch is that it does not fix the case where the input file as also added as an extra dependency with -fdepfile-entry; however, I reasoned that it shouldn't really be a problem in practice. I thought that it was a good trade-off ignoring that for slightly simpler code.

Mar 16 2018, 8:18 AM
dstenb created D44568: Fix emission of phony dependency targets when adding extra deps.
Mar 16 2018, 8:14 AM

Mar 2 2018

dstenb committed rL326573: Test commit: Remove an extraneous space. NFC.
Test commit: Remove an extraneous space. NFC
Mar 2 2018, 6:31 AM

Feb 1 2018

dstenb updated the diff for D42807: [GlobalOpt] Include padding in debug fragments.

Removed nonessential attributes.

Feb 1 2018, 10:55 AM · debug-info
dstenb created D42807: [GlobalOpt] Include padding in debug fragments.
Feb 1 2018, 10:39 AM · debug-info

Jan 26 2018

dstenb added inline comments to D42527: [DebugInfo] Fix fragment offset emission order for symbol locations.
Jan 26 2018, 4:36 AM · debug-info
dstenb added reviewers for D42527: [DebugInfo] Fix fragment offset emission order for symbol locations: aprantl, probinson, dblaikie.

Added reviewers.

Jan 26 2018, 1:03 AM · debug-info

Jan 25 2018

dstenb created D42527: [DebugInfo] Fix fragment offset emission order for symbol locations.
Jan 25 2018, 4:17 AM · debug-info

Jan 24 2018

dstenb created D42489: [GlobalOpt] Emit fragments using field offsets from struct layout.
Jan 24 2018, 8:46 AM

Oct 18 2017

dstenb added a comment to D33889: Mark intrinsics as norecurse.

Unless I'm mistaken, int_experimental_gc_statepoint should also be marked recursive?

Oct 18 2017, 8:54 AM

Sep 26 2017

dstenb updated the diff for D38172: [Debug info] Handle endianness when moving debug info for split integer values.

Simplified the test case according to dblaikie's comment (thanks!).

Sep 26 2017, 3:30 PM

Sep 25 2017

dstenb added a comment to D38172: [Debug info] Handle endianness when moving debug info for split integer values.

LGTM, but maybe wait for the other to have a look too before you land this.

Sep 25 2017, 5:03 AM

Sep 22 2017

dstenb created D38172: [Debug info] Handle endianness when moving debug info for split integer values.
Sep 22 2017, 4:24 AM

Aug 23 2017

dstenb added inline comments to D36865: [Reassociate] Do not drop debug location if replacement is missing.
Aug 23 2017, 1:07 AM
dstenb updated the diff for D36865: [Reassociate] Do not drop debug location if replacement is missing.

Changed so that the debug location is kept in the other cases.
Added CHECK statements (thanks for pointing that out!).

Aug 23 2017, 1:03 AM

Aug 21 2017

dstenb added a comment to D36865: [Reassociate] Do not drop debug location if replacement is missing.

I fully understand the rationale behind this patch and I think it is good, but why is it ok/desirable to drop the debug info in all other cases?

Aug 21 2017, 4:59 AM

Aug 18 2017

dstenb updated the summary of D36865: [Reassociate] Do not drop debug location if replacement is missing.
Aug 18 2017, 2:37 AM
dstenb created D36865: [Reassociate] Do not drop debug location if replacement is missing.
Aug 18 2017, 2:34 AM

Oct 13 2016

dstenb added reviewers for D25460: Fix memory issue in AttrBuilder::removeAttribute uses: mkuper, rnk.
Oct 13 2016, 1:47 AM

Oct 11 2016

dstenb retitled D25460: Fix memory issue in AttrBuilder::removeAttribute uses from to Fix memory issue in AttrBuilder::removeAttribute uses.
Oct 11 2016, 1:08 AM

Jun 20 2016

dstenb added inline comments to D21226: [SROA] Fix non-determinism caused by differing argument evaluation order .
Jun 20 2016, 4:35 AM
dstenb updated the diff for D21226: [SROA] Fix non-determinism caused by differing argument evaluation order .
Jun 20 2016, 12:49 AM
dstenb added a reviewer for D21226: [SROA] Fix non-determinism caused by differing argument evaluation order : patrik.h.hagglund.
Jun 20 2016, 12:40 AM

Jun 10 2016

dstenb retitled D21226: [SROA] Fix non-determinism caused by differing argument evaluation order from to [SROA] Fix non-determinism caused by differing argument evaluation order .
Jun 10 2016, 5:21 AM