Page MenuHomePhabricator

dstenb (David Stenberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2016, 1:55 AM (171 w, 3 d)

Recent Activity

Fri, Sep 20

dstenb committed rGb71d8d465aa9: Add a missing space in a MIR parser error message (authored by dstenb).
Add a missing space in a MIR parser error message
Fri, Sep 20, 7:44 AM
dstenb committed rL372398: Add a missing space in a MIR parser error message.
Add a missing space in a MIR parser error message
Fri, Sep 20, 7:40 AM

Thu, Sep 19

dstenb added a parent revision for D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation: D67768: [DebugInfo] Add interface for pre-calculating the size of emitted DWARF.
Thu, Sep 19, 9:08 AM · Restricted Project, debug-info
dstenb added a child revision for D67768: [DebugInfo] Add interface for pre-calculating the size of emitted DWARF: D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Thu, Sep 19, 9:08 AM · Restricted Project, debug-info
dstenb created D67768: [DebugInfo] Add interface for pre-calculating the size of emitted DWARF.
Thu, Sep 19, 9:08 AM · Restricted Project, debug-info
dstenb updated the diff for D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.

Update patch after comments, and change the semantics of the new operation. Rather than only introducing an internal variant that has the same behavior as DW_OP_entry_value, the new operation's operand specifies the number of operations (including the value/address operand) that are covered by the entry value, and that value is then converted to the byte size when we emit the entry value in DwarfExpression.

Thu, Sep 19, 9:04 AM · Restricted Project, debug-info
dstenb abandoned D67674: [WIP][DebugInfo] Allow multi-byte register entry values.

Thanks for looking at the changes!

Thu, Sep 19, 8:48 AM · Restricted Project
dstenb added inline comments to D67556: [ARM][AArch64][DebugInfo] Improve call site instruction interpretation.
Thu, Sep 19, 4:01 AM · debug-info

Tue, Sep 17

dstenb added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Tue, Sep 17, 12:12 PM · Restricted Project, debug-info
dstenb created D67674: [WIP][DebugInfo] Allow multi-byte register entry values.
Tue, Sep 17, 12:03 PM · Restricted Project
dstenb added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Tue, Sep 17, 11:58 AM · Restricted Project, debug-info

Mon, Sep 16

dstenb added a comment to D67556: [ARM][AArch64][DebugInfo] Improve call site instruction interpretation.

In general, is it really safe to describe loaded values at the call sites?

Mon, Sep 16, 5:42 AM · debug-info

Thu, Sep 12

dstenb added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Thu, Sep 12, 1:48 PM · Restricted Project, debug-info
dstenb created D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Thu, Sep 12, 4:30 AM · Restricted Project, debug-info

Sun, Sep 8

dstenb committed rG5a583665f4cb: [DebugInfo][X86] Describe call site values for zero-valued imms (authored by dstenb).
[DebugInfo][X86] Describe call site values for zero-valued imms
Sun, Sep 8, 7:26 AM
dstenb committed rL371333: [DebugInfo][X86] Describe call site values for zero-valued imms.
[DebugInfo][X86] Describe call site values for zero-valued imms
Sun, Sep 8, 7:20 AM
dstenb closed D67225: [DebugInfo][X86] Describe call site values for zero-valued imms.
Sun, Sep 8, 7:20 AM · Restricted Project, debug-info
dstenb committed rG8b70139e9596: [NFC] Make the describeLoadedValue() hook return machine operand objects (authored by dstenb).
[NFC] Make the describeLoadedValue() hook return machine operand objects
Sun, Sep 8, 7:06 AM
dstenb committed rL371332: [NFC] Make the describeLoadedValue() hook return machine operand objects.
[NFC] Make the describeLoadedValue() hook return machine operand objects
Sun, Sep 8, 7:03 AM
dstenb closed D67261: [NFC] Make the describeLoadedValue() hook return machine operand objects.
Sun, Sep 8, 7:03 AM · Restricted Project, debug-info
dstenb added a comment to D67225: [DebugInfo][X86] Describe call site values for zero-valued imms.

Thanks for the reviews! I'll land these commits shortly.

Sun, Sep 8, 5:59 AM · Restricted Project, debug-info

Fri, Sep 6

dstenb updated the diff for D67225: [DebugInfo][X86] Describe call site values for zero-valued imms.

Address the rest of the comments.

Fri, Sep 6, 2:04 AM · Restricted Project, debug-info
dstenb added inline comments to D67225: [DebugInfo][X86] Describe call site values for zero-valued imms.
Fri, Sep 6, 2:04 AM · Restricted Project, debug-info
dstenb added a child revision for D67261: [NFC] Make the describeLoadedValue() hook return machine operand objects: D67225: [DebugInfo][X86] Describe call site values for zero-valued imms.
Fri, Sep 6, 12:58 AM · Restricted Project, debug-info
dstenb added a parent revision for D67225: [DebugInfo][X86] Describe call site values for zero-valued imms: D67261: [NFC] Make the describeLoadedValue() hook return machine operand objects.
Fri, Sep 6, 12:58 AM · Restricted Project, debug-info
dstenb updated the diff for D67225: [DebugInfo][X86] Describe call site values for zero-valued imms.

Rebase on top of pointer -> object refactoring.

Fri, Sep 6, 12:58 AM · Restricted Project, debug-info
dstenb created D67261: [NFC] Make the describeLoadedValue() hook return machine operand objects.
Fri, Sep 6, 12:56 AM · Restricted Project, debug-info

Thu, Sep 5

dstenb added a comment to D67225: [DebugInfo][X86] Describe call site values for zero-valued imms.

I have experimented a bit with making the describeLoadedValue() hook return machine operand objects rather than pointers, as that can simplify the code slightly.

Thu, Sep 5, 7:43 AM · Restricted Project, debug-info
dstenb created D67225: [DebugInfo][X86] Describe call site values for zero-valued imms.
Thu, Sep 5, 7:30 AM · Restricted Project, debug-info

Fri, Aug 30

dstenb added inline comments to D67004: [DebugInfo] Enable call site parameter debug info for ARM and AArch64.
Fri, Aug 30, 12:01 PM · debug-info
dstenb committed rGb35d4699d093: [LiveDebugValues] Insert entry values after bundles (authored by dstenb).
[LiveDebugValues] Insert entry values after bundles
Fri, Aug 30, 2:07 AM
dstenb committed rL370448: [LiveDebugValues] Insert entry values after bundles.
[LiveDebugValues] Insert entry values after bundles
Fri, Aug 30, 2:05 AM
dstenb closed D66888: [LiveDebugValues] Insert entry values after bundles.
Fri, Aug 30, 2:05 AM · Restricted Project, debug-info

Thu, Aug 29

dstenb added inline comments to D66888: [LiveDebugValues] Insert entry values after bundles.
Thu, Aug 29, 7:53 AM · Restricted Project, debug-info
dstenb updated the diff for D66888: [LiveDebugValues] Insert entry values after bundles.

Add MachineBasicBlock::insertAfterBundle() helper function.

Thu, Aug 29, 7:34 AM · Restricted Project, debug-info

Wed, Aug 28

dstenb added a comment to D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.

I have interpreted the size as meaning the byte size of the DWARF block that the operation will cover. Assuming that, at the time of running LiveDebugValues I don't think there is a good way to query the size of the block that the entry value will cover; we don't know that until we actually emit the DWARF, as far as I can tell. That is why I have assumed that a hard coded operand of 1 is emitted there, with the assumption that only simple register location descriptions are supported.

However, I now got uncertain when looking at prependOpcodes() which is used to add the operation to the DIExpression:

Ops.push_back(dwarf::DW_OP_entry_value);
Add size info needed for entry value expression.
Add plus one for target register operand.
Ops.push_back(Expr->getNumElements() + 1);

As seen, there the number of pre-existing elements plus one is used. I don't think the number of elements does not map one-to-one with the byte size of the DWARF block, so I'm not sure how to interpret that. Can you help me understand what the operand in the DIExpression world indicates, @djtodoro?

I think your point is right. We wanted to have there hard-coded value 1 for the size of following expression. Except if we did not cover all the cases where we should avoid complex expressions, we always generate an entry value expression with an empty pre-existing DIExpression, so we assumed that this code will cover current situation and may be extended to support complex debug expressions as well. But, I also think it is hard to distinguish the size of a complex DIExpression until DWARF being printed, so maybe we can change the code to Ops.push_back(1); and put some kind of assertion there.

As far as I understand, we now emit the operation from the DIExpression as-is in the DWARF. That means that if we have a register that turns into a complex expression we will still say that the size of that expression is one byte. I have seen such cases with our downstream target, but I'll see if I can trigger that behavior with an upstream target with a source level reproducer.

If you can produce such scenario it will be desirable. We enabled the feature in this initial stage only for x86 targets, and tried to cover all the situations found for the target. We meant to cover all the places where we should avoid generation of debug entry values with complex expressions (now). Eventually, we should handle all types of expressions.

Wed, Aug 28, 9:15 AM · Restricted Project, debug-info
dstenb added inline comments to D66888: [LiveDebugValues] Insert entry values after bundles.
Wed, Aug 28, 9:00 AM · Restricted Project, debug-info
dstenb created D66888: [LiveDebugValues] Insert entry values after bundles.
Wed, Aug 28, 8:59 AM · Restricted Project, debug-info
dstenb added a comment to D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.

I have interpreted the size as meaning the byte size of the DWARF block that the operation will cover. Assuming that, at the time of running LiveDebugValues I don't think there is a good way to query the size of the block that the entry value will cover; we don't know that until we actually emit the DWARF, as far as I can tell. That is why I have assumed that a hard coded operand of 1 is emitted there, with the assumption that only simple register location descriptions are supported.

I think it would be reasonable to use the number of opcodes in the DIExpression in LLVM IR and only substitute the number of bytes in AsmPrinter.

+1. The DIExpression is more of an abstracted expression than a true DWARF expression, and even supports non-DWARF opcodes e.g. DW_OP_LLVM_convert. We can't be treating this as the size of the final expression.

Wed, Aug 28, 7:39 AM · Restricted Project, debug-info

Tue, Aug 27

dstenb added a comment to D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.
In D66746#1645802, @vsk wrote:

Thanks for the patch. Could you elaborate on what you mean by OP_entry_value only being able to wrap a single byte? Skimming the implementation, the impression I get is that a full machine-reg-expression can be attached to an OP_entry_value (see: DwarfCompileUnit::addComplexAddress).

Tue, Aug 27, 2:00 AM · Restricted Project, debug-info

Mon, Aug 26

dstenb created D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.
Mon, Aug 26, 8:15 AM · Restricted Project, debug-info
dstenb added a comment to D66467: [Codegen] skip debug instr to avoid code change.

It might be worthwhile to try to reduce the reproducer with Bugpoint.

Mon, Aug 26, 4:58 AM · Restricted Project

Aug 19 2019

dstenb added a comment to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

(A bit related to aprantl's latest comment.)

Aug 19 2019, 12:10 PM · Restricted Project, debug-info
dstenb added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Aug 19 2019, 9:38 AM · Restricted Project, debug-info
dstenb committed rG88df53e6eaf3: [DebugInfo] Allow bundled calls in the MIR's call site info (authored by dstenb).
[DebugInfo] Allow bundled calls in the MIR's call site info
Aug 19 2019, 5:41 AM
dstenb committed rL369256: [DebugInfo] Allow bundled calls in the MIR's call site info.
[DebugInfo] Allow bundled calls in the MIR's call site info
Aug 19 2019, 5:40 AM
dstenb closed D66145: [DebugInfo] Allow bundled calls in the MIR's call site info.
Aug 19 2019, 5:40 AM · Restricted Project, debug-info

Aug 15 2019

dstenb added a comment to D66145: [DebugInfo] Allow bundled calls in the MIR's call site info.

Thanks for the reviews! I can let this sit in Phabricator for a few more days to see if there are any more comments before landing it.

Aug 15 2019, 12:57 AM · Restricted Project, debug-info

Aug 14 2019

dstenb updated the diff for D66145: [DebugInfo] Allow bundled calls in the MIR's call site info.

Update test case according to comments.

Aug 14 2019, 1:30 AM · Restricted Project, debug-info

Aug 13 2019

dstenb created D66145: [DebugInfo] Allow bundled calls in the MIR's call site info.
Aug 13 2019, 8:43 AM · Restricted Project, debug-info

Aug 12 2019

dstenb committed rG9b29ec58b70e: [DebugInfo] Remove call sites when eliminating unreachable blocks (authored by dstenb).
[DebugInfo] Remove call sites when eliminating unreachable blocks
Aug 12 2019, 6:25 AM
dstenb committed rL368566: [DebugInfo] Remove call sites when eliminating unreachable blocks.
[DebugInfo] Remove call sites when eliminating unreachable blocks
Aug 12 2019, 6:24 AM
dstenb closed D64500: [DebugInfo] Remove call sites when eliminating unreachable blocks.
Aug 12 2019, 6:24 AM · Restricted Project, debug-info
dstenb added a comment to D64500: [DebugInfo] Remove call sites when eliminating unreachable blocks.

Thanks for the reviews, and sorry for taking some time to land this!

Aug 12 2019, 6:20 AM · Restricted Project, debug-info

Jul 12 2019

dstenb added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@dstenb Thanks a lot!

That seems like a good catch and we should support such scenario.

I think that it will be expensive to return a MachineOperand object.

Jul 12 2019, 4:48 AM · Restricted Project, debug-info
dstenb added a comment to D64500: [DebugInfo] Remove call sites when eliminating unreachable blocks.

I just want to add that I was a bit hesitant about generalizing the removal as I think it can be quite hard to tell when call site information has been removed, so I thought it would be better to have asserts trigger for each individual case, so that we can detect and assess what to do there, rather than dropping the information silently at the risk of false negatives.

Jul 12 2019, 2:03 AM · Restricted Project, debug-info

Jul 10 2019

dstenb created D64500: [DebugInfo] Remove call sites when eliminating unreachable blocks.
Jul 10 2019, 8:12 AM · Restricted Project, debug-info
dstenb added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

Thanks a lot for your work with this patch series! It seems very useful.

Jul 10 2019, 6:14 AM · Restricted Project, debug-info

Jul 9 2019

dstenb added a comment to D64421: [unittest] Add bogus register info..

Thanks a lot for putting the patch together so fast!

Jul 9 2019, 8:42 AM · Restricted Project
dstenb added a comment to D64261: [CodeGen] Enhance `MachineInstrSpan` to allow the end of MBB to be used..

The tests introduced in this commit currently fail when running UBSan, due to invoking getRegInfo() with RegInfo being null:

Jul 9 2019, 7:27 AM · Restricted Project

Jul 8 2019

dstenb added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

@dstenb We could land this right now, and the patch for the 'llvm-dwarfdump' stats could be a separate patch. Do you agree?

Jul 8 2019, 3:02 AM · Restricted Project, debug-info

Jul 5 2019

dstenb added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

Did you consider what should be done with llvm-dwarfdump's "scope bytes covered" statistics?

I think that it sounds reasonable to add an additional field there, something like "non-entry-val scope bytes covered".

Jul 5 2019, 1:03 AM · Restricted Project, debug-info

Jul 4 2019

dstenb added inline comments to D60716: [DwarfDebug] Dump call site debug info into DWARF.
Jul 4 2019, 7:09 AM · Restricted Project, debug-info
dstenb added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

The 'llvm-dwarfdump' does calculate the debug location statistics, but maybe we could think of reporting it with more information, since the debug location info is such important debug info. Please find a proposal for having a separate tool that will calculate only the debug location statistics on my github (https://github.com/djolertrk/llvm-locstats) and let me know if it can be useful for us. Potentially, we could add more options, functionalities, etc..

Jul 4 2019, 7:07 AM · Restricted Project, debug-info

Jul 2 2019

dstenb added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

Can you change this comment from describing what the code does (which is fairly obvious), to why it does it?

@aprantl Sure. Thanks for the comment!

I'm sorry for the late comment, but in the future I guess this could be extended so that entry_values are emitted for locals that are expressed in terms of parameters, as GCC does?

@dstenb Thanks for your attention and comments. Sure, that is the plan. This is initial set of patches that covers just non-modified function parameters. Even the initial patch within the GCC was handling just this situation. The ways for improving this (using benefits of the debug entry values) are extending the support for modified parameters (if its modification could be described as an expression over its entry value), supporting local variables, etc.

As far as I can tell, we don't tag non-parameter variables as NotModified, but can Clang later on be extended to mark them as such?

Yes, it can be extended.

Jul 2 2019, 4:10 AM · Restricted Project, debug-info
dstenb added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Jul 2 2019, 1:14 AM · Restricted Project, debug-info

Jun 13 2019

dstenb committed rG1278a1928231: Remove ';' after namespace's closing bracket [NFC] (authored by dstenb).
Remove ';' after namespace's closing bracket [NFC]
Jun 13 2019, 7:01 AM
dstenb committed rL363267: Remove ';' after namespace's closing bracket [NFC].
Remove ';' after namespace's closing bracket [NFC]
Jun 13 2019, 6:59 AM

Jun 7 2019

dstenb added inline comments to D62904: [DebugInfo] Honour variable fragments in LiveDebugValues.
Jun 7 2019, 8:36 AM · Restricted Project
dstenb added inline comments to D62904: [DebugInfo] Honour variable fragments in LiveDebugValues.
Jun 7 2019, 7:10 AM · Restricted Project

Jun 5 2019

dstenb added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

@dstenb Thanks for the comment!

Yes, we are constantly measuring debug location statistics. It is possible (and it makes sense) to extend the existing location statistic reporting, within LLVM, by avoiding locations that are entry values (we are actually working on that).

We will share the numbers.

Jun 5 2019, 10:59 AM · Restricted Project, debug-info
dstenb added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

Have you measured what the effect the emission of entry value locations has on the "scope bytes covered" statistics? I guess that it can increase quite a bit (especially later if we start describing non-parameter variables using parameter entry values)? If so, if the caller(s) do not have call site information, it will still not be able to print the variable. Would it make sense, and would it be possible, to introduce a "scope bytes covered without entry values" statistic, or some other statistic, which helps you assess how large part of the locations that rely on entry values?

Jun 5 2019, 5:40 AM · Restricted Project, debug-info

Jun 3 2019

dstenb added a comment to D61600: [DebugInfo] More precise variable range for stack locations.

Have you tested the performance when compiling Clang with ASAN enabled to make sure we're not accidentally regressing because of the more thorough single-location check?

I've built LLVM with '-DLLVM_USE_SANITIZER=Address' using downloaded clang binary to produce private clang binary. I've run tests and compiled latest version of gdb with new private binary and I didn't see any regression there. Is that what you meant?

Jun 3 2019, 3:00 AM · Restricted Project, debug-info

May 28 2019

dstenb committed rG5d0e6b6755da: Stop undef fragments from closing non-overlapping fragments (authored by dstenb).
Stop undef fragments from closing non-overlapping fragments
May 28 2019, 6:23 AM
dstenb committed rL361820: Stop undef fragments from closing non-overlapping fragments.
Stop undef fragments from closing non-overlapping fragments
May 28 2019, 6:23 AM
dstenb closed D62379: [DebugInfo] Stop undef fragments from closing non-overlapping fragments.
May 28 2019, 6:23 AM · Restricted Project, debug-info
dstenb updated the diff for D62379: [DebugInfo] Stop undef fragments from closing non-overlapping fragments.

Add a comment to the query function (undef debug values are mentioned in SourceLevelDebugging.rst, but I did not find any central explanations of such debug values in the code base).

May 28 2019, 4:29 AM · Restricted Project, debug-info

May 27 2019

dstenb accepted D61600: [DebugInfo] More precise variable range for stack locations.

Do you think that this is ready for landing now?

May 27 2019, 7:09 AM · Restricted Project, debug-info
dstenb updated the diff for D62379: [DebugInfo] Stop undef fragments from closing non-overlapping fragments.

Address comments (add MachineInstr:isUndefDebugValue query function)

May 27 2019, 7:03 AM · Restricted Project, debug-info
dstenb added inline comments to D60716: [DwarfDebug] Dump call site debug info into DWARF.
May 27 2019, 5:50 AM · Restricted Project, debug-info
dstenb added a comment to D61600: [DebugInfo] More precise variable range for stack locations.

Nit: Perhaps we should move the Value class out of DebugLocEntry now that we use it for DbgVariable also? However, I don't have any good ideas on in where to place it (e.g. which header file). I think we can land this without doing such a refactoring though.

May 27 2019, 5:17 AM · Restricted Project, debug-info
dstenb added a comment to D61600: [DebugInfo] More precise variable range for stack locations.

Thanks a lot! This "location list -> single location description" detection seems more robust, and should help us moving towards supporting rewrites of single-entry location lists containing fragments also.

May 27 2019, 4:31 AM · Restricted Project, debug-info

May 24 2019

dstenb added inline comments to D62379: [DebugInfo] Stop undef fragments from closing non-overlapping fragments.
May 24 2019, 8:23 AM · Restricted Project, debug-info
dstenb updated the diff for D62379: [DebugInfo] Stop undef fragments from closing non-overlapping fragments.

Update test cases after review comments.

May 24 2019, 8:17 AM · Restricted Project, debug-info
dstenb created D62379: [DebugInfo] Stop undef fragments from closing non-overlapping fragments.
May 24 2019, 4:49 AM · Restricted Project, debug-info
dstenb added inline comments to D62314: [DebugInfo] Use FrameDestroy to extend stack locations to the end of a function.
May 24 2019, 2:06 AM · Restricted Project

May 23 2019

dstenb added inline comments to D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location.
May 23 2019, 3:20 PM · Restricted Project, debug-info
dstenb added inline comments to D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location.
May 23 2019, 8:34 AM · Restricted Project, debug-info

May 22 2019

dstenb added a comment to D61600: [DebugInfo] More precise variable range for stack locations.

Adding a comment about another hand-written example.

May 22 2019, 3:16 PM · Restricted Project, debug-info

May 20 2019

dstenb added inline comments to D62002: [DwarfExpression] Refactor dwarf expression (NFC).
May 20 2019, 6:29 AM · Restricted Project, debug-info

May 15 2019

dstenb added inline comments to D61940: [DebugInfo] Don't always extend variable locations when the reg location is unchanging.
May 15 2019, 5:50 AM · Restricted Project
dstenb added inline comments to D61890: [LiveDebugValues] End variable's range with multiple locations at block entry.
May 15 2019, 2:03 AM · debug-info

May 7 2019

dstenb added a reviewer for D61600: [DebugInfo] More precise variable range for stack locations: jmorse.

(Adding Jeremy as reviewer as he has also been working in this area recently.)

May 7 2019, 6:22 AM · Restricted Project, debug-info
dstenb added inline comments to D61600: [DebugInfo] More precise variable range for stack locations.
May 7 2019, 3:43 AM · Restricted Project, debug-info

May 6 2019

dstenb added inline comments to D61600: [DebugInfo] More precise variable range for stack locations.
May 6 2019, 11:56 PM · Restricted Project, debug-info
dstenb added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

I cherry-picked the patches on top of r359425, and tried out some examples. Doing that, I encountered a case where entry values are not inserted with this patch.

May 6 2019, 8:47 AM · Restricted Project, debug-info

May 2 2019

dstenb added inline comments to D60716: [DwarfDebug] Dump call site debug info into DWARF.
May 2 2019, 5:47 AM · Restricted Project, debug-info

Apr 30 2019

dstenb added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

I cherry-picked the patches on top of r359425, and tried out some examples. Doing that, I encountered a case where entry values are not inserted with this patch.

Apr 30 2019, 6:50 AM · Restricted Project, debug-info

Apr 29 2019

dstenb added inline comments to D60866: [DWARF] Handle DW_OP_entry_value operand.
Apr 29 2019, 8:39 AM · Restricted Project, debug-info
dstenb added a comment to D60961: [TargetOption] Add option for enabling param entry val tracking dbg info.

(A minor comment, which is not related to the code changes themselves, is that this should be a parent revision to D58033, and not vice-versa as it is now.)

Apr 29 2019, 8:11 AM · Restricted Project, debug-info