Page MenuHomePhabricator

dstenb (David Stenberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2016, 1:55 AM (144 w, 5 d)

Recent Activity

Mon, Mar 18

dstenb committed rG8a2e4af7e750: [DebugInfo] Ignore bitcasts when lowering stack arg dbg.values (authored by dstenb).
[DebugInfo] Ignore bitcasts when lowering stack arg dbg.values
Mon, Mar 18, 4:28 AM
dstenb committed rL356363: [DebugInfo] Ignore bitcasts when lowering stack arg dbg.values.
[DebugInfo] Ignore bitcasts when lowering stack arg dbg.values
Mon, Mar 18, 4:27 AM
dstenb closed D58831: [DebugInfo] Ignore bitcasts when lowering stack arg dbg.values.
Mon, Mar 18, 4:26 AM · Restricted Project, debug-info

Wed, Mar 13

dstenb updated the diff for D59303: [DebugInfo] Pass all values in DebugLocEntry's constructor, NFC.

Move lambda expression back into assert() to avoid -Wunused-variable warning in non-assert builds.

Wed, Mar 13, 3:41 PM · Restricted Project, debug-info
Herald added a project to D57145: [DebugInfo] Remove redundant initialization of DbgVariable's MInsn, NFC: Restricted Project.

Ping.

Wed, Mar 13, 9:12 AM · Restricted Project, debug-info
dstenb added a parent revision for D59303: [DebugInfo] Pass all values in DebugLocEntry's constructor, NFC: D59301: [DebugInfo] Remove redundant DebugLocEntry::MergeValues() function, NFC.
Wed, Mar 13, 9:11 AM · Restricted Project, debug-info
dstenb added a child revision for D59301: [DebugInfo] Remove redundant DebugLocEntry::MergeValues() function, NFC: D59303: [DebugInfo] Pass all values in DebugLocEntry's constructor, NFC.
Wed, Mar 13, 9:11 AM · Restricted Project, debug-info
dstenb created D59303: [DebugInfo] Pass all values in DebugLocEntry's constructor, NFC.
Wed, Mar 13, 9:10 AM · Restricted Project, debug-info
dstenb created D59301: [DebugInfo] Remove redundant DebugLocEntry::MergeValues() function, NFC.
Wed, Mar 13, 9:07 AM · Restricted Project, debug-info
dstenb added inline comments to D58831: [DebugInfo] Ignore bitcasts when lowering stack arg dbg.values.
Wed, Mar 13, 9:02 AM · Restricted Project, debug-info

Thu, Mar 7

dstenb committed rG27ed855a6e1f: [analyzer] Handle comparison between non-default AS symbol and constant (authored by dstenb).
[analyzer] Handle comparison between non-default AS symbol and constant
Thu, Mar 7, 5:02 AM
dstenb committed rL355592: [analyzer] Handle comparison between non-default AS symbol and constant.
[analyzer] Handle comparison between non-default AS symbol and constant
Thu, Mar 7, 5:02 AM
dstenb committed rC355592: [analyzer] Handle comparison between non-default AS symbol and constant.
[analyzer] Handle comparison between non-default AS symbol and constant
Thu, Mar 7, 5:02 AM
dstenb closed D58665: [analyzer] Handle comparison between non-default AS symbol and constant.
Thu, Mar 7, 5:02 AM · Restricted Project
dstenb added a comment to D58665: [analyzer] Handle comparison between non-default AS symbol and constant.

Thanks for the review! I'll submit this shortly then.

Thu, Mar 7, 12:29 AM · Restricted Project

Wed, Mar 6

dstenb added inline comments to D58831: [DebugInfo] Ignore bitcasts when lowering stack arg dbg.values.
Wed, Mar 6, 12:47 AM · Restricted Project, debug-info

Tue, Mar 5

dstenb added inline comments to D58831: [DebugInfo] Ignore bitcasts when lowering stack arg dbg.values.
Tue, Mar 5, 7:43 AM · Restricted Project, debug-info

Fri, Mar 1

dstenb created D58831: [DebugInfo] Ignore bitcasts when lowering stack arg dbg.values.
Fri, Mar 1, 7:29 AM · Restricted Project, debug-info
dstenb added a comment to D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.

Some nitpicks.

Fri, Mar 1, 4:44 AM · Restricted Project

Wed, Feb 27

dstenb updated the diff for D58665: [analyzer] Handle comparison between non-default AS symbol and constant.

Address comments.

Wed, Feb 27, 7:53 AM · Restricted Project

Tue, Feb 26

dstenb created D58665: [analyzer] Handle comparison between non-default AS symbol and constant.
Tue, Feb 26, 1:25 AM · Restricted Project

Feb 18 2019

dstenb added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Feb 18 2019, 5:08 AM · debug-info

Feb 14 2019

dstenb abandoned D57587: NOT FOR COMMIT Print debug values in beginFunction().
Feb 14 2019, 3:51 AM

Feb 13 2019

dstenb added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Feb 13 2019, 1:19 PM · debug-info
dstenb added inline comments to D58044: [DwarfDebug] Dump call site debug info into DWARF.
Feb 13 2019, 8:27 AM · debug-info
dstenb added inline comments to D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
Feb 13 2019, 3:08 AM · debug-info
dstenb added inline comments to D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
Feb 13 2019, 3:08 AM · debug-info
dstenb committed rG9dbeca3d7786: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs (authored by dstenb).
[DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs
Feb 13 2019, 1:35 AM
dstenb committed rL353928: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.
[DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs
Feb 13 2019, 1:34 AM
dstenb closed D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.
Feb 13 2019, 1:34 AM · Restricted Project, debug-info
dstenb removed a parent revision for D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs: D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code.
Feb 13 2019, 12:39 AM · Restricted Project, debug-info
dstenb removed a child revision for D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code: D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.
Feb 13 2019, 12:39 AM · Restricted Project, debug-info

Feb 12 2019

dstenb added a comment to D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.

Thanks for the reviews! Unless there are any more comments, I'm planning on merging this tomorrow or Thursday.

Feb 12 2019, 7:28 AM · Restricted Project, debug-info
dstenb committed rGbbd2f972930e: [DebugInfo] Keep parameter DBG_VALUEs before prologue code (authored by dstenb).
[DebugInfo] Keep parameter DBG_VALUEs before prologue code
Feb 12 2019, 2:52 AM
dstenb committed rL353823: [DebugInfo] Keep parameter DBG_VALUEs before prologue code.
[DebugInfo] Keep parameter DBG_VALUEs before prologue code
Feb 12 2019, 2:51 AM
dstenb closed D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code.
Feb 12 2019, 2:51 AM · Restricted Project, debug-info

Feb 11 2019

dstenb added a comment to D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code.

Thanks for the reviews! I'm intending on landing this tomorrow.

Feb 11 2019, 7:57 AM · Restricted Project, debug-info

Feb 8 2019

dstenb added a comment to D56587: Introduce DW_OP_LLVM_convert.

How should DW_OP_convert be handled when targeting DWARF versions earlier than 5? There is the GNU extension DW_OP_GNU_convert, which GDB seems to have had support for since 2011. The operation seems to be the identical to the final version that got into DWARFv5, so LLDB should be able to handle the two variants transparently. Can we emit that GNU extension (under some limitations)?

Feb 8 2019, 6:57 AM · Restricted Project, debug-info
dstenb added inline comments to D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.
Feb 8 2019, 5:52 AM · Restricted Project, debug-info
dstenb updated the diff for D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.

Update after comment.

Feb 8 2019, 5:51 AM · Restricted Project, debug-info
dstenb added a comment to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Sorry for not noticing this before, but we noticed now that the test case is placed under test/CodeGen/X86/, although it is a simplifycfg test. Should it ideally be placed under test/Transforms/SimplifyCFG/?

Feb 8 2019, 4:03 AM · Restricted Project, debug-info

Feb 7 2019

dstenb updated the diff for D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.

I have changed the patch so that it still changes the labels for non-register debug values. This is done to reduce the regressions. I have not been able to find a C program where moving a constant-described value results in false positives. I will write a PR about getting SelectionDAG to emit debug values for constant arguments directly at the start of the function, which hopefully should make it possible to remove the rest of beginFunction() without as many regressions.

Feb 7 2019, 8:49 AM · Restricted Project, debug-info

Feb 6 2019

dstenb added inline comments to D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code.
Feb 6 2019, 4:26 AM · Restricted Project, debug-info
dstenb updated the diff for D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code.

Amend comment for stashEntryDbgValues().

Feb 6 2019, 4:24 AM · Restricted Project, debug-info

Feb 5 2019

dstenb updated the diff for D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code.

Add -mtriple to RUN line.

Feb 5 2019, 2:57 AM · Restricted Project, debug-info

Feb 4 2019

dstenb added a comment to D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.

I have divided this into three measurements:

Feb 4 2019, 6:56 AM · Restricted Project, debug-info

Feb 1 2019

dstenb added a comment to D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.

Does this have a noticeable effect on the debug info size?

Feb 1 2019, 7:34 AM · Restricted Project, debug-info
dstenb created D57587: NOT FOR COMMIT Print debug values in beginFunction().
Feb 1 2019, 7:02 AM

Jan 31 2019

dstenb added a child revision for D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code: D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.
Jan 31 2019, 6:54 AM · Restricted Project, debug-info
dstenb added a parent revision for D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs: D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code.
Jan 31 2019, 6:54 AM · Restricted Project, debug-info
dstenb created D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs.
Jan 31 2019, 6:52 AM · Restricted Project, debug-info
dstenb created D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code.
Jan 31 2019, 6:47 AM · Restricted Project, debug-info
dstenb added inline comments to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Jan 31 2019, 2:55 AM · Restricted Project, debug-info
dstenb added a comment to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Maybe it can be good to rename the test file to either the PR number, or something that says what it verifies? The "bbi-" number refer to one Ericsson's internal issue trackers, so it maybe not very useful here

Jan 31 2019, 2:32 AM · Restricted Project, debug-info

Jan 24 2019

dstenb created D57145: [DebugInfo] Remove redundant initialization of DbgVariable's MInsn, NFC.
Jan 24 2019, 2:43 AM · Restricted Project, debug-info

Jan 9 2019

dstenb committed rL350698: [DebugInfo] Omit location list entries with empty ranges.
[DebugInfo] Omit location list entries with empty ranges
Jan 9 2019, 2:02 AM
dstenb closed D55919: [DebugInfo] Omit location list entries with empty ranges.
Jan 9 2019, 2:02 AM · debug-info

Jan 8 2019

dstenb added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

This looks good to me, but I don't think I can give an official L-G-T-M.

Jan 8 2019, 7:58 AM · debug-info
dstenb added inline comments to D55919: [DebugInfo] Omit location list entries with empty ranges.
Jan 8 2019, 7:50 AM · debug-info

Jan 7 2019

dstenb added inline comments to D55919: [DebugInfo] Omit location list entries with empty ranges.
Jan 7 2019, 6:50 AM · debug-info

Dec 20 2018

dstenb created D55919: [DebugInfo] Omit location list entries with empty ranges.
Dec 20 2018, 2:51 AM · debug-info

Dec 17 2018

dstenb added inline comments to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Dec 17 2018, 1:23 AM · debug-info

Dec 14 2018

dstenb added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

I do not find the test file on trunk. Also, git log -- test/Transforms/Util/dbg-user-of-aext.ll in the git mirror does not yield anything, so it seems like the file has not previously existed either.

Is it perhaps something that is only available downstream, or am I overlooking something?

Dec 14 2018, 7:39 AM · debug-info
dstenb added a comment to D51813: [Util] Refer to [s|z]exts of args when converting dbg.declares (fix PR35400).

I do not find the test file on trunk. Also, git log -- test/Transforms/Util/dbg-user-of-aext.ll in the git mirror does not yield anything, so it seems like the file has not previously existed either.

Dec 14 2018, 7:21 AM · debug-info
dstenb added a comment to D55702: [clangd] Fix memory leak in ClangdTests..

With this patch applied we don't see any issues on our end. Thanks for the help!

Dec 14 2018, 4:44 AM

Dec 11 2018

dstenb committed rL348837: [DeadArgElim] Fixes for dbg.values using dead arg/return values.
[DeadArgElim] Fixes for dbg.values using dead arg/return values
Dec 11 2018, 2:36 AM
dstenb closed D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.
Dec 11 2018, 2:36 AM · debug-info

Dec 10 2018

dstenb added a comment to D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.

Thanks for the reviews! I'm planning on submitting this shortly then.

Dec 10 2018, 11:55 PM · debug-info
dstenb created D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.
Dec 10 2018, 7:56 AM · debug-info

Dec 4 2018

dstenb added inline comments to D55227: [DebugInfo] Don't drop dbg.value's of nullptr.
Dec 4 2018, 12:18 AM

Nov 26 2018

dstenb added a comment to D53758: Handle value uses wrapped in metadata for the use-list order.

Ping.

Nov 26 2018, 12:45 AM

Nov 15 2018

dstenb added inline comments to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 15 2018, 4:16 AM · debug-info

Nov 12 2018

dstenb updated the diff for D53758: Handle value uses wrapped in metadata for the use-list order.

Add another non-metadata user of @global_arr to the test case so that the verification of the global's use-list order fails when running without this patch. Also generalize the comment in the test case.

Nov 12 2018, 3:31 AM
dstenb added inline comments to D53758: Handle value uses wrapped in metadata for the use-list order.
Nov 12 2018, 1:18 AM

Nov 8 2018

dstenb updated the diff for D53758: Handle value uses wrapped in metadata for the use-list order.

In the previous revision I had overlooked two things in the writers:

Nov 8 2018, 6:18 AM

Nov 2 2018

dstenb committed rL345966: Allow null-valued function operands in getCalledFunction().
Allow null-valued function operands in getCalledFunction()
Nov 2 2018, 4:48 AM
dstenb closed D52537: Allow null-valued function operands in getCalledFunction().
Nov 2 2018, 4:48 AM
dstenb added a comment to D52537: Allow null-valued function operands in getCalledFunction().

Thanks for your reviews and suggestions! I'm planning on submitting this shortly.

Nov 2 2018, 1:22 AM

Nov 1 2018

dstenb added a comment to D52537: Allow null-valued function operands in getCalledFunction().

Does anyone more than @vsk have any thoughts on this?

Nov 1 2018, 3:38 AM

Oct 31 2018

dstenb added a watcher for debug-info: dstenb.
Oct 31 2018, 7:22 AM

Oct 26 2018

dstenb added a comment to D53758: Handle value uses wrapped in metadata for the use-list order.

I thought I had built up some confidence for this after a night of fuzz testing. However, first after creating this review I encountered a crash in the LL parser, which happened due to the use-list order containing too many elements with this patch.

Oct 26 2018, 7:10 AM
dstenb created D53758: Handle value uses wrapped in metadata for the use-list order.
Oct 26 2018, 6:05 AM

Oct 16 2018

dstenb resigned from D50377: [LICM] Use ICFLoopSafetyInfo in LICM.

Sorry, I can likely not give any valuable input for this review.

Oct 16 2018, 5:25 AM
dstenb committed rL344589: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.
[DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop
Oct 16 2018, 1:09 AM
dstenb closed D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.
Oct 16 2018, 1:09 AM

Oct 15 2018

dstenb added a comment to D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.

Thanks for the reviews! I'm planning on submitting this shortly.

Oct 15 2018, 1:05 AM

Oct 12 2018

dstenb added inline comments to D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.
Oct 12 2018, 6:19 AM
dstenb updated the diff for D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.

Move DbgValues and the findDbgValues() call closer to the use.

Oct 12 2018, 6:12 AM

Oct 11 2018

dstenb added a comment to D52537: Allow null-valued function operands in getCalledFunction().

Any thoughts on this?

Oct 11 2018, 7:46 AM
dstenb created D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop.
Oct 11 2018, 2:10 AM

Oct 1 2018

dstenb added a comment to D52537: Allow null-valued function operands in getCalledFunction().
In D52537#1246683, @vsk wrote:

As for the test, I think a unit test might work better (see unittests/IR/MetadataTest.cpp). If something about debug info or BDCE changes, the test will remain useful.

Oct 1 2018, 7:13 AM
dstenb updated the diff for D52537: Allow null-valued function operands in getCalledFunction().
  • Changed so that getCalledFunction() allows null valued operands.
  • Rewrote the test case to a unit test.
Oct 1 2018, 7:05 AM

Sep 27 2018

dstenb added a comment to D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..

It would be good to change the title to reflect what is done in MCP (at least before submitting this).

Sep 27 2018, 8:39 AM · debug-info

Sep 26 2018

dstenb created D52537: Allow null-valued function operands in getCalledFunction().
Sep 26 2018, 2:09 AM

Sep 7 2018

dstenb committed rL341659: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.
[DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV
Sep 7 2018, 6:55 AM
dstenb closed D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.
Sep 7 2018, 6:55 AM · debug-info

Sep 6 2018

dstenb added a comment to D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.

Thanks for the review! I'll submit this tomorrow when I have time to track the build bots.

Sep 6 2018, 6:41 AM · debug-info

Sep 5 2018

dstenb added inline comments to D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.
Sep 5 2018, 1:27 AM · debug-info
dstenb updated the diff for D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.

Removed unnecessary !dbg locations in the test. I also moved the file to test/DebugInfo/.

Sep 5 2018, 1:27 AM · debug-info
dstenb added a comment to D51612: [DebugInfo] Handle stack slot offsets for spilled sub-registers in LDV.

The best place to do the simplification / constant-folding in the DIExpresssion is in DwarfExpression.cpp, just before it gets emitted.

Sep 5 2018, 1:22 AM · debug-info