Page MenuHomePhabricator

dstenb (David Stenberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2016, 1:55 AM (223 w, 2 d)

Recent Activity

Mon, Sep 14

dstenb committed rGbfcb824ba528: [JumpThreading] Fix an incorrect Modified status (authored by dstenb).
[JumpThreading] Fix an incorrect Modified status
Mon, Sep 14, 1:37 AM
dstenb closed D87392: [JumpThreading] Fix an incorrect Modified status.
Mon, Sep 14, 1:37 AM · Restricted Project
dstenb added a comment to D87392: [JumpThreading] Fix an incorrect Modified status.

Thanks for the review!

Mon, Sep 14, 12:41 AM · Restricted Project

Thu, Sep 10

dstenb added a comment to D86812: [DebugInstrRef][1/3] Track PHI values through register allocation.

Just some drive-by nits while familiarizing myself with this patch series.

Thu, Sep 10, 9:01 AM · Restricted Project
dstenb updated the diff for D87392: [JumpThreading] Fix an incorrect Modified status.

Continue using a bool return instead of a tri-state.

Thu, Sep 10, 12:27 AM · Restricted Project
dstenb added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Thu, Sep 10, 12:03 AM · Restricted Project, debug-info

Wed, Sep 9

dstenb updated the summary of D87392: [JumpThreading] Fix an incorrect Modified status.
Wed, Sep 9, 9:30 AM · Restricted Project
dstenb requested review of D87392: [JumpThreading] Fix an incorrect Modified status.
Wed, Sep 9, 9:30 AM · Restricted Project
dstenb committed rG48fc78143876: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks (authored by dstenb).
[UnifyFunctionExitNodes] Fix Modified status for unreachable blocks
Wed, Sep 9, 4:36 AM
dstenb closed D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.
Wed, Sep 9, 4:36 AM · Restricted Project
dstenb added inline comments to D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.
Wed, Sep 9, 4:31 AM · Restricted Project

Tue, Sep 8

dstenb added a comment to D87078: [UnifyFunctionExitNodes] Remove unused getters, NFC.

Thanks, and sorry for overlooking the comments!

Tue, Sep 8, 11:44 AM · Restricted Project
dstenb committed rG17dce2fe43c9: [UnifyFunctionExitNodes] Remove unused getters, NFC (authored by dstenb).
[UnifyFunctionExitNodes] Remove unused getters, NFC
Tue, Sep 8, 11:43 AM
dstenb closed D87078: [UnifyFunctionExitNodes] Remove unused getters, NFC.
Tue, Sep 8, 11:42 AM · Restricted Project
dstenb added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Tue, Sep 8, 6:24 AM · Restricted Project, debug-info
dstenb added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Tue, Sep 8, 6:09 AM · Restricted Project, debug-info
dstenb added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

I will go through this more deeply, but just an initial comment is that I think it may be worth considering splitting it into two patches, in order to make it easier to review:

Tue, Sep 8, 5:55 AM · Restricted Project, debug-info

Thu, Sep 3

dstenb added inline comments to D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.
Thu, Sep 3, 6:25 AM · Restricted Project
dstenb added a reviewer for D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks: bjope.
Thu, Sep 3, 6:24 AM · Restricted Project
dstenb updated the diff for D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.

Address review comments.

Thu, Sep 3, 6:23 AM · Restricted Project
dstenb accepted D87024: [DebugInfo] Fix emitting DWARF64 .debug_macro[.dwo] sections (17/19)..

LGTM!

Thu, Sep 3, 5:58 AM · debug-info, Restricted Project
dstenb requested review of D87078: [UnifyFunctionExitNodes] Remove unused getters, NFC.
Thu, Sep 3, 2:18 AM · Restricted Project

Wed, Sep 2

dstenb added a comment to D85837: [GlobalOpt] Fix incorrect Modified status.

Thanks for the review!

Wed, Sep 2, 6:03 AM · Restricted Project
dstenb committed rG6d36b22b219f: [GlobalOpt] Fix an incorrect Modified status (authored by dstenb).
[GlobalOpt] Fix an incorrect Modified status
Wed, Sep 2, 6:02 AM
dstenb closed D85837: [GlobalOpt] Fix incorrect Modified status.
Wed, Sep 2, 6:02 AM · Restricted Project

Tue, Sep 1

dstenb added inline comments to D85837: [GlobalOpt] Fix incorrect Modified status.
Tue, Sep 1, 6:21 AM · Restricted Project
dstenb added a comment to D85837: [GlobalOpt] Fix incorrect Modified status.

Ping.

Tue, Sep 1, 2:53 AM · Restricted Project

Mon, Aug 24

dstenb added a comment to D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.

Gentle ping. I was not sure which reviews to add to this one, since the code has mostly remained unchanged since its original introduction in 2004, except for it being affected by wider changes.

Mon, Aug 24, 6:45 AM · Restricted Project

Aug 20 2020

dstenb committed rG8206257cb86b: [GlobalOpt] Fix an incorrect Modified status (authored by dstenb).
[GlobalOpt] Fix an incorrect Modified status
Aug 20 2020, 2:54 AM
dstenb committed rG7a1029fd1e41: Reland "[LoopUnswitch] Fix incorrect Modified status" (authored by dstenb).
Reland "[LoopUnswitch] Fix incorrect Modified status"
Aug 20 2020, 2:53 AM
dstenb closed D86149: [GlobalOpt] Fix another incorrect Modified status.
Aug 20 2020, 2:53 AM · Restricted Project
dstenb added a comment to D86149: [GlobalOpt] Fix another incorrect Modified status.

I'll land this with a comment added to the test case in the meanwhile.

Aug 20 2020, 2:38 AM · Restricted Project
dstenb added a reverting change for rGdfd447c22043: [LoopUnswitch] Fix incorrect Modified status: rGca688ae49759: Revert "[LoopUnswitch] Fix incorrect Modified status".
Aug 20 2020, 2:15 AM
dstenb committed rGca688ae49759: Revert "[LoopUnswitch] Fix incorrect Modified status" (authored by dstenb).
Revert "[LoopUnswitch] Fix incorrect Modified status"
Aug 20 2020, 2:15 AM
dstenb added a reverting change for D86085: [LoopUnswitch] Fix incorrect Modified status: rGca688ae49759: Revert "[LoopUnswitch] Fix incorrect Modified status".
Aug 20 2020, 2:15 AM · Restricted Project
dstenb committed rGdfd447c22043: [LoopUnswitch] Fix incorrect Modified status (authored by dstenb).
[LoopUnswitch] Fix incorrect Modified status
Aug 20 2020, 12:05 AM
dstenb closed D86085: [LoopUnswitch] Fix incorrect Modified status.
Aug 20 2020, 12:05 AM · Restricted Project

Aug 19 2020

dstenb added inline comments to D86149: [GlobalOpt] Fix another incorrect Modified status.
Aug 19 2020, 2:52 PM · Restricted Project

Aug 18 2020

dstenb added inline comments to D86149: [GlobalOpt] Fix another incorrect Modified status.
Aug 18 2020, 11:41 PM · Restricted Project
dstenb added a reviewer for D85837: [GlobalOpt] Fix incorrect Modified status: efriedma.
Aug 18 2020, 9:36 AM · Restricted Project
dstenb requested review of D86149: [GlobalOpt] Fix another incorrect Modified status.
Aug 18 2020, 9:36 AM · Restricted Project
dstenb requested review of D86085: [LoopUnswitch] Fix incorrect Modified status.
Aug 18 2020, 9:18 AM · Restricted Project
dstenb added a comment to D86085: [LoopUnswitch] Fix incorrect Modified status.

If you'd be able to add reproducers in follow up patch, that would be great.

Aug 18 2020, 9:17 AM · Restricted Project
dstenb updated the diff for D86085: [LoopUnswitch] Fix incorrect Modified status.

Slight refactoring of the existing test case, and add test cases for the other two returns.

Aug 18 2020, 9:16 AM · Restricted Project

Aug 17 2020

dstenb requested review of D86085: [LoopUnswitch] Fix incorrect Modified status.
Aug 17 2020, 9:10 AM · Restricted Project
dstenb added inline comments to D85971: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics.
Aug 17 2020, 12:23 AM · Restricted Project

Aug 14 2020

dstenb requested review of D85971: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics.
Aug 14 2020, 6:25 AM · Restricted Project

Aug 13 2020

dstenb committed rGe8ebebb0bde6: [InstCombine] Fix incorrect Modified status (authored by dstenb).
[InstCombine] Fix incorrect Modified status
Aug 13 2020, 6:11 AM
dstenb closed D85839: [InstCombine] Fix incorrect Modified status.
Aug 13 2020, 6:11 AM · Restricted Project

Aug 12 2020

dstenb updated the summary of D85839: [InstCombine] Fix incorrect Modified status.
Aug 12 2020, 8:13 AM · Restricted Project
dstenb requested review of D85839: [InstCombine] Fix incorrect Modified status.
Aug 12 2020, 8:13 AM · Restricted Project
dstenb requested review of D85837: [GlobalOpt] Fix incorrect Modified status.
Aug 12 2020, 7:26 AM · Restricted Project
dstenb requested review of D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.
Aug 12 2020, 1:47 AM · Restricted Project

Aug 11 2020

dstenb committed rGe2f32404727f: [DebugInfo] Allow GNU macro extension to be emitted (authored by dstenb).
[DebugInfo] Allow GNU macro extension to be emitted
Aug 11 2020, 8:01 AM
dstenb committed rGbb640645f524: [DebugInfo] Simplify DwarfDebug::emitMacro (authored by dstenb).
[DebugInfo] Simplify DwarfDebug::emitMacro
Aug 11 2020, 8:01 AM
dstenb closed D82975: [DebugInfo] Allow GNU macro extension to be emitted.
Aug 11 2020, 8:00 AM · Restricted Project, debug-info
dstenb closed D83557: [DebugInfo] Simplify DwarfDebug::emitMacro.
Aug 11 2020, 8:00 AM · debug-info, Restricted Project
dstenb committed rG91bd9db2cdbc: [DebugInfo] Allow GNU macro extension to be read (authored by dstenb).
[DebugInfo] Allow GNU macro extension to be read
Aug 11 2020, 4:31 AM
dstenb committed rG2892ed6d0fa9: [DebugInfo] Introduce GNU macro extension entry encodings (authored by dstenb).
[DebugInfo] Introduce GNU macro extension entry encodings
Aug 11 2020, 4:31 AM
dstenb committed rGa73008c1aed2: [DebugInfo] Refactor .debug_macro checks. NFCI (authored by dstenb).
[DebugInfo] Refactor .debug_macro checks. NFCI
Aug 11 2020, 4:31 AM
dstenb closed D82974: [DebugInfo] Allow GNU macro extension to be read.
Aug 11 2020, 4:31 AM · Restricted Project, debug-info
dstenb closed D82972: [DebugInfo] Introduce GNU macro extension entry encodings.
Aug 11 2020, 4:31 AM · Restricted Project, debug-info
dstenb closed D82971: [DebugInfo] Refactor .debug_macro checks. NFCI.
Aug 11 2020, 4:31 AM · Restricted Project, debug-info

Aug 10 2020

dstenb added a comment to D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

There are no FileCheck checks for the new metric, as far as I can tell?

Aug 10 2020, 6:57 AM · Restricted Project, debug-info

Aug 9 2020

dstenb added a comment to D82975: [DebugInfo] Allow GNU macro extension to be emitted.

What do you think about the patch series as it stands now, @SouraVX?

Aug 9 2020, 9:58 PM · Restricted Project, debug-info

Jul 15 2020

dstenb added a comment to D82975: [DebugInfo] Allow GNU macro extension to be emitted.

Thanks a lot for the perseverance reviewing this, @dblaikie!

Jul 15 2020, 1:31 AM · Restricted Project, debug-info

Jul 14 2020

dstenb updated the diff for D82975: [DebugInfo] Allow GNU macro extension to be emitted.

Fall back to the macinfo format for split DWARF, and add a test case for that.

Jul 14 2020, 9:13 AM · Restricted Project, debug-info
dstenb added inline comments to D82975: [DebugInfo] Allow GNU macro extension to be emitted.
Jul 14 2020, 9:12 AM · Restricted Project, debug-info

Jul 13 2020

dstenb added inline comments to D82975: [DebugInfo] Allow GNU macro extension to be emitted.
Jul 13 2020, 9:16 AM · Restricted Project, debug-info
dstenb updated the diff for D82975: [DebugInfo] Allow GNU macro extension to be emitted.

Assert on split DWARF.

Jul 13 2020, 9:12 AM · Restricted Project, debug-info

Jul 10 2020

dstenb added inline comments to D82975: [DebugInfo] Allow GNU macro extension to be emitted.
Jul 10 2020, 8:12 AM · Restricted Project, debug-info
dstenb added inline comments to D82975: [DebugInfo] Allow GNU macro extension to be emitted.
Jul 10 2020, 7:21 AM · Restricted Project, debug-info
dstenb updated the diff for D82975: [DebugInfo] Allow GNU macro extension to be emitted.

Rebase and address review comments.

Jul 10 2020, 7:19 AM · Restricted Project, debug-info
Herald added a project to D83557: [DebugInfo] Simplify DwarfDebug::emitMacro: Restricted Project.
Jul 10 2020, 7:16 AM · debug-info, Restricted Project

Jul 9 2020

dstenb added a comment to D82975: [DebugInfo] Allow GNU macro extension to be emitted.

(Sorry, I don't have a GCC trunk build readily available, so I used GCC 9.3.0 here.)

When using those flags, GCC seems to emit DW_MACRO_define_strp (DW_MACRO_GNU_define_indirect) entries, but with indexed strings as operands. Neither binutils nor GDB does consider that such entries may hold indexed strings, and just treats those operands as indirect strings, which is why they are not properly handled. "Overloading" those indirect operands with indexed strings seems very weird to me. Perhaps that is just a bug in GCC, rather than a limitation in the consumers?

Perhaps - though there was some thought put into supporting GNU debug_macro in v4/pre-standard Fission, given the DWP format had columns for both debug_macro and debug_macinfo ( https://gcc.gnu.org/wiki/DebugFissionDWP ). Don't think it's a big deal either way - if someone comes along wanting to add debug_macro support for pre-standard Fission, we can discuss what that format looks like at that point - happy enough for it to be unimplemented (& as I said before, have "-ggdb -gdwarf-4 -fdebug-macro -> debug_macro" and "-ggdb -gdwarf-4 -fdebug-macro -gsplit-dwarf -> debug_macinfo.dwo").

Jul 9 2020, 11:35 AM · Restricted Project, debug-info
dstenb added a comment to D83468: [Debuginfo] Fix for PR46653.

Could you please add a paragraph to the summary that explains why this change is done?

Jul 9 2020, 3:37 AM · debug-info, Restricted Project

Jul 8 2020

dstenb added a comment to D82975: [DebugInfo] Allow GNU macro extension to be emitted.

I think if it's about compatibility(analogous behavior with GCC), existing infra is Okay/Fine(Since same encodings are used). We just need to emit the .debug_macro section with version 4 and teach the llvm-dwarfdump to parse it correctly.

One difference though is that the GNU extension does not have anything like the strx entries that LLVM currently emits: https://github.com/gcc-mirror/gcc/blob/master/include/dwarf2.h#L425, so I assume we still need code to emit the strp entries when targeting DWARF 4?

Likely - but might want to check what GCC does - maybe it uses some kind of strx encoding that's not documented, etc.

My recollection is that .debug_macro was invented independently of the strx forms so the prototype probably wouldn't have used them. Easy enough to check whether GCC's -fdebug-macro with v4 is emitting a .debug_str_offsets section.

LLVM wouldn't be using strx forms from .debug_info for v4, and would have no other reason to emit .debug_str_offsets, so I wouldn't want LLVM to use them in a v4 compatibility mode .debug_macro section either.

GCC certainly seems to produce some kind of debug_macro.dwo section (& binutils dwp supports it in the index, if I recall correctly) using some form llvm-dwarfdump currently doesn't understand:

$ g++-tot -g3 main.cpp -c -gsplit-dwarf && llvm-objdump -h main.dwo | grep " \.debug"
  1 .debug_info.dwo        0000003c 0000000000000000 
  2 .debug_abbrev.dwo      0000003e 0000000000000000 
  3 .debug_macro.dwo       0000001e 0000000000000000 
  4 .debug_macro.dwo       00000364 0000000000000000 
  5 .debug_macro.dwo       00000013 0000000000000000 
  6 .debug_line.dwo        00000048 0000000000000000 
  7 .debug_str_offsets.dwo 000002d5 0000000000000000 
  8 .debug_str.dwo         00000e05 0000000000000000 
$ llvm-dwarfdump-tot main.dwo -debug-macro
main.dwo:       file format elf64-x86-64

.debug_macro.dwo contents:
0x00000000:
 - lineno: 19 macro: 
DW_MACINFO_invalid

I mean, I don't have strong feelings about supporting macro debug info in general, but if someone feels strongly about debug_macro GNU extension DWARFv4 support, there's certainly some GCC behavior that one could use to model the Split DWARF support for that off.

One more deciding factor to considered here(previously missed) is that: GDB(trunk) also doesn't understand GNU macro extensions(if you wish to call it) in split case.
i.e
gcc -g3 -gsplit-dwarf test.c
test.dwo contains .debug_macro.dwo forms which no tool(as of now can dump).
if you load a.out in GDB and try expanding macro(defined in source).
GDB will report

(gdb) info macro FOO
The symbol `FOO' has no definition as a C/C++ preprocessor macro
at <user-defined>:-1

on the other hand, if you try with -gstrict-dwarf -gsplit-dwarf. GDB is happy.
So at the end of the day, even if we allow GNU macro extension, things will still be broken for -gsplit-dwarf case.
Or we have to teach the debugger to understand this ?, this also hinges on the fact, what kinda form GCC uses in split-case in .debug_macro.dwo section.
That it self is unclear right ?

Jul 8 2020, 6:11 AM · Restricted Project, debug-info
dstenb added a comment to D82975: [DebugInfo] Allow GNU macro extension to be emitted.

When you say 'by default' - do you mean by default when the user requests macro debug info (via -fdebug-macro) or by default without any extra flag?
& what does GCC do? Does it have a way to emit the standard debug_macinfo in v4 and below? Or does it always emit the debug_macro GNU extension?

I'm not particularly sure of this(introduction of GNU encodings). Behavior of GCC trunk(11.0.0) is as follows:

gcc -g3 test.c -c, after dumping using objdump(2.32), GCC will create .debug_macro(sort of it's default, until you specify -gstrict-dwarf in which case GCC will generate .debug_macinfo).

As Sourabh says this is default when not emitting strict DWARF in GCC. For Clang, my intention was for it to be enabled by default for -fdebug-macro when tuning for GDB. Maybe it would also be interesting when tuning for LLDB?

Sounds alright. Not sure if the LLDB folks (@aprantl @JDevlieghere @labath) would be interested in that - a separate patch in any case.

Jul 8 2020, 5:18 AM · Restricted Project, debug-info

Jul 6 2020

dstenb updated the diff for D82975: [DebugInfo] Allow GNU macro extension to be emitted.

Rebase and address comment.

Jul 6 2020, 9:59 AM · Restricted Project, debug-info
dstenb added inline comments to D82974: [DebugInfo] Allow GNU macro extension to be read.
Jul 6 2020, 9:56 AM · Restricted Project, debug-info
dstenb updated the diff for D82974: [DebugInfo] Allow GNU macro extension to be read.

Address comments.

Jul 6 2020, 9:56 AM · Restricted Project, debug-info
dstenb added a comment to D82972: [DebugInfo] Introduce GNU macro extension entry encodings.

Do we really need this ?, Please have a look at https://sourceware.org/legacy-ml/gdb-patches/2017-02/msg00528.html
IMO, it would be unwise to commit it till the discussion thread in D82975 converges ?

Jul 6 2020, 7:55 AM · Restricted Project, debug-info
dstenb updated the summary of D82972: [DebugInfo] Introduce GNU macro extension entry encodings.
Jul 6 2020, 7:54 AM · Restricted Project, debug-info
dstenb updated the summary of D82972: [DebugInfo] Introduce GNU macro extension entry encodings.
Jul 6 2020, 7:53 AM · Restricted Project, debug-info

Jul 2 2020

dstenb added a comment to D82975: [DebugInfo] Allow GNU macro extension to be emitted.

When you say 'by default' - do you mean by default when the user requests macro debug info (via -fdebug-macro) or by default without any extra flag?
& what does GCC do? Does it have a way to emit the standard debug_macinfo in v4 and below? Or does it always emit the debug_macro GNU extension?

I'm not particularly sure of this(introduction of GNU encodings). Behavior of GCC trunk(11.0.0) is as follows:

gcc -g3 test.c -c, after dumping using objdump(2.32), GCC will create .debug_macro(sort of it's default, until you specify -gstrict-dwarf in which case GCC will generate .debug_macinfo).

Jul 2 2020, 8:37 AM · Restricted Project, debug-info
dstenb added inline comments to D82975: [DebugInfo] Allow GNU macro extension to be emitted.
Jul 2 2020, 6:57 AM · Restricted Project, debug-info

Jul 1 2020

dstenb created D82975: [DebugInfo] Allow GNU macro extension to be emitted.
Jul 1 2020, 9:10 AM · Restricted Project, debug-info
dstenb created D82974: [DebugInfo] Allow GNU macro extension to be read.
Jul 1 2020, 9:10 AM · Restricted Project, debug-info
dstenb created D82972: [DebugInfo] Introduce GNU macro extension entry encodings.
Jul 1 2020, 9:09 AM · Restricted Project, debug-info
dstenb created D82971: [DebugInfo] Refactor .debug_macro checks. NFCI.
Jul 1 2020, 9:09 AM · Restricted Project, debug-info
dstenb committed rG85460c4ea273: [DebugInfo] Do not emit entry values for composite locations (authored by dstenb).
[DebugInfo] Do not emit entry values for composite locations
Jul 1 2020, 2:08 AM
dstenb closed D75270: [DebugInfo] Do not emit entry values for composite locations.
Jul 1 2020, 2:07 AM · Restricted Project, debug-info

Jun 30 2020

dstenb added a comment to D75270: [DebugInfo] Do not emit entry values for composite locations.

Thanks, and sorry for letting this patch lay dormant. I'll land this tomorrow when I have time for the build bots.

Jun 30 2020, 1:37 PM · Restricted Project, debug-info

May 29 2020

dstenb accepted D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

LGTM. Sorry for the delay!

May 29 2020, 4:50 AM · Restricted Project, debug-info

May 25 2020

dstenb added a comment to D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

Minor comments. Looks good to me otherwise!

May 25 2020, 12:29 AM · Restricted Project, debug-info

May 14 2020

dstenb added a comment to D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug.

In beginInstruction() guard we should expect that delay slot instruction is immediately after call instruction, before label insertion.
In constructCallSiteEntryDIEs() guard we should expect that both the call instruction and its successor are followed by the same label.

@dstenb @vsk @djtodoro Thanks for your comments and, please,
let me know what do you think about this approach.

May 14 2020, 9:56 PM · Restricted Project, debug-info
dstenb accepted D78105: [CSInfo][ISEL] Call site info generation support for Mips.

Do you need help with landing this?

May 14 2020, 3:10 AM · Restricted Project, Restricted Project, debug-info

May 13 2020

dstenb added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.

I have a comment about the CHECK/PARSER test cases. Otherwise this looks good to me.

May 13 2020, 3:43 AM · Restricted Project, Restricted Project, debug-info

May 8 2020

dstenb accepted D79624: [NFC][DwarfDebug] Prefer explicit to auto type deduction.

Thanks!

May 8 2020, 6:56 AM · debug-info, Restricted Project
dstenb accepted D79616: [NFC][DwarfDebug] Avoid default capturing when using lambdas.
May 8 2020, 2:38 AM · debug-info, Restricted Project