petarj (Petar Jovanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 27 2014, 9:01 AM (229 w, 1 d)

Recent Activity

Fri, Jun 8

petarj added a comment to D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.

What's the status of this change?

Fri, Jun 8, 9:35 AM · Restricted Project

Thu, Jun 7

petarj committed rL334194: [Mips] Silencing warnings in instruction info (NFC).
[Mips] Silencing warnings in instruction info (NFC)
Thu, Jun 7, 6:10 AM
petarj closed D47876: [Mips] Silencing warnings in instruction info (NFC).
Thu, Jun 7, 6:10 AM

Wed, Jun 6

petarj committed rL334105: Change TII isCopyInstr way of returning arguments(NFC).
Change TII isCopyInstr way of returning arguments(NFC)
Wed, Jun 6, 9:40 AM
petarj closed D47364: Change TII isCopyInstr way of returning arguments(NFC).
Wed, Jun 6, 9:40 AM
petarj committed rL334071: [MIPS GlobalISel] Add lowerCall.
[MIPS GlobalISel] Add lowerCall
Wed, Jun 6, 12:31 AM
petarj closed D45627: [MIPS GlobalISel] Add lowerCall.
Wed, Jun 6, 12:31 AM

Wed, May 23

petarj committed rL333097: Silence warnings introduced with r333093.
Silence warnings introduced with r333093
Wed, May 23, 9:31 AM
petarj committed rL333093: [X86][MIPS][ARM] New machine instruction property 'isMoveReg'.
[X86][MIPS][ARM] New machine instruction property 'isMoveReg'
Wed, May 23, 8:32 AM
petarj closed D45204: [X86][MIPS][ARM] New machine instruction property 'isMoveReg'.
Wed, May 23, 8:32 AM

May 18 2018

Herald updated subscribers of D39115: [MIPS][MicroMIPS] Extending size reduction pass with LWP and SWP.
May 18 2018, 3:12 PM

May 17 2018

petarj committed rL332624: [mips] Add support for Global INValidate ASE.
[mips] Add support for Global INValidate ASE
May 17 2018, 9:34 AM
petarj closed D46268: [mips] Add support for Global INValidate ASE.
May 17 2018, 9:34 AM

May 10 2018

petarj added a comment to D46671: Use iteration instead of recursion in CFIInserter.

@violetav can you take a look?

May 10 2018, 3:31 AM
petarj added a reviewer for D46671: Use iteration instead of recursion in CFIInserter: violetav.
May 10 2018, 3:31 AM

May 7 2018

petarj committed rL331635: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.
Add option -verify-cfiinstrs to run verifier in CFIInstrInserter
May 7 2018, 7:13 AM
petarj closed D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.
May 7 2018, 7:13 AM
petarj updated the diff for D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.

Adding the test cases for -verify-cfiinstrs.

May 7 2018, 6:12 AM
petarj closed D46399: Skip unreachable blocks for CFIInstrInserter verify.

Committed in r331628. Closing the issue.

May 7 2018, 4:56 AM
petarj added a comment to rL331628: Skip unreachable blocks for CFIInstrInserter verify.

Reviewed at https://reviews.llvm.org/D46399

May 7 2018, 4:55 AM
petarj committed rL331628: Skip unreachable blocks for CFIInstrInserter verify.
Skip unreachable blocks for CFIInstrInserter verify
May 7 2018, 4:51 AM

May 4 2018

petarj added inline comments to D46399: Skip unreachable blocks for CFIInstrInserter verify.
May 4 2018, 4:14 PM
petarj updated the diff for D46399: Skip unreachable blocks for CFIInstrInserter verify.

Update the patch per comments.

May 4 2018, 4:13 PM
petarj added a comment to D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.

Instead of adding a new flag, would it be possible to make this part of the machine verifier? (-verify-machineinstrs)

May 4 2018, 2:56 PM
petarj added a comment to D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.

Seems like there should also be a test case that triggers the verify failure.

May 4 2018, 2:20 PM
petarj created D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.
May 4 2018, 11:51 AM
petarj updated the diff for D46399: Skip unreachable blocks for CFIInstrInserter verify.

Thanks Craig for the test example. The issues were related to unreachable blocks that exist with -O0, this patch now skips all of them and hopefully it will resolve issues you are seeing.

May 4 2018, 11:33 AM

May 3 2018

petarj updated the diff for D46399: Skip unreachable blocks for CFIInstrInserter verify.

Updated the patch according to the comments.

May 3 2018, 4:30 PM
petarj added a comment to D46399: Skip unreachable blocks for CFIInstrInserter verify.

It's not real. But bb4 is only reachable from bb2. I just wedged an empty block in the path from bb2 to bb3 in my previous case. So neither bb2 or bb4 are actually reachable from the start of the function.

May 3 2018, 4:13 PM
petarj added a comment to D46399: Skip unreachable blocks for CFIInstrInserter verify.

This fix fixes the original case, but its easy to break it again

target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"

; Function Attrs: noinline nounwind optnone uwtable
define hidden void @foo() #0 {
bb:
  br label %bb1

bb1:                                              ; preds = %bb3, %bb
  %tmp = icmp ne i32 0, 0
  br i1 %tmp, label %bb2, label %bb3

bb2:                                              ; preds = %bb1
  br label %bb4

bb4:                                              ; preds = %bb2
  br label %bb3

bb3:                                              ; preds = %bb4, %bb1
  br label %bb1
}

attributes #0 = { noinline nounwind optnone uwtable "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" }
May 3 2018, 3:52 PM
petarj created D46399: Skip unreachable blocks for CFIInstrInserter verify.
May 3 2018, 11:08 AM

Apr 27 2018

petarj committed rL331024: [mips] Add support for Virtualization ASE.
[mips] Add support for Virtualization ASE
Apr 27 2018, 2:15 AM
petarj closed D44905: [mips] Add support for Virtualization ASE.
Apr 27 2018, 2:15 AM

Apr 25 2018

petarj committed rL330863: Add s390x to XFAIL for illegal_read/write_test.cc.
Add s390x to XFAIL for illegal_read/write_test.cc
Apr 25 2018, 12:38 PM
petarj committed rCRT330863: Add s390x to XFAIL for illegal_read/write_test.cc.
Add s390x to XFAIL for illegal_read/write_test.cc
Apr 25 2018, 12:38 PM
petarj committed rCRT330849: Finetune supported arches for the tests added in r330840.
Finetune supported arches for the tests added in r330840
Apr 25 2018, 10:38 AM
petarj committed rL330849: Finetune supported arches for the tests added in r330840.
Finetune supported arches for the tests added in r330840
Apr 25 2018, 10:38 AM
petarj committed rCRT330840: [mips] Implement GetWriteFlag() for mips.
[mips] Implement GetWriteFlag() for mips
Apr 25 2018, 9:25 AM
petarj committed rL330840: [mips] Implement GetWriteFlag() for mips.
[mips] Implement GetWriteFlag() for mips
Apr 25 2018, 9:24 AM
petarj closed D45768: [mips] Implement GetWriteFlag() for mips.
Apr 25 2018, 9:24 AM · Restricted Project

Apr 24 2018

petarj committed rL330706: Correct dwarf unwind information in function epilogue.
Correct dwarf unwind information in function epilogue
Apr 24 2018, 3:37 AM
petarj closed D42848: Correct dwarf unwind information in function epilogue.
Apr 24 2018, 3:36 AM

Apr 12 2018

petarj committed rL329926: [MIPS GlobalISel] remove superfluous #includes (NFC).
[MIPS GlobalISel] remove superfluous #includes (NFC)
Apr 12 2018, 10:04 AM
petarj added inline comments to D44304: [MIPS GlobalISel] Select add i32, i32.
Apr 12 2018, 2:55 AM
petarj committed rL329888: [MIPS GlobalISel] minor update to MIR tests added in r329819.
[MIPS GlobalISel] minor update to MIR tests added in r329819
Apr 12 2018, 2:17 AM

Apr 11 2018

petarj committed rL329819: [MIPS GlobalISel] Select add i32, i32.
[MIPS GlobalISel] Select add i32, i32
Apr 11 2018, 8:15 AM
petarj closed D44304: [MIPS GlobalISel] Select add i32, i32.
Apr 11 2018, 8:15 AM

Mar 14 2018

petarj committed rL327511: [mips] Add support for CRC ASE.
[mips] Add support for CRC ASE
Mar 14 2018, 7:17 AM
petarj closed D44176: [mips] Add support for CRC ASE.
Mar 14 2018, 7:17 AM

Mar 12 2018

petarj added a comment to D42112: [PowerPC] Secure PLT support.

Can we get this patch in?

Mar 12 2018, 7:42 AM

Mar 8 2018

petarj added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

Is everyone OK with the patch now?

Mar 8 2018, 8:16 AM

Feb 23 2018

petarj added a comment to rL325888: [MIPS GlobalISel] Adding GlobalISel.

Hi,

Your patch broke the PowerPC sanitizers. Please fix.

It should be fixed with r325917.

Feb 23 2018, 8:14 AM
petarj committed rL325917: [mips] finish removal of unused fields in MipsInstructionSelector.
[mips] finish removal of unused fields in MipsInstructionSelector
Feb 23 2018, 7:49 AM
petarj committed rL325916: [mips] remove unused fields in MipsInstructionSelector.
[mips] remove unused fields in MipsInstructionSelector
Feb 23 2018, 7:36 AM
petarj committed rL325888: [MIPS GlobalISel] Adding GlobalISel.
[MIPS GlobalISel] Adding GlobalISel
Feb 23 2018, 3:11 AM
petarj closed D43583: [MIPS GlobalISel] Adding GlobalISel.
Feb 23 2018, 3:11 AM

Feb 22 2018

petarj accepted D43573: [mips] 6.0 Release notes.

All important work is listed.

Feb 22 2018, 6:40 AM

Feb 14 2018

petarj committed rL325119: [Utils] Salvage the debug info of DCE'ed 'and' instructions.
[Utils] Salvage the debug info of DCE'ed 'and' instructions
Feb 14 2018, 5:12 AM
petarj closed D43163: [Utils] Salvage the debug info of DCE'ed ‘and’ instructions.
Feb 14 2018, 5:12 AM · debug-info

Feb 6 2018

petarj committed rL324335: [DeadArgumentElim] Set pointer to DISubprogram before calling RAUW. NFC.
[DeadArgumentElim] Set pointer to DISubprogram before calling RAUW. NFC
Feb 6 2018, 3:14 AM
petarj closed D42794: [DeadArgumentElim] Set pointer to DISubprogram before calling RAUW. NFC.
Feb 6 2018, 3:14 AM · debug-info

Jan 31 2018

petarj committed rL323883: [DWARF] Allow duplication of tails with CFI instructions.
[DWARF] Allow duplication of tails with CFI instructions
Jan 31 2018, 8:00 AM
petarj closed D40979: [DWARF] Allow duplication of tails with CFI instructions.
Jan 31 2018, 7:59 AM

Jan 30 2018

petarj committed rL323784: [DeadArgumentElimination] Preserve llvm.dbg.values's first argument.
[DeadArgumentElimination] Preserve llvm.dbg.values's first argument
Jan 30 2018, 8:45 AM
petarj closed D42541: [DeadArgumentElimination] Preserve llvm.dbg.values's first argument.
Jan 30 2018, 8:45 AM · debug-info

Jan 22 2018

petarj committed rL323131: [mips] add warnings for using dsp and msa flags with inappropriate revisions.
[mips] add warnings for using dsp and msa flags with inappropriate revisions
Jan 22 2018, 8:45 AM
petarj closed D40490: [mips] Add warnings for using dsp and msa flags with inappropriate MIPS ISA revisions.
Jan 22 2018, 8:45 AM

Jan 19 2018

petarj committed rL323013: [TSan][MIPS] Expand sanitizer memory space to lower addresses.
[TSan][MIPS] Expand sanitizer memory space to lower addresses
Jan 19 2018, 4:08 PM
petarj committed rCRT323013: [TSan][MIPS] Expand sanitizer memory space to lower addresses.
[TSan][MIPS] Expand sanitizer memory space to lower addresses
Jan 19 2018, 4:08 PM
petarj closed D41777: [TSan][MIPS] Expand mips sanitizer memory space to include shadow mappings of low addresses.
Jan 19 2018, 4:08 PM · Restricted Project
petarj added a comment to D39053: [Bitfield] Add more cases to making the bitfield a separate location.

This sounds as a valid improvement. Can we have this code committed?

Jan 19 2018, 5:07 AM

Jan 16 2018

petarj committed rL322568: [LiveDebugValues] update kill-after-spill test with target triple.
[LiveDebugValues] update kill-after-spill test with target triple
Jan 16 2018, 7:58 AM
petarj committed rL322554: [LiveDebugValues] recognize spilled reg killed in instruction after spill.
[LiveDebugValues] recognize spilled reg killed in instruction after spill
Jan 16 2018, 6:47 AM
petarj closed D41226: [LiveDebugValues] recognize spilled register that is killed in instruction after the spill.
Jan 16 2018, 6:47 AM

Jan 9 2018

petarj committed rL322083: [EarlyCSE] Salvage debug info during DCE.
[EarlyCSE] Salvage debug info during DCE
Jan 9 2018, 7:10 AM
petarj closed D41496: [EarlyCSE] Salvage debug info during DCE.
Jan 9 2018, 7:10 AM

Jan 8 2018

petarj committed rL322020: Add lit.local.cfg in test/DebugInfo/MIR/Mips/.
Add lit.local.cfg in test/DebugInfo/MIR/Mips/
Jan 8 2018, 11:45 AM
petarj committed rL322015: [LiveDebugValues] Change condition for block termination recognition.
[LiveDebugValues] Change condition for block termination recognition
Jan 8 2018, 10:22 AM
petarj closed D41626: [LiveDebugValues]Change condition for block termination recognition.
Jan 8 2018, 10:22 AM · debug-info

Nov 30 2017

petarj added a comment to D40659: Fix the MIPS baremetal build.

The original change (r228767) was tested on Linux only (including Android). I have never tested this part of the code on any *BSD system.

Nov 30 2017, 3:39 PM
petarj added a comment to D40659: Fix the MIPS baremetal build.

Please correct this commit. This header is also present on NetBSD/MIPS.

Nov 30 2017, 2:56 PM
petarj accepted D40659: Fix the MIPS baremetal build.
Nov 30 2017, 10:27 AM

Nov 27 2017

petarj committed rL319030: [mips] fix asmstring of Ext and Ins instructions and mips16 JALRC/JRC.
[mips] fix asmstring of Ext and Ins instructions and mips16 JALRC/JRC
Nov 27 2017, 6:26 AM
petarj closed D38144: [mips][mips16] Fix asmstring of Ext and Ins instructions and mips16 JALRC and JRC by committing rL319030: [mips] fix asmstring of Ext and Ins instructions and mips16 JALRC/JRC.
Nov 27 2017, 6:26 AM

Nov 17 2017

petarj committed rL318521: [test-suite] fix unix-smail test issue when linking statically.
[test-suite] fix unix-smail test issue when linking statically
Nov 17 2017, 4:14 AM
petarj closed D40075: [test-suite] Fix unix-smail symbol clash with the symbols in libc when linking statically. by committing rL318521: [test-suite] fix unix-smail test issue when linking statically.
Nov 17 2017, 4:14 AM

Nov 16 2017

petarj added a comment to D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue.

This patch needs to be double-checked, tested again and hopefully committed.

Nov 16 2017, 4:35 AM
petarj added a reviewer for D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue: petarj.
Nov 16 2017, 4:33 AM

Nov 15 2017

petarj added reviewers for D40075: [test-suite] Fix unix-smail symbol clash with the symbols in libc when linking statically.: MatzeB, joelkevinjones, joel_k_jones.
Nov 15 2017, 3:04 PM
petarj committed rL318296: [mips] Improve genConstMult() to work with arbitrary precision.
[mips] Improve genConstMult() to work with arbitrary precision
Nov 15 2017, 7:24 AM
petarj closed D38130: [mips] Improve genConstMult() so it works with arbitrary precision by committing rL318296: [mips] Improve genConstMult() to work with arbitrary precision.
Nov 15 2017, 7:24 AM

Nov 13 2017

petarj committed rL318059: fix printing of alias instructions by removing redundant spacing.
fix printing of alias instructions by removing redundant spacing
Nov 13 2017, 10:01 AM
petarj closed D35946: Fix printing of alias instructions by removing redundant spacing by committing rL318059: fix printing of alias instructions by removing redundant spacing.
Nov 13 2017, 10:00 AM

Nov 7 2017

petarj committed rL317579: Reland "Correct dwarf unwind information in function epilogue for X86".
Reland "Correct dwarf unwind information in function epilogue for X86"
Nov 7 2017, 6:42 AM

Nov 1 2017

petarj committed rL317136: Revert "Correct dwarf unwind information in function epilogue for X86".
Revert "Correct dwarf unwind information in function epilogue for X86"
Nov 1 2017, 4:06 PM
petarj committed rL317100: Correct dwarf unwind information in function epilogue for X86.
Correct dwarf unwind information in function epilogue for X86
Nov 1 2017, 9:05 AM
petarj closed D35844: Correct dwarf unwind information in function epilogue by committing rL317100: Correct dwarf unwind information in function epilogue for X86.
Nov 1 2017, 9:05 AM

Oct 5 2017

petarj committed rL314994: [mips] implement .set dspr2 directive.
[mips] implement .set dspr2 directive
Oct 5 2017, 10:42 AM
petarj closed D38537: [mips] Implement .set dspr2 directive by committing rL314994: [mips] implement .set dspr2 directive.
Oct 5 2017, 10:42 AM
petarj added inline comments to D38537: [mips] Implement .set dspr2 directive.
Oct 5 2017, 6:00 AM