Page MenuHomePhabricator

petarj (Petar Jovanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 27 2014, 9:01 AM (254 w, 4 d)

Recent Activity

Oct 19 2018

petarj committed rL344818: [llvm-objdump] Fix --file-headers (-f) option.
[llvm-objdump] Fix --file-headers (-f) option
Oct 19 2018, 3:19 PM
petarj closed D53403: [llvm-objdump] Fix --file-headers (-f) option.
Oct 19 2018, 3:18 PM

Oct 17 2018

petarj committed rL344684: [MIPS GlobalISel] Legalize constants.
[MIPS GlobalISel] Legalize constants
Oct 17 2018, 3:32 AM
petarj closed D53077: [MIPS GlobalISel] Legalize constants.
Oct 17 2018, 3:32 AM

Oct 8 2018

petarj committed rL344007: [MIPS GlobalISel] Legalize i64 add.
[MIPS GlobalISel] Legalize i64 add
Oct 8 2018, 5:01 PM
petarj closed D52652: [MIPS GlobalISel] Legalize i64 add.
Oct 8 2018, 5:01 PM
petarj committed rL343999: [DebugInfo] Fix debug information label tests.
[DebugInfo] Fix debug information label tests
Oct 8 2018, 3:12 PM
petarj closed D52901: [DebugInfo] Fix debug information label tests..
Oct 8 2018, 3:12 PM

Sep 28 2018

petarj committed rL343315: [MIPS GlobalISel] Lower i64 arguments.
[MIPS GlobalISel] Lower i64 arguments
Sep 28 2018, 6:31 AM
petarj closed D52409: [MIPS GlobalISel] Lower i64 arguments.
Sep 28 2018, 6:31 AM

Sep 24 2018

petarj committed rL342884: [Mips][FastISel] Fix selectBranch on icmp i1.
[Mips][FastISel] Fix selectBranch on icmp i1
Sep 24 2018, 7:25 AM
petarj closed D52045: [Mips][FastISel] Fix selectBranch on icmp i1.
Sep 24 2018, 7:25 AM
petarj committed rL342871: [deadargelim] Update dbg.value of 'unused' parameters.
[deadargelim] Update dbg.value of 'unused' parameters
Sep 24 2018, 7:24 AM
petarj closed D51968: [deadargelim] Update dbg.value of 'unused' parameters.
Sep 24 2018, 7:24 AM · debug-info

Sep 11 2018

petarj committed rL341934: [MIPS] ORC JIT support.
[MIPS] ORC JIT support
Sep 11 2018, 6:13 AM
petarj closed D49665: [MIPS] ORC JIT support.
Sep 11 2018, 6:13 AM

Sep 10 2018

petarj added a comment to D49665: [MIPS] ORC JIT support.

Luka, can you please update the commit message? (e.g. "changed types in common code in few places, from uint64_t to uintptr_t" is not true anymore).

Sep 10 2018, 11:07 AM
petarj committed rL341840: [MIPS GlobalISel] Select icmp.
[MIPS GlobalISel] Select icmp
Sep 10 2018, 8:59 AM
petarj closed D51489: [MIPS GlobalISel] Select icmp.
Sep 10 2018, 8:59 AM

Aug 26 2018

petarj committed rL340697: [MIPS GlobalISel] Legalize i8 and i16 add.
[MIPS GlobalISel] Legalize i8 and i16 add
Aug 26 2018, 12:26 AM
petarj closed D51213: [MIPS GlobalISel] Legalize i8 and i16 add.
Aug 26 2018, 12:26 AM

Aug 23 2018

petarj committed rL340572: [MIPS GlobalISel] Lower i8 and i16 arguments.
[MIPS GlobalISel] Lower i8 and i16 arguments
Aug 23 2018, 1:42 PM
petarj closed D51031: [MIPS GlobalISel] Lower i8 and i16 arguments.
Aug 23 2018, 1:42 PM

Aug 21 2018

petarj committed rL340258: [MIPS GlobalISel] Select bitwise instructions.
[MIPS GlobalISel] Select bitwise instructions
Aug 21 2018, 1:16 AM
petarj closed D50183: [MIPS GlobalISel] Select bitwise instructions.
Aug 21 2018, 1:16 AM

Aug 20 2018

petarj committed rL340177: [zorg][mips] Update build failure email address to wavecomp.com.
[zorg][mips] Update build failure email address to wavecomp.com
Aug 20 2018, 7:43 AM
petarj closed D50853: [zorg][mips] Update build failure email address to wavecomp.com.
Aug 20 2018, 7:43 AM
petarj added a reviewer for D50853: [zorg][mips] Update build failure email address to wavecomp.com: abeserminji.
Aug 20 2018, 6:51 AM

Aug 16 2018

petarj added a reviewer for D50853: [zorg][mips] Update build failure email address to wavecomp.com: sdardis.
Aug 16 2018, 10:34 AM
petarj created D50853: [zorg][mips] Update build failure email address to wavecomp.com.
Aug 16 2018, 10:33 AM

Aug 1 2018

petarj committed rL338499: [MIPS GlobalISel] Select global address.
[MIPS GlobalISel] Select global address
Aug 1 2018, 2:04 AM
petarj closed D49803: [MIPS GlobalISel] Select global address.
Aug 1 2018, 2:04 AM

Jul 25 2018

petarj committed rL337912: [MIPS GlobalISel] Lower pointer arguments.
[MIPS GlobalISel] Lower pointer arguments
Jul 25 2018, 5:35 AM
petarj closed D49419: [MIPS GlobalISel] Lower pointer arguments.
Jul 25 2018, 5:35 AM

Jul 17 2018

petarj committed rL337288: [Mips][FastISel] Fix handling of icmp with i1 type.
[Mips][FastISel] Fix handling of icmp with i1 type
Jul 17 2018, 8:03 AM
petarj closed D49290: [Mips][FastISel] Fix handling of icmp with i1 type..
Jul 17 2018, 8:03 AM
petarj accepted D49290: [Mips][FastISel] Fix handling of icmp with i1 type..
Jul 17 2018, 8:02 AM
petarj requested changes to D49290: [Mips][FastISel] Fix handling of icmp with i1 type..

test/CodeGen/Mips/Fast-ISel/sel1.ll will fail with this change. Double check.

Jul 17 2018, 6:41 AM

Jul 16 2018

petarj committed rL337168: [MIPS GlobalISel] Select instructions to load and store i32 on stack.
[MIPS GlobalISel] Select instructions to load and store i32 on stack
Jul 16 2018, 6:34 AM
petarj closed D48957: [MIPS GlobalISel] Select all instructions required to load and store i32 on stack.
Jul 16 2018, 6:34 AM

Jul 13 2018

petarj committed rL336978: [LiveDebugValues] Tracking copying value between registers.
[LiveDebugValues] Tracking copying value between registers
Jul 13 2018, 1:29 AM
petarj closed D44016: [LiveDebugValues] Track transferring variable's value from one register to another.
Jul 13 2018, 1:29 AM · debug-info

Jul 3 2018

petarj committed rL336185: [MIPS GlobalISel] Lower arguments using stack.
[MIPS GlobalISel] Lower arguments using stack
Jul 3 2018, 2:36 AM
petarj closed D47934: [MIPS GlobalISel] Lower arguments using stack .
Jul 3 2018, 2:36 AM

Jul 2 2018

petarj committed rL336084: [Mips][FastISel] Do not duplicate condition while lowering branches.
[Mips][FastISel] Do not duplicate condition while lowering branches
Jul 2 2018, 2:02 AM
petarj closed D48642: [Mips][FastISel] Do not duplicate condition while lowering branches.
Jul 2 2018, 2:01 AM

Jun 29 2018

petarj committed rL335989: [mips] Support shrink-wrapping.
[mips] Support shrink-wrapping
Jun 29 2018, 9:42 AM
petarj closed D47947: [mips] Support shrink-wrapping.
Jun 29 2018, 9:41 AM

Jun 27 2018

petarj committed rL335811: [DwarfDebug] Remove unused argument (NFC).
[DwarfDebug] Remove unused argument (NFC)
Jun 27 2018, 9:55 PM
petarj closed D48590: [DwarfDebug] Remove unused argument (NFC).
Jun 27 2018, 9:55 PM · debug-info

Jun 8 2018

petarj added a comment to D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.

What's the status of this change?

Jun 8 2018, 9:35 AM · Restricted Project

Jun 7 2018

petarj committed rL334194: [Mips] Silencing warnings in instruction info (NFC).
[Mips] Silencing warnings in instruction info (NFC)
Jun 7 2018, 6:10 AM
petarj closed D47876: [Mips] Silencing warnings in instruction info (NFC).
Jun 7 2018, 6:10 AM

Jun 6 2018

petarj committed rL334105: Change TII isCopyInstr way of returning arguments(NFC).
Change TII isCopyInstr way of returning arguments(NFC)
Jun 6 2018, 9:40 AM
petarj closed D47364: Change TII isCopyInstr way of returning arguments(NFC).
Jun 6 2018, 9:40 AM
petarj committed rL334071: [MIPS GlobalISel] Add lowerCall.
[MIPS GlobalISel] Add lowerCall
Jun 6 2018, 12:31 AM
petarj closed D45627: [MIPS GlobalISel] Add lowerCall.
Jun 6 2018, 12:31 AM

May 23 2018

petarj committed rL333097: Silence warnings introduced with r333093.
Silence warnings introduced with r333093
May 23 2018, 9:31 AM
petarj committed rL333093: [X86][MIPS][ARM] New machine instruction property 'isMoveReg'.
[X86][MIPS][ARM] New machine instruction property 'isMoveReg'
May 23 2018, 8:32 AM
petarj closed D45204: [X86][MIPS][ARM] New machine instruction property 'isMoveReg'.
May 23 2018, 8:32 AM

May 18 2018

Herald updated subscribers of D39115: [MIPS][MicroMIPS] Extending size reduction pass with LWP and SWP.
May 18 2018, 3:12 PM

May 17 2018

petarj committed rL332624: [mips] Add support for Global INValidate ASE.
[mips] Add support for Global INValidate ASE
May 17 2018, 9:34 AM
petarj closed D46268: [mips] Add support for Global INValidate ASE.
May 17 2018, 9:34 AM

May 10 2018

petarj added a comment to D46671: Use iteration instead of recursion in CFIInserter.

@violetav can you take a look?

May 10 2018, 3:31 AM
petarj added a reviewer for D46671: Use iteration instead of recursion in CFIInserter: violetav.
May 10 2018, 3:31 AM

May 7 2018

petarj committed rL331635: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.
Add option -verify-cfiinstrs to run verifier in CFIInstrInserter
May 7 2018, 7:13 AM
petarj closed D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.
May 7 2018, 7:13 AM
petarj updated the diff for D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.

Adding the test cases for -verify-cfiinstrs.

May 7 2018, 6:12 AM
petarj closed D46399: Skip unreachable blocks for CFIInstrInserter verify.

Committed in r331628. Closing the issue.

May 7 2018, 4:56 AM
petarj added a comment to rL331628: Skip unreachable blocks for CFIInstrInserter verify.

Reviewed at https://reviews.llvm.org/D46399

May 7 2018, 4:55 AM
petarj committed rL331628: Skip unreachable blocks for CFIInstrInserter verify.
Skip unreachable blocks for CFIInstrInserter verify
May 7 2018, 4:51 AM

May 4 2018

petarj added inline comments to D46399: Skip unreachable blocks for CFIInstrInserter verify.
May 4 2018, 4:14 PM
petarj updated the diff for D46399: Skip unreachable blocks for CFIInstrInserter verify.

Update the patch per comments.

May 4 2018, 4:13 PM
petarj added a comment to D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.

Instead of adding a new flag, would it be possible to make this part of the machine verifier? (-verify-machineinstrs)

May 4 2018, 2:56 PM
petarj added a comment to D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.

Seems like there should also be a test case that triggers the verify failure.

May 4 2018, 2:20 PM
petarj created D46444: Add option -verify-cfiinstrs to run verifier in CFIInstrInserter.
May 4 2018, 11:51 AM
petarj updated the diff for D46399: Skip unreachable blocks for CFIInstrInserter verify.

Thanks Craig for the test example. The issues were related to unreachable blocks that exist with -O0, this patch now skips all of them and hopefully it will resolve issues you are seeing.

May 4 2018, 11:33 AM

May 3 2018

petarj updated the diff for D46399: Skip unreachable blocks for CFIInstrInserter verify.

Updated the patch according to the comments.

May 3 2018, 4:30 PM
petarj added a comment to D46399: Skip unreachable blocks for CFIInstrInserter verify.

It's not real. But bb4 is only reachable from bb2. I just wedged an empty block in the path from bb2 to bb3 in my previous case. So neither bb2 or bb4 are actually reachable from the start of the function.

May 3 2018, 4:13 PM
petarj added a comment to D46399: Skip unreachable blocks for CFIInstrInserter verify.

This fix fixes the original case, but its easy to break it again

target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"

; Function Attrs: noinline nounwind optnone uwtable
define hidden void @foo() #0 {
bb:
  br label %bb1

bb1:                                              ; preds = %bb3, %bb
  %tmp = icmp ne i32 0, 0
  br i1 %tmp, label %bb2, label %bb3

bb2:                                              ; preds = %bb1
  br label %bb4

bb4:                                              ; preds = %bb2
  br label %bb3

bb3:                                              ; preds = %bb4, %bb1
  br label %bb1
}

attributes #0 = { noinline nounwind optnone uwtable "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" }
May 3 2018, 3:52 PM
petarj created D46399: Skip unreachable blocks for CFIInstrInserter verify.
May 3 2018, 11:08 AM

Apr 27 2018

petarj committed rL331024: [mips] Add support for Virtualization ASE.
[mips] Add support for Virtualization ASE
Apr 27 2018, 2:15 AM
petarj closed D44905: [mips] Add support for Virtualization ASE.
Apr 27 2018, 2:15 AM

Apr 25 2018

petarj committed rL330863: Add s390x to XFAIL for illegal_read/write_test.cc.
Add s390x to XFAIL for illegal_read/write_test.cc
Apr 25 2018, 12:38 PM
petarj committed rCRT330863: Add s390x to XFAIL for illegal_read/write_test.cc.
Add s390x to XFAIL for illegal_read/write_test.cc
Apr 25 2018, 12:38 PM
petarj committed rCRT330849: Finetune supported arches for the tests added in r330840.
Finetune supported arches for the tests added in r330840
Apr 25 2018, 10:38 AM
petarj committed rL330849: Finetune supported arches for the tests added in r330840.
Finetune supported arches for the tests added in r330840
Apr 25 2018, 10:38 AM
petarj committed rCRT330840: [mips] Implement GetWriteFlag() for mips.
[mips] Implement GetWriteFlag() for mips
Apr 25 2018, 9:25 AM
petarj committed rL330840: [mips] Implement GetWriteFlag() for mips.
[mips] Implement GetWriteFlag() for mips
Apr 25 2018, 9:24 AM
petarj closed D45768: [mips] Implement GetWriteFlag() for mips.
Apr 25 2018, 9:24 AM · Restricted Project

Apr 24 2018

petarj committed rL330706: Correct dwarf unwind information in function epilogue.
Correct dwarf unwind information in function epilogue
Apr 24 2018, 3:37 AM
petarj closed D42848: Correct dwarf unwind information in function epilogue.
Apr 24 2018, 3:36 AM

Apr 12 2018

petarj committed rL329926: [MIPS GlobalISel] remove superfluous #includes (NFC).
[MIPS GlobalISel] remove superfluous #includes (NFC)
Apr 12 2018, 10:04 AM
petarj added inline comments to D44304: [MIPS GlobalISel] Select add i32, i32.
Apr 12 2018, 2:55 AM
petarj committed rL329888: [MIPS GlobalISel] minor update to MIR tests added in r329819.
[MIPS GlobalISel] minor update to MIR tests added in r329819
Apr 12 2018, 2:17 AM

Apr 11 2018

petarj committed rL329819: [MIPS GlobalISel] Select add i32, i32.
[MIPS GlobalISel] Select add i32, i32
Apr 11 2018, 8:15 AM
petarj closed D44304: [MIPS GlobalISel] Select add i32, i32.
Apr 11 2018, 8:15 AM

Mar 14 2018

petarj committed rL327511: [mips] Add support for CRC ASE.
[mips] Add support for CRC ASE
Mar 14 2018, 7:17 AM
petarj closed D44176: [mips] Add support for CRC ASE.
Mar 14 2018, 7:17 AM

Mar 12 2018

petarj added a comment to D42112: [PowerPC] Secure PLT support.

Can we get this patch in?

Mar 12 2018, 7:42 AM