This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] Remove & Replace old GICombiner Backend
ClosedPublic

Authored by Pierre-vh on Aug 24 2023, 12:10 AM.

Details

Summary

The MatchTable-based GlobalISel Combiner backend is the new default. There are no in-tree users left of the old backend.

  • Removed implementation of old MatchDAG-based Combiner, including tests, the backend itself and all supporting code.
  • Renamed MatchTable backend to GlobalISelCombinerEmitter.cpp + removed "-matchtable" from its CL option.
    • no need to have a verbose name as it's the only backend left now.

Diff Detail

Event Timeline

Pierre-vh created this revision.Aug 24 2023, 12:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 12:10 AM
Pierre-vh requested review of this revision.Aug 24 2023, 12:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 12:10 AM
aemerson accepted this revision.Aug 31 2023, 2:36 AM

I’ve checked with Daniel and no objections from the Apple side.

This revision is now accepted and ready to land.Aug 31 2023, 2:36 AM
This revision was landed with ongoing or failed builds.Aug 31 2023, 4:16 AM
This revision was automatically updated to reflect the committed changes.
llvm/utils/TableGen/GlobalISel/GIMatchTree.h