This is an archive of the discontinued LLVM Phabricator instance.

Differential D158252

Fix regression of D157680
ClosedPublic

Authored by XinWang10 on Aug 17 2023, 11:53 PM.

Details

Reviewers
skan
pengfei
Hahnfeld
Commits
rGb7cf9bbfde5e: Fix regression of D157680
Summary

Test cases in D157680 should be target specific, but miss some limit, add them back to make buildbot pass.

Diff Detail

Event Timeline

XinWang10 created this revision.Aug 17 2023, 11:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 11:53 PM
Herald added a subscriber: pengfei. · View Herald Transcript
XinWang10 requested review of this revision.Aug 17 2023, 11:53 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 17 2023, 11:53 PM
Herald added subscribers: llvm-commits, cfe-commits. · View Herald Transcript
XinWang10 added reviewers: skan, pengfei.Aug 17 2023, 11:54 PM
Hahnfeld accepted this revision.Aug 18 2023, 12:00 AM
Hahnfeld added a subscriber: Hahnfeld.

LG. IMHO such fixes to the tests can be committed without review :)

This revision is now accepted and ready to land.Aug 18 2023, 12:00 AM
skan accepted this revision.Aug 18 2023, 12:02 AM

LGTM

XinWang10 added a comment.Aug 18 2023, 12:07 AM
In D158252#4597933, @Hahnfeld wrote:

LG. IMHO such fixes to the tests can be committed without review :)

OK, Thanks for explanation.

This revision was landed with ongoing or failed builds.Aug 18 2023, 12:12 AM
Closed by commit rGb7cf9bbfde5e: Fix regression of D157680 (authored by XinWang10, committed by xin10.wang <wangxin8@scsel-icx-03.sc.intel.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
xin10.wang <wangxin8@scsel-icx-03.sc.intel.com> added a commit: rGb7cf9bbfde5e: Fix regression of D157680.
Harbormaster completed remote builds in B253409: Diff 551400.Aug 18 2023, 12:21 AM
Matt added a subscriber: Matt.Aug 18 2023, 11:47 AM
Matt added inline comments.
llvm/test/CodeGen/X86/x86-prefer-no-gather-no-scatter.ll
3

Thinking out loud about this combination, does it ever make sense for any subtarget to have both +fast-gather _and +prefer-no-gather features at the same time?

MaskRay added a subscriber: MaskRay.Aug 23 2023, 12:34 AM
MaskRay added inline comments.
clang/test/Driver/x86-no-gather-no-scatter.cpp
2

This may not be worth changing now because please don't use 3.4 deprecated -target for newer tests. And I'd expect that you have checked --target= as %clang_cl command uses it.

Revision Contents

PathSize
clang/
test/
Driver/
8 lines
llvm/
test/
CodeGen/
X86/
4 lines

Diff 551403

clang/test/Driver/x86-no-gather-no-scatter.cpp

/// Tests -mno-gather and -mno-scatter /// Tests -mno-gather and -mno-scatter
// RUN: %clang -c -mno-gather -### %s 2>&1 | FileCheck --check-prefix=NOGATHER %s // RUN: %clang -target x86_64-unknown-linux-gnu -c -mno-gather -### %s 2>&1 | FileCheck --check-prefix=NOGATHER %s
MaskRayUnsubmitted
Not Done
ReplyInline Actions

This may not be worth changing now because please don't use 3.4 deprecated -target for newer tests. And I'd expect that you have checked --target= as %clang_cl command uses it.

MaskRay: This may not be worth changing now because please don't use 3.4 deprecated `-target ` for newer…
// RUN: %clang_cl -c /Qgather- -### %s 2>&1 | FileCheck --check-prefix=NOGATHER %s // RUN: %clang_cl --target=x86_64-windows -c /Qgather- -### %s 2>&1 | FileCheck --check-prefix=NOGATHER %s
// NOGATHER: "-target-feature" "+prefer-no-gather" // NOGATHER: "-target-feature" "+prefer-no-gather"
// RUN: %clang -c -mno-scatter -### %s 2>&1 | FileCheck --check-prefix=NOSCATTER %s // RUN: %clang -target x86_64-unknown-linux-gnu -c -mno-scatter -### %s 2>&1 | FileCheck --check-prefix=NOSCATTER %s
// RUN: %clang_cl -c /Qscatter- -### %s 2>&1 | FileCheck --check-prefix=NOSCATTER %s // RUN: %clang_cl --target=x86_64-windows -c /Qscatter- -### %s 2>&1 | FileCheck --check-prefix=NOSCATTER %s
// NOSCATTER: "-target-feature" "+prefer-no-scatter" // NOSCATTER: "-target-feature" "+prefer-no-scatter"

llvm/test/CodeGen/X86/x86-prefer-no-gather-no-scatter.ll

; Check that if option prefer-no-gather/scatter can disable gather/scatter instructions. ; Check that if option prefer-no-gather/scatter can disable gather/scatter instructions.
; RUN: llc -mattr=+avx2,+fast-gather %s -o - | FileCheck %s --check-prefixes=GATHER ; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx2,+fast-gather %s -o - | FileCheck %s --check-prefixes=GATHER
; RUN: llc -mattr=+avx2,+fast-gather,+prefer-no-gather %s -o - | FileCheck %s --check-prefixes=NO-GATHER ; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx2,+fast-gather,+prefer-no-gather %s -o - | FileCheck %s --check-prefixes=NO-GATHER
MattUnsubmitted
Not Done
ReplyInline Actions

Thinking out loud about this combination, does it ever make sense for any subtarget to have both +fast-gather _and +prefer-no-gather features at the same time?

Matt: Thinking out loud about this combination, does it ever make sense for any subtarget to have…
; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512vl,+avx512dq < %s | FileCheck %s --check-prefix=SCATTER ; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512vl,+avx512dq < %s | FileCheck %s --check-prefix=SCATTER
; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512vl,+avx512dq,+prefer-no-gather < %s | FileCheck %s --check-prefix=SCATTER-NO-GATHER ; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512vl,+avx512dq,+prefer-no-gather < %s | FileCheck %s --check-prefix=SCATTER-NO-GATHER
; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512vl,+avx512dq,+prefer-no-scatter < %s | FileCheck %s --check-prefix=GATHER-NO-SCATTER ; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512vl,+avx512dq,+prefer-no-scatter < %s | FileCheck %s --check-prefix=GATHER-NO-SCATTER
; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512vl,+avx512dq,+prefer-no-gather,+prefer-no-scatter < %s | FileCheck %s --check-prefix=NO-SCATTER-GATHER ; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512vl,+avx512dq,+prefer-no-gather,+prefer-no-scatter < %s | FileCheck %s --check-prefix=NO-SCATTER-GATHER
@A = global [1024 x i8] zeroinitializer, align 128 @A = global [1024 x i8] zeroinitializer, align 128
@B = global [1024 x i64] zeroinitializer, align 128 @B = global [1024 x i64] zeroinitializer, align 128
@C = global [1024 x i64] zeroinitializer, align 128 @C = global [1024 x i64] zeroinitializer, align 128
▲ Show 20 Lines • Show All 188 Lines • Show Last 20 Lines