This patch fixes the issue that multiple definition of kernel environment global
variables can occur because of wrong linkage.
Fixes #64284.
Paths
| Differential D156955
[OpenMP] Fix the linkage for kernel environment global variable ClosedPublic Authored by tianshilei1992 on Aug 2 2023, 5:29 PM.
Details Summary This patch fixes the issue that multiple definition of kernel environment global Fixes #64284.
Diff Detail
Event TimelineComment Actions Assuming this is truly weak_odr, i.e. single definition that gets a symbol in the ELF. This revision is now accepted and ready to land.Aug 2 2023, 5:30 PM Comment Actions
Our previous _exec_mode is actually WeakAnyLinkage, which could potentially lead to mismatch. This revision was landed with ongoing or failed builds.Aug 3 2023, 6:33 PM Closed by commit rGc171ed4693fb: [OpenMP] Fix the linkage for kernel environment global variable (authored by tianshilei1992). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 547077 llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
mlir/test/Target/LLVMIR/omptarget-region-device-llvm.mlir
|