Page MenuHomePhabricator

gysit (Tobias Gysi)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2020, 5:34 AM (146 w, 5 d)

Recent Activity

Yesterday

gysit committed rG36fa80b04656: [mlir][llvm] Make additional int debug attribute parameters optional. (authored by gysit).
[mlir][llvm] Make additional int debug attribute parameters optional.
Tue, Nov 29, 4:06 AM · Restricted Project, Restricted Project
gysit closed D138437: [mlir][llvm] Make additional int debug attribute parameters optional..
Tue, Nov 29, 4:06 AM · Restricted Project, Restricted Project
gysit committed rGbe4b49407e69: [mlir][llvm] Import debug intrinsics from LLVMIR. (authored by gysit).
[mlir][llvm] Import debug intrinsics from LLVMIR.
Tue, Nov 29, 2:32 AM · Restricted Project, Restricted Project
gysit closed D138405: [mlir][llvm] Import debug intrinsics from LLVMIR..
Tue, Nov 29, 2:32 AM · Restricted Project, Restricted Project
gysit updated the diff for D138405: [mlir][llvm] Import debug intrinsics from LLVMIR..

Address reviewer comments.

Tue, Nov 29, 2:07 AM · Restricted Project, Restricted Project
gysit added inline comments to D138405: [mlir][llvm] Import debug intrinsics from LLVMIR..
Tue, Nov 29, 12:19 AM · Restricted Project, Restricted Project

Mon, Nov 28

gysit added a reviewer for D138437: [mlir][llvm] Make additional int debug attribute parameters optional.: rriddle.
Mon, Nov 28, 11:58 PM · Restricted Project, Restricted Project
gysit added a reviewer for D138405: [mlir][llvm] Import debug intrinsics from LLVMIR.: rriddle.
Mon, Nov 28, 11:57 PM · Restricted Project, Restricted Project

Mon, Nov 21

gysit requested review of D138437: [mlir][llvm] Make additional int debug attribute parameters optional..
Mon, Nov 21, 7:42 AM · Restricted Project, Restricted Project
gysit requested review of D138405: [mlir][llvm] Import debug intrinsics from LLVMIR..
Mon, Nov 21, 1:03 AM · Restricted Project, Restricted Project

Fri, Nov 18

gysit committed rGbc270f9ed1c8: [mlir][llvm] Iterative constant import from LLVM IR. (authored by gysit).
[mlir][llvm] Iterative constant import from LLVM IR.
Fri, Nov 18, 6:17 AM · Restricted Project, Restricted Project
gysit closed D137559: [mlir][llvm] Iterative constant import from LLVM IR..
Fri, Nov 18, 6:17 AM · Restricted Project, Restricted Project
gysit added inline comments to D137559: [mlir][llvm] Iterative constant import from LLVM IR..
Fri, Nov 18, 5:41 AM · Restricted Project, Restricted Project
gysit updated the diff for D137559: [mlir][llvm] Iterative constant import from LLVM IR..

Address comment.

Fri, Nov 18, 5:40 AM · Restricted Project, Restricted Project
gysit committed rG3f63889d58c3: [mlir][llvm] Import additional debug info from LLVMIR. (authored by gysit).
[mlir][llvm] Import additional debug info from LLVMIR.
Fri, Nov 18, 12:49 AM · Restricted Project, Restricted Project
gysit closed D138209: [mlir][llvm] Import additional debug info from LLVMIR..
Fri, Nov 18, 12:49 AM · Restricted Project, Restricted Project
gysit committed rG63502901ca44: [mlir][llvm] Make some debug info attribute parameters optional. (authored by gysit).
[mlir][llvm] Make some debug info attribute parameters optional.
Fri, Nov 18, 12:43 AM · Restricted Project, Restricted Project
gysit closed D138206: [mlir][llvm] Make some debug info attribute parameters optional..
Fri, Nov 18, 12:43 AM · Restricted Project, Restricted Project
gysit updated the diff for D138209: [mlir][llvm] Import additional debug info from LLVMIR..

Address comments.

Fri, Nov 18, 12:27 AM · Restricted Project, Restricted Project
gysit updated the diff for D138206: [mlir][llvm] Make some debug info attribute parameters optional..

Address comment.

Fri, Nov 18, 12:11 AM · Restricted Project, Restricted Project

Thu, Nov 17

gysit requested review of D138209: [mlir][llvm] Import additional debug info from LLVMIR..
Thu, Nov 17, 7:14 AM · Restricted Project, Restricted Project
gysit requested review of D138206: [mlir][llvm] Make some debug info attribute parameters optional..
Thu, Nov 17, 6:42 AM · Restricted Project, Restricted Project
gysit updated the diff for D137559: [mlir][llvm] Iterative constant import from LLVM IR..

Rebase.

Thu, Nov 17, 3:21 AM · Restricted Project, Restricted Project
gysit committed rG2c9d26478501: [mlir][llvm] Move call and gep LLVM IR import tests. (authored by gysit).
[mlir][llvm] Move call and gep LLVM IR import tests.
Thu, Nov 17, 1:42 AM · Restricted Project, Restricted Project
gysit closed D137636: [mlir][llvm] Move call and gep LLVM IR import tests..
Thu, Nov 17, 1:41 AM · Restricted Project, Restricted Project
gysit committed rG2920095d4109: [mlir][llvm] Consolidate function attribute import tests (NFC). (authored by gysit).
[mlir][llvm] Consolidate function attribute import tests (NFC).
Thu, Nov 17, 1:32 AM · Restricted Project, Restricted Project
gysit closed D137627: [mlir][llvm] Consolidate function attribute import tests (NFC)..
Thu, Nov 17, 1:31 AM · Restricted Project, Restricted Project
gysit committed rG356f41705d3b: [mlir][llvm] Test LLVM IR global variable import separately (NFC). (authored by gysit).
[mlir][llvm] Test LLVM IR global variable import separately (NFC).
Thu, Nov 17, 1:27 AM · Restricted Project, Restricted Project
gysit closed D137622: [mlir][llvm] Test LLVM IR global variable import separately (NFC)..
Thu, Nov 17, 1:26 AM · Restricted Project, Restricted Project

Tue, Nov 8

gysit updated the diff for D137622: [mlir][llvm] Test LLVM IR global variable import separately (NFC)..

Make struct type names consistent with other tests.

Tue, Nov 8, 6:02 AM · Restricted Project, Restricted Project
gysit requested review of D137636: [mlir][llvm] Move call and gep LLVM IR import tests..
Tue, Nov 8, 5:58 AM · Restricted Project, Restricted Project
gysit requested review of D137627: [mlir][llvm] Consolidate function attribute import tests (NFC)..
Tue, Nov 8, 3:39 AM · Restricted Project, Restricted Project
gysit requested review of D137622: [mlir][llvm] Test LLVM IR global variable import separately (NFC)..
Tue, Nov 8, 2:49 AM · Restricted Project, Restricted Project
gysit committed rG54fb17347bc0: [mlir][llvm] Test LLVM IR constant import separately. (authored by gysit).
[mlir][llvm] Test LLVM IR constant import separately.
Tue, Nov 8, 12:36 AM · Restricted Project, Restricted Project
gysit closed D137416: [mlir][llvm] Test LLVM IR constant import separately..
Tue, Nov 8, 12:36 AM · Restricted Project, Restricted Project
gysit committed rG9aae3dd94c88: [mlir][llvm] Update insertion point handling in LLVM import. (authored by gysit).
[mlir][llvm] Update insertion point handling in LLVM import.
Tue, Nov 8, 12:21 AM · Restricted Project, Restricted Project
gysit closed D136679: [mlir][llvm] Update insertion point handling in LLVM import..
Tue, Nov 8, 12:21 AM · Restricted Project, Restricted Project

Mon, Nov 7

gysit requested review of D137559: [mlir][llvm] Iterative constant import from LLVM IR..
Mon, Nov 7, 8:45 AM · Restricted Project, Restricted Project

Fri, Nov 4

gysit requested review of D137416: [mlir][llvm] Test LLVM IR constant import separately..
Fri, Nov 4, 5:35 AM · Restricted Project, Restricted Project
gysit updated the summary of D136679: [mlir][llvm] Update insertion point handling in LLVM import..
Fri, Nov 4, 2:36 AM · Restricted Project, Restricted Project
gysit updated the diff for D136679: [mlir][llvm] Update insertion point handling in LLVM import..

Address comments by tracking the insertion points using Operation* / Block*.

Fri, Nov 4, 2:35 AM · Restricted Project, Restricted Project

Oct 26 2022

gysit added inline comments to D136225: [mlir][llvmir] Support FastmathFlags for LLVM intrinsic operations..
Oct 26 2022, 11:07 PM · Restricted Project, Restricted Project, Restricted Project
gysit added inline comments to D136679: [mlir][llvm] Update insertion point handling in LLVM import..
Oct 26 2022, 4:53 AM · Restricted Project, Restricted Project
gysit added inline comments to D136679: [mlir][llvm] Update insertion point handling in LLVM import..
Oct 26 2022, 4:48 AM · Restricted Project, Restricted Project
gysit added inline comments to D136746: [mlir] Saturation arithmetic intrinsics.
Oct 26 2022, 4:26 AM · Restricted Project, Restricted Project
gysit added a comment to D136746: [mlir] Saturation arithmetic intrinsics.

Looks good from my side modulo the nit comment. Let's wait for @ftynse (the code owner) for the final approval.

Oct 26 2022, 4:24 AM · Restricted Project, Restricted Project
gysit added inline comments to D136746: [mlir] Saturation arithmetic intrinsics.
Oct 26 2022, 1:59 AM · Restricted Project, Restricted Project
gysit committed rG606634967da2: [mlir][llvm] Tighten LLVM dialect intrinsic type constraints. (authored by gysit).
[mlir][llvm] Tighten LLVM dialect intrinsic type constraints.
Oct 26 2022, 1:36 AM · Restricted Project, Restricted Project
gysit closed D136360: [mlir][llvm] Tighten LLVM dialect intrinsic type constraints..
Oct 26 2022, 1:35 AM · Restricted Project, Restricted Project

Oct 25 2022

gysit requested review of D136679: [mlir][llvm] Update insertion point handling in LLVM import..
Oct 25 2022, 6:23 AM · Restricted Project, Restricted Project
gysit committed rG14de3d5c634b: [mlir][llvm] Don't return a dangling reference in getCallableResults(). (authored by definelicht).
[mlir][llvm] Don't return a dangling reference in getCallableResults().
Oct 25 2022, 6:07 AM · Restricted Project, Restricted Project
gysit closed D136669: [mlir][llvm] Don't return a dangling reference in getCallableResults()..
Oct 25 2022, 6:06 AM · Restricted Project, Restricted Project
gysit added a comment to D136360: [mlir][llvm] Tighten LLVM dialect intrinsic type constraints..

@dcaballe I changed the integer type constraints on the vector predicate intrinsics from AnyInteger to AnySignlessInteger as well. I hope this does not conflict with your changes.

Oct 25 2022, 5:50 AM · Restricted Project, Restricted Project
gysit updated the diff for D136360: [mlir][llvm] Tighten LLVM dialect intrinsic type constraints..

Address comments:

  • use @below instead of @+1
  • use AnySignlessInteger for all intrinsics
Oct 25 2022, 5:44 AM · Restricted Project, Restricted Project

Oct 20 2022

gysit requested review of D136360: [mlir][llvm] Tighten LLVM dialect intrinsic type constraints..
Oct 20 2022, 7:46 AM · Restricted Project, Restricted Project

Oct 19 2022

gysit committed rG3ee58598c541: [mlir][llvm] Use longer variable names in LLVM IR import (NFC). (authored by gysit).
[mlir][llvm] Use longer variable names in LLVM IR import (NFC).
Oct 19 2022, 10:55 PM · Restricted Project, Restricted Project
gysit closed D136246: [mlir][llvm] Use longer variable names in LLVM IR import (NFC)..
Oct 19 2022, 10:54 PM · Restricted Project, Restricted Project
gysit updated the diff for D136246: [mlir][llvm] Use longer variable names in LLVM IR import (NFC)..

Fix formatting.

Oct 19 2022, 1:02 PM · Restricted Project, Restricted Project
gysit requested review of D136246: [mlir][llvm] Use longer variable names in LLVM IR import (NFC)..
Oct 19 2022, 4:25 AM · Restricted Project, Restricted Project
gysit committed rG388361590677: [mlir][llvm] Ordered traversal in LLVM IR import. (authored by gysit).
[mlir][llvm] Ordered traversal in LLVM IR import.
Oct 19 2022, 2:58 AM · Restricted Project, Restricted Project
gysit closed D136230: [mlir][llvm] Ordered traversal in LLVM IR import..
Oct 19 2022, 2:58 AM · Restricted Project, Restricted Project
gysit requested review of D136230: [mlir][llvm] Ordered traversal in LLVM IR import..
Oct 19 2022, 12:13 AM · Restricted Project, Restricted Project

Oct 18 2022

gysit committed rGb3ed69d37ce2: [mlir][llvm] Import matrix, vector, and assume intrinsics from LLVM IR. (authored by gysit).
[mlir][llvm] Import matrix, vector, and assume intrinsics from LLVM IR.
Oct 18 2022, 1:12 AM · Restricted Project, Restricted Project
gysit closed D136137: [mlir][llvm] Import matrix, vector, and assume intrinsics from LLVM IR..
Oct 18 2022, 1:12 AM · Restricted Project, Restricted Project
gysit updated the diff for D136137: [mlir][llvm] Import matrix, vector, and assume intrinsics from LLVM IR..

Remove redunant variable name in assume intrinsic declaration.

Oct 18 2022, 12:59 AM · Restricted Project, Restricted Project
gysit added a comment to D136137: [mlir][llvm] Import matrix, vector, and assume intrinsics from LLVM IR..

While you are looking at these, maybe we can also have more specific type constraints than the generic LLVM_Type?

Oct 18 2022, 12:48 AM · Restricted Project, Restricted Project

Oct 17 2022

gysit requested review of D136137: [mlir][llvm] Import matrix, vector, and assume intrinsics from LLVM IR..
Oct 17 2022, 11:58 PM · Restricted Project, Restricted Project
gysit committed rG5942456a30ea: [mlir][llvm] Add support for importing masked intrinsics from LLVM IR. (authored by gysit).
[mlir][llvm] Add support for importing masked intrinsics from LLVM IR.
Oct 17 2022, 5:55 AM · Restricted Project, Restricted Project
gysit closed D136058: [mlir][llvm] Add support for importing masked intrinsics from LLVM IR..
Oct 17 2022, 5:55 AM · Restricted Project, Restricted Project
gysit committed rGf471acfd03ce: [mlir][llvm] Use the tablegen error handling (NFC). (authored by gysit).
[mlir][llvm] Use the tablegen error handling (NFC).
Oct 17 2022, 5:42 AM · Restricted Project, Restricted Project
gysit closed D136057: [mlir][llvm] Use the tablegen error handling (NFC)..
Oct 17 2022, 5:42 AM · Restricted Project, Restricted Project
gysit updated the diff for D136058: [mlir][llvm] Add support for importing masked intrinsics from LLVM IR..

Address comments.

Oct 17 2022, 5:28 AM · Restricted Project, Restricted Project
gysit added inline comments to D136058: [mlir][llvm] Add support for importing masked intrinsics from LLVM IR..
Oct 17 2022, 4:37 AM · Restricted Project, Restricted Project
gysit updated the summary of D136057: [mlir][llvm] Use the tablegen error handling (NFC)..
Oct 17 2022, 4:28 AM · Restricted Project, Restricted Project
gysit updated the diff for D136057: [mlir][llvm] Use the tablegen error handling (NFC)..

Address comments.

Oct 17 2022, 4:27 AM · Restricted Project, Restricted Project
gysit added a comment to D136057: [mlir][llvm] Use the tablegen error handling (NFC)..

This sounds strange. Maybe try running under the debugger. Also check that the same compiler flags are getting used for tools and for libraries, maybe some cross-compilation related weirdness is involved.

Oct 17 2022, 2:22 AM · Restricted Project, Restricted Project
gysit updated the diff for D136058: [mlir][llvm] Add support for importing masked intrinsics from LLVM IR..

Address comments.

Oct 17 2022, 1:28 AM · Restricted Project, Restricted Project
gysit added inline comments to D136058: [mlir][llvm] Add support for importing masked intrinsics from LLVM IR..
Oct 17 2022, 1:04 AM · Restricted Project, Restricted Project
gysit added a comment to D136057: [mlir][llvm] Use the tablegen error handling (NFC)..

It looks like the point of a custom method was to exit more gracefully than abort. Can you comment on why harder failures are desired?

Oct 17 2022, 12:52 AM · Restricted Project, Restricted Project
gysit requested review of D136058: [mlir][llvm] Add support for importing masked intrinsics from LLVM IR..
Oct 17 2022, 12:20 AM · Restricted Project, Restricted Project
gysit requested review of D136057: [mlir][llvm] Use the tablegen error handling (NFC)..
Oct 17 2022, 12:03 AM · Restricted Project, Restricted Project

Oct 16 2022

gysit resigned from D119904: [mlir][Linalg] Generalize identity generic op removal to handle trivial broadcasts..
Oct 16 2022, 12:20 AM · Restricted Project, Restricted Project
gysit resigned from D120027: [mlir][linalg] Support arbitrary element types in named operations via attributes.
Oct 16 2022, 12:19 AM · Restricted Project, Restricted Project

Oct 14 2022

gysit committed rG9f13900371c4: [mlir][llvm] Use tablegen to import atomic ops from LLVM IR. (authored by gysit).
[mlir][llvm] Use tablegen to import atomic ops from LLVM IR.
Oct 14 2022, 5:26 AM · Restricted Project, Restricted Project
gysit closed D135944: [mlir][llvm] Use tablegen to import atomic ops from LLVM IR..
Oct 14 2022, 5:26 AM · Restricted Project, Restricted Project
gysit committed rGea9cae03d780: [mlir][llvm] Use tablegen to import shufflevector from LLVM IR. (authored by gysit).
[mlir][llvm] Use tablegen to import shufflevector from LLVM IR.
Oct 14 2022, 4:59 AM · Restricted Project, Restricted Project
gysit closed D135880: [mlir][llvm] Use tablegen to import shufflevector from LLVM IR..
Oct 14 2022, 4:59 AM · Restricted Project, Restricted Project
gysit committed rG7114185f4e51: [mlir][llvm] Use tablegen to import extract/insert ops from LLVM IR. (authored by gysit).
[mlir][llvm] Use tablegen to import extract/insert ops from LLVM IR.
Oct 14 2022, 12:10 AM · Restricted Project, Restricted Project
gysit closed D135874: [mlir][llvm] Use tablegen to import extract/insert ops from LLVM IR..
Oct 14 2022, 12:10 AM · Restricted Project, Restricted Project

Oct 13 2022

gysit requested review of D135944: [mlir][llvm] Use tablegen to import atomic ops from LLVM IR..
Oct 13 2022, 11:30 PM · Restricted Project, Restricted Project
gysit added inline comments to D135880: [mlir][llvm] Use tablegen to import shufflevector from LLVM IR..
Oct 13 2022, 9:12 AM · Restricted Project, Restricted Project
gysit requested review of D135880: [mlir][llvm] Use tablegen to import shufflevector from LLVM IR..
Oct 13 2022, 8:12 AM · Restricted Project, Restricted Project
gysit updated the diff for D135874: [mlir][llvm] Use tablegen to import extract/insert ops from LLVM IR..

Move tests close to the extract/insert element tests.

Oct 13 2022, 7:57 AM · Restricted Project, Restricted Project
gysit requested review of D135874: [mlir][llvm] Use tablegen to import extract/insert ops from LLVM IR..
Oct 13 2022, 6:59 AM · Restricted Project, Restricted Project
gysit committed rGcc49a74a7bc6: [mlir][llvm] Use TableGen to import compare ops from LLVM IR. (authored by gysit).
[mlir][llvm] Use TableGen to import compare ops from LLVM IR.
Oct 13 2022, 5:34 AM · Restricted Project, Restricted Project
gysit closed D135855: [mlir][llvm] Use TableGen to import compare ops from LLVM IR..
Oct 13 2022, 5:34 AM · Restricted Project, Restricted Project
gysit updated the diff for D135855: [mlir][llvm] Use TableGen to import compare ops from LLVM IR..

Address comments.

Oct 13 2022, 3:04 AM · Restricted Project, Restricted Project
gysit added inline comments to D135855: [mlir][llvm] Use TableGen to import compare ops from LLVM IR..
Oct 13 2022, 1:31 AM · Restricted Project, Restricted Project
gysit requested review of D135855: [mlir][llvm] Use TableGen to import compare ops from LLVM IR..
Oct 13 2022, 12:51 AM · Restricted Project, Restricted Project

Oct 12 2022

gysit committed rGa938f3a9b58d: [mlir] Fix bitwidth of memref-to-llvm constant. (authored by gysit).
[mlir] Fix bitwidth of memref-to-llvm constant.
Oct 12 2022, 7:18 AM · Restricted Project, Restricted Project