Page MenuHomePhabricator

gysit (Tobias Gysi)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2020, 5:34 AM (95 w, 3 d)

Recent Activity

Yesterday

gysit committed rG69bcff46bff3: [mlir][linalg] Pad independent of application order (NFC). (authored by gysit).
[mlir][linalg] Pad independent of application order (NFC).
Sun, Dec 5, 11:36 PM
gysit closed D114851: [mlir][linalg] Pad independent of application order (NFC)..
Sun, Dec 5, 11:36 PM · Restricted Project

Wed, Dec 1

gysit updated the diff for D114868: [mlir][linalg] Update transformation marker if no other pattern matches..

Improve comment.

Wed, Dec 1, 6:13 AM · Restricted Project
gysit requested review of D114869: [mlir][linalg] Shorter prefixes in CodegenStrategy test (NFC)..
Wed, Dec 1, 6:00 AM · Restricted Project
gysit requested review of D114868: [mlir][linalg] Update transformation marker if no other pattern matches..
Wed, Dec 1, 5:59 AM · Restricted Project
gysit updated the diff for D114855: [mlir][linalg] Support generalization of generic..

Updated comment.

Wed, Dec 1, 5:59 AM · Restricted Project
gysit requested review of D114855: [mlir][linalg] Support generalization of generic..
Wed, Dec 1, 1:41 AM · Restricted Project
gysit accepted D114852: [mlir] Add a helper for TiledLoopOp to get an operand tied to the bbArg..
Wed, Dec 1, 12:28 AM · Restricted Project
gysit added a reviewer for D114851: [mlir][linalg] Pad independent of application order (NFC).: mehdi_amini.

@mehdi_amini this patch makes the padding robust with respect to the pattern application order and should address the concern you raised in https://reviews.llvm.org/D114689.

Wed, Dec 1, 12:20 AM · Restricted Project
gysit requested review of D114851: [mlir][linalg] Pad independent of application order (NFC)..
Wed, Dec 1, 12:18 AM · Restricted Project

Tue, Nov 30

gysit committed rGc8f2139eb0de: [mlir][linalg] Add decompose to CodegenStrategy. (authored by gysit).
[mlir][linalg] Add decompose to CodegenStrategy.
Tue, Nov 30, 7:55 AM
gysit closed D114798: [mlir][linalg] Add decompose to CodegenStrategy..
Tue, Nov 30, 7:54 AM · Restricted Project
gysit committed rG98dbcff19cfe: [mlir][linalg] Adapt the decompose patterns to use a filter (NFC). (authored by gysit).
[mlir][linalg] Adapt the decompose patterns to use a filter (NFC).
Tue, Nov 30, 7:47 AM
gysit closed D114797: [mlir][linalg] Adapt the decompose patterns to use a filter (NFC)..
Tue, Nov 30, 7:47 AM · Restricted Project
gysit committed rG316e627c2b98: [mlir][linalg] Support the empty anchor op string when padding. (authored by gysit).
[mlir][linalg] Support the empty anchor op string when padding.
Tue, Nov 30, 7:38 AM
gysit closed D114690: [mlir][linalg] Support the empty anchor op string when padding..
Tue, Nov 30, 7:37 AM · Restricted Project
gysit committed rG7f7103cd06b0: [mlir][linalg] Use top down traversal for padding. (authored by gysit).
[mlir][linalg] Use top down traversal for padding.
Tue, Nov 30, 7:31 AM
gysit closed D114689: [mlir][linalg] Use top down traversal for padding..
Tue, Nov 30, 7:31 AM · Restricted Project
gysit committed rG1ae7342a7dd4: [mlir][linalg] Fix windows build issue in hoist padding. (authored by gysit).
[mlir][linalg] Fix windows build issue in hoist padding.
Tue, Nov 30, 7:22 AM
gysit closed D114775: [mlir][linalg] Fix windows build issue in hoist padding..
Tue, Nov 30, 7:22 AM · Restricted Project
gysit committed rG914e72d40014: [mlir][linalg] Run CSE after every CodegenStrategy transformation. (authored by gysit).
[mlir][linalg] Run CSE after every CodegenStrategy transformation.
Tue, Nov 30, 7:09 AM
gysit closed D114585: [mlir][linalg] Run CSE after every CodegenStrategy transformation..
Tue, Nov 30, 7:09 AM · Restricted Project
gysit updated the diff for D114798: [mlir][linalg] Add decompose to CodegenStrategy..

Move decompose in front of generalization.

Tue, Nov 30, 6:47 AM · Restricted Project
gysit updated the diff for D114797: [mlir][linalg] Adapt the decompose patterns to use a filter (NFC)..

Rebase.

Tue, Nov 30, 6:46 AM · Restricted Project
gysit updated the diff for D114690: [mlir][linalg] Support the empty anchor op string when padding..

Rebase.

Tue, Nov 30, 6:45 AM · Restricted Project
gysit requested review of D114798: [mlir][linalg] Add decompose to CodegenStrategy..
Tue, Nov 30, 6:25 AM · Restricted Project
gysit updated the diff for D114797: [mlir][linalg] Adapt the decompose patterns to use a filter (NFC)..

Rebase.

Tue, Nov 30, 6:23 AM · Restricted Project
gysit requested review of D114797: [mlir][linalg] Adapt the decompose patterns to use a filter (NFC)..
Tue, Nov 30, 6:21 AM · Restricted Project
gysit updated the diff for D114585: [mlir][linalg] Run CSE after every CodegenStrategy transformation..

Run CSE from within the enabeling pass using a dynamic pass pipeline.

Tue, Nov 30, 1:34 AM · Restricted Project
gysit committed rG0d0371f58ff0: [mlir][OpDSL] Fix OpDSL tests after https://reviews.llvm.org/D114680. (authored by gysit).
[mlir][OpDSL] Fix OpDSL tests after https://reviews.llvm.org/D114680.
Tue, Nov 30, 12:58 AM
gysit closed D114731: [mlir][OpDSL] Fix OpDSL tests after https://reviews.llvm.org/D114680..
Tue, Nov 30, 12:58 AM · Restricted Project
gysit added a comment to D114731: [mlir][OpDSL] Fix OpDSL tests after https://reviews.llvm.org/D114680..

Good point! Still working on making my patches smaller and one thing at the time only...

Tue, Nov 30, 12:49 AM · Restricted Project
gysit updated the diff for D114731: [mlir][OpDSL] Fix OpDSL tests after https://reviews.llvm.org/D114680..

Address comment.

Tue, Nov 30, 12:42 AM · Restricted Project

Mon, Nov 29

gysit added a reviewer for D114775: [mlir][linalg] Fix windows build issue in hoist padding.: hpmorgan.

@hpmorgan I hope I found the right henry morgan and this fixes the issue. Let's follow up here!

Mon, Nov 29, 11:59 PM · Restricted Project
gysit requested review of D114775: [mlir][linalg] Fix windows build issue in hoist padding..
Mon, Nov 29, 11:55 PM · Restricted Project
gysit added a reviewer for D114731: [mlir][OpDSL] Fix OpDSL tests after https://reviews.llvm.org/D114680.: stellaraccident.
Mon, Nov 29, 11:59 AM · Restricted Project
gysit requested review of D114731: [mlir][OpDSL] Fix OpDSL tests after https://reviews.llvm.org/D114680..
Mon, Nov 29, 11:56 AM · Restricted Project

Sun, Nov 28

gysit requested review of D114690: [mlir][linalg] Support the empty anchor op string when padding..
Sun, Nov 28, 11:29 PM · Restricted Project
gysit requested review of D114689: [mlir][linalg] Use top down traversal for padding..
Sun, Nov 28, 11:28 PM · Restricted Project

Fri, Nov 26

gysit added inline comments to D114585: [mlir][linalg] Run CSE after every CodegenStrategy transformation..
Fri, Nov 26, 1:47 AM · Restricted Project

Thu, Nov 25

gysit committed rG8d07ba817c98: [mlir][linalg] Simplify the hoist padding tests. (authored by gysit).
[mlir][linalg] Simplify the hoist padding tests.
Thu, Nov 25, 11:41 PM
gysit closed D114608: [mlir][linalg] Simplify the hoist padding tests..
Thu, Nov 25, 11:40 PM · Restricted Project
gysit requested review of D114608: [mlir][linalg] Simplify the hoist padding tests..
Thu, Nov 25, 11:02 AM · Restricted Project
gysit requested review of D114585: [mlir][linalg] Run CSE after every CodegenStrategy transformation..
Thu, Nov 25, 5:12 AM · Restricted Project
gysit committed rG43dc6d5d57d7: [mlir][linalg] Cleanup hoisting test (NFC). (authored by gysit).
[mlir][linalg] Cleanup hoisting test (NFC).
Thu, Nov 25, 2:47 AM
gysit closed D114442: [mlir][linalg] Cleanup hoisting test (NFC)..
Thu, Nov 25, 2:46 AM · Restricted Project
gysit committed rG4b03906346a8: [mlir][linalg] Perform checks early in hoist padding. (authored by gysit).
[mlir][linalg] Perform checks early in hoist padding.
Thu, Nov 25, 2:41 AM
gysit closed D114438: [mlir][linalg] Perform checks early in hoist padding..
Thu, Nov 25, 2:41 AM · Restricted Project
gysit committed rGfd723eaa9254: [mlir][linalg] Limit hoist padding to constant paddings. (authored by gysit).
[mlir][linalg] Limit hoist padding to constant paddings.
Thu, Nov 25, 2:36 AM
gysit closed D114428: [mlir][linalg] Limit hoist padding to constant paddings..
Thu, Nov 25, 2:36 AM · Restricted Project
gysit committed rGed7c1fb9b099: [mlir][linalg] Add backward slice filtering in hoist padding. (authored by gysit).
[mlir][linalg] Add backward slice filtering in hoist padding.
Thu, Nov 25, 2:30 AM
gysit closed D114420: [mlir][linalg] Add backward slice filtering in hoist padding..
Thu, Nov 25, 2:30 AM · Restricted Project

Wed, Nov 24

gysit committed rGb6e7b1be732d: [mlir][linalg] Simplify padding test (NFC). (authored by gysit).
[mlir][linalg] Simplify padding test (NFC).
Wed, Nov 24, 11:26 AM
gysit closed D114227: [mlir][linalg] Simplify padding test (NFC)..
Wed, Nov 24, 11:26 AM · Restricted Project
gysit committed rG86f186efea7b: [mlir][linalg] Add makeComposedPadHighOp. (authored by gysit).
[mlir][linalg] Add makeComposedPadHighOp.
Wed, Nov 24, 11:20 AM
gysit closed D114175: [mlir][linalg] Add makeComposedPadHighOp..
Wed, Nov 24, 11:19 AM · Restricted Project
gysit committed rGa4fd8cb76f81: [mlir][linalg] Update failure conditions for… (authored by gysit).
[mlir][linalg] Update failure conditions for…
Wed, Nov 24, 11:11 AM
gysit closed D114161: [mlir][linalg] Update failure conditions for padOperandToSmallestStaticBoundingBox..
Wed, Nov 24, 11:11 AM · Restricted Project
gysit updated the diff for D114438: [mlir][linalg] Perform checks early in hoist padding..

Remove temporary check.

Wed, Nov 24, 10:58 AM · Restricted Project
gysit added inline comments to D114420: [mlir][linalg] Add backward slice filtering in hoist padding..
Wed, Nov 24, 10:55 AM · Restricted Project
gysit updated the diff for D114420: [mlir][linalg] Add backward slice filtering in hoist padding..

Address comment and reintroduced a check.

Wed, Nov 24, 10:52 AM · Restricted Project

Tue, Nov 23

gysit updated the diff for D114442: [mlir][linalg] Cleanup hoisting test (NFC)..

Improve comments.

Tue, Nov 23, 8:11 AM · Restricted Project
gysit requested review of D114442: [mlir][linalg] Cleanup hoisting test (NFC)..
Tue, Nov 23, 7:52 AM · Restricted Project
gysit updated the diff for D114438: [mlir][linalg] Perform checks early in hoist padding..

Add additional test with a loop that prevents hoisting.

Tue, Nov 23, 7:51 AM · Restricted Project
gysit requested review of D114438: [mlir][linalg] Perform checks early in hoist padding..
Tue, Nov 23, 6:40 AM · Restricted Project
gysit added a comment to D114387: [mlir][Vector] Thread 0-d vectors through ExtractElementOp..

I find it quite scary that LLVM dit not complain a second about me accessing element 1 of a vector<1xf32> and produced the result I was expecting ...

Tue, Nov 23, 5:01 AM · Restricted Project
gysit accepted D114387: [mlir][Vector] Thread 0-d vectors through ExtractElementOp..
Tue, Nov 23, 4:36 AM · Restricted Project
gysit requested review of D114428: [mlir][linalg] Limit hoist padding to constant paddings..
Tue, Nov 23, 2:56 AM · Restricted Project
gysit requested review of D114420: [mlir][linalg] Add backward slice filtering in hoist padding..
Tue, Nov 23, 1:32 AM · Restricted Project

Mon, Nov 22

gysit updated the diff for D114175: [mlir][linalg] Add makeComposedPadHighOp..

Rebase.

Mon, Nov 22, 9:27 AM · Restricted Project
gysit updated the diff for D114161: [mlir][linalg] Update failure conditions for padOperandToSmallestStaticBoundingBox..

Improve dynamic extract slice missing test.

Mon, Nov 22, 9:23 AM · Restricted Project
gysit updated the diff for D114227: [mlir][linalg] Simplify padding test (NFC)..

Rebase.

Mon, Nov 22, 9:11 AM · Restricted Project
gysit updated the diff for D114175: [mlir][linalg] Add makeComposedPadHighOp..

Rebase.

Mon, Nov 22, 9:11 AM · Restricted Project
gysit updated the diff for D114161: [mlir][linalg] Update failure conditions for padOperandToSmallestStaticBoundingBox..

Address comment.

Mon, Nov 22, 8:54 AM · Restricted Project
gysit committed rG247a1a55eb6a: [mlir][linalg] Use getAsOpFoldResult in padding (NFC). (authored by gysit).
[mlir][linalg] Use getAsOpFoldResult in padding (NFC).
Mon, Nov 22, 5:27 AM
gysit closed D114153: [mlir][linalg] Use getAsOpFoldResult in padding (NFC)..
Mon, Nov 22, 5:26 AM · Restricted Project
gysit committed rG32c43241e716: [mlir][linalg] Always generate an extract/insert slice pair when tiling output… (authored by gysit).
[mlir][linalg] Always generate an extract/insert slice pair when tiling output…
Mon, Nov 22, 5:13 AM
gysit closed D114085: [mlir][linalg] Always generate an extract/insert slice pair when tiling output tensors..
Mon, Nov 22, 5:13 AM · Restricted Project
gysit committed rGf7751a3a4218: [mlir][linalg] Remove tile and fuse test pass (NFC). (authored by gysit).
[mlir][linalg] Remove tile and fuse test pass (NFC).
Mon, Nov 22, 4:44 AM
gysit closed D114068: [mlir][linalg] Remove tile and fuse test pass (NFC)..
Mon, Nov 22, 4:44 AM · Restricted Project
gysit updated the diff for D114227: [mlir][linalg] Simplify padding test (NFC)..

Make check prefixes consisten with other codegen strategy tests.

Mon, Nov 22, 3:20 AM · Restricted Project
gysit committed rGe3d386ea2733: [mlir][linalg] Add a tile and fuse on tensors pattern. (authored by gysit).
[mlir][linalg] Add a tile and fuse on tensors pattern.
Mon, Nov 22, 3:14 AM
gysit closed D114067: [mlir][linalg] Add a tile and fuse on tensors pattern..
Mon, Nov 22, 3:14 AM · Restricted Project
gysit updated the diff for D114175: [mlir][linalg] Add makeComposedPadHighOp..

Address comment.

Mon, Nov 22, 2:50 AM · Restricted Project
gysit updated the diff for D114153: [mlir][linalg] Use getAsOpFoldResult in padding (NFC)..

Rebase.

Mon, Nov 22, 2:49 AM · Restricted Project
gysit committed rG0ccc44cec067: [mlir][linalg] Fix tile and fuse for outermost reduction. (authored by gysit).
[mlir][linalg] Fix tile and fuse for outermost reduction.
Mon, Nov 22, 2:45 AM
gysit closed D114012: [mlir][linalg] Fix tile and fuse for outermost reduction..
Mon, Nov 22, 2:45 AM · Restricted Project
gysit accepted D113933: [mlir] Fix unintentional mutation by VectorType/RankedTensorType::Builder dropDim.
Mon, Nov 22, 2:39 AM · Restricted Project
gysit updated the diff for D114067: [mlir][linalg] Add a tile and fuse on tensors pattern..

Rebase.

Mon, Nov 22, 2:16 AM · Restricted Project

Fri, Nov 19

gysit added a reviewer for D114175: [mlir][linalg] Add makeComposedPadHighOp.: pifon2a.
Fri, Nov 19, 2:05 AM · Restricted Project
gysit added a reviewer for D114161: [mlir][linalg] Update failure conditions for padOperandToSmallestStaticBoundingBox.: pifon2a.
Fri, Nov 19, 2:04 AM · Restricted Project
gysit updated the summary of D114161: [mlir][linalg] Update failure conditions for padOperandToSmallestStaticBoundingBox..
Fri, Nov 19, 2:01 AM · Restricted Project
gysit updated the summary of D114175: [mlir][linalg] Add makeComposedPadHighOp..
Fri, Nov 19, 1:47 AM · Restricted Project
gysit requested review of D114227: [mlir][linalg] Simplify padding test (NFC)..
Fri, Nov 19, 1:39 AM · Restricted Project
gysit updated the diff for D114175: [mlir][linalg] Add makeComposedPadHighOp..

Improve test.

Fri, Nov 19, 1:38 AM · Restricted Project
gysit updated the diff for D114161: [mlir][linalg] Update failure conditions for padOperandToSmallestStaticBoundingBox..

Rebase.

Fri, Nov 19, 1:37 AM · Restricted Project
gysit updated the diff for D114153: [mlir][linalg] Use getAsOpFoldResult in padding (NFC)..

Rebase.

Fri, Nov 19, 1:37 AM · Restricted Project
gysit updated the diff for D114085: [mlir][linalg] Always generate an extract/insert slice pair when tiling output tensors..

Rebase.

Fri, Nov 19, 1:36 AM · Restricted Project
gysit updated the diff for D114067: [mlir][linalg] Add a tile and fuse on tensors pattern..

Rebase.

Fri, Nov 19, 1:35 AM · Restricted Project

Thu, Nov 18

gysit requested review of D114175: [mlir][linalg] Add makeComposedPadHighOp..
Thu, Nov 18, 10:31 AM · Restricted Project