- User Since
- Feb 7 2020, 5:34 AM (146 w, 5 d)
Address reviewer comments.
Mon, Nov 28
Mon, Nov 21
Fri, Nov 18
Thu, Nov 17
Tue, Nov 8
Make struct type names consistent with other tests.
Mon, Nov 7
Fri, Nov 4
Address comments by tracking the insertion points using Operation* / Block*.
Oct 26 2022
Looks good from my side modulo the nit comment. Let's wait for @ftynse (the code owner) for the final approval.
Oct 25 2022
@dcaballe I changed the integer type constraints on the vector predicate intrinsics from AnyInteger to AnySignlessInteger as well. I hope this does not conflict with your changes.
- use @below instead of @+1
- use AnySignlessInteger for all intrinsics
Oct 20 2022
Oct 19 2022
Oct 18 2022
Remove redunant variable name in assume intrinsic declaration.
While you are looking at these, maybe we can also have more specific type constraints than the generic LLVM_Type?
Oct 17 2022
This sounds strange. Maybe try running under the debugger. Also check that the same compiler flags are getting used for tools and for libraries, maybe some cross-compilation related weirdness is involved.
It looks like the point of a custom method was to exit more gracefully than abort. Can you comment on why harder failures are desired?
Oct 16 2022
Oct 14 2022
Oct 13 2022
Move tests close to the extract/insert element tests.