Page MenuHomePhabricator

gysit (Tobias Gysi)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2020, 5:34 AM (61 w, 5 d)

Recent Activity

Today

gysit committed rGce82843f72a7: [mlir][linalg] update fusion to support linalg index operations. (authored by gysit).
[mlir][linalg] update fusion to support linalg index operations.
Wed, Apr 14, 8:38 AM
gysit closed D100456: [mlir][linalg] update fusion to support linalg index operations..
Wed, Apr 14, 8:38 AM · Restricted Project
gysit added reviewers for D100479: [mlir][linalg] update fusion on tensors to support linalg index operations.: pifon2a, ftynse.
Wed, Apr 14, 7:15 AM · Restricted Project
gysit requested review of D100479: [mlir][linalg] update fusion on tensors to support linalg index operations..
Wed, Apr 14, 7:13 AM · Restricted Project
gysit added inline comments to D100456: [mlir][linalg] update fusion to support linalg index operations..
Wed, Apr 14, 1:43 AM · Restricted Project
gysit added reviewers for D100456: [mlir][linalg] update fusion to support linalg index operations.: pifon2a, ftynse.
Wed, Apr 14, 1:42 AM · Restricted Project
gysit requested review of D100456: [mlir][linalg] update fusion to support linalg index operations..
Wed, Apr 14, 1:41 AM · Restricted Project

Yesterday

gysit updated the diff for D100373: [mlir][linalg] lower index operations during linalg to vector lowering..

Addressing review comments:

  • rename StaticOperandDims to OperandStaticDims
  • spell out auto
  • use llvm::append instead of a loop
Tue, Apr 13, 11:02 AM · Restricted Project
gysit added reviewers for D100395: [mlir][linalg] update drop unit dims to support linalg index operations.: pifon2a, ftynse.
Tue, Apr 13, 10:13 AM · Restricted Project
gysit requested review of D100395: [mlir][linalg] update drop unit dims to support linalg index operations..
Tue, Apr 13, 10:13 AM · Restricted Project
gysit committed rG8ea5d190ecc7: [mlir][linalg] update tiling to support linalg index operations. (authored by gysit).
[mlir][linalg] update tiling to support linalg index operations.
Tue, Apr 13, 7:38 AM
gysit closed D100379: [mlir][linalg] update tiling to support linalg index operations..
Tue, Apr 13, 7:37 AM · Restricted Project
gysit updated the diff for D100379: [mlir][linalg] update tiling to support linalg index operations..

Use affine apply to perform index computations.

Tue, Apr 13, 7:01 AM · Restricted Project
gysit added a comment to D100379: [mlir][linalg] update tiling to support linalg index operations..

Note that the tile-indexed.mlir test is the counterpart to the tile-indexed-generic.mlir test.

Tue, Apr 13, 5:28 AM · Restricted Project
gysit added reviewers for D100379: [mlir][linalg] update tiling to support linalg index operations.: pifon2a, ftynse.
Tue, Apr 13, 5:26 AM · Restricted Project
gysit requested review of D100379: [mlir][linalg] update tiling to support linalg index operations..
Tue, Apr 13, 5:25 AM · Restricted Project
gysit added reviewers for D100373: [mlir][linalg] lower index operations during linalg to vector lowering.: pifon2a, ftynse.
Tue, Apr 13, 2:29 AM · Restricted Project
gysit requested review of D100373: [mlir][linalg] lower index operations during linalg to vector lowering..
Tue, Apr 13, 2:28 AM · Restricted Project
gysit committed rGef30179efff2: [mlir][linalg] lower index operations during linalg to loop lowering. (authored by gysit).
[mlir][linalg] lower index operations during linalg to loop lowering.
Tue, Apr 13, 2:05 AM
gysit closed D100364: [mlir][linalg] lower index operations during linalg to loop lowering..
Tue, Apr 13, 2:05 AM · Restricted Project

Mon, Apr 12

gysit added reviewers for D100364: [mlir][linalg] lower index operations during linalg to loop lowering.: pifon2a, ftynse.

The new test cases in loops.mlir duplicate the existing tests for the indexed_generic operation (below). The code after lowering is the same the only difference is the input code (linalg.generic + linalg.index instead of linalg.indexed_generic).

Mon, Apr 12, 11:48 PM · Restricted Project
gysit requested review of D100364: [mlir][linalg] lower index operations during linalg to loop lowering..
Mon, Apr 12, 11:46 PM · Restricted Project
gysit committed rG93f9922d65f8: [mlir][linalg] adding operation to access the iteration index of enclosing… (authored by gysit).
[mlir][linalg] adding operation to access the iteration index of enclosing…
Mon, Apr 12, 6:40 AM
gysit closed D100292: [mlir][linalg] adding operation to access the iteration index of enclosing linalg ops..
Mon, Apr 12, 6:39 AM · Restricted Project
gysit added inline comments to D100292: [mlir][linalg] adding operation to access the iteration index of enclosing linalg ops..
Mon, Apr 12, 4:42 AM · Restricted Project
gysit updated the diff for D100292: [mlir][linalg] adding operation to access the iteration index of enclosing linalg ops..

Confine the dim attribute to values larger than zero.

Mon, Apr 12, 4:38 AM · Restricted Project
gysit committed rG33ce6f02caec: [mlir][linalg] fixing hard-coded variable names in a test (NFC) (authored by gysit).
[mlir][linalg] fixing hard-coded variable names in a test (NFC)
Mon, Apr 12, 3:36 AM
gysit added reviewers for D100292: [mlir][linalg] adding operation to access the iteration index of enclosing linalg ops.: pifon2a, ftynse.
Mon, Apr 12, 2:26 AM · Restricted Project
gysit requested review of D100292: [mlir][linalg] adding operation to access the iteration index of enclosing linalg ops..
Mon, Apr 12, 2:25 AM · Restricted Project

Thu, Apr 8

gysit committed rGb614ada0e80f: [mlir] add support for index type in vectors. (authored by gysit).
[mlir] add support for index type in vectors.
Thu, Apr 8, 1:32 AM
gysit closed D99948: [mlir] add support for index type in vectors..
Thu, Apr 8, 1:32 AM · Restricted Project
gysit updated the diff for D99948: [mlir] add support for index type in vectors..
  • updated to reflect ongoing changes
Thu, Apr 8, 1:09 AM · Restricted Project

Wed, Apr 7

gysit added inline comments to D99948: [mlir] add support for index type in vectors..
Wed, Apr 7, 7:42 AM · Restricted Project
gysit updated the diff for D99948: [mlir] add support for index type in vectors..

Addressing the following comments:

  • added a simple end-to-end integration test
  • updated the rational to reflect the index type support
  • introduced a method to get the closest module or data layout op
Wed, Apr 7, 7:39 AM · Restricted Project

Tue, Apr 6

gysit added inline comments to D99948: [mlir] add support for index type in vectors..
Tue, Apr 6, 5:23 AM · Restricted Project
gysit requested review of D99948: [mlir] add support for index type in vectors..
Tue, Apr 6, 5:20 AM · Restricted Project

Mon, Mar 29

gysit accepted D99499: [mlir][Linalg] Fix fusion on tensors operands / bbArg mismatch.
Mon, Mar 29, 6:24 AM · Restricted Project

Wed, Mar 24

gysit committed rG880822255e21: [mlir][linalg] Do not call region builder during vectorization. (authored by gysit).
[mlir][linalg] Do not call region builder during vectorization.
Wed, Mar 24, 7:56 AM
gysit closed D99168: [mlir][linalg] Do not call region builder during vectorization..
Wed, Mar 24, 7:56 AM · Restricted Project

Tue, Mar 23

gysit requested review of D99168: [mlir][linalg] Do not call region builder during vectorization..
Tue, Mar 23, 3:41 AM · Restricted Project

Mar 8 2021

gysit committed rGc1a4cd551f1c: [mlir][linalg] refactor the result handling during vectorization. (authored by gysit).
[mlir][linalg] refactor the result handling during vectorization.
Mar 8 2021, 11:27 PM
gysit closed D98182: [mlir][linalg] refactor the result handling during vectorization..
Mar 8 2021, 11:27 PM · Restricted Project
gysit requested review of D98182: [mlir][linalg] refactor the result handling during vectorization..
Mar 8 2021, 8:09 AM · Restricted Project

Mar 1 2021

gysit abandoned D95160: [mlir][GPU] make the index bitwidth configurable during the GPU to LLVM conversion.
Mar 1 2021, 6:16 AM · Restricted Project

Feb 22 2021

gysit added a comment to D95160: [mlir][GPU] make the index bitwidth configurable during the GPU to LLVM conversion.

Hi Tobias!

I'm curious, wouldn't it be easier to compile the runtime wrappers for 32bit instead of casting the arguments?

Feb 22 2021, 11:27 PM · Restricted Project

Feb 14 2021

gysit committed rG99f3510b4137: Reland "[mlir] add support for verification in integration tests" (authored by gysit).
Reland "[mlir] add support for verification in integration tests"
Feb 14 2021, 11:33 AM
gysit closed D96593: Reland "[mlir] add support for verification in integration tests".
Feb 14 2021, 11:33 AM · Restricted Project
gysit added inline comments to D96593: Reland "[mlir] add support for verification in integration tests".
Feb 14 2021, 3:59 AM · Restricted Project
gysit updated the diff for D96593: Reland "[mlir] add support for verification in integration tests".
  • addressed Kayjukh's comments
Feb 14 2021, 3:55 AM · Restricted Project

Feb 12 2021

gysit added inline comments to D96593: Reland "[mlir] add support for verification in integration tests".
Feb 12 2021, 11:57 PM · Restricted Project
gysit updated the diff for D96593: Reland "[mlir] add support for verification in integration tests".
  • address comments aartbik's comments
  • return error by value
Feb 12 2021, 11:53 PM · Restricted Project
gysit added inline comments to D96593: Reland "[mlir] add support for verification in integration tests".
Feb 12 2021, 12:39 PM · Restricted Project
gysit requested review of D96593: Reland "[mlir] add support for verification in integration tests".
Feb 12 2021, 4:31 AM · Restricted Project

Feb 9 2021

gysit updated the diff for D96326: [mlir] add support for verification in integration tests.

Added missing algorithms header to fix Windows build.

Feb 9 2021, 11:20 AM · Restricted Project
gysit added a comment to D96326: [mlir] add support for verification in integration tests.

To be clear, the windows mlir buildbot is broken because of this change:

http://lab.llvm.org:8011/#/builders/13/builds/4284

Perhaps you are not getting the notifications?

Feb 9 2021, 10:23 AM · Restricted Project
gysit added a reverting change for rG5fa893cc383b: [mlir] add support for verification in integration tests: rGdd719fda7657: Revert "[mlir] add support for verification in integration tests".
Feb 9 2021, 10:19 AM
gysit committed rGdd719fda7657: Revert "[mlir] add support for verification in integration tests" (authored by gysit).
Revert "[mlir] add support for verification in integration tests"
Feb 9 2021, 10:19 AM
gysit added a reverting change for D96326: [mlir] add support for verification in integration tests: rGdd719fda7657: Revert "[mlir] add support for verification in integration tests".
Feb 9 2021, 10:19 AM · Restricted Project
gysit committed rG5fa893cc383b: [mlir] add support for verification in integration tests (authored by gysit).
[mlir] add support for verification in integration tests
Feb 9 2021, 8:56 AM
gysit closed D96326: [mlir] add support for verification in integration tests.
Feb 9 2021, 8:55 AM · Restricted Project
gysit added a comment to D96326: [mlir] add support for verification in integration tests.

@nicolasvasilache the updated revision should address your comments. The linter may not be happy with the function naming (_mlir_ciface) and I somewhat prefer the older function names.

Feb 9 2021, 5:12 AM · Restricted Project
gysit updated the diff for D96326: [mlir] add support for verification in integration tests.

Avoid std::cout and return number of errors instead of printing success or failure. Restructured the unit tests to limit the scope of the verification code. Also tried to address the lint issues. Howerever the _mlir_ciface_ perfix is fix as far as I understand.

Feb 9 2021, 5:08 AM · Restricted Project
gysit requested review of D96326: [mlir] add support for verification in integration tests.
Feb 9 2021, 2:16 AM · Restricted Project

Jan 21 2021

gysit requested review of D95160: [mlir][GPU] make the index bitwidth configurable during the GPU to LLVM conversion.
Jan 21 2021, 12:06 PM · Restricted Project

Jan 20 2021

gysit committed rG4c1eaf26ae70: [mlir] fix the rocm runtime wrapper to account for cuda / rocm api differences (authored by gysit).
[mlir] fix the rocm runtime wrapper to account for cuda / rocm api differences
Jan 20 2021, 9:49 AM
gysit closed D95027: [mlir] fix the rocm runtime wrapper to account for cuda / rocm api differences.
Jan 20 2021, 9:49 AM · Restricted Project
gysit requested review of D95027: [mlir] fix the rocm runtime wrapper to account for cuda / rocm api differences.
Jan 20 2021, 1:05 AM · Restricted Project

Nov 20 2020

gysit accepted D91880: [mlir] canonicalize away zero-iteration SCF for loops.
Nov 20 2020, 11:14 AM · Restricted Project

Oct 11 2020

gysit committed rG93377888ae89: [mlir] add scf.if op canonicalization pattern that removes unused results (authored by gysit).
[mlir] add scf.if op canonicalization pattern that removes unused results
Oct 11 2020, 1:45 AM
gysit closed D89029: [mlir] add scf.if op canonicalization pattern that removes unused results.
Oct 11 2020, 1:45 AM · Restricted Project
gysit updated the diff for D89029: [mlir] add scf.if op canonicalization pattern that removes unused results.

update to latest master

Oct 11 2020, 1:36 AM · Restricted Project

Oct 9 2020

gysit added inline comments to D89029: [mlir] add scf.if op canonicalization pattern that removes unused results.
Oct 9 2020, 12:04 AM · Restricted Project
gysit updated the diff for D89029: [mlir] add scf.if op canonicalization pattern that removes unused results.
  • exit early if the pattern does not apply
  • update terminators of then and else bodies in place using the setOperands method
Oct 9 2020, 12:01 AM · Restricted Project

Oct 8 2020

gysit requested review of D89029: [mlir] add scf.if op canonicalization pattern that removes unused results.
Oct 8 2020, 1:18 AM · Restricted Project

Oct 7 2020

gysit committed rG149dc94c1d52: [mlir] fix the types used during the generation of the kernel param array (authored by gysit).
[mlir] fix the types used during the generation of the kernel param array
Oct 7 2020, 7:26 AM
gysit closed D88959: [mlir] fix the types used during the generation of the kernel param array.
Oct 7 2020, 7:26 AM · Restricted Project
gysit requested review of D88959: [mlir] fix the types used during the generation of the kernel param array.
Oct 7 2020, 5:35 AM · Restricted Project

Jul 29 2020

gysit committed rG77c3b016c424: [mlir] fix error handling in rocm runtime wrapper (authored by gysit).
[mlir] fix error handling in rocm runtime wrapper
Jul 29 2020, 1:11 PM
gysit closed D84861: [mlir] fix error handling in rocm runtime wrapper.
Jul 29 2020, 1:11 PM · Restricted Project
gysit requested review of D84861: [mlir] fix error handling in rocm runtime wrapper.
Jul 29 2020, 8:53 AM · Restricted Project

Jun 29 2020

gysit committed rG10643c9ad85b: [mlir] make the bitwidth of device side index computations configurable (reland) (authored by gysit).
[mlir] make the bitwidth of device side index computations configurable (reland)
Jun 29 2020, 3:45 AM
gysit added a reverting change for rGd10b1a38a7df: [mlir] make the bitwidth of device side index computations configurable: rG10643c9ad85b: [mlir] make the bitwidth of device side index computations configurable (reland).
Jun 29 2020, 3:45 AM
gysit closed D82475: [mlir] make the bitwidth of device side index computations configurable.
Jun 29 2020, 3:44 AM · Restricted Project

Jun 27 2020

gysit updated the diff for D82475: [mlir] make the bitwidth of device side index computations configurable.
  • revert to using static instead of thread_local
  • removed more inconsistent spaces
Jun 27 2020, 1:31 AM · Restricted Project

Jun 26 2020

gysit updated the diff for D82475: [mlir] make the bitwidth of device side index computations configurable.

Adressed Alex's comments:

  • make default configuration thread_local
  • fixed clang tidy issues
  • removed unnecessary spaces
Jun 26 2020, 8:10 AM · Restricted Project
gysit committed rG652a79659a89: [mlir] fix off-by-one error in collapseParallelLoops (authored by gysit).
[mlir] fix off-by-one error in collapseParallelLoops
Jun 26 2020, 7:04 AM
gysit closed D82634: [mlir] fix off-by-one error in collapseParallelLoops.
Jun 26 2020, 7:03 AM · Restricted Project
gysit created D82634: [mlir] fix off-by-one error in collapseParallelLoops.
Jun 26 2020, 2:40 AM · Restricted Project
gysit committed rG48f1d4fcd27c: [mlir] parallel loop canonicalization (authored by gysit).
[mlir] parallel loop canonicalization
Jun 26 2020, 1:04 AM
gysit closed D82191: [mlir] parallel loop canonicalization.
Jun 26 2020, 1:04 AM · Restricted Project

Jun 25 2020

gysit updated the diff for D82191: [mlir] parallel loop canonicalization.
  • Added a comment that reflects the discussions about clone (can be reverted) vs inline (performance).
  • The current implementation is revertible at the cost of cloning the loop body.
  • Use std::tie to improve the code readability.
Jun 25 2020, 11:20 AM · Restricted Project
gysit committed rGcd730816058b: [mlir] parallel loop tiling optimization for loops with static bounds (authored by gysit).
[mlir] parallel loop tiling optimization for loops with static bounds
Jun 25 2020, 12:30 AM
gysit closed D82003: [mlir] parallel loop tiling optimization for loops with static bounds.
Jun 25 2020, 12:30 AM · Restricted Project

Jun 24 2020

gysit created D82475: [mlir] make the bitwidth of device side index computations configurable.
Jun 24 2020, 9:10 AM · Restricted Project

Jun 23 2020

gysit added inline comments to D80285: [mlir] make the bitwidth of device side index computations configurable.
Jun 23 2020, 2:32 PM · Restricted Project, Restricted Project
gysit added inline comments to D80285: [mlir] make the bitwidth of device side index computations configurable.
Jun 23 2020, 11:15 AM · Restricted Project, Restricted Project
gysit committed rG2ff6fad70049: Revert "[mlir] make the bitwidth of device side index computations configurable" (authored by gysit).
Revert "[mlir] make the bitwidth of device side index computations configurable"
Jun 23 2020, 10:43 AM
gysit added a reverting change for rGd10b1a38a7df: [mlir] make the bitwidth of device side index computations configurable: rG2ff6fad70049: Revert "[mlir] make the bitwidth of device side index computations configurable".
Jun 23 2020, 10:43 AM
gysit abandoned D82364: [mlir] fix ConvertToLLVMPattern constructor.
Jun 23 2020, 10:43 AM · Restricted Project
gysit added inline comments to D82191: [mlir] parallel loop canonicalization.
Jun 23 2020, 9:04 AM · Restricted Project