Page MenuHomePhabricator

Dinistro (Christian Ulmann)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2021, 5:52 AM (65 w, 4 d)

Recent Activity

Today

Dinistro updated the diff for D143376: [mlir][llvm] Add support for loop metadata import.

fix the unused variable warning

Tue, Feb 7, 7:50 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D143473: [mlir][llvm] Purge struct_attr.

additional test cleanup

Tue, Feb 7, 7:30 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D143492: [mlir][llvm] Add MD_prof import error handling.

address NIT comment

Tue, Feb 7, 6:56 AM · Restricted Project, Restricted Project
Dinistro added inline comments to D143473: [mlir][llvm] Purge struct_attr.
Tue, Feb 7, 6:52 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D143473: [mlir][llvm] Purge struct_attr.

address review comments.

Tue, Feb 7, 6:49 AM · Restricted Project, Restricted Project
Dinistro added inline comments to D143376: [mlir][llvm] Add support for loop metadata import.
Tue, Feb 7, 6:11 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D143376: [mlir][llvm] Add support for loop metadata import.

address reviewer comments

Tue, Feb 7, 6:11 AM · Restricted Project, Restricted Project
Dinistro requested review of D143492: [mlir][llvm] Add MD_prof import error handling.
Tue, Feb 7, 5:21 AM · Restricted Project, Restricted Project
Dinistro requested review of D143473: [mlir][llvm] Purge struct_attr.
Tue, Feb 7, 12:38 AM · Restricted Project, Restricted Project

Yesterday

Dinistro updated the diff for D143376: [mlir][llvm] Add support for loop metadata import.

Fix windows build with explicit cast to llvm::MDNode

Mon, Feb 6, 7:56 AM · Restricted Project, Restricted Project
Dinistro committed rGa9787577ee57: [mlir][llvm] Add missing license header (NFC) (authored by Dinistro).
[mlir][llvm] Add missing license header (NFC)
Mon, Feb 6, 3:18 AM · Restricted Project, Restricted Project
Dinistro requested review of D143376: [mlir][llvm] Add support for loop metadata import.
Mon, Feb 6, 3:09 AM · Restricted Project, Restricted Project

Sun, Feb 5

Dinistro accepted D143370: [mlir][llvm] Drop opaque ptr test in LLVM IR import..

LGTM!

Sun, Feb 5, 11:53 PM · Restricted Project, Restricted Project

Fri, Feb 3

Dinistro accepted D143152: [mlir][llvm] Fix bug in constant import from LLVM IR..

LGTM!
The algorithm change made it indeed more easy to understand.

Fri, Feb 3, 7:34 AM · Restricted Project, Restricted Project
Dinistro added inline comments to D143064: [mlir][llvm] Add structured loop metadata.
Fri, Feb 3, 5:21 AM · Restricted Project, Restricted Project

Thu, Feb 2

Dinistro committed rG889a11783ec0: [mlir][llvm] Add structured loop metadata (authored by Dinistro).
[mlir][llvm] Add structured loop metadata
Thu, Feb 2, 11:58 PM · Restricted Project, Restricted Project
Dinistro closed D143064: [mlir][llvm] Add structured loop metadata.
Thu, Feb 2, 11:58 PM · Restricted Project, Restricted Project
Dinistro accepted D143189: [mlir][llvm] Use tablegen for enum conversion..

I added one comment regarding naming but the rest LGTM! It's nice to see this conversion functions gone, especially as some of them did not cover everything.

Thu, Feb 2, 11:51 PM · Restricted Project, Restricted Project
Dinistro updated the diff for D143064: [mlir][llvm] Add structured loop metadata.

address additional review comments

Thu, Feb 2, 4:24 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D143064: [mlir][llvm] Add structured loop metadata.

refactoring of the conversion class

Thu, Feb 2, 12:19 AM · Restricted Project, Restricted Project

Wed, Feb 1

Dinistro updated the diff for D143064: [mlir][llvm] Add structured loop metadata.

move into separate files and dispatch through ModuleTranslation

Wed, Feb 1, 8:36 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D143064: [mlir][llvm] Add structured loop metadata.

Address the renaming comments

Wed, Feb 1, 8:03 AM · Restricted Project, Restricted Project
Dinistro requested review of D143064: [mlir][llvm] Add structured loop metadata.
Wed, Feb 1, 5:46 AM · Restricted Project, Restricted Project

Tue, Jan 31

Dinistro accepted D142884: [mlir][llvm] Opaque pointer support for atomic and call ops..

LGTM module the comment.

Tue, Jan 31, 11:28 PM · Restricted Project, Restricted Project
Dinistro committed rG5212058405ba: Reland "[mlir][LLVM] Add all LLVM parameter attributes" (authored by Dinistro).
Reland "[mlir][LLVM] Add all LLVM parameter attributes"
Tue, Jan 31, 12:12 AM · Restricted Project, Restricted Project
Dinistro closed D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes".
Tue, Jan 31, 12:12 AM · Restricted Project, Restricted Project

Mon, Jan 30

Dinistro added a comment to D142884: [mlir][llvm] Opaque pointer support for atomic and call ops..

Overall, this is looking good to me.
Please wait for the opinions of others as they might have other concerns.

Mon, Jan 30, 8:33 AM · Restricted Project, Restricted Project
Dinistro retitled D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes" from [mlir][LLVM] Add all LLVM parameter attributes to Reland "[mlir][LLVM] Add all LLVM parameter attributes".
Mon, Jan 30, 1:19 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes".

Fix the broken build by making the detail helpers static header functions.

Mon, Jan 30, 1:15 AM · Restricted Project, Restricted Project
Dinistro reopened D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes".
Mon, Jan 30, 1:03 AM · Restricted Project, Restricted Project
Dinistro added a reverting change for rG54941942c82f: [mlir][LLVM] Add all LLVM parameter attributes: rGbd0c809209fe: Revert "[mlir][LLVM] Add all LLVM parameter attributes".
Mon, Jan 30, 12:39 AM · Restricted Project, Restricted Project
Dinistro committed rGbd0c809209fe: Revert "[mlir][LLVM] Add all LLVM parameter attributes" (authored by Dinistro).
Revert "[mlir][LLVM] Add all LLVM parameter attributes"
Mon, Jan 30, 12:38 AM · Restricted Project, Restricted Project
Dinistro added a reverting change for D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes": rGbd0c809209fe: Revert "[mlir][LLVM] Add all LLVM parameter attributes".
Mon, Jan 30, 12:38 AM · Restricted Project, Restricted Project

Sun, Jan 29

Dinistro committed rG54941942c82f: [mlir][LLVM] Add all LLVM parameter attributes (authored by Dinistro).
[mlir][LLVM] Add all LLVM parameter attributes
Sun, Jan 29, 11:57 PM · Restricted Project, Restricted Project
Dinistro closed D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes".
Sun, Jan 29, 11:57 PM · Restricted Project, Restricted Project

Fri, Jan 27

Dinistro accepted D142605: [mlir][llvm] Import access group metadata..

LGTM!

Fri, Jan 27, 1:44 AM · Restricted Project, Restricted Project
Dinistro updated the summary of D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes".
Fri, Jan 27, 12:35 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes".

Commit message change and additional comment addressing.

Fri, Jan 27, 12:34 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes".

address review comments and drop intrinsic specific attributes.

Fri, Jan 27, 12:18 AM · Restricted Project, Restricted Project

Thu, Jan 26

Dinistro added a comment to D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes".

Is importing and exporting immarg really required? IIRC this attribute is only valid on arguments of intrinsics, and so far we've been modelling (most of, but should be all of) these specific intrinsics to have attributes for immarg arguments within the LLVM Dialect.

Thu, Jan 26, 11:58 PM · Restricted Project, Restricted Project
Dinistro added inline comments to D142605: [mlir][llvm] Import access group metadata..
Thu, Jan 26, 8:46 AM · Restricted Project, Restricted Project
Dinistro added inline comments to rGc5da2dca2c34: [MLIR][LLVM] Support inlining of LLVM::AllocaOp..
Thu, Jan 26, 8:20 AM · Restricted Project, Restricted Project
Dinistro requested review of D142635: Reland "[mlir][LLVM] Add all LLVM parameter attributes".
Thu, Jan 26, 7:55 AM · Restricted Project, Restricted Project

Wed, Jan 25

Dinistro committed rG56880fd257e2: [mlir][LLVM] Add result attribute import support (authored by Dinistro).
[mlir][LLVM] Add result attribute import support
Wed, Jan 25, 6:54 AM · Restricted Project, Restricted Project
Dinistro closed D142476: [mlir][LLVM] Add result attribute import support.
Wed, Jan 25, 6:54 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142476: [mlir][LLVM] Add result attribute import support.

address additional comments and extend tests

Wed, Jan 25, 6:18 AM · Restricted Project, Restricted Project
Dinistro committed rGbe4b87353e42: [mlir][LLVM] Add param attr verifiers (authored by Dinistro).
[mlir][LLVM] Add param attr verifiers
Wed, Jan 25, 6:05 AM · Restricted Project, Restricted Project
Dinistro closed D142372: [mlir][LLVM] Add param attr verifiers.
Wed, Jan 25, 6:05 AM · Restricted Project, Restricted Project
Dinistro added inline comments to D142372: [mlir][LLVM] Add param attr verifiers.
Wed, Jan 25, 4:54 AM · Restricted Project, Restricted Project

Tue, Jan 24

Dinistro requested review of D142476: [mlir][LLVM] Add result attribute import support.
Tue, Jan 24, 7:42 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142372: [mlir][LLVM] Add param attr verifiers.

Add checks for invalid result attributes. This checks explicitly looks for otherwise valid argument attributes, as there might be arbitrary attributes attached to a result.

Tue, Jan 24, 4:47 AM · Restricted Project, Restricted Project
Dinistro committed rG551ee367252a: [mlir][FuncToLLVM] Fix arg attr memref interaction (authored by Dinistro).
[mlir][FuncToLLVM] Fix arg attr memref interaction
Tue, Jan 24, 12:51 AM · Restricted Project, Restricted Project
Dinistro closed D142212: [mlir][FuncToLLVM] Fix arg attr memref interaction.
Tue, Jan 24, 12:51 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142372: [mlir][LLVM] Add param attr verifiers.

Address additional comments

Tue, Jan 24, 12:37 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142372: [mlir][LLVM] Add param attr verifiers.

rename test file and add a comment to indicate the start of the respective test cases.

Tue, Jan 24, 12:26 AM · Restricted Project, Restricted Project
Dinistro added inline comments to D142372: [mlir][LLVM] Add param attr verifiers.
Tue, Jan 24, 12:11 AM · Restricted Project, Restricted Project
Dinistro added reviewers for D142372: [mlir][LLVM] Add param attr verifiers: laszlokindrat, laszlo-luminous.
Tue, Jan 24, 12:02 AM · Restricted Project, Restricted Project

Mon, Jan 23

Dinistro added inline comments to D142372: [mlir][LLVM] Add param attr verifiers.
Mon, Jan 23, 11:59 PM · Restricted Project, Restricted Project
Dinistro updated the diff for D142372: [mlir][LLVM] Add param attr verifiers.

address review comments

Mon, Jan 23, 11:58 PM · Restricted Project, Restricted Project
Dinistro updated the summary of D142372: [mlir][LLVM] Add param attr verifiers.
Mon, Jan 23, 8:37 AM · Restricted Project, Restricted Project
Dinistro requested review of D142372: [mlir][LLVM] Add param attr verifiers.
Mon, Jan 23, 8:33 AM · Restricted Project, Restricted Project
Dinistro added a comment to D142212: [mlir][FuncToLLVM] Fix arg attr memref interaction.

The diff description no longer matches the change.

Mon, Jan 23, 2:02 AM · Restricted Project, Restricted Project
Dinistro updated the summary of D142212: [mlir][FuncToLLVM] Fix arg attr memref interaction.
Mon, Jan 23, 2:02 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142212: [mlir][FuncToLLVM] Fix arg attr memref interaction.

Changed the handling to drop all argument attributes in the case of a type expanding to multiple arguments

Mon, Jan 23, 12:50 AM · Restricted Project, Restricted Project

Fri, Jan 20

Dinistro added inline comments to D142212: [mlir][FuncToLLVM] Fix arg attr memref interaction.
Fri, Jan 20, 9:41 AM · Restricted Project, Restricted Project
Dinistro committed rG3d36df3ee3fc: [mlir][LLVM] Add passthrough import support (authored by Dinistro).
[mlir][LLVM] Add passthrough import support
Fri, Jan 20, 7:31 AM · Restricted Project, Restricted Project
Dinistro closed D142098: [mlir][LLVM] Add passthrough import support.
Fri, Jan 20, 7:31 AM · Restricted Project, Restricted Project
Dinistro committed rGeef538f4e11c: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp. (authored by definelicht).
[MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp.
Fri, Jan 20, 7:27 AM · Restricted Project, Restricted Project
Dinistro closed D141682: [MLIR][LLVM] Support inlining LLVM::CallOp to LLVM::FuncOp..
Fri, Jan 20, 7:27 AM · Restricted Project, Restricted Project
Dinistro requested review of D142212: [mlir][FuncToLLVM] Fix arg attr memref interaction.
Fri, Jan 20, 7:13 AM · Restricted Project, Restricted Project

Thu, Jan 19

Dinistro updated the diff for D142098: [mlir][LLVM] Add passthrough import support.

change unreachable message

Thu, Jan 19, 6:24 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142098: [mlir][LLVM] Add passthrough import support.

address review comments

Thu, Jan 19, 6:12 AM · Restricted Project, Restricted Project
Dinistro committed rGe741b8c2e520: [llvm][ir] Purge MD_prof custom accessors (authored by Dinistro).
[llvm][ir] Purge MD_prof custom accessors
Thu, Jan 19, 5:30 AM · Restricted Project, Restricted Project
Dinistro closed D141393: [llvm][ir] Purge MD_prof custom accessors.
Thu, Jan 19, 5:30 AM · Restricted Project, Restricted Project
Dinistro accepted D142086: [mlir][llvm] Drop cyclic dependencies during debug metadata import..

LGTM!

Thu, Jan 19, 4:28 AM · Restricted Project, Restricted Project
Dinistro committed rG9b9cfe77a50a: [mlir][LLVM] Replace readnone with memory effects (authored by Dinistro).
[mlir][LLVM] Replace readnone with memory effects
Thu, Jan 19, 2:58 AM · Restricted Project, Restricted Project
Dinistro closed D142013: [mlir][LLVM] Replace readnone with memory effects.
Thu, Jan 19, 2:58 AM · Restricted Project, Restricted Project
Dinistro requested review of D142098: [mlir][LLVM] Add passthrough import support.
Thu, Jan 19, 2:27 AM · Restricted Project, Restricted Project

Wed, Jan 18

Dinistro updated the diff for D142013: [mlir][LLVM] Replace readnone with memory effects.

addressing review comments

Wed, Jan 18, 7:26 AM · Restricted Project, Restricted Project
Dinistro requested review of D142013: [mlir][LLVM] Replace readnone with memory effects.
Wed, Jan 18, 6:18 AM · Restricted Project, Restricted Project
Dinistro added inline comments to D142002: [mlir][FuncToLLVM] Drop llvm.linkage attribute.
Wed, Jan 18, 5:26 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142002: [mlir][FuncToLLVM] Drop llvm.linkage attribute.

Addressed review comments

Wed, Jan 18, 5:25 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D142002: [mlir][FuncToLLVM] Drop llvm.linkage attribute.

Small comment change

Wed, Jan 18, 3:00 AM · Restricted Project, Restricted Project
Dinistro requested review of D142002: [mlir][FuncToLLVM] Drop llvm.linkage attribute.
Wed, Jan 18, 2:54 AM · Restricted Project, Restricted Project

Sun, Jan 15

Dinistro added a comment to D141393: [llvm][ir] Purge MD_prof custom accessors.

Thank you very much for the reviews. Could one of you commit this revision for me as I do not yet have commit access?

Sun, Jan 15, 11:25 PM · Restricted Project, Restricted Project

Thu, Jan 12

Dinistro accepted D141261: [mlir][llvm] Add an explicit void type debug info attribute..
Thu, Jan 12, 8:25 AM · Restricted Project, Restricted Project, Restricted Project
Dinistro added inline comments to D141261: [mlir][llvm] Add an explicit void type debug info attribute..
Thu, Jan 12, 3:57 AM · Restricted Project, Restricted Project, Restricted Project
Dinistro accepted D141480: [mlir][llvm] A DICompositeTypeAttr is also a DIScopeAttr..

LGTM!

Thu, Jan 12, 2:40 AM · Restricted Project, Restricted Project
Dinistro accepted D141468: [mlir][llvm] Handle debug metadata arg lists during LLVM IR import..

LGTM!

Thu, Jan 12, 2:37 AM · Restricted Project, Restricted Project
Dinistro added inline comments to D141393: [llvm][ir] Purge MD_prof custom accessors.
Thu, Jan 12, 12:27 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D141393: [llvm][ir] Purge MD_prof custom accessors.

address additional comments

Thu, Jan 12, 12:22 AM · Restricted Project, Restricted Project

Wed, Jan 11

Dinistro updated the diff for D141393: [llvm][ir] Purge MD_prof custom accessors.

Minor improvement

Wed, Jan 11, 4:00 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D141393: [llvm][ir] Purge MD_prof custom accessors.

address reviewer comments

Wed, Jan 11, 2:56 AM · Restricted Project, Restricted Project

Tue, Jan 10

Dinistro added a comment to D141393: [llvm][ir] Purge MD_prof custom accessors.

Added the reviewers of the previous commits to ProfDataUtils.cpp.

Tue, Jan 10, 9:09 AM · Restricted Project, Restricted Project
Dinistro added reviewers for D141393: [llvm][ir] Purge MD_prof custom accessors: bogner, davidxl, tejohnson.
Tue, Jan 10, 9:08 AM · Restricted Project, Restricted Project
Dinistro requested review of D141393: [llvm][ir] Purge MD_prof custom accessors.
Tue, Jan 10, 8:42 AM · Restricted Project, Restricted Project
Dinistro added inline comments to D141357: [mlir][llvm] Improve error messages during LLVM IR import..
Tue, Jan 10, 2:03 AM · Restricted Project, Restricted Project
Dinistro accepted D141265: [mlir][llvm] Call the instruction builders from a static method (NFC)..

Ensuring that the mlirBuilders cannot access private members and thus forcing them to use the more stable public interface of ModuleImport is a good idea. LGTM!

Tue, Jan 10, 1:58 AM · Restricted Project, Restricted Project

Jan 6 2023

Dinistro accepted D141115: [mlir:LLVM] Rudimentary inlining support for LLVM load store..

LGTM!

Jan 6 2023, 7:53 AM · Restricted Project, Restricted Project
Dinistro updated the diff for D141122: [mlir][llvm] Add branch weights to call and invoke.

address review comments

Jan 6 2023, 6:01 AM · Restricted Project, Restricted Project