[Sema][ObjC] Invalidate BlockDecl with invalid ParmVarDecl

[danix800]

Summary

BlockDecl should be invalidated because of its invalid ParmVarDecl.

Fixes #1 of https://github.com/llvm/llvm-project/issues/64005

[danix800]

Update ReleaseNotes

[hokein]

thanks, the fix looks reasonable to me

clang/test/AST/ast-dump-recovery.m

22

nit: a => gh64005

[danix800]

clang/test/AST/ast-dump-recovery.m

22

Will be fixed in the final commit!

clang/lib/Sema/SemaExpr.cpp

     AI->setOwningFunction(CurBlock->TheDecl);
 
     // If this has an identifier, add it to the scope stack.
     if (AI->getIdentifier()) {
       CheckShadow(CurBlock->TheScope, AI);
 
       PushOnScopeChains(AI, CurBlock->TheScope);
     }
+
+    if (AI->isInvalidDecl())
+      CurBlock->TheDecl->setInvalidDecl();
   }
 }
 
 /// ActOnBlockError - If there is an error parsing a block, this callback
 /// is invoked to pop the information about the block from the action impl.
 void Sema::ActOnBlockError(SourceLocation CaretLoc, Scope *CurScope) {
   // Leave the expression-evaluation context.
   DiscardCleanupsInEvaluationContext();

clang/test/AST/ast-dump-recovery.m

void k(Foo *foo) {
   // CHECK-CHECK:  `-RecoveryExpr {{.*}}
   [foo method:undef];
 
   // CHECK:      ImplicitCastExpr {{.*}} '<dependent type>' contains-errors
   // CHECK-NEXT: `-RecoveryExpr {{.*}} '<dependent type>' contains-errors
   // CHECK-NEXT:   `-DeclRefExpr {{.*}} 'foo'
   foo.undef;
 }
+
+// CHECK:      `-BlockExpr {{.*}} 'int (^)(int, int)'
+// CHECK-NEXT:   `-BlockDecl {{.*}} invalid
+int (^a)(int, int) = ^(int, undefine b) {
+   return 1;
+};