This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Use GlobalISel MatchTable Combiner Backend
ClosedPublic

Authored by Pierre-vh on Jun 27 2023, 2:59 AM.

Details

Summary

Only a few minor test changes needed because I removed the "helper" suffix from the combiner name, as it's not really a helper anymore but more like the implementation itself.

Depends on D153757

NOTE: This would land iff D153757 (RFC) lands too.

Diff Detail

Event Timeline

Pierre-vh created this revision.Jun 27 2023, 2:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2023, 2:59 AM
Pierre-vh requested review of this revision.Jun 27 2023, 2:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2023, 2:59 AM
arsenm added inline comments.Jun 30 2023, 12:16 PM
llvm/lib/Target/AArch64/GISel/AArch64O0PreLegalizerCombiner.cpp
63

s/00/O0/

112

I'd expect a member for subtarget (and/or you could get it from MachineIRBuilder)

llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp
409

There's a subtarget member?

llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp
416

Why are these losing static?

Pierre-vh updated this revision to Diff 537020.Jul 4 2023, 3:01 AM
Pierre-vh marked 4 inline comments as done.

Rebase + comments

Pierre-vh added inline comments.Jul 4 2023, 3:01 AM
llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp
409

There is no subtarget member in AArch64PostLegalizerCombinerInfo or MI as far as I can see

llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp
416

They've been moved in an anonymous namespace and static is implied already in those

Pierre-vh updated this revision to Diff 537266.Jul 5 2023, 2:26 AM

Call setupMF

aemerson accepted this revision.Jul 6 2023, 1:46 PM

LGTM.

This revision is now accepted and ready to land.Jul 6 2023, 1:46 PM
This revision was landed with ongoing or failed builds.Jul 11 2023, 2:27 AM
This revision was automatically updated to reflect the committed changes.