This is an archive of the discontinued LLVM Phabricator instance.

[doc][LoongArch] Add missed release note about `ual` feature addition
ClosedPublic

Authored by SixWeining on Jun 11 2023, 11:13 PM.

Diff Detail

Event Timeline

SixWeining created this revision.Jun 11 2023, 11:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2023, 11:13 PM
SixWeining requested review of this revision.Jun 11 2023, 11:13 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 11 2023, 11:13 PM
xen0n added a comment.Jun 21 2023, 8:34 PM

Thanks for the catch!

llvm/docs/ReleaseNotes.rst
176

nit: "A" (the following sound is not a vowel)

177

nit: "for generic 64-bit"

Here "for" (compared to "on") is to signify it's controlled by target instead of host spec.

MaskRay accepted this revision.Jun 21 2023, 10:06 PM
MaskRay added inline comments.
llvm/docs/ReleaseNotes.rst
177

Target feature is internal and mentioning it in release notes may be excessive (if we do, there are too many to enumerate ...). I think we can omit mentioning the target feature. Focusing on the behavior about the user-facing -m[no-]unaligned-access is more useful.

This revision is now accepted and ready to land.Jun 21 2023, 10:06 PM
SixWeining added inline comments.Jun 25 2023, 6:49 PM
llvm/docs/ReleaseNotes.rst
176

Thanks. I will modify it later.

177

I think it depends on the different users we are targeting. Command line options like -m[no-]unaligned-access are targeting clang users while target features are targeting llvm users.

Address xen0n's comments.

This revision was landed with ongoing or failed builds.Jun 25 2023, 7:38 PM
This revision was automatically updated to reflect the committed changes.