Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D152303

[ExprConstant] fix ICE from Evaluate on _Atomic structs
ClosedPublic
Actions

Authored by nickdesaulniers on Jun 6 2023, 1:15 PM.

Details

Reviewers
efriedma
ahatanak
aaron.ballman
Commits
rG9daab7fb02d2: [ExprConstant] fix ICE from Evaluate on _Atomic structs
Summary

Fixes two crashes reported by @efriedma and @ahatanak, as per
@ahatanak's analysis.

Link: https://reviews.llvm.org/D151587#4397446
Link: https://reviews.llvm.org/D151587#4399684

Diff Detail

Event Timeline

nickdesaulniers created this revision.Jun 6 2023, 1:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 1:15 PM
nickdesaulniers requested review of this revision.Jun 6 2023, 1:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 1:15 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nickdesaulniers added reviewers: efriedma, ahatanak.Jun 6 2023, 1:15 PM
nickdesaulniers mentioned this in D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first.
nickdesaulniers added a child revision: D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first.
Harbormaster completed remote builds in B237048: Diff 529011.Jun 6 2023, 4:23 PM
ahatanak accepted this revision.Jun 8 2023, 5:44 AM

LGTM

This revision is now accepted and ready to land.Jun 8 2023, 5:44 AM
aaron.ballman accepted this revision.Jun 8 2023, 5:57 AM
aaron.ballman added a subscriber: aaron.ballman.

Please add a release note for the fix, but otherwise LGTM. Thank you!

nickdesaulniers updated this revision to Diff 529652.Jun 8 2023, 9:56 AM
  • add release note
Harbormaster completed remote builds in B237536: Diff 529652.Jun 8 2023, 1:04 PM
Closed by commit rG9daab7fb02d2: [ExprConstant] fix ICE from Evaluate on _Atomic structs (authored by nickdesaulniers). · Explain WhyJun 8 2023, 1:20 PM
This revision was automatically updated to reflect the committed changes.
nickdesaulniers added a commit: rG9daab7fb02d2: [ExprConstant] fix ICE from Evaluate on _Atomic structs.

Revision Contents
Changeset List

PathSize
clang/
docs/
2 lines
lib/
AST/
1 line
test/
CodeGenCXX/
22 lines

Diff 529703

View Options

clang/docs/ReleaseNotes.rst

Loading...
View Options

clang/lib/AST/ExprConstant.cpp

Loading...
View Options

clang/test/CodeGenCXX/atomicinit.cpp

Loading...