This is an archive of the discontinued LLVM Phabricator instance.

[NFC][Py Reformat] Reformat lit.local.cfg python files in llvm
ClosedPublic

Authored by thieta on May 17 2023, 2:04 AM.

Details

Summary

This is a follow-up to b71edfaa4ec3c998aadb35255ce2f60bba2940b0
since I forgot the lit.local.cfg files in that one.

Reformatting is done with black.

If you end up having problems merging this commit because you
have made changes to a python file, the best way to handle that
is to run git checkout --ours <yourfile> and then reformat it
with black.

If you run into any problems, post to discourse about it and
we will try to help.

RFC Thread below:

https://discourse.llvm.org/t/rfc-document-and-standardize-python-code-style

Diff Detail

Event Timeline

thieta created this revision.May 17 2023, 2:04 AM
Herald added a reviewer: MaskRay. · View Herald Transcript
Herald added a reviewer: ributzka. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
thieta requested review of this revision.May 17 2023, 2:04 AM
barannikov88 accepted this revision.May 17 2023, 2:24 AM
This revision is now accepted and ready to land.May 17 2023, 2:24 AM
kwk accepted this revision.May 17 2023, 3:33 AM
kwk added a subscriber: kwk.

I've gone through all code snippets and it LGTM. Sometimes the review was annoying. That is because the length of a quoted string decides if a change of quotation marks the whole string or just the quotes as changed. See for yourself.

I've gone through all code snippets and it LGTM. Sometimes the review was annoying. That is because the length of a quoted string decides if a change of quotation marks the whole string or just the quotes as changed. See for yourself.

That is sure a bit annoying. Thanks for doing all of that!

This revision was landed with ongoing or failed builds.May 17 2023, 8:03 AM
This revision was automatically updated to reflect the committed changes.