addressing feedback

In D159221#4632279, @wenlei wrote:

Thanks for attempting the clean up. I think the original version is probably more readable. I left comments there. wdyt?

addressing feedback

addressing feedback, fix typo.

rebase

rebase

rebase

rebase

rebase

Updating D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile

Updating D158891: [CSSPGO] Retire FlattenProfileForMatching

Split the original patch into four patches, https://reviews.llvm.org/D156725, https://reviews.llvm.org/D158891, https://reviews.llvm.org/D158900, https://reviews.llvm.org/D158817
Or you can simply find them in the patch stack.

rebase

fix typo

rebase on https://reviews.llvm.org/D158817

move dbg print into runStaleProfileMatching

addressing feedback

Updating D156725: [CSSPGO] Improve profile staleness report for post-link time

addressing feedback

Updating D156725: [CSSPGO] Improve profile staleness report for post-link time

retire flatten-profile-for-matching switch, always use flattened profile for matching.

update the commment.

In D156715#4561996, @hoy wrote:

In D156715#4558585, @wlei wrote:

In D156715#4550679, @hoy wrote:

How does perf look like after disabling annotating imported functions?

So far from what I tested, there is no perf change if only disabling annotating imported functions. Note that this also disables the profile matching for the imported functions, so it could cause perf issue, depending on if the imported functions is stale.

Discussed offline. This effect of this change is potentially two-fold :

1. positive impact of disabling unnecessary matching for non-stale profiles
2. negative impact of disabling matching for to-be-inlined imported functions with a stale profile.

Currently they are not tested separately. With a solution of #1, allowing matching for #2 might be a win. Suggesting to hold on this change until we have a good solution for #1.

Thoughts?

addressing feedback

In D156715#4550679, @hoy wrote:

How does perf look like after disabling annotating imported functions?

Updating D156715: [CSSPGO] Fix issues with post-link function checksum check

1. change to simply return(not add to the import list)
2. update the comments

addressing feedback

addressing feedback, updated the comments.

addressing feedback.

Good catch!

LGTM, thanks.

In D147456#4306762, @mysterymath wrote:

It looks like this change or its followup is causing test failures on the Fuchsia toolchain builders:

https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8782540257332498033/test-results?sortby=&groupby=

Script:
--
: 'RUN: at line 3';   /b/s/w/ir/x/w/staging/llvm_build/bin/opt < /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/Transforms/SampleProfile/pseudo-probe-stale-profile-matching.ll -passes=sample-profile -sample-profile-file=/b/s/w/ir/x/w/llvm-llvm-project/llvm/test/Transforms/SampleProfile/Inputs/pseudo-probe-stale-profile-matching.prof --salvage-stale-profile -S --debug-only=sample-profile 2>&1 | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/Transforms/SampleProfile/pseudo-probe-stale-profile-matching.ll
--
Exit Code: 1

Command Output (stderr):
--
/b/s/w/ir/x/w/llvm-llvm-project/llvm/test/Transforms/SampleProfile/pseudo-probe-stale-profile-matching.ll:66:10: error: CHECK: expected string not found in input
; CHECK: Callsite with callee:foo is matched from 13 to 6
         ^
<stdin>:12:34: note: scanning from here
Location is matched from 11 to 11
                                 ^
<stdin>:13:1: note: possible intended match here
Callsite with callee:foo is matched from 13 to 0
^