User Details
- User Since
- Sep 14 2020, 11:36 PM (17 w, 5 d)
Fri, Jan 15
fix typo and rebase
fix typo
Addressing Wei's feedback
Remove more redundancy cases during deduplication
Thu, Jan 14
Refine the cl::desc for CSProfColdThres and CSProfKeepCold
Wed, Jan 13
rewrote the comments, adding more examples
Tue, Jan 12
rebase
Rebase and addressing Wei's feedback
Addessing Wei's feedback
Mon, Jan 11
Addressing Wei's feedback
Address Wei's feedback
Addressing Wei's feedback
Wed, Jan 6
Kindly ping @wmi ,
I have addressed feedbacks from Hongtao and Wenlei, want to know whether this's also good for you or any other questions.
Also for other pseudo probe patches(https://reviews.llvm.org/D92334, https://reviews.llvm.org/D92896, https://reviews.llvm.org/D92998). Thanks!
Tue, Jan 5
rebase and fix clang-tidy
Tue, Dec 22
fix lint
added CHECK-NEXT and other refactoring work
Mon, Dec 21
rebase and fix clang-tidy
rebase
Address Hongtao's feedback: support profile checksum and some other NFC work
Dec 18 2020
rebase
Dec 16 2020
LBRSample will be added when AutoFDO support is moved into llvm-profgen, right? For AutoFDO, we could use the same infrastructure except that context will always be empty.
Good question, Yes, my initial thought is to decouple this by using separated LBRSample when it comes to AutoFDO, perhaps this's good for readability. I guess your suggestion is for the performance since we won't have virtual call. That's good. If so and we don't have other kinds of perf sample, we might don't need the base class PerfSample and can just name HybridSample to more general name(like PerfSample).
Address Wenlei's feedback
Dec 15 2020
LGTM, Thanks for woking on this @tstellar
address reviewers' feedback
Dec 11 2020
Address some feedback from hongtao. The string handling part will be redesigned and come later
Dec 10 2020
change to use post-order traversal to extract inlined context stack
Dec 9 2020
rebase
Chang to use SmallVector instead of std::list
Address Hongtao's feedback
Dec 8 2020
rebase
Address Hongtao's feedback, reuse the code from pseudo probe encoding and some refactoring work
Dec 7 2020
Hi, @vitalybuka , sorry for the test failure, the fix-up patch(https://reviews.llvm.org/D92816) is already landed, please update the repo, thanks!
change according wenlei's suggestion
rebase and update the diff summary
Dec 4 2020
address Hongtao's feedback
Dec 3 2020
fix a missing genHashCode, also add a assertion for this
add more comments
Address wenlei's feedback
Dec 1 2020
remove deprecated code(pseudo probe CFG decoding) which is replaced by other design inside llvm
add const qualifier for some functions
Address reviewers' feedback: added more comments and some refactoring work