Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

wlei (Lei Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2020, 11:36 PM (158 w, 6 d)

Recent Activity

Aug 31 2023

wlei committed rGf14a5ff6357c: [CSSPGO] Refactoring findIRAnchors (authored by wlei).
[CSSPGO] Refactoring findIRAnchors
Aug 31 2023, 4:26 PM · Restricted Project, Restricted Project
wlei closed D159169: [CSSPGO] Refactoring findIRAnchors.
Aug 31 2023, 4:26 PM · Restricted Project, Restricted Project
wlei added inline comments to D159169: [CSSPGO] Refactoring findIRAnchors.
Aug 31 2023, 4:01 PM · Restricted Project, Restricted Project
wlei updated the diff for D159169: [CSSPGO] Refactoring findIRAnchors.

addressing feedback

Aug 31 2023, 3:59 PM · Restricted Project, Restricted Project
wlei abandoned D159221: [RFC] Alterative to https://reviews.llvm.org/D159169.
Aug 31 2023, 12:31 PM · Restricted Project, Restricted Project
wlei added a comment to D159221: [RFC] Alterative to https://reviews.llvm.org/D159169.

Thanks for attempting the clean up. I think the original version is probably more readable. I left comments there. wdyt?

Aug 31 2023, 12:31 PM · Restricted Project, Restricted Project

Aug 30 2023

wlei retitled D159221: [RFC] Alterative to https://reviews.llvm.org/D159169 from tmp to [RFC] Alterative to https://reviews.llvm.org/D159169.
Aug 30 2023, 6:03 PM · Restricted Project, Restricted Project
wlei committed rG4bb6bbb9bf76: [CSSPGO] Skip reporting staleness metrics for imported functions (authored by wlei).
[CSSPGO] Skip reporting staleness metrics for imported functions
Aug 30 2023, 6:02 PM · Restricted Project, Restricted Project
wlei committed rG3365cd454407: [CSSPGO] Compute checksum mismatch recursively on nested profile (authored by wlei).
[CSSPGO] Compute checksum mismatch recursively on nested profile
Aug 30 2023, 6:02 PM · Restricted Project, Restricted Project
wlei committed rG62a3f6c96eb3: [CSSPGO] Retire FlattenProfileForMatching (authored by wlei).
[CSSPGO] Retire FlattenProfileForMatching
Aug 30 2023, 6:02 PM · Restricted Project, Restricted Project
wlei committed rG062af2e76366: [CSSPGO] Support stale profile matching for LTO (authored by wlei).
[CSSPGO] Support stale profile matching for LTO
Aug 30 2023, 6:02 PM · Restricted Project, Restricted Project
wlei committed rG148cceb0d6b5: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction (authored by wlei).
[CSSPGO] Refactoring SampleProfileMatcher::runOnFunction
Aug 30 2023, 6:02 PM · Restricted Project, Restricted Project
wlei closed D156725: [CSSPGO] Skip reporting staleness metrics for imported functions.
Aug 30 2023, 6:02 PM · Restricted Project, Restricted Project
wlei closed D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile.
Aug 30 2023, 6:01 PM · Restricted Project, Restricted Project
wlei closed D158891: [CSSPGO] Retire FlattenProfileForMatching.
Aug 30 2023, 6:01 PM · Restricted Project, Restricted Project
wlei closed D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.
Aug 30 2023, 6:01 PM · Restricted Project, Restricted Project
wlei closed D156722: [CSSPGO] Support stale profile matching for LTO.
Aug 30 2023, 6:01 PM · Restricted Project, Restricted Project
wlei added inline comments to D158891: [CSSPGO] Retire FlattenProfileForMatching.
Aug 30 2023, 2:17 PM · Restricted Project, Restricted Project
wlei added inline comments to D159169: [CSSPGO] Refactoring findIRAnchors.
Aug 30 2023, 1:27 PM · Restricted Project, Restricted Project
wlei requested review of D159221: [RFC] Alterative to https://reviews.llvm.org/D159169.
Aug 30 2023, 1:16 PM · Restricted Project, Restricted Project
wlei added inline comments to D159169: [CSSPGO] Refactoring findIRAnchors.
Aug 30 2023, 11:05 AM · Restricted Project, Restricted Project
wlei added inline comments to D159169: [CSSPGO] Refactoring findIRAnchors.
Aug 30 2023, 12:15 AM · Restricted Project, Restricted Project
wlei updated the diff for D159169: [CSSPGO] Refactoring findIRAnchors.

addressing feedback

Aug 30 2023, 12:15 AM · Restricted Project, Restricted Project

Aug 29 2023

wlei updated the summary of D159169: [CSSPGO] Refactoring findIRAnchors.
Aug 29 2023, 11:17 PM · Restricted Project, Restricted Project
wlei requested review of D159169: [CSSPGO] Refactoring findIRAnchors.
Aug 29 2023, 11:12 PM · Restricted Project, Restricted Project
wlei added inline comments to D158891: [CSSPGO] Retire FlattenProfileForMatching.
Aug 29 2023, 10:52 PM · Restricted Project, Restricted Project
wlei added inline comments to D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.
Aug 29 2023, 9:08 PM · Restricted Project, Restricted Project
wlei added inline comments to D158891: [CSSPGO] Retire FlattenProfileForMatching.
Aug 29 2023, 7:55 PM · Restricted Project, Restricted Project
wlei added inline comments to D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.
Aug 29 2023, 5:46 PM · Restricted Project, Restricted Project
wlei updated the diff for D158891: [CSSPGO] Retire FlattenProfileForMatching.

addressing feedback, fix typo.

Aug 29 2023, 5:06 PM · Restricted Project, Restricted Project
wlei added inline comments to D158891: [CSSPGO] Retire FlattenProfileForMatching.
Aug 29 2023, 5:03 PM · Restricted Project, Restricted Project

Aug 25 2023

wlei updated the diff for D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile.

rebase

Aug 25 2023, 6:02 PM · Restricted Project, Restricted Project
wlei updated the diff for D156725: [CSSPGO] Skip reporting staleness metrics for imported functions.

rebase

Aug 25 2023, 6:02 PM · Restricted Project, Restricted Project
wlei updated the diff for D156725: [CSSPGO] Skip reporting staleness metrics for imported functions.

rebase

Aug 25 2023, 6:01 PM · Restricted Project, Restricted Project
wlei updated the diff for D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile.

rebase

Aug 25 2023, 5:53 PM · Restricted Project, Restricted Project
wlei updated the diff for D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile.

rebase

Aug 25 2023, 5:52 PM · Restricted Project, Restricted Project
wlei updated the diff for D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile.

Updating D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile

Aug 25 2023, 5:48 PM · Restricted Project, Restricted Project
wlei added inline comments to D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile.
Aug 25 2023, 5:47 PM · Restricted Project, Restricted Project
wlei added inline comments to D158891: [CSSPGO] Retire FlattenProfileForMatching.
Aug 25 2023, 5:38 PM · Restricted Project, Restricted Project
wlei updated the diff for D158891: [CSSPGO] Retire FlattenProfileForMatching.

Updating D158891: [CSSPGO] Retire FlattenProfileForMatching

Aug 25 2023, 5:38 PM · Restricted Project, Restricted Project
wlei added a comment to D156725: [CSSPGO] Skip reporting staleness metrics for imported functions.

Split the original patch into four patches, https://reviews.llvm.org/D156725, https://reviews.llvm.org/D158891, https://reviews.llvm.org/D158900, https://reviews.llvm.org/D158817
Or you can simply find them in the patch stack.

Aug 25 2023, 3:16 PM · Restricted Project, Restricted Project
wlei retitled D156725: [CSSPGO] Skip reporting staleness metrics for imported functions from [CSSPGO] Improve profile staleness report for post-link time to [CSSPGO] Skip reporting staleness metrics for imported functions.
Aug 25 2023, 3:13 PM · Restricted Project, Restricted Project
wlei updated the diff for D156725: [CSSPGO] Skip reporting staleness metrics for imported functions.

rebase

Aug 25 2023, 3:09 PM · Restricted Project, Restricted Project
wlei updated the summary of D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile.
Aug 25 2023, 2:58 PM · Restricted Project, Restricted Project
wlei requested review of D158900: [CSSPGO] Compute checksum mismatch recursively on nested profile.
Aug 25 2023, 2:49 PM · Restricted Project, Restricted Project
wlei updated the summary of D158891: [CSSPGO] Retire FlattenProfileForMatching.
Aug 25 2023, 2:19 PM · Restricted Project, Restricted Project
wlei requested review of D158891: [CSSPGO] Retire FlattenProfileForMatching.
Aug 25 2023, 2:13 PM · Restricted Project, Restricted Project
wlei updated the diff for D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.

fix typo

Aug 25 2023, 1:52 PM · Restricted Project, Restricted Project
wlei retitled D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction from [CSSPGO] Refactoring populateIRLocations and countProfileMismatches to [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.
Aug 25 2023, 1:45 PM · Restricted Project, Restricted Project
wlei updated the diff for D156722: [CSSPGO] Support stale profile matching for LTO.

rebase on https://reviews.llvm.org/D158817

Aug 25 2023, 1:31 PM · Restricted Project, Restricted Project
wlei updated the diff for D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.

move dbg print into runStaleProfileMatching

Aug 25 2023, 1:30 PM · Restricted Project, Restricted Project
wlei added inline comments to D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.
Aug 25 2023, 1:22 PM · Restricted Project, Restricted Project
wlei updated the diff for D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.

addressing feedback

Aug 25 2023, 1:11 PM · Restricted Project, Restricted Project

Aug 24 2023

wlei updated the diff for D156725: [CSSPGO] Skip reporting staleness metrics for imported functions.

Updating D156725: [CSSPGO] Improve profile staleness report for post-link time

Aug 24 2023, 11:49 PM · Restricted Project, Restricted Project
wlei added inline comments to D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.
Aug 24 2023, 11:46 PM · Restricted Project, Restricted Project
wlei updated the summary of D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.
Aug 24 2023, 11:42 PM · Restricted Project, Restricted Project
wlei requested review of D158817: [CSSPGO] Refactoring SampleProfileMatcher::runOnFunction.
Aug 24 2023, 11:32 PM · Restricted Project, Restricted Project
wlei added inline comments to D156722: [CSSPGO] Support stale profile matching for LTO.
Aug 24 2023, 11:30 PM · Restricted Project, Restricted Project
wlei updated the diff for D156722: [CSSPGO] Support stale profile matching for LTO.

addressing feedback

Aug 24 2023, 11:30 PM · Restricted Project, Restricted Project

Aug 15 2023

wlei updated the diff for D156725: [CSSPGO] Skip reporting staleness metrics for imported functions.

Updating D156725: [CSSPGO] Improve profile staleness report for post-link time

Aug 15 2023, 12:17 AM · Restricted Project, Restricted Project
wlei updated the diff for D156725: [CSSPGO] Skip reporting staleness metrics for imported functions.

retire flatten-profile-for-matching switch, always use flattened profile for matching.

Aug 15 2023, 12:06 AM · Restricted Project, Restricted Project

Aug 11 2023

wlei added inline comments to D156722: [CSSPGO] Support stale profile matching for LTO.
Aug 11 2023, 9:41 AM · Restricted Project, Restricted Project

Aug 10 2023

wlei updated the diff for D156722: [CSSPGO] Support stale profile matching for LTO.

update the commment.

Aug 10 2023, 12:09 PM · Restricted Project, Restricted Project
wlei added inline comments to D156722: [CSSPGO] Support stale profile matching for LTO.
Aug 10 2023, 11:57 AM · Restricted Project, Restricted Project

Aug 8 2023

wlei added inline comments to D157061: [SampleProfile] Potential use after move in SampleProfileLoader::promoteMergeNotInlinedContextSamples.
Aug 8 2023, 12:06 PM · Restricted Project, Restricted Project

Aug 4 2023

wlei planned changes to D156715: [CSSPGO] Fix issues with post-link function checksum check.

How does perf look like after disabling annotating imported functions?

So far from what I tested, there is no perf change if only disabling annotating imported functions. Note that this also disables the profile matching for the imported functions, so it could cause perf issue, depending on if the imported functions is stale.

Discussed offline. This effect of this change is potentially two-fold :

  1. positive impact of disabling unnecessary matching for non-stale profiles
  2. negative impact of disabling matching for to-be-inlined imported functions with a stale profile.

Currently they are not tested separately. With a solution of #1, allowing matching for #2 might be a win. Suggesting to hold on this change until we have a good solution for #1.

Thoughts?

Aug 4 2023, 2:54 PM · Restricted Project, Restricted Project
wlei added inline comments to D157061: [SampleProfile] Potential use after move in SampleProfileLoader::promoteMergeNotInlinedContextSamples.
Aug 4 2023, 11:11 AM · Restricted Project, Restricted Project
wlei added inline comments to D156722: [CSSPGO] Support stale profile matching for LTO.
Aug 4 2023, 10:50 AM · Restricted Project, Restricted Project
wlei updated the diff for D156722: [CSSPGO] Support stale profile matching for LTO.

addressing feedback

Aug 4 2023, 10:50 AM · Restricted Project, Restricted Project

Aug 3 2023

wlei added a comment to D156715: [CSSPGO] Fix issues with post-link function checksum check.

How does perf look like after disabling annotating imported functions?

Aug 3 2023, 12:34 PM · Restricted Project, Restricted Project
wlei updated the diff for D156715: [CSSPGO] Fix issues with post-link function checksum check.

Updating D156715: [CSSPGO] Fix issues with post-link function checksum check

Aug 3 2023, 12:34 PM · Restricted Project, Restricted Project

Jul 31 2023

wlei retitled D156725: [CSSPGO] Skip reporting staleness metrics for imported functions from [CSSPGO] Improve computing profile staleness metrics in post-link time to [CSSPGO] Improve profile staleness report for post-link time.
Jul 31 2023, 12:28 PM · Restricted Project, Restricted Project
wlei requested review of D156725: [CSSPGO] Skip reporting staleness metrics for imported functions.
Jul 31 2023, 11:29 AM · Restricted Project, Restricted Project
wlei updated the summary of D156722: [CSSPGO] Support stale profile matching for LTO.
Jul 31 2023, 11:19 AM · Restricted Project, Restricted Project
wlei requested review of D156722: [CSSPGO] Support stale profile matching for LTO.
Jul 31 2023, 11:01 AM · Restricted Project, Restricted Project
wlei updated the summary of D156715: [CSSPGO] Fix issues with post-link function checksum check.
Jul 31 2023, 10:54 AM · Restricted Project, Restricted Project
wlei requested review of D156715: [CSSPGO] Fix issues with post-link function checksum check.
Jul 31 2023, 9:48 AM · Restricted Project, Restricted Project

Jul 7 2023

wlei committed rGbfefeeb13952: [SamplePGO] Fix ICE that callee samples returns null while finding import… (authored by wlei).
[SamplePGO] Fix ICE that callee samples returns null while finding import…
Jul 7 2023, 2:57 PM · Restricted Project, Restricted Project
wlei closed D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 7 2023, 2:57 PM · Restricted Project, Restricted Project
wlei updated the summary of D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 7 2023, 2:53 PM · Restricted Project, Restricted Project
wlei updated the diff for D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
  1. change to simply return(not add to the import list)
  2. update the comments
Jul 7 2023, 12:15 PM · Restricted Project, Restricted Project
wlei added inline comments to D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 7 2023, 12:10 PM · Restricted Project, Restricted Project
wlei added inline comments to D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 7 2023, 11:13 AM · Restricted Project, Restricted Project
wlei added inline comments to D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 7 2023, 10:44 AM · Restricted Project, Restricted Project

Jul 6 2023

wlei added inline comments to D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 6 2023, 11:26 PM · Restricted Project, Restricted Project
wlei added inline comments to D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 6 2023, 11:18 PM · Restricted Project, Restricted Project
wlei updated the diff for D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.

addressing feedback

Jul 6 2023, 3:09 PM · Restricted Project, Restricted Project
wlei retitled D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions from [CSSPGO] Fix ICE that callee samples returns null while finding import functions to [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 6 2023, 3:09 PM · Restricted Project, Restricted Project
wlei updated the summary of D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 6 2023, 11:35 AM · Restricted Project, Restricted Project
wlei requested review of D154637: [SamplePGO] Fix ICE that callee samples returns null while finding import functions.
Jul 6 2023, 11:10 AM · Restricted Project, Restricted Project

Jun 29 2023

wlei committed rG444d2e1a5405: [CSSPGO] Enable stale profile matching by default for CSSPGO (authored by wlei).
[CSSPGO] Enable stale profile matching by default for CSSPGO
Jun 29 2023, 11:19 AM · Restricted Project, Restricted Project
wlei closed D154027: [CSSPGO] Enable stale profile matching by default for CSSPGO.
Jun 29 2023, 11:19 AM · Restricted Project, Restricted Project

Jun 28 2023

wlei updated the diff for D154027: [CSSPGO] Enable stale profile matching by default for CSSPGO.

addressing feedback, updated the comments.

Jun 28 2023, 6:21 PM · Restricted Project, Restricted Project
wlei updated the diff for D154027: [CSSPGO] Enable stale profile matching by default for CSSPGO.

addressing feedback.

Jun 28 2023, 5:48 PM · Restricted Project, Restricted Project
wlei updated the summary of D154027: [CSSPGO] Enable stale profile matching by default for CSSPGO.
Jun 28 2023, 5:47 PM · Restricted Project, Restricted Project
wlei updated the summary of D154027: [CSSPGO] Enable stale profile matching by default for CSSPGO.
Jun 28 2023, 5:25 PM · Restricted Project, Restricted Project
wlei requested review of D154027: [CSSPGO] Enable stale profile matching by default for CSSPGO.
Jun 28 2023, 5:22 PM · Restricted Project, Restricted Project
wlei accepted D153995: [NFC][Sample PGO] Avoid non-const accessor for CallsiteSamples.

Good catch!

Jun 28 2023, 12:07 PM · Restricted Project, Restricted Project

Jun 26 2023

wlei accepted D153730: [NFC] Generalize llvm-profgen message to cover both AutoFDO and CSSPGO.

LGTM, thanks.

Jun 26 2023, 9:06 AM · Restricted Project, Restricted Project

Apr 28 2023

wlei added a comment to D147456: [SamplePGO] Stale profile matching(part 1).

It looks like this change or its followup is causing test failures on the Fuchsia toolchain builders:

https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8782540257332498033/test-results?sortby=&groupby=

Script:
--
: 'RUN: at line 3';   /b/s/w/ir/x/w/staging/llvm_build/bin/opt < /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/Transforms/SampleProfile/pseudo-probe-stale-profile-matching.ll -passes=sample-profile -sample-profile-file=/b/s/w/ir/x/w/llvm-llvm-project/llvm/test/Transforms/SampleProfile/Inputs/pseudo-probe-stale-profile-matching.prof --salvage-stale-profile -S --debug-only=sample-profile 2>&1 | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/Transforms/SampleProfile/pseudo-probe-stale-profile-matching.ll
--
Exit Code: 1

Command Output (stderr):
--
/b/s/w/ir/x/w/llvm-llvm-project/llvm/test/Transforms/SampleProfile/pseudo-probe-stale-profile-matching.ll:66:10: error: CHECK: expected string not found in input
; CHECK: Callsite with callee:foo is matched from 13 to 6
         ^
<stdin>:12:34: note: scanning from here
Location is matched from 11 to 11
                                 ^
<stdin>:13:1: note: possible intended match here
Callsite with callee:foo is matched from 13 to 0
^
Apr 28 2023, 3:59 PM · Restricted Project, Restricted Project