Page MenuHomePhabricator

wlei (Lei Wang)
Software Engineer at Facebook

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2020, 11:36 PM (94 w, 1 d)

Recent Activity

Wed, Jun 29

wlei updated the summary of D128859: [llvm-profgen] Do not cache the frame location stack during computing inlined context size.
Wed, Jun 29, 3:05 PM · Restricted Project, Restricted Project
wlei requested review of D128859: [llvm-profgen] Do not cache the frame location stack during computing inlined context size.
Wed, Jun 29, 2:56 PM · Restricted Project, Restricted Project

Mon, Jun 27

wlei committed rG7e86b13c63f2: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie (authored by wlei).
[CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie
Mon, Jun 27, 11:30 PM · Restricted Project, Restricted Project
wlei committed rGaa58b7b1e30f: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie (authored by wlei).
[CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie
Mon, Jun 27, 11:30 PM · Restricted Project, Restricted Project
wlei committed rGeba5749262d9: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie (authored by wlei).
[CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie
Mon, Jun 27, 11:30 PM · Restricted Project, Restricted Project
wlei closed D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 27, 11:30 PM · Restricted Project, Restricted Project
wlei closed D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Mon, Jun 27, 11:30 PM · Restricted Project, Restricted Project
wlei closed D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
Mon, Jun 27, 11:30 PM · Restricted Project, Restricted Project
wlei updated the summary of D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 27, 11:18 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 27, 7:32 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

Addressing Wenlei's feeback: add an iterator API for SampleContextTracker and other refactors.

Mon, Jun 27, 5:51 PM · Restricted Project, Restricted Project
wlei updated the diff for D126827: [llvm-profgen] Fix a loading address bug for pseudo probe profile.

changed all offset usage to preferred address based virtual address

Mon, Jun 27, 11:00 AM · Restricted Project, Restricted Project

Thu, Jun 23

wlei updated the diff for D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

Addressing Wenlei's feedback

Thu, Jun 23, 8:16 PM · Restricted Project, Restricted Project

Wed, Jun 22

wlei added inline comments to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
Wed, Jun 22, 10:50 PM · Restricted Project, Restricted Project
wlei updated the diff for D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

add a valid state check for the trie conversion.

Wed, Jun 22, 10:49 PM · Restricted Project, Restricted Project
wlei updated the diff for D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

Updating D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie

Wed, Jun 22, 10:28 PM · Restricted Project, Restricted Project
wlei added inline comments to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
Wed, Jun 22, 10:18 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

rebase

Wed, Jun 22, 6:30 PM · Restricted Project, Restricted Project
wlei updated the diff for D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

rebase

Wed, Jun 22, 6:23 PM · Restricted Project, Restricted Project
wlei updated the diff for D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

addressing Wenlei's feedback

Wed, Jun 22, 6:18 PM · Restricted Project, Restricted Project

Tue, Jun 14

wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Tue, Jun 14, 11:42 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

Updating D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie

Tue, Jun 14, 11:42 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

rebase, memory leak issue is addressed in the https://reviews.llvm.org/D125246

Tue, Jun 14, 9:04 PM · Restricted Project, Restricted Project
wlei updated the diff for D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

rebase

Tue, Jun 14, 8:57 PM · Restricted Project, Restricted Project
wlei updated the diff for D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

Put all FSamples in a std::list<FunctionSamples> to avoid memory new and delete.

Tue, Jun 14, 8:55 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Tue, Jun 14, 6:56 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Tue, Jun 14, 6:22 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

move memory free code inside llvm-profgen

Tue, Jun 14, 3:53 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Tue, Jun 14, 12:29 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

free memory allocated by llvm-profgen

Tue, Jun 14, 9:33 AM · Restricted Project, Restricted Project

Mon, Jun 13

wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 13, 11:50 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 13, 10:22 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

Updating D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie

Mon, Jun 13, 10:22 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

addressing feedback from Hongtao

Mon, Jun 13, 5:23 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 13, 3:35 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 13, 1:44 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 13, 12:31 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 13, 11:59 AM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 13, 10:00 AM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

Updating D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie

Mon, Jun 13, 9:59 AM · Restricted Project, Restricted Project

Fri, Jun 10

wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Fri, Jun 10, 9:55 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

Make a union type for fullcontext(array) and context trie node.

Fri, Jun 10, 9:51 PM · Restricted Project, Restricted Project
wlei updated the diff for D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

added more commments.

Fri, Jun 10, 10:35 AM · Restricted Project, Restricted Project
wlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Fri, Jun 10, 9:24 AM · Restricted Project, Restricted Project
wlei updated the diff for D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

Updating D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie

Fri, Jun 10, 9:22 AM · Restricted Project, Restricted Project

Thu, Jun 9

wlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Thu, Jun 9, 10:48 PM · Restricted Project, Restricted Project
wlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Thu, Jun 9, 10:21 PM · Restricted Project, Restricted Project
wlei updated the diff for D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

changed to use virtual function for collectProfiledFunctions.

Thu, Jun 9, 10:05 PM · Restricted Project, Restricted Project
wlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Thu, Jun 9, 9:37 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

Addressing reviewers' feedback. Also added the build time and memory usage number in the summary.

Thu, Jun 9, 9:29 PM · Restricted Project, Restricted Project
wlei updated the summary of D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Thu, Jun 9, 9:28 PM · Restricted Project, Restricted Project
wlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Thu, Jun 9, 9:21 PM · Restricted Project, Restricted Project
wlei updated the diff for D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

Updating D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie

Thu, Jun 9, 6:44 PM · Restricted Project, Restricted Project
wlei updated the diff for D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

Updating D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie

Thu, Jun 9, 6:39 PM · Restricted Project, Restricted Project
wlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Thu, Jun 9, 6:38 PM · Restricted Project, Restricted Project

Wed, Jun 8

wlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Wed, Jun 8, 4:50 PM · Restricted Project, Restricted Project
wlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Wed, Jun 8, 4:34 PM · Restricted Project, Restricted Project
wlei added inline comments to D126827: [llvm-profgen] Fix a loading address bug for pseudo probe profile.
Wed, Jun 8, 2:39 PM · Restricted Project, Restricted Project
wlei added inline comments to D126827: [llvm-profgen] Fix a loading address bug for pseudo probe profile.
Wed, Jun 8, 2:30 PM · Restricted Project, Restricted Project
wlei accepted D127330: [CSSPGO][Preinliner] Set default value of sample-profile-inline-limit-max to 3000.

LGTM.

Wed, Jun 8, 11:52 AM · Restricted Project, Restricted Project

Mon, Jun 6

wlei updated the diff for D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

Updating D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie

Mon, Jun 6, 7:26 PM · Restricted Project, Restricted Project
wlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Mon, Jun 6, 7:26 PM · Restricted Project, Restricted Project
wlei updated the diff for D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

use std::move to avoid memory copy
remove the "memory free" code, will add in a separate patch.

Mon, Jun 6, 4:25 PM · Restricted Project, Restricted Project
wlei added inline comments to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
Mon, Jun 6, 4:25 PM · Restricted Project, Restricted Project
wlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Mon, Jun 6, 11:23 AM · Restricted Project, Restricted Project

Jun 3 2022

wlei updated the summary of D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Jun 3 2022, 5:49 PM · Restricted Project, Restricted Project
wlei updated the diff for D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

Updating D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie

Jun 3 2022, 5:49 PM · Restricted Project, Restricted Project
wlei requested review of D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Jun 3 2022, 4:08 PM · Restricted Project, Restricted Project
wlei updated the summary of D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Jun 3 2022, 4:06 PM · Restricted Project, Restricted Project
wlei requested review of D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Jun 3 2022, 4:03 PM · Restricted Project, Restricted Project
wlei added inline comments to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
Jun 3 2022, 12:09 PM · Restricted Project, Restricted Project
wlei updated the diff for D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

rebase
using context tracker directly

Jun 3 2022, 12:09 PM · Restricted Project, Restricted Project

Jun 1 2022

wlei retitled D126827: [llvm-profgen] Fix a loading address bug for pseudo probe profile from [llvm-profgen] fix a loading address bug for pseudo probe profile to [llvm-profgen] Fix a loading address bug for pseudo probe profile.
Jun 1 2022, 2:21 PM · Restricted Project, Restricted Project
wlei requested review of D126827: [llvm-profgen] Fix a loading address bug for pseudo probe profile.
Jun 1 2022, 2:16 PM · Restricted Project, Restricted Project

May 18 2022

wlei added inline comments to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
May 18 2022, 10:54 AM · Restricted Project, Restricted Project
wlei updated the diff for D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

Addressing feedback.

May 18 2022, 10:54 AM · Restricted Project, Restricted Project

May 12 2022

wlei committed rG9f732af583c0: [llvm-profgen] Filter out oversized LBR ranges. (authored by hoy).
[llvm-profgen] Filter out oversized LBR ranges.
May 12 2022, 10:59 AM · Restricted Project, Restricted Project
wlei closed D125448: [llvm-profgen] Filter out oversized LBR ranges..
May 12 2022, 10:59 AM · Restricted Project, Restricted Project
wlei added inline comments to D125448: [llvm-profgen] Filter out oversized LBR ranges..
May 12 2022, 10:41 AM · Restricted Project, Restricted Project
wlei updated the diff for D125448: [llvm-profgen] Filter out oversized LBR ranges..

upper_bound to lower_bound

May 12 2022, 10:30 AM · Restricted Project, Restricted Project
wlei added inline comments to D125448: [llvm-profgen] Filter out oversized LBR ranges..
May 12 2022, 10:27 AM · Restricted Project, Restricted Project
wlei added inline comments to D125448: [llvm-profgen] Filter out oversized LBR ranges..
May 12 2022, 10:10 AM · Restricted Project, Restricted Project
wlei added inline comments to D125448: [llvm-profgen] Filter out oversized LBR ranges..
May 12 2022, 9:54 AM · Restricted Project, Restricted Project
wlei updated the summary of D125448: [llvm-profgen] Filter out oversized LBR ranges..
May 12 2022, 9:33 AM · Restricted Project, Restricted Project
wlei updated the diff for D125448: [llvm-profgen] Filter out oversized LBR ranges..

addressing Wenlei's feedback

May 12 2022, 9:29 AM · Restricted Project, Restricted Project

May 11 2022

wlei requested review of D125448: [llvm-profgen] Filter out oversized LBR ranges..
May 11 2022, 10:54 PM · Restricted Project, Restricted Project

May 10 2022

wlei updated the diff for D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

Updating D125255: [llvm-profgen] Support a threshold to control hiding warning summaries

May 10 2022, 7:26 PM · Restricted Project, Restricted Project
wlei updated the diff for D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

IsCritical -> AlwaysEmit

May 10 2022, 7:24 PM · Restricted Project, Restricted Project

May 9 2022

wlei added a comment to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

Our experiment on one internal service showed that the context key's memory can be reduced from 80GB to 300MB.

This is awesome! Thanks for the work!

How about running time?

May 9 2022, 8:54 PM · Restricted Project, Restricted Project
wlei added a comment to D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

add a parameter to emitWarningSummary to customize value for critical warning, default value increase to 20%.

Do we even need a threshold for emitting critical ones? If it's critical, we should always emit them?

Sorry for the confusing, " customize value for critical warning" is wrong, I meant the parameter is used to treat warnings of different importance differently. For critical warning, the threshold is 0, then it's always emitted. For non-critical ones, developer can still set a threshold or use the default one, then emit it if it's above it.

Ok, maybe a verbose mode is enough for enabling all warnings. I can see that a threshold for non-critical warnings could be potentially useful, but also wondering if we could just keep things very simple here. The goal is not to give user a lot of control on what to print out, but to make sure 1) the default warning printing is meaningful to average users, 2) advanced users have a way to print everything.

May 9 2022, 8:45 PM · Restricted Project, Restricted Project
wlei updated the diff for D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

Updating D125255: [llvm-profgen] Support a threshold to control hiding warning summaries

May 9 2022, 8:45 PM · Restricted Project, Restricted Project
wlei added a comment to D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

add a parameter to emitWarningSummary to customize value for critical warning, default value increase to 20%.

Do we even need a threshold for emitting critical ones? If it's critical, we should always emit them?

May 9 2022, 7:44 PM · Restricted Project, Restricted Project
wlei added a comment to D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

I'm not sure if a universal threshold for filtering warning is a good way to deal with this. Maybe look at this from a different angle -- for some warnings, any instance is bad, for others, we can tolerate them. Hence, an alternative: for critical ones, we should always print out any non-zero value; for others, print them only under a "verbose" mode?

May 9 2022, 4:50 PM · Restricted Project, Restricted Project
wlei updated the diff for D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

Updating D125255: [llvm-profgen] Support a threshold to control hiding warning summaries

May 9 2022, 4:50 PM · Restricted Project, Restricted Project
wlei updated the summary of D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.
May 9 2022, 12:04 PM · Restricted Project, Restricted Project
wlei requested review of D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.
May 9 2022, 12:02 PM · Restricted Project, Restricted Project
wlei updated the summary of D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
May 9 2022, 10:56 AM · Restricted Project, Restricted Project
wlei requested review of D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
May 9 2022, 10:39 AM · Restricted Project, Restricted Project

Apr 28 2022

wlei committed rGbfcb2c1119d9: [llvm-profgen] Decouple artificial branch from LBR parser and fix external… (authored by wlei).
[llvm-profgen] Decouple artificial branch from LBR parser and fix external…
Apr 28 2022, 4:08 PM · Restricted Project, Restricted Project
wlei closed D118177: [llvm-profgen] Decouple artificial branch from LBR parser and fix external address related issues.
Apr 28 2022, 4:08 PM · Restricted Project, Restricted Project