Page MenuHomePhabricator

kwk (Konrad Wilhelm Kleine)
Senior Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2014, 8:11 AM (431 w, 15 h)

Recent Activity

Thu, May 19

kwk added a reverting change for rG32a0482a65b8: Add cmake to source release tarballs: rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it.
Thu, May 19, 2:13 AM
kwk added a reverting change for rG3a33664e8838: Add cmake/ to release tarballs via concatenation: rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it.
Thu, May 19, 2:13 AM · Restricted Project
kwk committed rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it (authored by kwk).
[release] Add cmake as an extra tarball and not bundle it
Thu, May 19, 2:13 AM · Restricted Project, Restricted Project
kwk added a reverting change for D118481: Add cmake to source release tarballs: rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it.
Thu, May 19, 2:13 AM · Restricted Project
kwk added a reverting change for D121972: Add cmake/ to release tarballs via concatenation: rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it.
Thu, May 19, 2:13 AM · Restricted Project, Restricted Project
kwk closed D125798: [release] Add cmake as an extra tarball and not bundle it.
Thu, May 19, 2:13 AM · Restricted Project, Restricted Project

Tue, May 17

kwk added a reviewer for D125798: [release] Add cmake as an extra tarball and not bundle it: aaronpuchert.
Tue, May 17, 8:45 AM · Restricted Project, Restricted Project
kwk added a reverting change for rG32a0482a65b8: Add cmake to source release tarballs: D125798: [release] Add cmake as an extra tarball and not bundle it.
Tue, May 17, 8:30 AM
kwk added a reverting change for rG3a33664e8838: Add cmake/ to release tarballs via concatenation: D125798: [release] Add cmake as an extra tarball and not bundle it.
Tue, May 17, 8:30 AM · Restricted Project
kwk requested review of D125798: [release] Add cmake as an extra tarball and not bundle it.
Tue, May 17, 8:30 AM · Restricted Project, Restricted Project
kwk added a reverting change for D118481: Add cmake to source release tarballs: D125798: [release] Add cmake as an extra tarball and not bundle it.
Tue, May 17, 8:30 AM · Restricted Project
kwk added a reverting change for D121972: Add cmake/ to release tarballs via concatenation: D125798: [release] Add cmake as an extra tarball and not bundle it.
Tue, May 17, 8:30 AM · Restricted Project, Restricted Project
kwk added a comment to D125763: [pgo] Fix doc typo: thingswith -> things with.

Thanks!

Do you have commit access?

Tue, May 17, 6:01 AM · Restricted Project, Restricted Project
kwk committed rG329dc5587cea: [pgo] Fix doc typo: thingswith -> things with (authored by kwk).
[pgo] Fix doc typo: thingswith -> things with
Tue, May 17, 6:01 AM · Restricted Project, Restricted Project
kwk closed D125763: [pgo] Fix doc typo: thingswith -> things with.
Tue, May 17, 6:01 AM · Restricted Project, Restricted Project
kwk added reviewers for D125763: [pgo] Fix doc typo: thingswith -> things with: george.burgess.iv, thakis.
Tue, May 17, 3:52 AM · Restricted Project, Restricted Project
kwk requested review of D125763: [pgo] Fix doc typo: thingswith -> things with.
Tue, May 17, 3:50 AM · Restricted Project, Restricted Project

Thu, May 12

kwk accepted D124405: docs: add instructions for stand-alone builds of lld.

LGTM

Thu, May 12, 6:17 AM · Restricted Project, Restricted Project

Wed, May 11

kwk committed rZORG2b96a257f15d: Make standalone-build-x86_64 a standalone builder (authored by kwk).
Make standalone-build-x86_64 a standalone builder
Wed, May 11, 9:29 AM · Restricted Project
kwk closed D125005: Make standalone-build-x86_64 a standalone builder.
Wed, May 11, 9:29 AM · Restricted Project

Tue, May 10

kwk updated the diff for D125005: Make standalone-build-x86_64 a standalone builder.
  • Organize build script with functions
Tue, May 10, 7:23 AM · Restricted Project
kwk added a comment to D125005: Make standalone-build-x86_64 a standalone builder.

@tstellar sparse checkout is implemented

Tue, May 10, 1:18 AM · Restricted Project
kwk updated the diff for D125005: Make standalone-build-x86_64 a standalone builder.
  • Sparse checkout only the directories needed
Tue, May 10, 1:12 AM · Restricted Project
kwk added inline comments to D125005: Make standalone-build-x86_64 a standalone builder.
Tue, May 10, 12:50 AM · Restricted Project

Mon, May 9

kwk added a comment to D125005: Make standalone-build-x86_64 a standalone builder.

@nikic @tstellar The patch is no longer needed because of the changes to the minimal config suggested by @tstellar . I hope we can get it in now.

Mon, May 9, 1:18 PM · Restricted Project
kwk updated the summary of D125005: Make standalone-build-x86_64 a standalone builder.
Mon, May 9, 1:16 PM · Restricted Project
kwk updated the diff for D125005: Make standalone-build-x86_64 a standalone builder.
  • Patch not needed with minimal config and LLVM_ROOT
Mon, May 9, 1:16 PM · Restricted Project
kwk added inline comments to D125005: Make standalone-build-x86_64 a standalone builder.
Mon, May 9, 1:08 PM · Restricted Project
kwk updated the diff for D125005: Make standalone-build-x86_64 a standalone builder.
  • Remove no longer needed export
Mon, May 9, 1:08 PM · Restricted Project
kwk updated the diff for D125005: Make standalone-build-x86_64 a standalone builder.
Mon, May 9, 1:00 PM · Restricted Project
kwk added inline comments to D125005: Make standalone-build-x86_64 a standalone builder.
Mon, May 9, 12:37 PM · Restricted Project
kwk added a comment to D125005: Make standalone-build-x86_64 a standalone builder.

@tstellar I'm trying your minimal config now on my build machine. I thought you wanted more details which is why I've taken the settings from Copr builds.

Mon, May 9, 12:35 PM · Restricted Project
kwk updated the summary of D125005: Make standalone-build-x86_64 a standalone builder.
Mon, May 9, 2:43 AM · Restricted Project

Thu, May 5

kwk requested review of D125005: Make standalone-build-x86_64 a standalone builder.
Thu, May 5, 5:10 AM · Restricted Project

Tue, May 3

kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

I found another problem with both regular expressions (pre mine and mine): They cannot find

Tue, May 3, 9:13 AM · Restricted Project, Restricted Project, Restricted Project
kwk planned changes to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

Some thing that doesn't work at the moment is ordering an include like this:

Tue, May 3, 9:00 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the summary of D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Tue, May 3, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

@krasimir could you please test this patch on your side? I've reopened it and tested it with the following file that contains both // and /* ... */ trailing comments on include lines followed by foo<T> and alike. The includes use <...> and "..." notation to locate files.

Tue, May 3, 7:32 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

Address trailing comments on include lines by ignoring slashes in
characters that lead up to the match groups.

Tue, May 3, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
kwk reopened D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Tue, May 3, 7:25 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Apr 26

kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

It appears that this regressed include sorting in the following case, where the contents of test.h show the expected include order and the clang-format behavior before this patch:

% cat test.h
#include <cstdint>

#include "util/bar.h"
#include "util/foo/foo.h"  // foo<T>
% bin/clang-format --version; bin/clang-format -style=google test.h
clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git d46fa023caa2db5a9f1e21dd038bcb626261d958)
#include "util/foo/foo.h"  // foo<T>
#include <cstdint>

#include "util/bar.h"

@kwk could you please take a look

Tue, Apr 26, 12:01 PM · Restricted Project, Restricted Project, Restricted Project

Apr 23 2022

kwk committed rZORGa41bdc33cf8a: Added worker and placeholder for standalone-build-x86_64 builder (authored by kwk).
Added worker and placeholder for standalone-build-x86_64 builder
Apr 23 2022, 12:22 PM · Restricted Project
kwk closed D124172: Added worker and placeholder for standalone-build-x86_64 builder.
Apr 23 2022, 12:22 PM · Restricted Project
kwk updated the diff for D124172: Added worker and placeholder for standalone-build-x86_64 builder.
  • Rebased on main and removing fuzz
Apr 23 2022, 4:55 AM · Restricted Project
kwk updated the diff for D124172: Added worker and placeholder for standalone-build-x86_64 builder.
  • Remove comment on builder
Apr 23 2022, 4:47 AM · Restricted Project
kwk added inline comments to D124172: Added worker and placeholder for standalone-build-x86_64 builder.
Apr 23 2022, 3:34 AM · Restricted Project

Apr 21 2022

kwk retitled D124172: Added worker and placeholder for standalone-build-x86_64 builder from Added placeholder for standalone-build-x86_64 builder to Added worker and placeholder for standalone-build-x86_64 builder.
Apr 21 2022, 11:16 PM · Restricted Project
kwk retitled D124172: Added worker and placeholder for standalone-build-x86_64 builder from Added standalone-build-x86_64 builder to Added placeholder for standalone-build-x86_64 builder.
Apr 21 2022, 11:15 PM · Restricted Project
kwk added inline comments to D124172: Added worker and placeholder for standalone-build-x86_64 builder.
Apr 21 2022, 11:14 PM · Restricted Project
kwk updated the diff for D124172: Added worker and placeholder for standalone-build-x86_64 builder.
  • Added mail notifier for standalone-build-x86_64 builder
Apr 21 2022, 7:18 AM · Restricted Project
kwk requested review of D124172: Added worker and placeholder for standalone-build-x86_64 builder.
Apr 21 2022, 7:13 AM · Restricted Project

Apr 20 2022

kwk committed rGd46fa023caa2: [clang-format] SortIncludes should support "@import" lines in Objective-C (authored by kwk).
[clang-format] SortIncludes should support "@import" lines in Objective-C
Apr 20 2022, 12:22 AM · Restricted Project, Restricted Project
kwk closed D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Apr 20 2022, 12:22 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the summary of D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Apr 20 2022, 12:05 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the summary of D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Apr 20 2022, 12:00 AM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • typo: @include bar; -> @import bar;
Apr 19 2022, 3:53 AM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

Should we handle #import and @import for Object-C only so as to simply the regex for C++?

Apr 19 2022, 3:51 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Make functions lowercase
Apr 19 2022, 3:45 AM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2022

kwk added inline comments to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Apr 16 2022, 12:30 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Make function static
Apr 16 2022, 12:29 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Use proposed reverse loop
Apr 16 2022, 12:26 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Added llvm:: namespace
Apr 16 2022, 12:23 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Put shared code for finding include names HeaderIncludes
Apr 16 2022, 12:19 PM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2022

kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

@HazardyKnusperkeks I've addressed your comments and did an early return together with llvm_unreachable() which is used in the clang/lib/Format in other places as well. I hope this is to your liking. There's no longer an assert. Do you want that as well?

Mar 22 2022, 1:13 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Address review comment
Mar 22 2022, 1:11 PM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

@MyDeveloperDay can you please have another look now that the patch has additional tests and most comments that still apply have been addressed?

Mar 22 2022, 2:37 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Remove duplicate assert
Mar 21 2022, 2:34 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Remove left-over comment
Mar 21 2022, 2:32 PM · Restricted Project, Restricted Project, Restricted Project
kwk committed rG063bd3b886b2: [format] Use int8_t as the underlying type of all enums in FormatStyle (authored by kwk).
[format] Use int8_t as the underlying type of all enums in FormatStyle
Mar 21 2022, 2:28 PM · Restricted Project
kwk closed D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle.
Mar 21 2022, 2:28 PM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

@HazardyKnusperkeks thank you for the approval. Can you have one last view please? I've introduced a function to get the match instead of repeating the for loop two times.

Mar 21 2022, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • introduce getIncludeNameFromMatches
  • Fix format
Mar 21 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle.

@HazardyKnusperkeks @owenpan can you please have a quick look again. All I did was rebasing my changes and in the meantime I was interrupted... This patch has been sitting for some time and I'd like to land it as soon one of you approves it.

Mar 21 2022, 12:10 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle.

Fixup my work after interruption by screaming children wanting dinner ;)

Mar 21 2022, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle.

Fixup

Mar 21 2022, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle.

Rebased

Mar 21 2022, 8:45 AM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D121972: Add cmake/ to release tarballs via concatenation.

git archive --help says:

<path>
    Without an optional path parameter, all files and subdirectories of the
    current working directory are included in the archive. If one or more paths
    are specified, only these are included.

so perhaps we should consider just doing something like that? if a two directory tarbomb is no good, we can add another layer of nesting?

Mar 21 2022, 5:09 AM · Restricted Project, Restricted Project
kwk accepted D121972: Add cmake/ to release tarballs via concatenation.

I've tested this patch and it works for me:

Mar 21 2022, 5:02 AM · Restricted Project, Restricted Project
kwk updated kwk.
Mar 21 2022, 4:50 AM
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Fix tests
Mar 21 2022, 3:19 AM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Mar 21 2022, 3:13 AM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

Some test with a main header and blocks would be nice.

This one please. :)

Mar 21 2022, 3:11 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Fix: int -> bool
Mar 21 2022, 3:06 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Address review comments on grouping and main headers
Mar 21 2022, 3:05 AM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

kwk requested changes to D121972: Add cmake/ to release tarballs via concatenation.

Would it be easier just to package the cmake directory in a separate tarball?

Mar 18 2022, 6:39 AM · Restricted Project, Restricted Project

Mar 16 2022

kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

Addressed review comments.

Mar 16 2022, 3:52 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Use std::numeric_limits<int>::max() instead of INT_MAX
Mar 16 2022, 3:51 AM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2022

kwk updated the summary of D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Mar 15 2022, 10:13 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Fix formatting
Mar 15 2022, 10:11 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the summary of D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Mar 15 2022, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

Changed the strategy of how includes are sorted by increasing the priority if an include is of the "new" type: @import Foundation;. This will sort these includes after everything else just as requested in https://github.com/llvm/llvm-project/issues/38995.

Mar 15 2022, 10:08 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2022

kwk planned changes to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

A test if failing. Need to address this first.

Mar 10 2022, 1:08 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the summary of D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Mar 10 2022, 12:53 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the summary of D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Mar 10 2022, 12:52 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the summary of D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Mar 10 2022, 12:51 PM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

Thank you for your comments! I've addressed many of them and now address the rest.

Mar 10 2022, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
  • Make @ or # not optional again
  • Remove [\t\n\ \\]*
  • Properly concat string
Mar 10 2022, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
kwk added a project to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C: Restricted Project.
Mar 10 2022, 3:44 AM · Restricted Project, Restricted Project, Restricted Project
kwk requested review of D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Mar 10 2022, 3:44 AM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2022

kwk added a comment to D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle.

Please use the clang-format tag.

Mar 3 2022, 3:54 AM · Restricted Project, Restricted Project, Restricted Project