Page MenuHomePhabricator

kwk (Konrad Wilhelm Kleine)
Senior Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2014, 8:11 AM (475 w, 3 d)

Recent Activity

Wed, Mar 22

kwk requested changes to D143535: github: Add manual workflow to build and upload release binaries.

@tstellar Sorry for the late reply. But I have some thoughts.

Wed, Mar 22, 8:11 AM · Restricted Project, Restricted Project

Fri, Mar 17

kwk abandoned D75750: [lldb] integrate debuginfod.

There already is a Debuginfod implementation in LLVM by now. Abandoning revision.

Fri, Mar 17, 9:06 AM · Restricted Project, Restricted Project
kwk added a comment to D75750: [lldb] integrate debuginfod.

Looks like it is already there: https://github.com/llvm/llvm-project/tree/main/llvm/include/llvm/Debuginfod

Fri, Mar 17, 9:05 AM · Restricted Project, Restricted Project
kwk updated subscribers of D75750: [lldb] integrate debuginfod.

@iridinite please see these:

Fri, Mar 17, 8:56 AM · Restricted Project, Restricted Project

Feb 22 2023

kwk added a comment to D143535: github: Add manual workflow to build and upload release binaries.

Added some ideas. Maybe not all so good.

Feb 22 2023, 10:17 AM · Restricted Project, Restricted Project

Feb 10 2023

kwk accepted D142726: [Workflow] Add Release Repo sync script.

LGTM except for a more detailed explanation in the comments at one place and except for a small change that slipped in because I requested too many changes ;)

Feb 10 2023, 3:56 AM · Restricted Project, Restricted Project

Feb 9 2023

kwk added inline comments to D142726: [Workflow] Add Release Repo sync script.
Feb 9 2023, 3:49 AM · Restricted Project, Restricted Project

Feb 7 2023

kwk added a comment to D142726: [Workflow] Add Release Repo sync script.

@thieta I hope my comments make some sense.

Feb 7 2023, 12:56 PM · Restricted Project, Restricted Project

Jan 25 2023

kwk accepted D137890: Add install targets for gtest.

Works for me.

Jan 25 2023, 8:50 AM · Restricted Project, Restricted Project
kwk accepted D138472: clang/cmake: Use installed gtest libraries for stand-alone builds.

Working for me.

Jan 25 2023, 8:48 AM · Restricted Project, Restricted Project

Jan 23 2023

kwk added a comment to D141581: [build] Fix stand-alone builds of clang..

This is currently holding back further testing on our end which is concerning me a bit, especially as we approach the branch point. Could you revert this please if a fix isn't imminent? Thank you!

Jan 23 2023, 2:05 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2023

kwk added a comment to D141581: [build] Fix stand-alone builds of clang..

@tstellar as you suspected, I had the following problem when building clang in standalone mode and your patch solved it for me. Thank you.

Jan 20 2023, 11:47 AM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

kwk updated the diff for D141050: [standalone-build] outsource, simplify and unify repetitive CMake code.
  • both, build tree and install method support find_package by setting different LLVM_CMAKE_DIR
Jan 12 2023, 3:15 AM · Restricted Project, Restricted Project

Jan 10 2023

kwk updated the diff for D141050: [standalone-build] outsource, simplify and unify repetitive CMake code.
  • Make require_llvm_utility_binary_path usable from a build-tree setup
Jan 10 2023, 8:57 AM · Restricted Project, Restricted Project
kwk added a comment to D141050: [standalone-build] outsource, simplify and unify repetitive CMake code.

Thank you @phosek for your review! I really appreciate it. I've addressed all of your comments. Could you give it another review?

Jan 10 2023, 4:37 AM · Restricted Project, Restricted Project
kwk updated the diff for D141050: [standalone-build] outsource, simplify and unify repetitive CMake code.
  • Don't quote output variables
  • Use 2 space indention in CMake files
  • Make out_var optional for get_llvm_utility_binary_path
  • Rename get_llvm_utility_binary_path -> require_llvm_utility_binary_path
Jan 10 2023, 4:37 AM · Restricted Project, Restricted Project

Jan 5 2023

kwk retitled D141063: DRAFT: [standalone-build] fix ccache, enable lit tests, and use proper cmake prefix path from [standalone-build] fix ccache, enable lit tests, and use proper cmake prefix path to DRAFT: [standalone-build] fix ccache, enable lit tests, and use proper cmake prefix path.
Jan 5 2023, 7:37 AM · Restricted Project
kwk requested review of D141063: DRAFT: [standalone-build] fix ccache, enable lit tests, and use proper cmake prefix path.
Jan 5 2023, 7:36 AM · Restricted Project
kwk updated the summary of D141050: [standalone-build] outsource, simplify and unify repetitive CMake code.
Jan 5 2023, 7:07 AM · Restricted Project, Restricted Project
kwk requested review of D141050: [standalone-build] outsource, simplify and unify repetitive CMake code.
Jan 5 2023, 6:18 AM · Restricted Project, Restricted Project

Nov 22 2022

kwk added inline comments to D138472: clang/cmake: Use installed gtest libraries for stand-alone builds.
Nov 22 2022, 2:38 AM · Restricted Project, Restricted Project

Nov 18 2022

kwk added a comment to D126506: workflows: Use new custom runners from github.

This is just a ping. About the status of this patch.

Nov 18 2022, 7:29 AM · Restricted Project, Restricted Project
kwk requested changes to D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used.

As much as I would like this to be fixed. I vote against this patch because in lld/CMakeLists.txt there's an almost (if not entirely) identical piece of code that screams to be outsourced into a /cmake/Modules/FindLit.cmake (to be created). I'll have a look at this and see if I can come up with a patch for this. Afterall /cmake is the central place to distribute shared CMake code between subprojects, right @phosek (didn't you create /cmake in the first place)?

Nov 18 2022, 1:58 AM · Restricted Project, Restricted Project

Nov 16 2022

kwk committed rZORG938bd91a3c01: [builder][standalone-build] Move CMake verbose flags to right position (authored by kwk).
[builder][standalone-build] Move CMake verbose flags to right position
Nov 16 2022, 5:25 AM · Restricted Project
kwk closed D138126: [builder][standalone-build] Move CMake verbose flags to right position.
Nov 16 2022, 5:25 AM · Restricted Project
kwk requested review of D138126: [builder][standalone-build] Move CMake verbose flags to right position.
Nov 16 2022, 5:20 AM · Restricted Project
kwk committed rZORGf8cd3a5523e2: [builder][standalone-build] Have separate trace/verbose vars to control the… (authored by kwk).
[builder][standalone-build] Have separate trace/verbose vars to control the…
Nov 16 2022, 5:06 AM · Restricted Project
kwk closed D138120: [builder][standalone-build] Have separate trace/verbose vars to control the build output.
Nov 16 2022, 5:06 AM · Restricted Project
kwk updated the diff for D138120: [builder][standalone-build] Have separate trace/verbose vars to control the build output.

Squashed commits

Nov 16 2022, 5:03 AM · Restricted Project
kwk updated the diff for D138120: [builder][standalone-build] Have separate trace/verbose vars to control the build output.
  • Reorg vars
Nov 16 2022, 4:59 AM · Restricted Project
kwk updated the diff for D138120: [builder][standalone-build] Have separate trace/verbose vars to control the build output.
  • Remove redundant vars
Nov 16 2022, 4:57 AM · Restricted Project
kwk updated the summary of D138120: [builder][standalone-build] Have separate trace/verbose vars to control the build output.
Nov 16 2022, 4:55 AM · Restricted Project
kwk requested review of D138120: [builder][standalone-build] Have separate trace/verbose vars to control the build output.
Nov 16 2022, 4:52 AM · Restricted Project
kwk closed D138114: [builder][standalone-build] Allow for cmake tracing by setting CMAKE_TRACE.
Nov 16 2022, 3:38 AM · Restricted Project
kwk committed rZORG309311823ec3: [builder][standalone-build] Allow for cmake tracing by setting CMAKE_TRACE (authored by kwk).
[builder][standalone-build] Allow for cmake tracing by setting CMAKE_TRACE
Nov 16 2022, 3:38 AM · Restricted Project
kwk requested review of D138114: [builder][standalone-build] Allow for cmake tracing by setting CMAKE_TRACE.
Nov 16 2022, 3:28 AM · Restricted Project

Nov 10 2022

kwk committed rGfd8ba4f5373f: [release] Add third-party tarball to release for standalone builds (authored by kwk).
[release] Add third-party tarball to release for standalone builds
Nov 10 2022, 11:56 AM · Restricted Project, Restricted Project
kwk closed D137777: [release] Add third-party tarball to release for standalone builds.
Nov 10 2022, 11:56 AM · Restricted Project, Restricted Project
kwk requested review of D137777: [release] Add third-party tarball to release for standalone builds.
Nov 10 2022, 3:16 AM · Restricted Project, Restricted Project

Oct 5 2022

kwk accepted D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp.
Oct 5 2022, 8:14 AM · Restricted Project, Restricted Project, Restricted Project

Oct 4 2022

kwk added a comment to D133476: [automation] Add scripts to automate GitHub projects.

[...]
I tried to port my changes over to ghgql - and it seems to work mostly. I filed two issues in the ghgql repo where this one: https://github.com/kwk/ghgql/issues/5 is currently the biggest blocker.

Oct 4 2022, 5:52 AM · Restricted Project, Restricted Project

Sep 30 2022

kwk committed rZORGfe57c7e93b85: [builder][standalone-build-x86_64] Use ccache to speedup builds and test lld (authored by kwk).
[builder][standalone-build-x86_64] Use ccache to speedup builds and test lld
Sep 30 2022, 12:56 PM · Restricted Project
kwk closed D134987: [builder][standalone-build-x86_64] Use ccache to speedup builds and test lld.
Sep 30 2022, 12:56 PM · Restricted Project
kwk requested review of D134987: [builder][standalone-build-x86_64] Use ccache to speedup builds and test lld.
Sep 30 2022, 12:45 PM · Restricted Project
kwk closed D134973: [builder][standalone-build-x86_64] Batch build commits.
Sep 30 2022, 12:04 PM · Restricted Project
kwk committed rZORGf528d54ec986: [builder][standalone-build-x86_64] Batch build commits (authored by kwk).
[builder][standalone-build-x86_64] Batch build commits
Sep 30 2022, 12:04 PM · Restricted Project
kwk requested review of D134973: [builder][standalone-build-x86_64] Batch build commits.
Sep 30 2022, 10:19 AM · Restricted Project
kwk retitled D134733: [clang-format][NFC] more centric handling of include name matching from [clang-format][chore] transparent #include name regex to [clang-format][NFC] more centric handling of include name matching.
Sep 30 2022, 2:58 AM · Restricted Project, Restricted Project, Restricted Project
kwk added inline comments to D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp.
Sep 30 2022, 2:50 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D134733: [clang-format][NFC] more centric handling of include name matching.
  • Make include regex a static member and not a function (@owenpan did this in D134852)
  • Run clang-format
Sep 30 2022, 2:44 AM · Restricted Project, Restricted Project, Restricted Project

Sep 29 2022

kwk added inline comments to D134733: [clang-format][NFC] more centric handling of include name matching.
Sep 29 2022, 1:31 AM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp.

I didn't see much difference in what this patch does compare to mine but I saw that it removes the need for instantiating multiple llvm::Regex objects from a single static pattern. But that's something I've just done in a new revision of my own patch: https://reviews.llvm.org/D134733?vs=463205&id=463786#toc . This fast clean up makes it only harder for me to get my patch in but essentially both do the same thing except that I also have a single convenience function for trimming include names from " and <>". Also I have removed the need to duplicate the knowledge of which matching group one has to pick in order to get to the include name. This knowledge is now local to a function.

Sep 29 2022, 1:18 AM · Restricted Project, Restricted Project, Restricted Project
kwk updated the diff for D134733: [clang-format][NFC] more centric handling of include name matching.
  • Remove ad-hoc instantiated IncludeRegex objects
Sep 29 2022, 1:14 AM · Restricted Project, Restricted Project, Restricted Project

Sep 28 2022

kwk added a comment to D134733: [clang-format][NFC] more centric handling of include name matching.

@MyDeveloperDay please see my potentially uneducated comments.

Sep 28 2022, 3:11 AM · Restricted Project, Restricted Project, Restricted Project

Sep 27 2022

kwk accepted D133923: [Release] Add bump-version script..

With respect to the future solution of making the version more centralized (see https://discourse.llvm.org/t/rfc-centralized-location-for-version-information/65295) I think this looks good. Great job!

Sep 27 2022, 6:03 AM · Restricted Project, Restricted Project
kwk abandoned D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

@kwk have we bottomed out on this issue? its been stale for a bit. If we are not going to work on it further can be "Abandon" the review to get it off our lists?

Sep 27 2022, 5:52 AM · Restricted Project, Restricted Project, Restricted Project
kwk requested review of D134733: [clang-format][NFC] more centric handling of include name matching.
Sep 27 2022, 5:49 AM · Restricted Project, Restricted Project, Restricted Project
kwk added a comment to D133476: [automation] Add scripts to automate GitHub projects.

[...]
The only thing I would make sure we avoid is to make this to-complicated, graphql already seems very over-engineered (to my eyes) and we just need such a small small subset that we shouldn't put to much effort into handling all kinds of queries and edge-cases.

Sep 27 2022, 1:35 AM · Restricted Project, Restricted Project

Sep 23 2022

kwk added inline comments to D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check.
Sep 23 2022, 2:17 AM · Restricted Project, Restricted Project

Sep 15 2022

kwk added a comment to D133923: [Release] Add bump-version script..

For Swift I found a PR:
https://github.com/apple/swift/pull/58931/files
The version is in a CMake file, but there were not that many files updated.

For Rust. I found a version file:
https://github.com/rust-lang/rust/blob/master/src/version

Most projects store the current version in ChangeLog files.

Sep 15 2022, 3:16 AM · Restricted Project, Restricted Project
kwk added a comment to D133923: [Release] Add bump-version script..

There is no room for a VERSION file at the root of the repository and everybody reads the file if necessary?

I suggested this at some point - but it never got traction. Maybe showing the complexity of this script can be a catalyst of changing this (especially for the bazel build system).

I have used this script for 15.x branch just to make sure I don't forget anything, since it's many files that needs to be updated.

Sep 15 2022, 2:04 AM · Restricted Project, Restricted Project

Sep 12 2022

kwk added inline comments to D133476: [automation] Add scripts to automate GitHub projects.
Sep 12 2022, 1:57 AM · Restricted Project, Restricted Project
kwk added inline comments to D133476: [automation] Add scripts to automate GitHub projects.
Sep 12 2022, 1:55 AM · Restricted Project, Restricted Project
kwk requested changes to D133476: [automation] Add scripts to automate GitHub projects.

@thieta as much as I like the effort you've made here. I'd like to propose a standalone GraphQL library. You're adding lots of code that is hard to trust without tests. That is why I started to create a library with tests and a release process to pypi. I think much of the things you do here are so generic that we can integrate them into the library at will.

Sep 12 2022, 1:52 AM · Restricted Project, Restricted Project

Aug 18 2022

kwk committed rZORG5f511e112a7c: [standalone-build] Build install and use python-lit (authored by kwk).
[standalone-build] Build install and use python-lit
Aug 18 2022, 11:43 AM · Restricted Project
kwk closed D131733: [standalone-build] Build install and use python-lit and run tests for llvm.
Aug 18 2022, 11:43 AM · Restricted Project
kwk retitled D131733: [standalone-build] Build install and use python-lit and run tests for llvm from [standalone-build] Build install and use python-lit to [standalone-build] Build install and use python-lit and run tests for llvm.
Aug 18 2022, 8:34 AM · Restricted Project
kwk updated the diff for D131733: [standalone-build] Build install and use python-lit and run tests for llvm.
  • Fixup python lit installation and run llvm tests
  • remove unused defines from lld cmake and move out of directory which later is overwritten by the next git sparse checkout
Aug 18 2022, 8:34 AM · Restricted Project

Aug 16 2022

kwk updated the diff for D131733: [standalone-build] Build install and use python-lit and run tests for llvm.
  • Fix installation of python lit and discoverability of the python lit module
Aug 16 2022, 8:18 AM · Restricted Project

Aug 11 2022

kwk planned changes to D131733: [standalone-build] Build install and use python-lit and run tests for llvm.

Locally this errors out with:

Aug 11 2022, 3:34 PM · Restricted Project
kwk requested review of D131733: [standalone-build] Build install and use python-lit and run tests for llvm.
Aug 11 2022, 3:28 PM · Restricted Project
kwk committed rZORGf14e5f1c94ab: [standalone-build] run check-all for llvm sub-project (authored by kwk).
[standalone-build] run check-all for llvm sub-project
Aug 11 2022, 2:59 PM · Restricted Project
kwk committed rZORG6f4d9812877e: [standalone-build] external lit built not by llvm but python-lit (authored by kwk).
[standalone-build] external lit built not by llvm but python-lit
Aug 11 2022, 2:59 PM · Restricted Project

Jul 28 2022

kwk added inline comments to D119412: github: Automatically create backport requests for bugs referenced in commit messages.
Jul 28 2022, 2:26 PM · Restricted Project, Restricted Project

Jul 27 2022

kwk abandoned D129998: [standalone-build-x86_64] Increase timeout.

I've found the error and now my worker is running fine since yesterday. I started the worker container in detached mode but quit the SSH session. This eventually caused the container to get a SIGTERM (143).

Jul 27 2022, 10:25 AM · Restricted Project

Jul 26 2022

kwk committed rZORG3b60d98af85a: [standalone-build-x86_64]: build lld (authored by kwk).
[standalone-build-x86_64]: build lld
Jul 26 2022, 1:14 AM · Restricted Project
kwk closed D129553: [standalone-build-x86_64]: build lld.
Jul 26 2022, 1:14 AM · Restricted Project
kwk accepted D126423: github: Automatically assign reviewers for backport requests.

LGTM.

Jul 26 2022, 1:06 AM · Restricted Project, Restricted Project
kwk accepted D99780: workflows: Add GitHub action for automating some release tasks.

I don't see serious problems with this change. And my comments are just improvements. Good Work!

Jul 26 2022, 12:04 AM · Restricted Project, Restricted Project

Jul 18 2022

Herald added a project to D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs: Restricted Project.
Jul 18 2022, 8:28 AM · Restricted Project, Restricted Project
kwk requested review of D129998: [standalone-build-x86_64] Increase timeout.
Jul 18 2022, 4:02 AM · Restricted Project
kwk committed rZORG5067c2ded9f7: Remove jobs prop from standalone-build-x86_64 worker (authored by kwk).
Remove jobs prop from standalone-build-x86_64 worker
Jul 18 2022, 1:38 AM · Restricted Project

Jul 12 2022

kwk added inline comments to D129553: [standalone-build-x86_64]: build lld.
Jul 12 2022, 4:05 AM · Restricted Project
kwk updated the diff for D129553: [standalone-build-x86_64]: build lld.
  • Remove redundant info
Jul 12 2022, 3:26 AM · Restricted Project
kwk requested review of D129553: [standalone-build-x86_64]: build lld.
Jul 12 2022, 3:05 AM · Restricted Project

Jul 11 2022

kwk added inline comments to D126423: github: Automatically assign reviewers for backport requests.
Jul 11 2022, 3:53 AM · Restricted Project, Restricted Project
kwk removed a reviewer for D125744: github: Add a helpful message for issues without milestones: kkleine.
Jul 11 2022, 3:28 AM · Restricted Project, Restricted Project
kwk accepted D125744: github: Add a helpful message for issues without milestones.

LGTM now. Thank you for addressing the comments.

Jul 11 2022, 3:28 AM · Restricted Project, Restricted Project

Jul 6 2022

kwk requested changes to D126423: github: Automatically assign reviewers for backport requests.

Can you please add links to the phabricator HTTP API documentation that you're using?

Jul 6 2022, 9:32 AM · Restricted Project, Restricted Project
kwk requested changes to D125744: github: Add a helpful message for issues without milestones.

Looks good except for what I think is a typo and some suggestion for improving the readability and how things are connected with the workflow. Afterall, this is triggered by a comment, that produces another comment that we want to ignore or skip. Hm, maybe skip is better than ignore?

Jul 6 2022, 9:07 AM · Restricted Project, Restricted Project

May 19 2022

kwk added a reverting change for rG32a0482a65b8: Add cmake to source release tarballs: rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it.
May 19 2022, 2:13 AM
kwk added a reverting change for rG3a33664e8838: Add cmake/ to release tarballs via concatenation: rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it.
May 19 2022, 2:13 AM · Restricted Project
kwk committed rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it (authored by kwk).
[release] Add cmake as an extra tarball and not bundle it
May 19 2022, 2:13 AM · Restricted Project, Restricted Project
kwk added a reverting change for D118481: Add cmake to source release tarballs: rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it.
May 19 2022, 2:13 AM · Restricted Project
kwk added a reverting change for D121972: Add cmake/ to release tarballs via concatenation: rGc0f5beef2fb1: [release] Add cmake as an extra tarball and not bundle it.
May 19 2022, 2:13 AM · Restricted Project, Restricted Project
kwk closed D125798: [release] Add cmake as an extra tarball and not bundle it.
May 19 2022, 2:13 AM · Restricted Project, Restricted Project

May 17 2022

kwk added a reviewer for D125798: [release] Add cmake as an extra tarball and not bundle it: aaronpuchert.
May 17 2022, 8:45 AM · Restricted Project, Restricted Project
kwk added a reverting change for rG32a0482a65b8: Add cmake to source release tarballs: D125798: [release] Add cmake as an extra tarball and not bundle it.
May 17 2022, 8:30 AM
kwk added a reverting change for rG3a33664e8838: Add cmake/ to release tarballs via concatenation: D125798: [release] Add cmake as an extra tarball and not bundle it.
May 17 2022, 8:30 AM · Restricted Project
kwk requested review of D125798: [release] Add cmake as an extra tarball and not bundle it.
May 17 2022, 8:30 AM · Restricted Project, Restricted Project