Page MenuHomePhabricator

kwk (Konrad Wilhelm Kleine)
Senior Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2014, 8:11 AM (295 w, 1 d)

I'm a dad, husband and have a passion for playing the acoustic guitar and taking as well as developing pictures with my analogue photo camera. I also swim, run and ride my mountainbike.

C/C++ is my day to day programming language and I have more than three years of experience with the Go programming language from my previous job.

Recent Activity

Today

kwk added a comment to D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default..
In D69041#1711707, @kwk wrote:

@grimar I don't understand why you created this patch, when I'm working on it already.

@kwk Sorry if you feel your work is commandeered. On D68943, it was me who said

Nice! Can you post a differential for the yaml2obj change? I believe the differential can focus on lldb and remove yaml2obj changes (kwk will still get credited for the test cleanups).

I skimmed through your yaml2obj changes in D68943 and I believed a complete fix needs more work than your change. check-llvm-tools check-llvm-object should expose more tests that you missed.

Thu, Oct 17, 2:54 AM
kwk abandoned D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

Abandoning for D69041

Thu, Oct 17, 2:25 AM · Restricted Project, Restricted Project
kwk added a comment to D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default..
In D69041#1711707, @kwk wrote:

@grimar I don't understand why you created this patch, when I'm working on it already.

I only wanted to help, because supposed that the correct direction is not clear for you (since your version did not fix any of existent test cases that were failing,
obj2yaml tool did not compile and there was at least one obliously wrong place in 'initSymtabSectionHeader' that broke the normal logic).
And it was also not fully clear to me what is exactly needed until I run check-llvm with the first more or less stable version of the patch at least.

Now when the whole picture is revealed, feel free to commandeer this revision or use it as a reference for your patch if you would like to continue it.
Or let me continue. Please let me know about your decision, I'll put this on hold until that.

Thu, Oct 17, 2:25 AM

Yesterday

kwk added a comment to D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default..

@grimar I don't understand why you created this patch, when I'm working on it already. That's a waste of my time.

Wed, Oct 16, 12:40 PM

Tue, Oct 15

kwk added a comment to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

I noticed that the order of sections does matter to some tests. Before the .symtab section was always the first one and now it is the last of the implicit sections being created. Some Link: X checks break because X points to a different section. In order to compensate for this I will make .symtab the first of the implicit sections again. In my local testing this already helps a bit. In cases where we refer to a section by number and expect .symtab to be the section being referenced, I have two options: 1st) create a symbol to force .symtab to be implicitly created or 2nd) change the name of the expected section. Just tell me what you want.

Tue, Oct 15, 4:55 AM · Restricted Project, Restricted Project
kwk updated the diff for D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
  • Remove unnecessary section
  • Have consitent ordering of run, check and YAML lines
  • use ## for comments in YAML
  • Remove not needed Entry and Sections
  • Only have Name for a symbol
  • Moved test files from llvm/test/ObjectYAML/ELF/ to llvm/test/tools/yaml2obj/
  • Fixup for test files
Tue, Oct 15, 1:58 AM · Restricted Project, Restricted Project
kwk added a comment to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

@grimar I've tackled the most obvious of your comments. I will now see what fails in llvm/test/tools/yaml2obj.

Tue, Oct 15, 1:58 AM · Restricted Project, Restricted Project

Mon, Oct 14

kwk added a comment to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

This is not correct. A lot of yaml2obj tests fail with:

yaml2obj: error: unknown section referenced: '.symtab' by YAML section '.rela.text'

Mon, Oct 14, 8:43 AM · Restricted Project, Restricted Project
kwk added a comment to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

Moved yaml2obj tests under llvm subtree.

Mon, Oct 14, 6:52 AM · Restricted Project, Restricted Project
kwk updated the diff for D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
  • moved test files over to llvm subtree
Mon, Oct 14, 6:52 AM · Restricted Project, Restricted Project
kwk planned changes to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

Move tests over to llvm/llvm/test/ObjectYAML/ELF/.

Mon, Oct 14, 6:06 AM · Restricted Project, Restricted Project
kwk added inline comments to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
Mon, Oct 14, 6:06 AM · Restricted Project, Restricted Project
kwk updated the diff for D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
  • restore formatting
Mon, Oct 14, 5:56 AM · Restricted Project, Restricted Project
kwk updated the diff for D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
  • Silence FileCheck in test
Mon, Oct 14, 5:47 AM · Restricted Project, Restricted Project
kwk created D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
Mon, Oct 14, 5:47 AM · Restricted Project, Restricted Project

Sat, Oct 12

kwk committed rL374645: Added Konrad Kleine's usernames for svn and github.
Added Konrad Kleine's usernames for svn and github
Sat, Oct 12, 1:32 AM

Tue, Oct 8

kwk committed rG6d7fb29914e3: [lldb] Avoid resource leak (authored by kwk).
[lldb] Avoid resource leak
Tue, Oct 8, 9:04 AM
kwk closed D68638: [lldb] Avoid resource leak.
Tue, Oct 8, 9:04 AM · Restricted Project
kwk committed rL374071: [lldb] Avoid resource leak.
[lldb] Avoid resource leak
Tue, Oct 8, 8:54 AM
kwk committed rG8970d88b65f0: Simplify LZMA decoding by using ArrayRef::take_back (authored by kwk).
Simplify LZMA decoding by using ArrayRef::take_back
Tue, Oct 8, 8:45 AM
kwk closed D68647: Simplify LZMA decoding by using ArrayRef::take_back.
Tue, Oct 8, 8:45 AM · Restricted Project
kwk committed rL374069: Simplify LZMA decoding by using ArrayRef::take_back.
Simplify LZMA decoding by using ArrayRef::take_back
Tue, Oct 8, 8:45 AM
kwk added inline comments to D68647: Simplify LZMA decoding by using ArrayRef::take_back.
Tue, Oct 8, 7:57 AM · Restricted Project
kwk updated the diff for D68647: Simplify LZMA decoding by using ArrayRef::take_back.

Fixup

Tue, Oct 8, 7:57 AM · Restricted Project
kwk created D68647: Simplify LZMA decoding by using ArrayRef::take_back.
Tue, Oct 8, 7:48 AM · Restricted Project
kwk created D68638: [lldb] Avoid resource leak.
Tue, Oct 8, 6:51 AM · Restricted Project
kwk added a comment to D68614: [LLDB] Remove standalone build dep on llvm-strip.

I think I'm guilty for adding llvm-strip to LLDB_TEST_DEPS I wasn't aware that it might cause problems.

Tue, Oct 8, 5:46 AM · Restricted Project

Mon, Oct 7

kwk committed rG2c082b48274f: [lldb][ELF] Read symbols from .gnu_debugdata sect. (authored by kwk).
[lldb][ELF] Read symbols from .gnu_debugdata sect.
Mon, Oct 7, 10:09 PM
kwk committed rL373891: [lldb][ELF] Read symbols from .gnu_debugdata sect..
[lldb][ELF] Read symbols from .gnu_debugdata sect.
Mon, Oct 7, 10:08 PM
kwk closed D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

Closed by 2c082b48274fcba62bf9b3acb63075aedcc7a976.

Mon, Oct 7, 3:49 AM · Restricted Project, Restricted Project
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

rebased

Mon, Oct 7, 3:46 AM · Restricted Project, Restricted Project

Sat, Oct 5

kwk added a comment to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

@labath as much as I would love to merge this patch I get errors from these tests that I didn't see before. They only appear after rebasing onto master:

Sat, Oct 5, 2:07 PM · Restricted Project, Restricted Project
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

Rebased onto current master

Sat, Oct 5, 12:38 PM · Restricted Project, Restricted Project
kwk added a comment to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

@labath ah, I've just seen that you did accept the revision already. Will merge it then after running tests once more.

Sat, Oct 5, 12:32 PM · Restricted Project, Restricted Project
kwk added a comment to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

@labath I've addressed all you comments. Thank you for answering @jankratochvil's question as well. If this patch is good to go now, please give a thumbs up.

Sat, Oct 5, 12:32 PM · Restricted Project, Restricted Project
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
  • Fix typo: s/a. /a ./
  • Fix comment header
  • Remove redundant input buffer check
  • Remove another redundant input buffer check
  • Change variable initialization to assign
  • added comment about minidebuginfo
Sat, Oct 5, 12:32 PM · Restricted Project, Restricted Project

Wed, Oct 2

kwk updated the summary of D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Wed, Oct 2, 9:40 AM · Restricted Project, Restricted Project
kwk requested review of D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

Tests did pass so this change is ready for review @labath @jankratochvil .

Wed, Oct 2, 9:06 AM · Restricted Project, Restricted Project
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
  • Change logic and comment for when .dynsym is parsed
  • Use different pattern for error checking
  • use less auto
  • Remove required system-linux test feature from LZMA tests
Wed, Oct 2, 9:03 AM · Restricted Project, Restricted Project
kwk planned changes to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Wed, Oct 2, 9:03 AM · Restricted Project, Restricted Project
kwk abandoned D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

Here's the relevant transcript from #lldb@otfc for why this change is abandoned.

Wed, Oct 2, 8:00 AM · Restricted Project, Restricted Project
kwk planned changes to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

LLVM reasoning for why to go with std::vector: http://llvm.org/docs/ProgrammersManual.html#set-like-containers-std-set-smallset-setvector-etc.

Wed, Oct 2, 2:38 AM · Restricted Project, Restricted Project

Tue, Oct 1

kwk added inline comments to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
Tue, Oct 1, 8:47 AM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Check that no additional symbols follow after the expected ones
  • Use compiler-generated copy-ctor
  • Cleanup from experiment
  • Simplify NamedELFSymbol::hash()
  • Cleanup
Tue, Oct 1, 8:47 AM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Simplify NamedELFSymbol::hash()
Tue, Oct 1, 3:56 AM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Fix comment
Tue, Oct 1, 3:22 AM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Correct comment of test
Tue, Oct 1, 3:21 AM · Restricted Project, Restricted Project
kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

@labath can you please check this patch one last time (hopefully)?

Tue, Oct 1, 2:40 AM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Remove verbose output in test
  • Fix typo: smymtab -> symtab
  • Move compare and hash logic out of base class into derived class as requested
Tue, Oct 1, 2:38 AM · Restricted Project, Restricted Project

Mon, Sep 30

kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Fix comment
Mon, Sep 30, 12:52 PM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • include test code in .c test file
Mon, Sep 30, 8:31 AM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Added YAML test to merge symbols
Mon, Sep 30, 7:33 AM · Restricted Project, Restricted Project
kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

@labath I did prepare some YAML file but apparently yaml2obj isn't meant to deal with this properly. Instead I get an Error like this: yaml2obj: error: repeated symbol name: 'main'. It looks like symbols from the Symbols: part of the YAML file are just added by name to a map. Changing yaml2obj for this seems a bit too heavy right now. If you're okay I'll go with a few more c programs if I can pull them off.

Mon, Sep 30, 6:18 AM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • typo: dynmic -> dynamic
  • Applied changes requested in review
Mon, Sep 30, 4:27 AM · Restricted Project, Restricted Project
kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

This looks fairly ok to me, but it could use a more explicit test of the symbol uniqueing code. Right, now I believe the two tests you added check that the symbols are _not_ uniqued. (They're also a bit hard to follow due to the whole

objcopy business). Could you create a test with a yaml file which will contain various edge cases relevant to this code. I'm thinking of stuff like "a dynsym and a symtab symbol at the same address, but a different name", "a dynsym and symtab symbols with identical names, but different addresses", etc. Then just run "image dump symtab" on that file to check what we have parsed?
Mon, Sep 30, 4:26 AM · Restricted Project, Restricted Project

Thu, Sep 26

kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

Interesting. It looks like we indeed have a test (the only one failing atm.) that wants a symbol to be added twice:

Thu, Sep 26, 10:05 PM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Use symbol name including @VERSION suffix.
Thu, Sep 26, 10:02 PM · Restricted Project, Restricted Project
kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

I think I've finished the implementation now and should have answered all your comments and concerns. I run tests now. I would appreciate if you (@clayborg , @labath , @jankratochvil ) can take a look at this patch again.

Thu, Sep 26, 9:33 PM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • make the section name part of NamedELFSymbol
Thu, Sep 26, 9:15 PM · Restricted Project, Restricted Project
kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

Not all is answered now but please respect: https://reviews.llvm.org/D67390#1683705

Thu, Sep 26, 9:03 PM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Change order of compare members to match order of member definitions.
Thu, Sep 26, 9:01 PM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Cleanup
Thu, Sep 26, 8:39 PM · Restricted Project, Restricted Project
kwk updated the summary of D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
Thu, Sep 26, 2:39 PM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Cleanup
Thu, Sep 26, 2:35 PM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Adjust other occurrence of AddSymbol where ELF plays a role
  • Working tests
  • Use unordered_set for storing unique elf symbols
Thu, Sep 26, 9:03 AM · Restricted Project, Restricted Project

Wed, Sep 25

kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

Please wait before reviewing this patch again. I will let you know when things do work.

Wed, Sep 25, 11:55 PM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Revert "Change test expectation to find 2 instead of 1 symbol"
Wed, Sep 25, 2:00 AM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • [LLDB][ELF] Fixup for comments in D67390
  • Change test expectation to find 2 instead of 1 symbol
  • symbol uniqueness by using elf::ELFSymbol
Wed, Sep 25, 1:55 AM · Restricted Project, Restricted Project

Tue, Sep 24

kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

@clayborg @labath I'm still trying to only add symbols when they are unique.

Tue, Sep 24, 10:11 AM · Restricted Project, Restricted Project

Mon, Sep 23

kwk committed rGc45fe95e9721: [LLDB] Fix logically dead code (authored by kwk).
[LLDB] Fix logically dead code
Mon, Sep 23, 7:05 AM
kwk committed rL372608: [LLDB] Fix logically dead code.
[LLDB] Fix logically dead code
Mon, Sep 23, 7:04 AM
kwk closed D67915: [LLDB] Fix logically dead code.
Mon, Sep 23, 7:04 AM · Restricted Project, Restricted Project
kwk added a comment to D67915: [LLDB] Fix logically dead code.

@jankratochvil the file only has two revisions: https://github.com/llvm/llvm-project/commits/b9c1b51e45b845debb76d8658edabca70ca56079/lldb/include/lldb/Core/LoadedModuleInfoList.h

Mon, Sep 23, 6:46 AM · Restricted Project, Restricted Project
kwk updated the summary of D67915: [LLDB] Fix logically dead code.
Mon, Sep 23, 6:41 AM · Restricted Project, Restricted Project
kwk added a reviewer for D67915: [LLDB] Fix logically dead code: jankratochvil.
Mon, Sep 23, 6:41 AM · Restricted Project, Restricted Project
kwk created D67915: [LLDB] Fix logically dead code.
Mon, Sep 23, 6:41 AM · Restricted Project, Restricted Project

Wed, Sep 18

kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

@clayborg are you on IRC?

Wed, Sep 18, 1:39 AM · Restricted Project, Restricted Project

Sep 17 2019

kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

@clayborg thank you for this explanation. My patch for minidebuginfo is already done in D66791 . But this one here I was asked to pull out as a separate patch. For good reasons as we see. I wonder how this extra parameter SymbolMapType of yours does help. In the end I have to identify duplicates. But if no symbol with the same name should be added then why do I care about where the symbol is coming from?

Sep 17 2019, 2:16 AM · Restricted Project, Restricted Project

Sep 16 2019

kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

@clayborg what address is it exactly to store here std::map<lldb::addr_t, ContString> SymbolMapType;? As an example dc_symbol.GetAddress().GetFileAddress() is something that would work but as soon as we have minidebuginfo, then we might end having the same symbol coming from two different object files and so their address would still be different. Also do you want me to keep this map in ObjectFileELF?

Sep 16 2019, 9:24 AM · Restricted Project, Restricted Project
kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
In D67390#1667270, @kwk wrote:

@labath how shall we go about this? We do have the situation that when you lookup a symbol you might find it twice if it is in .dynsym and in .symtab. Shall I adjust the test expectation to that or change my implementation?

That's a good question (and another reason why I wanted this to be a separate patch). Since only two tests broke it does not seem like having some symbols twice does much harm. OTOH, having an identical symbol twice does seem like asking for trouble down the line. One possibility would be to restrict this merging to the gnu_debugdata case only. Another option would be to make the merging code smarter and avoid adding the symbol a second time if it has the same name and address. That would have the advantage of having the symbol just once in the common case, while still preserving the full information (in case the symbol tables were munged independently of the gnu_debugdata thingy).

Overall, I guess I would prefer the last solution (inserting only different symbols) unless that turns out to be difficult. In that case, I think just restricting this to gnu_debugdata is fine.

Sep 16 2019, 4:58 AM · Restricted Project, Restricted Project

Sep 15 2019

kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • [LLDB][ELF] Fixup for comments in D67390
  • Change test expectation to find 2 instead of 1 symbol
Sep 15 2019, 9:19 PM · Restricted Project, Restricted Project
kwk reopened D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
Sep 15 2019, 9:19 PM · Restricted Project, Restricted Project

Sep 12 2019

kwk added inline comments to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Sep 12 2019, 2:02 AM · Restricted Project, Restricted Project

Sep 11 2019

kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

@stella.stamenova I've reverted this patch and thanks for letting me know.

Sep 11 2019, 10:48 PM · Restricted Project, Restricted Project
kwk added a comment to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Sep 11 2019, 10:36 PM · Restricted Project, Restricted Project
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
  • Addressed review comments
Sep 11 2019, 10:32 PM · Restricted Project, Restricted Project
kwk committed rG2f3884ca1d89: Revert "[LLDB][ELF] Load both, .symtab and .dynsym sections" (authored by kwk).
Revert "[LLDB][ELF] Load both, .symtab and .dynsym sections"
Sep 11 2019, 7:34 AM
kwk added a reverting change for rG3a4781bbf4f3: [LLDB][ELF] Load both, .symtab and .dynsym sections: rG2f3884ca1d89: Revert "[LLDB][ELF] Load both, .symtab and .dynsym sections".
Sep 11 2019, 7:34 AM
kwk committed rGd44c4a71df9d: Revert "[LLDB][ELF] Fixup for comments in D67390" (authored by kwk).
Revert "[LLDB][ELF] Fixup for comments in D67390"
Sep 11 2019, 7:34 AM
kwk added a reverting change for rG813f05915d29: [LLDB][ELF] Fixup for comments in D67390: rGd44c4a71df9d: Revert "[LLDB][ELF] Fixup for comments in D67390".
Sep 11 2019, 7:33 AM
kwk committed rL371625: Revert "[LLDB][ELF] Load both, .symtab and .dynsym sections".
Revert "[LLDB][ELF] Load both, .symtab and .dynsym sections"
Sep 11 2019, 7:33 AM
kwk committed rL371624: Revert "[LLDB][ELF] Fixup for comments in D67390".
Revert "[LLDB][ELF] Fixup for comments in D67390"
Sep 11 2019, 7:33 AM
kwk added inline comments to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Sep 11 2019, 3:19 AM · Restricted Project, Restricted Project
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

Rebased on master to include changes from D67390

Sep 11 2019, 3:19 AM · Restricted Project, Restricted Project
kwk committed rG813f05915d29: [LLDB][ELF] Fixup for comments in D67390 (authored by kwk).
[LLDB][ELF] Fixup for comments in D67390
Sep 11 2019, 3:16 AM
kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

@labath I've addressed your comment rewrites in a fixup commit that I've commited without a review (llvm-svn: 371600): https://reviews.llvm.org/rLLDB371600

Sep 11 2019, 3:15 AM · Restricted Project, Restricted Project
kwk committed rL371600: [LLDB][ELF] Fixup for comments in D67390.
[LLDB][ELF] Fixup for comments in D67390
Sep 11 2019, 3:11 AM
kwk committed rG3a4781bbf4f3: [LLDB][ELF] Load both, .symtab and .dynsym sections (authored by kwk).
[LLDB][ELF] Load both, .symtab and .dynsym sections
Sep 11 2019, 3:01 AM
kwk committed rL371599: [LLDB][ELF] Load both, .symtab and .dynsym sections.
[LLDB][ELF] Load both, .symtab and .dynsym sections
Sep 11 2019, 3:01 AM
kwk closed D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
Sep 11 2019, 3:01 AM · Restricted Project, Restricted Project