- User Since
- Feb 19 2014, 8:11 AM (475 w, 3 d)
Wed, Mar 22
@tstellar Sorry for the late reply. But I have some thoughts.
Fri, Mar 17
There already is a Debuginfod implementation in LLVM by now. Abandoning revision.
Looks like it is already there: https://github.com/llvm/llvm-project/tree/main/llvm/include/llvm/Debuginfod
@iridinite please see these:
Feb 22 2023
Added some ideas. Maybe not all so good.
Feb 10 2023
LGTM except for a more detailed explanation in the comments at one place and except for a small change that slipped in because I requested too many changes ;)
Feb 9 2023
Feb 7 2023
@thieta I hope my comments make some sense.
Jan 25 2023
Works for me.
Working for me.
Jan 23 2023
Jan 20 2023
@tstellar as you suspected, I had the following problem when building clang in standalone mode and your patch solved it for me. Thank you.
Jan 12 2023
- both, build tree and install method support find_package by setting different LLVM_CMAKE_DIR
Jan 10 2023
- Make require_llvm_utility_binary_path usable from a build-tree setup
Thank you @phosek for your review! I really appreciate it. I've addressed all of your comments. Could you give it another review?
- Don't quote output variables
- Use 2 space indention in CMake files
- Make out_var optional for get_llvm_utility_binary_path
- Rename get_llvm_utility_binary_path -> require_llvm_utility_binary_path
Jan 5 2023
Nov 22 2022
Nov 18 2022
This is just a ping. About the status of this patch.
As much as I would like this to be fixed. I vote against this patch because in lld/CMakeLists.txt there's an almost (if not entirely) identical piece of code that screams to be outsourced into a /cmake/Modules/FindLit.cmake (to be created). I'll have a look at this and see if I can come up with a patch for this. Afterall /cmake is the central place to distribute shared CMake code between subprojects, right @phosek (didn't you create /cmake in the first place)?
Nov 16 2022
- Reorg vars
- Remove redundant vars
Nov 10 2022
Oct 5 2022
Oct 4 2022
Sep 30 2022
Sep 29 2022
I didn't see much difference in what this patch does compare to mine but I saw that it removes the need for instantiating multiple llvm::Regex objects from a single static pattern. But that's something I've just done in a new revision of my own patch: https://reviews.llvm.org/D134733?vs=463205&id=463786#toc . This fast clean up makes it only harder for me to get my patch in but essentially both do the same thing except that I also have a single convenience function for trimming include names from " and <>". Also I have removed the need to duplicate the knowledge of which matching group one has to pick in order to get to the include name. This knowledge is now local to a function.
- Remove ad-hoc instantiated IncludeRegex objects
Sep 28 2022
@MyDeveloperDay please see my potentially uneducated comments.
Sep 27 2022
With respect to the future solution of making the version more centralized (see https://discourse.llvm.org/t/rfc-centralized-location-for-version-information/65295) I think this looks good. Great job!
Sep 23 2022
Sep 15 2022
Sep 12 2022
@thieta as much as I like the effort you've made here. I'd like to propose a standalone GraphQL library. You're adding lots of code that is hard to trust without tests. That is why I started to create a library with tests and a release process to pypi. I think much of the things you do here are so generic that we can integrate them into the library at will.
Aug 18 2022
- Fixup python lit installation and run llvm tests
- remove unused defines from lld cmake and move out of directory which later is overwritten by the next git sparse checkout
Aug 16 2022
- Fix installation of python lit and discoverability of the python lit module
Aug 11 2022
Locally this errors out with:
Jul 28 2022
Jul 27 2022
I've found the error and now my worker is running fine since yesterday. I started the worker container in detached mode but quit the SSH session. This eventually caused the container to get a SIGTERM (143).
Jul 26 2022
I don't see serious problems with this change. And my comments are just improvements. Good Work!
Jul 18 2022
Jul 12 2022
- Remove redundant info
Jul 11 2022
LGTM now. Thank you for addressing the comments.
Jul 6 2022
Can you please add links to the phabricator HTTP API documentation that you're using?
Looks good except for what I think is a typo and some suggestion for improving the readability and how things are connected with the workflow. Afterall, this is triggered by a comment, that produces another comment that we want to ignore or skip. Hm, maybe skip is better than ignore?