Page MenuHomePhabricator

kwk (Konrad Wilhelm Kleine)
Senior Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2014, 8:11 AM (343 w, 2 d)

I'm a dad, husband and have a passion for playing the acoustic guitar and taking as well as developing pictures with my analogue photo camera. I also swim, run and skateboard.

C/C++ is my day to day programming language and I have more than three years of experience with the Go programming language from my previous job here at Red Hat.

Recent Activity

Jul 15 2020

kwk added a comment to D83180: Set generic error in SBError SetErrorToGenericError.

LGTM but a test would indeed be nice.

Jul 15 2020, 5:43 AM · Restricted Project

Jul 10 2020

kwk committed rGecfa01e956a4: [lldb] on s390x fix override issue (authored by kwk).
[lldb] on s390x fix override issue
Jul 10 2020, 12:12 PM
kwk closed D83580: [lldb] on s390x fix override issue.
Jul 10 2020, 12:12 PM · Restricted Project
kwk added a comment to D83580: [lldb] on s390x fix override issue.

Possible followup: shouldn't all the other Get* be flagged as const too?

Jul 10 2020, 12:11 PM · Restricted Project
kwk added inline comments to rG7fa7b81bcbd0: Combine multiple defs of arm64 register sets.
Jul 10 2020, 12:03 PM
kwk updated the summary of D83580: [lldb] on s390x fix override issue.
Jul 10 2020, 11:56 AM · Restricted Project
kwk added a reviewer for D83580: [lldb] on s390x fix override issue: omjavaid.
Jul 10 2020, 11:53 AM · Restricted Project
kwk added reviewers for D83580: [lldb] on s390x fix override issue: tstellar, serge-sans-paille.
Jul 10 2020, 11:50 AM · Restricted Project
Herald added a project to D83580: [lldb] on s390x fix override issue: Restricted Project.
Jul 10 2020, 11:50 AM · Restricted Project

Jun 26 2020

kwk planned changes to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 26 2020, 5:24 AM · Restricted Project
kwk added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 26 2020, 3:13 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Simplify logic
Jun 26 2020, 3:13 AM · Restricted Project

Jun 25 2020

kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Add newlines
Jun 25 2020, 5:14 AM · Restricted Project
kwk added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 25 2020, 5:14 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • bring back logic to keep a symbol context when a function passes and add a comment as Jan suggested
  • remove test from scripted resolver that calls SearchFilterByModulesAndSupportFiles::AddressPasses
    • before the test checked that a non existing file doesn't cause setting a breakpoint location
    • the logic in AddressPasses before was to identify the CU of a symbol context and check if it's file is in the list of files that are allowed to pass. We agreed to change this logic so that not only CU's are checked but also files in which a function is declared. SearchFilterByModulesAndSupportFiles::FunctionPasses now does exactly that but it is not called from the BreakPointResolverScripted class, only from BreakpointResolverName.
    • It is an open question how to deal with this and I hope Jim can help here.
    • Shall we maybe take another file from the SymbolContext to see if we can filter by that in AddressPasses? Here's a dump of the filter context for the removed test:
Jun 25 2020, 5:14 AM · Restricted Project

Jun 24 2020

kwk committed rG4bfa43809fe6: [lldb] fix typo in docs: withing -> within (authored by kwk).
[lldb] fix typo in docs: withing -> within
Jun 24 2020, 2:40 AM

Jun 18 2020

kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Remove old logic that was no longer needed since my search filter now adaptively adds eSymbolContextCompUnit and not always returns it.
Jun 18 2020, 3:14 AM · Restricted Project

Jun 17 2020

kwk added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 17 2020, 11:58 PM · Restricted Project
kwk added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

@labath @jingham @jankratochvil The test change suggested by @labath is now in place and it works. @jankratochvil, I've removed the logic that checks seomthing with the CU from AddressPasses. That logic now lives in FunctionPasses where it logically makes more sense to me. The whole filtering by CU logic from AddressPasses is gone now and I wonder if @jingham has some thoughts on this.

Jun 17 2020, 11:58 PM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Align tests with reviewer expectations
Jun 17 2020, 11:25 PM · Restricted Project

Jun 15 2020

kwk added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 15 2020, 7:33 AM · Restricted Project

Jun 10 2020

kwk updated the summary of D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Jun 10 2020, 7:37 AM · Restricted Project
kwk planned changes to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
IMPORTANT: The behavior of target.inline-breakpoint-strategy when set to headers is still subject to change!
Jun 10 2020, 7:37 AM · Restricted Project
kwk added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

@labath I've applied all the ideas we ping-ponged yesterday and I decided to go with alternating the target.inline-breakpoint-strategy from always (the default) to headers. This way you can exactly see in the test file how things are behaving. So before going into the actual code review I'd like to ask you and @jingham to take a look at the test file. Is it the behavior described there the desired outcome? Then we can discuss the implementation.

Jun 10 2020, 4:20 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • remove debug output from test
Jun 10 2020, 3:48 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Fix comment
Jun 10 2020, 3:47 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • remove commented out code
Jun 10 2020, 3:47 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Outsource parts into SearchFilterByModulesAndSupportFiles::FunctionPasses
  • Tests with alternating setting target.inline-breakpoint-strategy between "always" and "headers"
  • Respecting target.inline-breakpoint-strategy setting in SearchFilterByModulesAndSupportFiles and maded adjustments in BreakpointResolverName::SearchCallback
  • Renamed SearchFilterByModuleListAndCUList to SearchFilterByModulesAndSupportFiles
Jun 10 2020, 3:47 AM · Restricted Project

Jun 3 2020

kwk committed rGe636e6b79ac0: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro (authored by kwk).
[clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro
Jun 3 2020, 2:22 PM
kwk closed D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
Jun 3 2020, 2:21 PM · Restricted Project, Restricted Project
kwk awarded D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output. a Like token.
Jun 3 2020, 2:02 AM · Restricted Project

Jun 2 2020

kwk added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

LGTM with 2 small nits, but I'd still give a few days see if anyone else wants to weight in.

Jun 2 2020, 2:16 PM · Restricted Project, Restricted Project
kwk updated the diff for D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
  • Return macro name by reference
  • Add colon to paragraph showing code
Jun 2 2020, 1:10 PM · Restricted Project, Restricted Project
kwk added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

Done.

Jun 2 2020, 1:10 PM · Restricted Project, Restricted Project
kwk committed rGeaebcbc67926: [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN (authored by kwk).
[lldb] NFC remove DISALLOW_COPY_AND_ASSIGN
Jun 2 2020, 10:26 AM
kwk closed D80543: [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN.
Jun 2 2020, 10:26 AM · Restricted Project
kwk updated the diff for D80543: [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN.

Rebased

Jun 2 2020, 10:25 AM · Restricted Project
kwk added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

Marked more comments as "done" after going through the code again.

Jun 2 2020, 9:19 AM · Restricted Project, Restricted Project

May 28 2020

kwk added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

@njames93 I've addressed all your comments and hope the patch is good to land now :)

May 28 2020, 1:45 PM · Restricted Project, Restricted Project
kwk updated the diff for D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
  • Don't store SourceManager but get it from Preprocessor
  • Use getName instead of getNameStart
  • Remove FIXME
  • change warning message
  • doxygen: \a -> \p
  • Make MacroName private and add getter
May 28 2020, 1:45 PM · Restricted Project, Restricted Project
kwk retitled D80543: [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN from [lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion to [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN.
May 28 2020, 1:13 PM · Restricted Project
kwk added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

@labath please see my inline comment.

May 28 2020, 7:34 AM · Restricted Project
kwk added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

@njames93 and @Eugene.Zelenko do you guys think this patch is ready to be approved and land?

May 28 2020, 5:23 AM · Restricted Project, Restricted Project

May 27 2020

kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • don't hard-code --color and --dump-input on FileCheck invocation
May 27 2020, 5:22 AM · Restricted Project
kwk added inline comments to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
May 27 2020, 3:44 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • make test CHECKs less strict
May 27 2020, 3:44 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • use %t in files created in tests
May 27 2020, 3:12 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • rebase
  • Rename function in test from inlined_42 to function_in_header
  • Typo: compulation -> compilation
May 27 2020, 3:12 AM · Restricted Project
kwk added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

@Eugene.Zelenko thank you for your patience with me. I fixed the link.

May 27 2020, 12:30 AM · Restricted Project, Restricted Project
kwk updated the diff for D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
  • fix link in doc
May 27 2020, 12:30 AM · Restricted Project, Restricted Project

May 26 2020

kwk updated the diff for D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
  • Adjust link to documentation
May 26 2020, 10:49 AM · Restricted Project, Restricted Project
kwk added inline comments to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
May 26 2020, 10:49 AM · Restricted Project, Restricted Project
kwk added inline comments to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
May 26 2020, 10:49 AM · Restricted Project, Restricted Project
kwk added inline comments to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
May 26 2020, 10:17 AM · Restricted Project, Restricted Project
kwk updated the diff for D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
  • Refer to modernize-use-equals-delete for warning about deleted functions in private sections
May 26 2020, 10:16 AM · Restricted Project, Restricted Project
kwk added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

Thanks @njames93 and @Eugene.Zelenko for your review. Most of it, I addressed but for some I have comments. See inline.

May 26 2020, 9:44 AM · Restricted Project, Restricted Project
kwk updated the diff for D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
  • Avoid constructing string
  • CamelCase for vars
  • more readable snippets for documentation
  • Added empty line after header in documentation
  • Remove sentence from doc
  • Remove unimportant tests
May 26 2020, 9:44 AM · Restricted Project, Restricted Project
kwk added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

@njames93 I've implemented everything you've mentioned. This simplified a lot.

May 26 2020, 3:11 AM · Restricted Project, Restricted Project
kwk updated the diff for D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
  • Wrap RUN lines
  • Use CamelCase variable name
  • Simplify access to options
  • Make check options const
  • Use two-line placeholder
  • Automate placement of semicolon at the end
May 26 2020, 3:11 AM · Restricted Project, Restricted Project
kwk updated the diff for D80543: [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN.

[lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion

May 26 2020, 2:39 AM · Restricted Project
kwk abandoned D80543: [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN.

Sorry, wrong revisions uploaded

May 26 2020, 2:39 AM · Restricted Project
kwk created D80543: [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN.
May 26 2020, 2:39 AM · Restricted Project
kwk updated the summary of D80543: [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN.
May 26 2020, 2:39 AM · Restricted Project
kwk planned changes to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

Thank you @njames93 for the review. I'm implementing what you wrote.

May 26 2020, 2:39 AM · Restricted Project, Restricted Project

May 25 2020

kwk updated the diff for D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
  • Move comment about FinalizeWithSemicolon into code
May 25 2020, 10:28 PM · Restricted Project, Restricted Project
kwk added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

@Eugene.Zelenko thank you for the review. I've fixed all places that you've mentioned. And have a question about one thing in particular. See inline.

May 25 2020, 9:59 PM · Restricted Project, Restricted Project
kwk updated the diff for D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
  • Make ReplaceDisallowCopyAndAssignMacroCheck only work in C++11 and above
  • Remove unrelated changes from clang-tools-extra/docs/clang-tidy/checks/list.rst
  • documentation simplification
  • Move comment into code
  • use single ticks
May 25 2020, 9:59 PM · Restricted Project, Restricted Project
kwk created D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.
May 25 2020, 12:51 PM · Restricted Project, Restricted Project

May 5 2020

kwk committed rG24b4965ce65b: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with… (authored by kwk).
[clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with…
May 5 2020, 2:36 PM
kwk closed D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3.
May 5 2020, 2:36 PM · Restricted Project
kwk updated the diff for D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3.
May 5 2020, 2:36 PM · Restricted Project
kwk created D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3.
May 5 2020, 8:03 AM · Restricted Project
kwk updated the summary of D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3.
May 5 2020, 8:03 AM · Restricted Project
kwk updated the summary of D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3.
May 5 2020, 8:03 AM · Restricted Project
kwk updated the summary of D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3.
May 5 2020, 8:03 AM · Restricted Project
kwk added reviewers for D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3: djasper, dsanders.
May 5 2020, 8:03 AM · Restricted Project

Apr 20 2020

kwk added a comment to D78242: [lldb/Docs] Add some more info about the test suite layout.

I've marked some mistakes that were not addressed yet but are marked as "Done".

Apr 20 2020, 10:45 PM · Restricted Project
kwk added a comment to D72698: [lldb] Add method decls to a CXXRecordDecl only after all their properties are defined.

The only code that is currently after addDecl is changing whether the special members are
defaulted/trivial. I'm not sure if this actually fixes anything but it's more correct than what we
did before.

Apr 20 2020, 10:45 PM · Restricted Project

Apr 17 2020

kwk updated subscribers of D75750: [lldb] integrate debuginfod.

lldb-dev is indeed a better place for the architectural discussion. However, moving the discussion there does not automatically unblock this patch. "get something in now and improve the architecture later" almost never works out in practice. In fact I would say that adding debuginfod is a good way to cement the status quo.

Apr 17 2020, 5:54 AM · Restricted Project
kwk added inline comments to D76855: [lldb][NFC] Mention how to disable version check in reproducer in version check error message.
Apr 17 2020, 3:12 AM
kwk accepted D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool.

All tests pass. I first thought that the lldb/test/Shell/Reproducer/TestGDBRemoteRepro.test test didn't work but it seems to be flaky.

Apr 17 2020, 2:07 AM · Restricted Project
kwk resigned from D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool.

I resign because I think @labath made some good points that I cannot argue about.

Apr 17 2020, 2:07 AM · Restricted Project
kwk added a comment to D75750: [lldb] integrate debuginfod.

So it might be good to have the SymbolVendors use one or more SymbolServer plug-ins.

I don't believe we have anything that would require all modules in a given target (or whatever) to use the same symbol vendor type. [...]

Just for clarity, is someone proposing to undertake such a rework of that infrastructure? It sounds like this is becoming a prerequisite for Konrad's patch, but if no one's actually doing it, that means Konrad's work is on hold indefinitely. Is that the intent?

Yes, I believe that is becoming a prerequisite. I believe Konrad is willing to try to implement that, but I have advised him to hold on a bit until the exact details are hashed out.

Apr 17 2020, 1:35 AM · Restricted Project

Apr 16 2020

kwk added a comment to D78242: [lldb/Docs] Add some more info about the test suite layout.

This looks good overall. I would add a section describing which test suite to use when you're interested in a particular DWARF feature for example. I heard from my GDB colleagues that the don't use a compiler, because that might change and produce a different DWARF. Instead they use a DWARF assembler (IIRC). I guess the analogy to LLDB would be yaml2obj which I see not mentioned here. Does it make sense to at least reference it in a section?

Apr 16 2020, 6:10 AM · Restricted Project
kwk awarded D78242: [lldb/Docs] Add some more info about the test suite layout a Love token.
Apr 16 2020, 6:04 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Remove not needed include
Apr 16 2020, 3:23 AM · Restricted Project

Apr 15 2020

kwk added a comment to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

Yes, I believe this matches the behavior we were talking about.

I could make a bunch of comments on the implementation and the test, but I'm not sure if we're at that stage yet...

Apr 15 2020, 6:32 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Revert "Honor the module"
Apr 15 2020, 6:32 AM · Restricted Project
kwk planned changes to D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
Apr 15 2020, 6:32 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Honor the module
Apr 15 2020, 6:32 AM · Restricted Project
kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Modify SearchFilterByModuleListAndCU
  • format
Apr 15 2020, 5:59 AM · Restricted Project

Apr 14 2020

kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.

Ran git clang-format

Apr 14 2020, 7:27 AM · Restricted Project
kwk abandoned D78109: Ran git clang-format.

Sorry, wrong arc diff invocation.

Apr 14 2020, 7:27 AM · Restricted Project
kwk created D78109: Ran git clang-format.
Apr 14 2020, 6:55 AM · Restricted Project

Apr 7 2020

kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • Simplified test
Apr 7 2020, 5:23 AM · Restricted Project

Apr 6 2020

kwk updated the diff for D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint.
  • rebased onto master to get rid of NFC change
Apr 6 2020, 8:05 AM · Restricted Project
kwk committed rG9072df8ac143: [lldb][nfc] remove overriden funcs with default impl (authored by kwk).
[lldb][nfc] remove overriden funcs with default impl
Apr 6 2020, 7:33 AM
kwk closed D77376: [lldb][nfc] remove overriden funcs with default impl.
Apr 6 2020, 7:33 AM · Restricted Project
kwk added a comment to D77376: [lldb][nfc] remove overriden funcs with default impl.

@jankratochvil thanks for the tip.
@labath, addressed your comments and will now push it.

Apr 6 2020, 5:54 AM · Restricted Project
kwk updated the diff for D77376: [lldb][nfc] remove overriden funcs with default impl.
  • Simplify comments
Apr 6 2020, 5:54 AM · Restricted Project