Page MenuHomePhabricator

kwk (Konrad Wilhelm Kleine)
Senior Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2014, 8:11 AM (286 w, 5 d)

I'm a dad, husband and have a passion for playing the acoustic guitar and taking as well as developing pictures with my analogue photo camera. I also swim, run and ride my mountainbike.

C/C++ is my day to day programming language and I have more than three years of experience with the Go programming language from my previous job.

Recent Activity

Today

kwk added inline comments to D60963: Fix dereferencing null pointer.
Mon, Aug 19, 12:46 AM · Restricted Project, Restricted Project

Tue, Aug 13

kwk added inline comments to D60963: Fix dereferencing null pointer.
Tue, Aug 13, 5:49 AM · Restricted Project, Restricted Project
kwk requested changes to D65682: Give a little more info when "run_to_x_breakpoint" fails.
Tue, Aug 13, 5:41 AM · Restricted Project

Thu, Jul 25

Herald updated subscribers of D60054: [llvm-objcopy] Add --keep-symbols option.
Thu, Jul 25, 1:27 AM · Restricted Project
kwk awarded D60054: [llvm-objcopy] Add --keep-symbols option a Love token.
Thu, Jul 25, 1:25 AM · Restricted Project

Jun 11 2019

kwk added a comment to D62852: Ignore DIEs in the skeleton unit in a DWO scenario.

This patch fixes a couple of existing tests,

Jun 11 2019, 12:49 AM · Restricted Project

Jun 4 2019

kwk added a comment to D62623: Reduce memory consumption of coverage dumps.
In D62623#1524666, @kwk wrote:

@kwk: looks like you're still compiling with clang-7, this patch is to be applied on the master version of LLVM/clang, then you can install it and use it to recompile llvm/lld with coverage info.

Does it make sense to you?

@serge-sans-paille oh yes. Absolutely. Thank you! I will try that out right away.

Jun 4 2019, 12:30 AM · Restricted Project

May 31 2019

kwk added a comment to D62623: Reduce memory consumption of coverage dumps.

@kwk: looks like you're still compiling with clang-7, this patch is to be applied on the master version of LLVM/clang, then you can install it and use it to recompile llvm/lld with coverage info.

Does it make sense to you?

May 31 2019, 1:40 AM · Restricted Project

May 29 2019

kwk added a comment to D62623: Reduce memory consumption of coverage dumps.
In D62623#1521999, @kwk wrote:

@serge-sans-paille testing it now.

May 29 2019, 6:36 PM · Restricted Project
kwk added a comment to D62623: Reduce memory consumption of coverage dumps.

@serge-sans-paille testing it now.

May 29 2019, 1:49 PM · Restricted Project

May 23 2019

kwk committed rG342571e8d6eb: [lldb] followup fix for https://reviews.llvm.org/D62305 (authored by kwk).
[lldb] followup fix for https://reviews.llvm.org/D62305
May 23 2019, 3:40 PM
kwk committed rL361565: [lldb] followup fix for https://reviews.llvm.org/D62305.
[lldb] followup fix for https://reviews.llvm.org/D62305
May 23 2019, 3:36 PM
kwk committed rLLDB361565: [lldb] followup fix for https://reviews.llvm.org/D62305.
[lldb] followup fix for https://reviews.llvm.org/D62305
May 23 2019, 3:36 PM
kwk closed D62337: [lldb] followup fix for https://reviews.llvm.org/D62305.
May 23 2019, 3:36 PM · Restricted Project
kwk added reviewers for D62337: [lldb] followup fix for https://reviews.llvm.org/D62305: stella.stamenova, JDevlieghere.
May 23 2019, 11:51 AM · Restricted Project
kwk created D62337: [lldb] followup fix for https://reviews.llvm.org/D62305.
May 23 2019, 11:51 AM · Restricted Project
kwk committed rG85200645c6e8: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t' (authored by kwk).
[lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'
May 23 2019, 8:15 AM
kwk committed rL361503: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.
[lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'
May 23 2019, 8:15 AM
kwk committed rLLDB361503: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.
[lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'
May 23 2019, 8:15 AM
kwk closed D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.
May 23 2019, 8:15 AM · Restricted Project
kwk added reviewers for D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t': RKSimon, courbet, jhenderson.
May 23 2019, 7:36 AM · Restricted Project
kwk updated the diff for D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.
  • Return empty lldb::thread_result_t as {}
May 23 2019, 7:25 AM · Restricted Project
kwk updated the summary of D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.
May 23 2019, 6:55 AM · Restricted Project
kwk updated the diff for D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.

Return lldb::thread_result_t() instead of NULL

May 23 2019, 6:19 AM · Restricted Project
kwk added a comment to D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.

returning lldb::thread_result_t() is probably the best thing to do here...

May 23 2019, 6:19 AM · Restricted Project
kwk updated the summary of D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.
May 23 2019, 6:13 AM · Restricted Project
kwk updated the diff for D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.

Fixed second place where nullptr couldn't be converted

May 23 2019, 6:13 AM · Restricted Project
kwk added a reviewer for D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t': jankratochvil.
May 23 2019, 6:06 AM · Restricted Project
kwk added reviewers for D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t': JDevlieghere, teemperor.
May 23 2019, 6:03 AM · Restricted Project
kwk created D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'.
May 23 2019, 6:03 AM · Restricted Project
kwk committed rG248a13057a4a: [lldb] NFC modernize codebase with modernize-use-nullptr (authored by kwk).
[lldb] NFC modernize codebase with modernize-use-nullptr
May 23 2019, 4:18 AM
kwk committed rL361484: [lldb] NFC modernize codebase with modernize-use-nullptr.
[lldb] NFC modernize codebase with modernize-use-nullptr
May 23 2019, 4:18 AM
kwk committed rLLDB361484: [lldb] NFC modernize codebase with modernize-use-nullptr.
[lldb] NFC modernize codebase with modernize-use-nullptr
May 23 2019, 4:17 AM
kwk closed D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.
May 23 2019, 4:15 AM · Restricted Project, Restricted Project
kwk updated the diff for D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.

Rebase onto master

May 23 2019, 4:03 AM · Restricted Project, Restricted Project
kwk updated the diff for D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.

Rebased onto master

May 23 2019, 3:30 AM · Restricted Project, Restricted Project
kwk updated the diff for D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.

Unchanged commit

May 23 2019, 3:07 AM · Restricted Project, Restricted Project
kwk updated the diff for D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.
  • Ran git clang-format HEAD^ and picked changes by hand using git add -p
  • Remove left-overs from unfinished rebase before
May 23 2019, 1:46 AM · Restricted Project, Restricted Project

May 22 2019

kwk added a comment to D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.

@JDevlieghere I have commit access now. I'm currently working on rebasing my changes and resolving conflicts in these files where my patch wasn't rebaseable.

May 22 2019, 7:12 AM · Restricted Project, Restricted Project
kwk committed rG0e7994718bc4: Added a dot at the end of comment (authored by kwk).
Added a dot at the end of comment
May 22 2019, 6:22 AM
kwk committed rLLDB361383: Added a dot at the end of comment.
Added a dot at the end of comment
May 22 2019, 6:21 AM
kwk committed rL361383: Added a dot at the end of comment.
Added a dot at the end of comment
May 22 2019, 6:21 AM
kwk closed D62243: Added a dot at the end of comment.
May 22 2019, 6:21 AM · Restricted Project
kwk added a reviewer for D62243: Added a dot at the end of comment: jankratochvil.
May 22 2019, 4:03 AM · Restricted Project
kwk created D62243: Added a dot at the end of comment.
May 22 2019, 4:03 AM · Restricted Project

May 21 2019

kwk added reviewers for D62182: builder lldb-x86_64-fedora: more verbosity: gkistanova, jankratochvil.
May 21 2019, 3:03 AM · Restricted Project
kwk created D62182: builder lldb-x86_64-fedora: more verbosity.
May 21 2019, 3:03 AM · Restricted Project

May 16 2019

kwk added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.

I withdraw from my approach and thanks to @teemperor I have found something else to work on. Thank you for this fruitful discussion.

May 16 2019, 1:12 AM · Restricted Project
kwk abandoned D61737: [lldb] add -ex CLI option as alias to --one-line.
May 16 2019, 1:12 AM · Restricted Project

May 15 2019

kwk added a comment to D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.

@JDevlieghere can you please commit this in my name? I don't have commit access yet. I've filed an email an hope to get it soon.

May 15 2019, 5:03 AM · Restricted Project, Restricted Project

May 13 2019

kwk retitled D61847: [lldb] NFC modernize codebase with modernize-use-nullptr from [lldb] modernize codebase with modernize-use-nullptr to [lldb] NFC modernize codebase with modernize-use-nullptr.
May 13 2019, 5:33 AM · Restricted Project, Restricted Project
kwk added a comment to D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.

@teemperor I've addressed all of your comments. Can you please have another look?

May 13 2019, 5:21 AM · Restricted Project, Restricted Project
kwk updated the diff for D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.
May 13 2019, 5:14 AM · Restricted Project, Restricted Project
kwk added inline comments to D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.
May 13 2019, 2:22 AM · Restricted Project, Restricted Project
Herald added a reviewer for D61847: [lldb] NFC modernize codebase with modernize-use-nullptr: espindola.
May 13 2019, 1:29 AM · Restricted Project, Restricted Project

May 10 2019

kwk added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.

@teemperor Do you recommend me to work on support for GDB's --args parameter then and ditch this review?

May 10 2019, 5:07 AM · Restricted Project
kwk added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.

I would rather not clutter up the lldb command driver's options with gdb command flags. That seems like it will make lldb harder to figure out and reduce our freedom to choose reasonable short names for lldb driver options.

May 10 2019, 12:23 AM · Restricted Project
kwk updated the diff for D61737: [lldb] add -ex CLI option as alias to --one-line.
May 10 2019, 12:04 AM · Restricted Project

May 9 2019

kwk updated the summary of D61737: [lldb] add -ex CLI option as alias to --one-line.
May 9 2019, 8:47 AM · Restricted Project
kwk updated the summary of D61737: [lldb] add -ex CLI option as alias to --one-line.
May 9 2019, 8:47 AM · Restricted Project
kwk created D61737: [lldb] add -ex CLI option as alias to --one-line.
May 9 2019, 8:40 AM · Restricted Project

May 5 2019

kwk added a comment to D61483: [www] list command: lldb run <args>.

This is the old documentation. You should edit the new one in docs/use/map.rst.

May 5 2019, 11:38 PM · Restricted Project

May 3 2019

kwk added a reviewer for D61483: [www] list command: lldb run <args>: jasonmolenda.
May 3 2019, 3:13 AM · Restricted Project
kwk updated the summary of D61483: [www] list command: lldb run <args>.
May 3 2019, 3:10 AM · Restricted Project
kwk updated the summary of D61483: [www] list command: lldb run <args>.
May 3 2019, 3:05 AM · Restricted Project
kwk added a comment to D61440: C.128 override, virtual keyword handling.

Looks good now, thanks!

May 3 2019, 1:27 AM · Restricted Project, Restricted Project
kwk added a comment to D61440: C.128 override, virtual keyword handling.

@teemperor I've squashed my commits without the last one that did those many changes in the file lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp. I hope at least the result is fine now.

May 3 2019, 12:08 AM · Restricted Project, Restricted Project

May 2 2019

kwk added a comment to D61440: C.128 override, virtual keyword handling.

Not sure how you invoke git clang-format, but I assume you specified the wrong commit range...

May 2 2019, 1:31 PM · Restricted Project, Restricted Project
kwk added a comment to D61440: C.128 override, virtual keyword handling.

FYI, I still think there are some style issues there (e.g. the AppleObjCRuntimeV2.cpp change makes it longer than 80 chars) but I can just clang-format this before committing.

Otherwise, unless someone objects to this change I'll merge this tomorrow. Thanks for the patch @kkleine!

May 2 2019, 12:50 PM · Restricted Project, Restricted Project
kwk added a comment to D61440: C.128 override, virtual keyword handling.

@teemperor I would have loved to use clang-format for this but apparently the LLDB code is still manually formatted. It would be a bliss to just use the LLVM clang-format style and never ever talk about "style" again.

May 2 2019, 12:31 PM · Restricted Project, Restricted Project
kwk added a comment to D61440: C.128 override, virtual keyword handling.

LGTM module some minor code style issues (You removed some virtuals but didn't fix the indentation of the parameters on the next line, see the inline comments for examples).

May 2 2019, 12:27 PM · Restricted Project, Restricted Project
kwk updated the summary of D61440: C.128 override, virtual keyword handling.
May 2 2019, 6:36 AM · Restricted Project, Restricted Project

May 1 2019

kwk added a comment to D61368: Fix build URL in new LLDB website.

I just realized that you probably don't have commit access yet, so I'll commit this for you. Thanks for the patch!

May 1 2019, 1:26 PM · Restricted Project, Restricted Project

Sep 24 2014

kwk added a comment to D2098: Introduce clang-query tool..

Can you please explain a usage of the "set bind-root" command? Why would I not want to match the loaded AST against a given matcher?

Sep 24 2014, 7:01 AM

Sep 2 2014

kwk updated subscribers of rL194227: Introduce clang-query tool..
Sep 2 2014, 3:23 AM
kwk updated subscribers of D2098: Introduce clang-query tool..
Sep 2 2014, 3:22 AM