This is an archive of the discontinued LLVM Phabricator instance.

Differential D148937

Adopt Properties to store operations inherent Attributes in the Tensor dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 9:38 AM.

Download Raw Diff

Details

Reviewers

rriddle
jpienaar
nicolasvasilache

Commits

rG16a74c359505: Adopt Properties to store operations inherent Attributes in the Tensor dialect

Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 9:38 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 9:38 AM

Herald added subscribers: bviyer, hanchung, Moerafaat and 21 others. · View Herald Transcript

mehdi_amini requested review of this revision.Apr 21 2023, 9:38 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 9:38 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

mehdi_amini added a child revision: D148938: Adopt Properties to store operations inherent Attributes in the Transform dialect.Apr 21 2023, 9:39 AM

mehdi_amini added a parent revision: D148936: Adopt Properties to store operations inherent Attributes in the SPIRV dialect.

Harbormaster completed remote builds in B227235: Diff 515801.Apr 21 2023, 11:20 AM

Rebase

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:07 PM

This revision is now accepted and ready to land.Apr 23 2023, 11:07 PM

Harbormaster completed remote builds in B227625: Diff 516270.Apr 23 2023, 11:52 PM

Rebase

Harbormaster completed remote builds in B227934: Diff 516680.Apr 25 2023, 2:26 AM

This revision was landed with ongoing or failed builds.May 10 2023, 4:16 PM

Closed by commit rG16a74c359505: Adopt Properties to store operations inherent Attributes in the Tensor dialect (authored by mehdi_amini). · Explain Why

This revision was automatically updated to reflect the committed changes.

mehdi_amini added a commit: rG16a74c359505: Adopt Properties to store operations inherent Attributes in the Tensor dialect.

Revision Contents

Path

Size

mlir/

include/

mlir/

Dialect/

Tensor/

IR/

1 line

Diff 516016

mlir/include/mlir/Dialect/Tensor/IR/TensorBase.td

	Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines		let description = [{

	The `tensor` type is actually a builtin type (it lives in the builtin			The `tensor` type is actually a builtin type (it lives in the builtin
	dialect), and does not live in this dialect.			dialect), and does not live in this dialect.

	}];			}];

	let hasCanonicalizer = 1;			let hasCanonicalizer = 1;
	let hasConstantMaterializer = 1;			let hasConstantMaterializer = 1;
				let usePropertiesForAttributes = 1;
	let dependentDialects = [			let dependentDialects = [
	"affine::AffineDialect",			"affine::AffineDialect",
	"arith::ArithDialect",			"arith::ArithDialect",
	"complex::ComplexDialect",			"complex::ComplexDialect",
	];			];
	}			}

	#endif // TENSOR_BASE			#endif // TENSOR_BASE