This is an archive of the discontinued LLVM Phabricator instance.

Differential D148933

Adopt Properties to store operations inherent Attributes in the SCF dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 9:37 AM.

Download Raw Diff

Details

Reviewers

rriddle
jpienaar
nicolasvasilache

Commits

rG8e39a539ae87: Adopt Properties to store operations inherent Attributes in the SCF dialect

Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 9:37 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 9:37 AM

Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript

mehdi_amini requested review of this revision.Apr 21 2023, 9:37 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 9:37 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

mehdi_amini added a child revision: D148934: Adopt Properties to store operations inherent Attributes in the Shape dialect.Apr 21 2023, 9:40 AM

mehdi_amini added a parent revision: D148900: Adopt Properties to store operations inherent Attributes in the Quant dialect.

Harbormaster completed remote builds in B227230: Diff 515795.Apr 21 2023, 11:25 AM

Rebase

Harbormaster completed remote builds in B227407: Diff 516012.Apr 21 2023, 10:21 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:09 PM

This revision is now accepted and ready to land.Apr 23 2023, 11:09 PM

Rebase

Harbormaster completed remote builds in B227930: Diff 516676.Apr 25 2023, 2:16 AM

This revision was landed with ongoing or failed builds.May 10 2023, 4:16 PM

Closed by commit rG8e39a539ae87: Adopt Properties to store operations inherent Attributes in the SCF dialect (authored by mehdi_amini). · Explain Why

This revision was automatically updated to reflect the committed changes.

mehdi_amini added a commit: rG8e39a539ae87: Adopt Properties to store operations inherent Attributes in the SCF dialect.

Revision Contents

Path

Size

mlir/

include/

mlir/

Dialect/

SCF/

IR/

1 line

Diff 516266

mlir/include/mlir/Dialect/SCF/IR/SCFOps.td

	Show All 20 Lines
	include "mlir/Interfaces/ParallelCombiningOpInterface.td"			include "mlir/Interfaces/ParallelCombiningOpInterface.td"
	include "mlir/Interfaces/SideEffectInterfaces.td"			include "mlir/Interfaces/SideEffectInterfaces.td"
	include "mlir/Interfaces/ViewLikeInterface.td"			include "mlir/Interfaces/ViewLikeInterface.td"

	def SCF_Dialect : Dialect {			def SCF_Dialect : Dialect {
	let name = "scf";			let name = "scf";
	let cppNamespace = "::mlir::scf";			let cppNamespace = "::mlir::scf";
	let dependentDialects = ["arith::ArithDialect"];			let dependentDialects = ["arith::ArithDialect"];
				let usePropertiesForAttributes = 1;
	}			}

	// Base class for SCF dialect ops.			// Base class for SCF dialect ops.
	class SCF_Op<string mnemonic, list<Trait> traits = []> :			class SCF_Op<string mnemonic, list<Trait> traits = []> :
	Op<SCF_Dialect, mnemonic, traits>;			Op<SCF_Dialect, mnemonic, traits>;

	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//
	// ConditionOp			// ConditionOp
	▲ Show 20 Lines • Show All 1,174 Lines • Show Last 20 Lines