This is an archive of the discontinued LLVM Phabricator instance.

Differential D148898

Adopt Properties to store operations inherent Attributes in the PDL dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:05 AM.

Details

Reviewers
rriddle
jpienaar
nicolasvasilache
Commits
rG307d0cceb9de: Adopt Properties to store operations inherent Attributes in the PDL dialect
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 12:05 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 12:05 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 12:05 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B227101: Diff 515626.Apr 21 2023, 12:35 AM
mehdi_amini added a parent revision: D148897: Adopt Properties to store operations inherent Attributes in the OpenMP dialect.Apr 21 2023, 9:07 AM
mehdi_amini added a child revision: D148899: Adopt Properties to store operations inherent Attributes in the PDLInterp dialect.
mehdi_amini updated this revision to Diff 515790.Apr 21 2023, 9:31 AM

Rebase

Harbormaster completed remote builds in B227226: Diff 515790.Apr 21 2023, 11:09 AM
mehdi_amini updated this revision to Diff 516009.Apr 21 2023, 8:22 PM

Rebase

Harbormaster completed remote builds in B227404: Diff 516009.Apr 21 2023, 10:05 PM
mehdi_amini updated this revision to Diff 516263.Apr 23 2023, 10:32 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:09 PM
This revision is now accepted and ready to land.Apr 23 2023, 11:09 PM
Harbormaster completed remote builds in B227618: Diff 516263.Apr 23 2023, 11:46 PM
mehdi_amini updated this revision to Diff 516673.Apr 25 2023, 12:20 AM

Rebase

Harbormaster completed remote builds in B227927: Diff 516673.Apr 25 2023, 2:08 AM
This revision was landed with ongoing or failed builds.May 10 2023, 6:54 AM
Closed by commit rG307d0cceb9de: Adopt Properties to store operations inherent Attributes in the PDL dialect (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG307d0cceb9de: Adopt Properties to store operations inherent Attributes in the PDL dialect.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
PDL/
IR/
1 line

Diff 520979

mlir/include/mlir/Dialect/PDL/IR/PDLDialect.td

Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines let description = [{
other features such as applying external constraints or external generator other features such as applying external constraints or external generator
methods. These features and more are detailed below. methods. These features and more are detailed below.
}]; }];
let name = "pdl"; let name = "pdl";
let cppNamespace = "::mlir::pdl"; let cppNamespace = "::mlir::pdl";
let useDefaultTypePrinterParser = 1; let useDefaultTypePrinterParser = 1;
let usePropertiesForAttributes = 1;
let extraClassDeclaration = [{ let extraClassDeclaration = [{
void registerTypes(); void registerTypes();
}]; }];
} }
#endif // MLIR_DIALECT_PDL_IR_PDLDIALECT #endif // MLIR_DIALECT_PDL_IR_PDLDIALECT