This is an archive of the discontinued LLVM Phabricator instance.

Differential D148894

Adopt Properties to store operations inherent Attributes in the MLProgram dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:05 AM.

Details

Reviewers
rriddle
jpienaar
nicolasvasilache
Commits
rG9bda58120f27: Adopt Properties to store operations inherent Attributes in the MLProgram…
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 12:05 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 12:05 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 12:05 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B227097: Diff 515622.Apr 21 2023, 12:33 AM
mehdi_amini added a child revision: D148895: Adopt Properties to store operations inherent Attributes in the NVGPU dialect.Apr 21 2023, 9:02 AM
mehdi_amini added a parent revision: D148893: Adopt Properties to store operations inherent Attributes in the Memref dialect.
mehdi_amini updated this revision to Diff 515785.Apr 21 2023, 9:30 AM

Rebase

Harbormaster completed remote builds in B227222: Diff 515785.Apr 21 2023, 11:08 AM
mehdi_amini updated this revision to Diff 516005.Apr 21 2023, 8:22 PM

Rebase

Harbormaster completed remote builds in B227400: Diff 516005.Apr 21 2023, 9:58 PM
mehdi_amini updated this revision to Diff 516259.Apr 23 2023, 10:32 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:10 PM
This revision is now accepted and ready to land.Apr 23 2023, 11:10 PM
Harbormaster completed remote builds in B227614: Diff 516259.Apr 23 2023, 11:30 PM
mehdi_amini updated this revision to Diff 516669.Apr 25 2023, 12:20 AM

Rebase

Harbormaster completed remote builds in B227923: Diff 516669.Apr 25 2023, 2:09 AM
This revision was landed with ongoing or failed builds.May 9 2023, 5:31 PM
Closed by commit rG9bda58120f27: Adopt Properties to store operations inherent Attributes in the MLProgram… (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG9bda58120f27: Adopt Properties to store operations inherent Attributes in the MLProgram….

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
MLProgram/
IR/
1 line

Diff 516669

mlir/include/mlir/Dialect/MLProgram/IR/MLProgramBase.td

Show All 23 Lines let description = [{
This dialect is under active development, and while stability is an This dialect is under active development, and while stability is an
eventual goal, it is not guaranteed at this juncture. Given the early state, eventual goal, it is not guaranteed at this juncture. Given the early state,
it is recommended to inquire further prior to using this dialect. it is recommended to inquire further prior to using this dialect.
}]; }];
let useDefaultAttributePrinterParser = 1; let useDefaultAttributePrinterParser = 1;
let useDefaultTypePrinterParser = 1; let useDefaultTypePrinterParser = 1;
let usePropertiesForAttributes = 1;
} }
#endif // MLPROGRAM_BASE #endif // MLPROGRAM_BASE