This is an archive of the discontinued LLVM Phabricator instance.

Differential D148891

Adopt Properties to store operations inherent Attributes in the IRDL dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:04 AM.

Details

Reviewers
rriddle
jpienaar
nicolasvasilache
Commits
rGfeace14fb974: Adopt Properties to store operations inherent Attributes in the IRDL dialect
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 12:04 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 12:04 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 12:04 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B227094: Diff 515619.Apr 21 2023, 12:29 AM
mehdi_amini added a child revision: D148892: Adopt Properties to store operations inherent Attributes in the Math dialect.Apr 21 2023, 9:03 AM
mehdi_amini added a parent revision: D148890: Adopt Properties to store operations inherent Attributes in the Index dialect.
mehdi_amini updated this revision to Diff 515782.Apr 21 2023, 9:30 AM

Rebase

Harbormaster completed remote builds in B227219: Diff 515782.Apr 21 2023, 11:03 AM
mehdi_amini updated this revision to Diff 516002.Apr 21 2023, 8:22 PM

Rebase

Harbormaster completed remote builds in B227397: Diff 516002.Apr 21 2023, 9:49 PM
mehdi_amini updated this revision to Diff 516256.Apr 23 2023, 10:32 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:11 PM
This revision is now accepted and ready to land.Apr 23 2023, 11:11 PM
Harbormaster completed remote builds in B227611: Diff 516256.Apr 23 2023, 11:34 PM
mehdi_amini updated this revision to Diff 516666.Apr 25 2023, 12:20 AM

Rebase

Harbormaster completed remote builds in B227920: Diff 516666.Apr 25 2023, 2:25 AM
This revision was landed with ongoing or failed builds.May 9 2023, 5:31 PM
Closed by commit rGfeace14fb974: Adopt Properties to store operations inherent Attributes in the IRDL dialect (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rGfeace14fb974: Adopt Properties to store operations inherent Attributes in the IRDL dialect.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
IRDL/
IR/
1 line

Diff 516002

mlir/include/mlir/Dialect/IRDL/IR/IRDL.td

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines let description = [{
satisfy the same constraint). satisfy the same constraint).
IRDL variables are handle over `mlir::Attribute`. In order to support IRDL variables are handle over `mlir::Attribute`. In order to support
manipulating `mlir::Type`, IRDL wraps all types in an `mlir::TypeAttr` manipulating `mlir::Type`, IRDL wraps all types in an `mlir::TypeAttr`
attribute. The rationale of this is to simplify the dialect. attribute. The rationale of this is to simplify the dialect.
}]; }];
let useDefaultTypePrinterParser = 1; let useDefaultTypePrinterParser = 1;
let usePropertiesForAttributes = 1;
let name = "irdl"; let name = "irdl";
let cppNamespace = "::mlir::irdl"; let cppNamespace = "::mlir::irdl";
} }
#endif // MLIR_DIALECT_IRDL_IR_IRDL #endif // MLIR_DIALECT_IRDL_IR_IRDL