This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] implement index redution on dense level (for CSR)
ClosedPublic

Authored by Peiming on Apr 4 2023, 11:22 AM.

Diff Detail

Event Timeline

Peiming created this revision.Apr 4 2023, 11:22 AM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Apr 4 2023, 11:22 AM
Peiming updated this revision to Diff 510973.Apr 4 2023, 5:18 PM

add conv_3d test.

Peiming updated this revision to Diff 511157.Apr 5 2023, 11:01 AM

fix bug (on CSC and tensor formats with last level being dense).

Peiming updated this revision to Diff 511160.Apr 5 2023, 11:05 AM

fix format.

Peiming updated this revision to Diff 511163.Apr 5 2023, 11:09 AM

fix memory leakage.

aartbik added inline comments.Apr 5 2023, 12:19 PM
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp
758

eleborate on this, where and how?
this may be trivial to you know, but it won't be in the future ;-)

mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h
317–318

This needs a method doc now explaining what all parameters really mean
(lo and hi in particular)

395

something in the sentence does not flow? (2x is?)

Peiming updated this revision to Diff 511241.Apr 5 2023, 5:26 PM
Peiming marked 2 inline comments as done.

address comments.

Peiming marked an inline comment as done.Apr 5 2023, 5:26 PM
Peiming added inline comments.
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp
758

You are right, I should probably think about how to re-org the code here a little bit too...

aartbik accepted this revision.Apr 15 2023, 4:52 PM
aartbik added inline comments.
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
1488

can we assert on isUndefDLT here?
that way the semantic change worries me a little less ;-)

This revision is now accepted and ready to land.Apr 15 2023, 4:52 PM
aartbik added inline comments.Apr 15 2023, 4:57 PM
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp
1491

can you spell this outerMost (one t)

Peiming updated this revision to Diff 514268.Apr 17 2023, 9:16 AM
Peiming marked an inline comment as done.

address comments.

Peiming marked an inline comment as done.Apr 17 2023, 9:16 AM
Peiming updated this revision to Diff 514272.Apr 17 2023, 9:27 AM

fix errors.

This revision was landed with ongoing or failed builds.Apr 17 2023, 9:36 AM
This revision was automatically updated to reflect the committed changes.
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conv_3d.mlir