Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp | ||
---|---|---|
758 | eleborate on this, where and how? | |
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h | ||
317–318 | This needs a method doc now explaining what all parameters really mean | |
395 | something in the sentence does not flow? (2x is?) |
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp | ||
---|---|---|
758 | You are right, I should probably think about how to re-org the code here a little bit too... |
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
---|---|---|
1488 | can we assert on isUndefDLT here? |
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp | ||
---|---|---|
1486 | can you spell this outerMost (one t) |
This needs a method doc now explaining what all parameters really mean
(lo and hi in particular)