The "outs" is confusing for the tensor domain as these are immutable
object. These arguments are used for:
- the iteration domain / shape of the results.
- the initial value used when reduction are involved.
Differential D146036 Authored by mehdi_amini on Mar 14 2023, 5:16 AM.
Details Summary The "outs" is confusing for the tensor domain as these are immutable
Diff Detail
Event TimelineHerald added subscribers: pcwang-thead, limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript This revision is now accepted and ready to land.Mar 14 2023, 5:24 AM Comment Actions I don't have strong opinions here, all names are confusing .. init makes one think that the tensor needs to be initialized to a meaningful value, this is not the case if the associated bbArg is not used. if anything, I'd go for dest personally with a doc that the dest may or may not be read. Comment Actions
dest looks to me like "writing to a tensor" again. The "destination" of the tensor-based op is the LHS of the = and the "yielded" values in the body. Large DiffThis large diff affects 266 files. Files without inline comments have been collapsed. Expand All Files
Revision Contents
Diff 505045 mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-analysis-empty-tensor-elimination.mlir |