Page MenuHomePhabricator

pifon2a (Alexander Belyaev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:48 AM (123 w, 2 d)

Recent Activity

Sat, May 14

pifon2a accepted D125615: [mlir][bufferize] Better user control of layout maps.
Sat, May 14, 1:01 PM · Restricted Project, Restricted Project
pifon2a accepted D125614: [mlir][bufferize] Infer memref types when possible.
Sat, May 14, 12:58 PM · Restricted Project, Restricted Project

Fri, May 6

pifon2a accepted D125017: [mlir][bufferize] Disallow adding new bufferizable ops during bufferization.

Thank you a lot!

Fri, May 6, 2:27 AM · Restricted Project, Restricted Project

Thu, May 5

pifon2a accepted D125015: [mlir][bufferize] Do not copy buffers with undefined contents.
Thu, May 5, 8:50 AM · Restricted Project, Restricted Project

Wed, May 4

pifon2a accepted D124934: [mlir][scf][bufferize] Update verifyAnalysis error message.
Wed, May 4, 9:23 AM · Restricted Project, Restricted Project
pifon2a accepted D124933: [mlir][scf][bufferize][NFC] Split ForOp bufferization into smaller functions.
Wed, May 4, 9:23 AM · Restricted Project, Restricted Project
pifon2a committed rGe8f7d019fc21: [mlir] Add a flag to allow equivalent results. (authored by pifon2a).
[mlir] Add a flag to allow equivalent results.
Wed, May 4, 8:48 AM · Restricted Project, Restricted Project
pifon2a closed D124931: [mlir] Add a flag to allow equivalent results..
Wed, May 4, 8:48 AM · Restricted Project, Restricted Project
pifon2a requested review of D124931: [mlir] Add a flag to allow equivalent results..
Wed, May 4, 8:46 AM · Restricted Project, Restricted Project
pifon2a accepted D124928: [mlir][scf][bufferize][NFC] Simplify verifyAnalysis implementation.
Wed, May 4, 8:42 AM · Restricted Project, Restricted Project

Fri, Apr 22

pifon2a accepted D124265: [mlir][bufferize][NFC] Add function boundary bufferization flag to BufferizationOptions.
Fri, Apr 22, 8:12 AM · Restricted Project, Restricted Project
pifon2a accepted D124264: [mlir][bufferize][NFC] Rewrite op filter logic.
Fri, Apr 22, 8:11 AM · Restricted Project, Restricted Project

Apr 20 2022

pifon2a accepted D123214: [mlir][bufferize][NFC] Move FuncOp bufferization to BufferizableOpInterface impl.
Apr 20 2022, 12:13 AM · Restricted Project, Restricted Project
pifon2a accepted D123618: [mlir][bufferize][NFC] Use custom walk instead of GreedyPatternRewriter.
Apr 20 2022, 12:12 AM · Restricted Project, Restricted Project

Apr 13 2022

pifon2a accepted D123641: Fix iteration counting in greedy pattern application.
Apr 13 2022, 5:45 AM · Restricted Project, Restricted Project

Apr 6 2022

pifon2a added a comment to D123161: Revert "[mlir] Rewrite canonicalization of collapse(expand) and expand(collapse).".

Thank you for the IR to reproduce it. The 0-rank case was not handled correctly. And it is also surprising that there were no tests for that. I fixed it in https://github.com/llvm/llvm-project/commit/747b10be95200a71f4e6b8ca9f0aaea20db1b164

Apr 6 2022, 3:58 AM · Restricted Project, Restricted Project
pifon2a added a reverting change for rG96e9b6c9dc60: Revert "[mlir] Rewrite canonicalization of collapse(expand) and expand…: rG747b10be9520: Revert "Revert "[mlir] Rewrite canonicalization of collapse(expand) and expand….
Apr 6 2022, 3:19 AM · Restricted Project, Restricted Project
pifon2a committed rG747b10be9520: Revert "Revert "[mlir] Rewrite canonicalization of collapse(expand) and expand… (authored by pifon2a).
Revert "Revert "[mlir] Rewrite canonicalization of collapse(expand) and expand…
Apr 6 2022, 3:19 AM · Restricted Project, Restricted Project
pifon2a added a reverting change for D123161: Revert "[mlir] Rewrite canonicalization of collapse(expand) and expand(collapse).": rG747b10be9520: Revert "Revert "[mlir] Rewrite canonicalization of collapse(expand) and expand….
Apr 6 2022, 3:18 AM · Restricted Project, Restricted Project

Apr 5 2022

pifon2a updated the diff for D122883: [mlir] Add a pass to print content of memrefs and the related ops IR..

Address the concerns. :)

Apr 5 2022, 5:07 AM · Restricted Project, Restricted Project
pifon2a accepted D123108: [mlir][tensor] Implement ReifyRankedShapedTypeOpInterface on PadOp.
Apr 5 2022, 2:31 AM · Restricted Project, Restricted Project
pifon2a committed rG004d4f898069: [mlir] Update BUILD.bazel. (authored by pifon2a).
[mlir] Update BUILD.bazel.
Apr 5 2022, 2:26 AM · Restricted Project
pifon2a committed rGcc6788aecec3: [mlir] Update mlir/BUILD.bazel. (authored by pifon2a).
[mlir] Update mlir/BUILD.bazel.
Apr 5 2022, 1:15 AM · Restricted Project
pifon2a added a comment to D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..

@nicolasvasilache I pushed the commit to fix the bugs. If you have further suggestions/comments, I ll be happy to address them.

Apr 5 2022, 1:11 AM · Restricted Project, Restricted Project
pifon2a committed rG64f659bee67b: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse). (authored by pifon2a).
[mlir] Rewrite canonicalization of collapse(expand) and expand(collapse).
Apr 5 2022, 1:11 AM · Restricted Project, Restricted Project
pifon2a closed D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..
Apr 5 2022, 1:10 AM · Restricted Project, Restricted Project

Apr 4 2022

pifon2a accepted D123027: [mlir] Support tensor.pad bufferization.
Apr 4 2022, 9:23 AM · Restricted Project, Restricted Project
pifon2a added inline comments to D122883: [mlir] Add a pass to print content of memrefs and the related ops IR..
Apr 4 2022, 9:10 AM · Restricted Project, Restricted Project
pifon2a added a reviewer for D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) .: bkramer.
Apr 4 2022, 8:17 AM · Restricted Project, Restricted Project

Apr 1 2022

pifon2a updated the diff for D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..

Fix compiler warnings.

Apr 1 2022, 8:24 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..

Update the strided example.

Apr 1 2022, 8:16 AM · Restricted Project, Restricted Project
pifon2a added inline comments to D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..
Apr 1 2022, 7:56 AM · Restricted Project, Restricted Project
pifon2a retitled D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) . from [mlir] Rewrite canonicalization of collapse_shape(expand_shape). to [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..
Apr 1 2022, 7:54 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..

Update the pattern for expand(collapse).

Apr 1 2022, 7:53 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D122883: [mlir] Add a pass to print content of memrefs and the related ops IR..

Address the comments.

Apr 1 2022, 2:36 AM · Restricted Project, Restricted Project
pifon2a added inline comments to D122883: [mlir] Add a pass to print content of memrefs and the related ops IR..
Apr 1 2022, 2:36 AM · Restricted Project, Restricted Project
pifon2a requested review of D122883: [mlir] Add a pass to print content of memrefs and the related ops IR..
Apr 1 2022, 2:03 AM · Restricted Project, Restricted Project

Mar 30 2022

pifon2a added a comment to D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..

Rewrite of the expand(collapse

Mar 30 2022, 8:09 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..

Address the comments.

Mar 30 2022, 8:09 AM · Restricted Project, Restricted Project

Mar 29 2022

pifon2a retitled D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) . from [mlir] Rewrite canonicalization of expand_shape(collapse_shape). to [mlir] Rewrite canonicalization of collapse_shape(expand_shape)..
Mar 29 2022, 10:03 AM · Restricted Project, Restricted Project
pifon2a requested review of D122666: [mlir] Rewrite canonicalization of collapse(expand) and expand(collapse) ..
Mar 29 2022, 10:01 AM · Restricted Project, Restricted Project

Mar 24 2022

pifon2a committed rGbef928f8b251: [llvm] Initialize and move UseUpRegs outside of `union` MemOp struct. (authored by pifon2a).
[llvm] Initialize and move UseUpRegs outside of `union` MemOp struct.
Mar 24 2022, 8:54 AM · Restricted Project
pifon2a closed D122405: [llvm] Initialize and move UseUpRegs outside of `union` MemOp struct..
Mar 24 2022, 8:53 AM · Restricted Project, Restricted Project
pifon2a added a reviewer for D122405: [llvm] Initialize and move UseUpRegs outside of `union` MemOp struct.: bkramer.
Mar 24 2022, 8:32 AM · Restricted Project, Restricted Project
pifon2a requested review of D122405: [llvm] Initialize and move UseUpRegs outside of `union` MemOp struct..
Mar 24 2022, 8:32 AM · Restricted Project, Restricted Project

Mar 23 2022

pifon2a committed rG5bcc90ee614a: [clang] Update BUILD.bazel after 89f6b26f1beb2c1344f5cfeb34e405128544c76b. (authored by pifon2a).
[clang] Update BUILD.bazel after 89f6b26f1beb2c1344f5cfeb34e405128544c76b.
Mar 23 2022, 1:48 AM · Restricted Project

Mar 22 2022

pifon2a accepted D122225: [mlir][Arith] Make integer max/min commutative..
Mar 22 2022, 7:15 AM · Restricted Project, Restricted Project

Mar 21 2022

pifon2a committed rG215b5ce628c2: [mlir] Add a function to print C-strings to RunnerUtils.cpp. (authored by pifon2a).
[mlir] Add a function to print C-strings to RunnerUtils.cpp.
Mar 21 2022, 5:09 AM · Restricted Project
pifon2a closed D122066: [mlir] Add a function to print C-strings to RunnerUtils.cpp..
Mar 21 2022, 5:09 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D122066: [mlir] Add a function to print C-strings to RunnerUtils.cpp..

Add an awesome test.

Mar 21 2022, 3:02 AM · Restricted Project, Restricted Project

Mar 20 2022

pifon2a updated the diff for D122066: [mlir] Add a function to print C-strings to RunnerUtils.cpp..

update

Mar 20 2022, 8:24 AM · Restricted Project, Restricted Project

Mar 19 2022

pifon2a requested review of D122066: [mlir] Add a function to print C-strings to RunnerUtils.cpp..
Mar 19 2022, 4:48 AM · Restricted Project, Restricted Project

Mar 7 2022

pifon2a accepted D121043: [mlir][shape] Migrate bufferization to BufferizableOpInterface.

Thank you!

Mar 7 2022, 1:31 AM · Restricted Project, Restricted Project

Mar 4 2022

pifon2a accepted D120985: [mlir][bufferize] Add BufferizationState initializers.
Mar 4 2022, 11:05 AM · Restricted Project, Restricted Project

Mar 3 2022

pifon2a accepted D120893: [mlir][bufferize] Always bufferize top-to-bottom.
Mar 3 2022, 5:05 AM · Restricted Project, Restricted Project
pifon2a accepted D120883: [mlir][linalg][bufferize] Migrate --linalg-bufferize to BufferizableOpInterface-based bufferization.
Mar 3 2022, 2:56 AM · Restricted Project, Restricted Project

Feb 28 2022

pifon2a committed rG1a829d2d0695: [mlir] Purge linalg.tiled_loop. (authored by pifon2a).
[mlir] Purge linalg.tiled_loop.
Feb 28 2022, 12:07 AM
pifon2a closed D119415: [mlir] Purge linalg.tiled_loop..
Feb 28 2022, 12:06 AM · Restricted Project

Feb 24 2022

pifon2a accepted D120473: [mlir][linalg] Cast back to the original type after making linalg.generic outputs more static.
Feb 24 2022, 4:41 AM · Restricted Project

Feb 19 2022

pifon2a accepted D120191: [mlir][bufferize][NFC] Rename `comprehensive-function-bufferize` to `one-shot-bufferize`.
Feb 19 2022, 11:50 AM · Restricted Project
pifon2a accepted D120189: [mlir][bufferize] Add a way for ops to fail the analysis.
Feb 19 2022, 11:48 AM · Restricted Project

Feb 17 2022

pifon2a accepted D120044: [BufferDeallocation] Don't assume successor operands are unique.
Feb 17 2022, 4:58 AM · Restricted Project

Feb 10 2022

pifon2a requested review of D119415: [mlir] Purge linalg.tiled_loop..
Feb 10 2022, 12:53 AM · Restricted Project

Feb 9 2022

pifon2a committed rGc962038914dc: [mlir][nfc] Expose linalg tiling helpers. (authored by pifon2a).
[mlir][nfc] Expose linalg tiling helpers.
Feb 9 2022, 6:26 AM
pifon2a closed D119330: [mlir][nfc] Expose linalg tiling helpers..
Feb 9 2022, 6:26 AM · Restricted Project
pifon2a updated the diff for D119330: [mlir][nfc] Expose linalg tiling helpers..

update

Feb 9 2022, 6:20 AM · Restricted Project
pifon2a requested review of D119330: [mlir][nfc] Expose linalg tiling helpers..
Feb 9 2022, 6:17 AM · Restricted Project

Feb 1 2022

pifon2a committed rGebc815378696: Revert "Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead."" (authored by pifon2a).
Revert "Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead.""
Feb 1 2022, 9:22 AM
pifon2a added a reverting change for rG25bf6a2a9bc6: Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead.": rGebc815378696: Revert "Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead."".
Feb 1 2022, 9:22 AM

Jan 31 2022

pifon2a added a reverting change for rG016956b68081: [mlir] Purge `linalg.copy` and use `memref.copy` instead.: rG25bf6a2a9bc6: Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead.".
Jan 31 2022, 9:53 AM
pifon2a committed rG25bf6a2a9bc6: Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead." (authored by pifon2a).
Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead."
Jan 31 2022, 9:53 AM
pifon2a added a reverting change for D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead.: rG25bf6a2a9bc6: Revert "[mlir] Purge `linalg.copy` and use `memref.copy` instead.".
Jan 31 2022, 9:53 AM · Restricted Project
pifon2a committed rG016956b68081: [mlir] Purge `linalg.copy` and use `memref.copy` instead. (authored by pifon2a).
[mlir] Purge `linalg.copy` and use `memref.copy` instead.
Jan 31 2022, 9:26 AM
pifon2a closed D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead..
Jan 31 2022, 9:26 AM · Restricted Project
pifon2a updated the diff for D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead..

rebase

Jan 31 2022, 9:19 AM · Restricted Project
pifon2a updated the diff for D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead..

rebase

Jan 31 2022, 9:17 AM · Restricted Project
pifon2a updated the diff for D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead..

rebase

Jan 31 2022, 5:20 AM · Restricted Project

Jan 30 2022

pifon2a accepted D118559: [mlir][bufferize][NFC] Move std BufferizableOpInterfaceImpl to std dialect.
Jan 30 2022, 4:04 AM · Restricted Project
pifon2a accepted D118557: [mlir][bufferize][NFC] Move scf BufferizableOpInterface impl to scf dialect.
Jan 30 2022, 3:58 AM · Restricted Project
pifon2a accepted D118540: [mlir][bufferize][NFC] Move vector BufferizableOpInterface impl to vector dialect.
Jan 30 2022, 3:57 AM · Restricted Project
pifon2a accepted D118483: [mlir][bufferize] Merge tensor-constant-bufferize into arith-bufferize.
Jan 30 2022, 3:57 AM · Restricted Project

Jan 28 2022

pifon2a accepted D118244: [MLIR][arith] More float op folders.
Jan 28 2022, 3:31 AM · Restricted Project

Jan 26 2022

pifon2a accepted D118243: [mlir][bufferization] Add an option to use memref types without layout maps.
Jan 26 2022, 5:46 AM · Restricted Project

Jan 25 2022

pifon2a accepted D118116: [mlir][Linalg] Add GenericOp self-copy on buffers folding.

Thank you!

Jan 25 2022, 3:18 AM · Restricted Project

Jan 24 2022

pifon2a added a comment to D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead..

Notes for reviewers:

Jan 24 2022, 4:02 AM · Restricted Project
pifon2a updated the diff for D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead..

another flag.

Jan 24 2022, 4:01 AM · Restricted Project
pifon2a updated the diff for D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead..

fix the flag.

Jan 24 2022, 3:57 AM · Restricted Project
pifon2a updated the diff for D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead..

Rebase

Jan 24 2022, 3:51 AM · Restricted Project
pifon2a requested review of D118028: [mlir] Purge `linalg.copy` and use `memref.copy` instead..
Jan 24 2022, 3:46 AM · Restricted Project

Jan 22 2022

pifon2a added inline comments to D117892: [mlir] Move linalg::PadTensorOp to tensor::PadOp..
Jan 22 2022, 2:48 AM · Restricted Project
pifon2a committed rG4041354b4c12: [mlir] Add SingleBlockImplicitTerminator<"tensor::YieldOp"> to PadOp. (authored by pifon2a).
[mlir] Add SingleBlockImplicitTerminator<"tensor::YieldOp"> to PadOp.
Jan 22 2022, 2:47 AM

Jan 21 2022

pifon2a committed rGfd0c6f53913f: [mlir] Move linalg::PadTensorOp to tensor::PadOp. (authored by pifon2a).
[mlir] Move linalg::PadTensorOp to tensor::PadOp.
Jan 21 2022, 11:03 AM
pifon2a closed D117892: [mlir] Move linalg::PadTensorOp to tensor::PadOp..
Jan 21 2022, 11:02 AM · Restricted Project
pifon2a updated the diff for D117892: [mlir] Move linalg::PadTensorOp to tensor::PadOp..

Fix the wrapped line

Jan 21 2022, 7:34 AM · Restricted Project
pifon2a requested review of D117892: [mlir] Move linalg::PadTensorOp to tensor::PadOp..
Jan 21 2022, 7:29 AM · Restricted Project

Jan 18 2022

pifon2a accepted D117641: [mlir][bufferization] Move one-shot bufferization to Bufferization dialect.

nice!

Jan 18 2022, 11:57 PM · Restricted Project

Jan 14 2022

pifon2a accepted D117314: [mlir][memref] Fix memref.copy of scalar memref.
Jan 14 2022, 7:14 AM · Restricted Project

Jan 13 2022

pifon2a committed rG436d17a8e9e9: [mlir] Expose a function to get vector::CombiningKind from Operation*. (authored by pifon2a).
[mlir] Expose a function to get vector::CombiningKind from Operation*.
Jan 13 2022, 11:28 PM
pifon2a closed D117283: [mlir][nfc] Expose a function to get vector::CombiningKind from Operation*..
Jan 13 2022, 11:28 PM · Restricted Project
pifon2a requested review of D117283: [mlir][nfc] Expose a function to get vector::CombiningKind from Operation*..
Jan 13 2022, 11:24 PM · Restricted Project