Page MenuHomePhabricator

pifon2a (Alexander Belyaev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:48 AM (54 w, 21 h)

Recent Activity

Today

pifon2a committed rGfc58bfd02f8d: [mlir] Remove complex ops from Standard dialect. (authored by pifon2a).
[mlir] Remove complex ops from Standard dialect.
Thu, Jan 21, 1:39 AM
pifon2a closed D95077: [mlir] Remove complex ops from Standard dialect..
Thu, Jan 21, 1:39 AM · Restricted Project

Yesterday

pifon2a requested review of D95077: [mlir] Remove complex ops from Standard dialect..
Wed, Jan 20, 12:28 PM · Restricted Project
pifon2a committed rGb1e1bbae0e30: [mlir] Add ComplexDialect to SCF->GPU pass. (authored by pifon2a).
[mlir] Add ComplexDialect to SCF->GPU pass.
Wed, Jan 20, 12:18 PM
pifon2a accepted D95076: [mlir] Fix SubTensorInsertOp semantics.
Wed, Jan 20, 12:16 PM · Restricted Project
pifon2a accepted D95076: [mlir] Fix SubTensorInsertOp semantics.
Wed, Jan 20, 12:10 PM · Restricted Project
pifon2a accepted D95041: [MLIR][Standard] Add log1p operation to std.
Wed, Jan 20, 8:13 AM · Restricted Project

Tue, Jan 19

pifon2a committed rG11f4c58c153c: [mlir] Add `complex.abs`, `complex.div` and `complex.mul` to ComplexOps. (authored by pifon2a).
[mlir] Add `complex.abs`, `complex.div` and `complex.mul` to ComplexOps.
Tue, Jan 19, 3:10 AM
pifon2a closed D94911: [mlir] Add `complex.abs`, `complex.div` and `complex.mul` to ComplexOps..
Tue, Jan 19, 3:10 AM · Restricted Project
pifon2a updated the diff for D94911: [mlir] Add `complex.abs`, `complex.div` and `complex.mul` to ComplexOps..

Add complex namespace to examples in ComplexOps.td.

Tue, Jan 19, 2:20 AM · Restricted Project
pifon2a updated the diff for D94911: [mlir] Add `complex.abs`, `complex.div` and `complex.mul` to ComplexOps..

Address the comments.

Tue, Jan 19, 2:18 AM · Restricted Project

Mon, Jan 18

pifon2a requested review of D94911: [mlir] Add `complex.abs`, `complex.div` and `complex.mul` to ComplexOps..
Mon, Jan 18, 5:27 AM · Restricted Project

Fri, Jan 15

pifon2a committed rGd0cb0d30a431: [mlir] Add Complex dialect. (authored by pifon2a).
[mlir] Add Complex dialect.
Fri, Jan 15, 11:03 AM
pifon2a closed D94764: [mlir] Add Complex dialect..
Fri, Jan 15, 11:03 AM · Restricted Project
pifon2a updated the diff for D94764: [mlir] Add Complex dialect..

Fix the typo.

Fri, Jan 15, 10:53 AM · Restricted Project
pifon2a updated the diff for D94764: [mlir] Add Complex dialect..

Address the comments.

Fri, Jan 15, 10:51 AM · Restricted Project
pifon2a updated the summary of D94764: [mlir] Add Complex dialect..
Fri, Jan 15, 4:26 AM · Restricted Project
pifon2a requested review of D94764: [mlir] Add Complex dialect..
Fri, Jan 15, 4:25 AM · Restricted Project

Tue, Jan 12

pifon2a accepted D94493: [mlir][Linalg] NFC - Refactor fusion APIs.
Tue, Jan 12, 6:05 AM · Restricted Project

Fri, Jan 8

pifon2a added a reverting change for rG4284afdf9432: [SLP]Need shrink the load vector after reordering.: rGbcbdeafa9cb3: Revert "[SLP]Need shrink the load vector after reordering.".
Fri, Jan 8, 5:43 AM
pifon2a committed rGbcbdeafa9cb3: Revert "[SLP]Need shrink the load vector after reordering." (authored by pifon2a).
Revert "[SLP]Need shrink the load vector after reordering."
Fri, Jan 8, 5:43 AM
pifon2a added a reverting change for D93967: [SLP]Need shrink the load vector after reordering.: rGbcbdeafa9cb3: Revert "[SLP]Need shrink the load vector after reordering.".
Fri, Jan 8, 5:42 AM · Restricted Project
pifon2a added a reverting change for rG6b0ee02747ed: Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer…: rG9c4b2225b24d: Revert "Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic….
Fri, Jan 8, 5:18 AM
pifon2a committed rG9c4b2225b24d: Revert "Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic… (authored by pifon2a).
Revert "Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic…
Fri, Jan 8, 5:18 AM

Tue, Jan 5

pifon2a committed rG89ae5b5b6a47: [mlir] Add canonicalization pattern out_tensor->linalg->dim to out_tensor->dim. (authored by pifon2a).
[mlir] Add canonicalization pattern out_tensor->linalg->dim to out_tensor->dim.
Tue, Jan 5, 6:15 AM
pifon2a closed D94079: [mlir] Add canonicalization pattern out_tensor->linalg->dim to out_tensor->dim..
Tue, Jan 5, 6:15 AM · Restricted Project
pifon2a requested review of D94079: [mlir] Add canonicalization pattern out_tensor->linalg->dim to out_tensor->dim..
Tue, Jan 5, 4:53 AM · Restricted Project

Wed, Dec 30

pifon2a accepted D93947: [mlir] Fix indexing of first offset operand in ops that implement OffsetSizeAndStrideOpInterface.
Wed, Dec 30, 8:50 AM · Restricted Project
pifon2a accepted D93944: Fixes warning 'enumeration value not handled in switch'..

Thank you!

Wed, Dec 30, 6:55 AM · Restricted Project
pifon2a committed rGe47e313d647e: [mlir] Fix a typo MemRefType -> UnrankedMemRefType (authored by pifon2a).
[mlir] Fix a typo MemRefType -> UnrankedMemRefType
Wed, Dec 30, 5:35 AM

Dec 18 2020

pifon2a accepted D93469: [mlir][Linalg] Revisit the Linalg on tensors abstraction.

Thank you, Nicolas!

Dec 18 2020, 11:40 AM · Restricted Project

Dec 17 2020

pifon2a accepted D93180: [mlir][Linalg] Account for the case where loop bounds depend on output shape..
Dec 17 2020, 9:46 AM · Restricted Project
pifon2a accepted D93374: [mlir][Linalg] Define a linalg.init_tensor operation..
Dec 17 2020, 9:45 AM · Restricted Project

Dec 16 2020

pifon2a added a reverting change for rGf8184d4c44df: [mlir] Lookup the latest value with a legal type when remapping values.: rG9ca67d7f4467: Revert "[mlir] Lookup the latest value with a legal type when remapping values.".
Dec 16 2020, 2:09 PM
pifon2a committed rG9ca67d7f4467: Revert "[mlir] Lookup the latest value with a legal type when remapping values." (authored by pifon2a).
Revert "[mlir] Lookup the latest value with a legal type when remapping values."
Dec 16 2020, 2:09 PM
pifon2a added a reverting change for D93126: [mlir] Lookup the latest value with a legal type when remapping values.: rG9ca67d7f4467: Revert "[mlir] Lookup the latest value with a legal type when remapping values.".
Dec 16 2020, 2:09 PM · Restricted Project
pifon2a committed rGf8184d4c44df: [mlir] Lookup the latest value with a legal type when remapping values. (authored by pifon2a).
[mlir] Lookup the latest value with a legal type when remapping values.
Dec 16 2020, 12:53 AM
pifon2a closed D93126: [mlir] Lookup the latest value with a legal type when remapping values..
Dec 16 2020, 12:53 AM · Restricted Project

Dec 15 2020

pifon2a updated the diff for D93126: [mlir] Lookup the latest value with a legal type when remapping values..

Address the comments

Dec 15 2020, 11:43 PM · Restricted Project
pifon2a edited reviewers for D93126: [mlir] Lookup the latest value with a legal type when remapping values., added: rriddle; removed: mravishankar, nicolasvasilache.
Dec 15 2020, 7:06 AM · Restricted Project
pifon2a added a comment to D93126: [mlir] Lookup the latest value with a legal type when remapping values..

Thanks @herhut , now it looks much better.

Dec 15 2020, 7:05 AM · Restricted Project
pifon2a updated the diff for D93126: [mlir] Lookup the latest value with a legal type when remapping values..

Address more comments.

Dec 15 2020, 7:04 AM · Restricted Project
pifon2a retitled D93126: [mlir] Lookup the latest value with a legal type when remapping values. from [mlir] Fix the condition for target materialization attempt. to [mlir] Lookup the latest value with a legal type when remapping values..
Dec 15 2020, 5:59 AM · Restricted Project
pifon2a updated the diff for D93126: [mlir] Lookup the latest value with a legal type when remapping values..

Address the comments.

Dec 15 2020, 5:57 AM · Restricted Project

Dec 11 2020

pifon2a added reviewers for D93126: [mlir] Lookup the latest value with a legal type when remapping values.: mravishankar, nicolasvasilache.
Dec 11 2020, 9:59 AM · Restricted Project
pifon2a requested review of D93126: [mlir] Lookup the latest value with a legal type when remapping values..
Dec 11 2020, 9:14 AM · Restricted Project

Dec 8 2020

pifon2a accepted D92871: [MLIR] Expose target configuration for lowering to NVVM.
Dec 8 2020, 10:43 AM · Restricted Project
pifon2a accepted D92850: Add sqrt lowering from standard to NVVM.
Dec 8 2020, 8:06 AM · Restricted Project
pifon2a accepted D92838: Add rsqrt lowering from standard to NVVM.

Thank you!

Dec 8 2020, 5:23 AM · Restricted Project

Nov 24 2020

pifon2a accepted D92030: [mlir] NFC - Refactor and expose a parsing helper for OffsetSizeAndStrideInterface.
Nov 24 2020, 7:09 AM · Restricted Project
pifon2a accepted D92031: [mlir] NFC - Refactor and expose a helper printOffsetSizesAndStrides helper function..
Nov 24 2020, 7:06 AM · Restricted Project
pifon2a requested changes to D91969: [MLIR] Added support for dynamic shaped allocas to promote-buffers-to-stack pass..
Nov 24 2020, 5:03 AM · Restricted Project
pifon2a added a comment to D82534: [MLIR][Shape] Lower `shape.size_eq` to the standard dialect.

@frgossen this one is obsolete, right? we can probably close it.

Nov 24 2020, 5:03 AM · Restricted Project
pifon2a accepted D92011: [mlir] NFC - Expose an OffsetSizeAndStrideOpInterface.

super-nice!

Nov 24 2020, 5:02 AM · Restricted Project
pifon2a committed rGfd92c5dbeeeb: [mlir][linalg] Add bufferization pattern for `linalg.indexed_generic`. (authored by pifon2a).
[mlir][linalg] Add bufferization pattern for `linalg.indexed_generic`.
Nov 24 2020, 2:15 AM
pifon2a closed D92014: [mlir][linalg] Add bufferization pattern for `linalg.indexed_generic`..
Nov 24 2020, 2:14 AM · Restricted Project
pifon2a requested review of D92014: [mlir][linalg] Add bufferization pattern for `linalg.indexed_generic`..
Nov 24 2020, 2:09 AM · Restricted Project

Nov 23 2020

pifon2a committed rGc6b2c17e9c28: [mlir] Add a print function for memref<*xi64>. (authored by pifon2a).
[mlir] Add a print function for memref<*xi64>.
Nov 23 2020, 7:18 AM
pifon2a closed D91070: [mlir] Add print functions for i64, index..
Nov 23 2020, 7:18 AM · Restricted Project
pifon2a updated the diff for D91070: [mlir] Add print functions for i64, index..

Address the comments.

Nov 23 2020, 6:57 AM · Restricted Project

Nov 9 2020

pifon2a abandoned D90785: [mlir] Move `expand-atomic` to test passes. Enable the pattern in Std2LLVM rewrite..

abandoned in favor of https://reviews.llvm.org/D91082

Nov 9 2020, 1:17 PM · Restricted Project
pifon2a committed rG9d02e0e38df5: [mlir][std] Add ExpandOps pass. (authored by pifon2a).
[mlir][std] Add ExpandOps pass.
Nov 9 2020, 12:59 PM
pifon2a closed D91082: [mlir][std] Add ExpandOps pass..
Nov 9 2020, 12:58 PM · Restricted Project
pifon2a updated the diff for D91082: [mlir][std] Add ExpandOps pass..

Fix CMake.

Nov 9 2020, 12:57 PM · Restricted Project
pifon2a requested review of D91082: [mlir][std] Add ExpandOps pass..
Nov 9 2020, 7:47 AM · Restricted Project
pifon2a accepted D91079: [mlir] Fix bug in use of rewiter for AtomicRMWOp..
Nov 9 2020, 6:59 AM · Restricted Project
pifon2a requested review of D91070: [mlir] Add print functions for i64, index..
Nov 9 2020, 5:44 AM · Restricted Project

Nov 6 2020

pifon2a added a comment to D90785: [mlir] Move `expand-atomic` to test passes. Enable the pattern in Std2LLVM rewrite..

I can imagine users that only want the conversion and prefer to handle expansions differently, by targeting LLVM intrinsics or specific instructions if they go to lower levels without leaving MLIR. Different platforms may support different atomics. This was the argument for keeping tanh expansion outside the conversion to LLVM as far as I recall.

Nov 6 2020, 4:36 AM · Restricted Project

Nov 5 2020

pifon2a committed rGd413f4bc62e5: [mlir] Fix missing namespaces in OpBuildGen.cpp (authored by pifon2a).
[mlir] Fix missing namespaces in OpBuildGen.cpp
Nov 5 2020, 9:13 AM
pifon2a closed D90858: [mlir] Fix missing namespaces in OpBuildGen.cpp.
Nov 5 2020, 9:12 AM · Restricted Project
pifon2a updated the diff for D90858: [mlir] Fix missing namespaces in OpBuildGen.cpp.

Fix mlir-reduce.cpp

Nov 5 2020, 9:12 AM · Restricted Project
pifon2a updated the diff for D90858: [mlir] Fix missing namespaces in OpBuildGen.cpp.

Remove a line

Nov 5 2020, 8:58 AM · Restricted Project
pifon2a requested review of D90858: [mlir] Fix missing namespaces in OpBuildGen.cpp.
Nov 5 2020, 8:55 AM · Restricted Project
pifon2a accepted D90856: [MLIR] Fix missing namespaces in `mlir/unittests/TableGen/OpBuildGen.cpp`.
Nov 5 2020, 8:32 AM · Restricted Project
pifon2a committed rG72c65b698e3a: [mlir] Move TestDialect and its passes to mlir::test namespace. (authored by pifon2a).
[mlir] Move TestDialect and its passes to mlir::test namespace.
Nov 5 2020, 6:30 AM
pifon2a closed D90794: [mlir] Move TestDialect and its passes to mlir::test namespace..
Nov 5 2020, 6:29 AM · Restricted Project

Nov 4 2020

pifon2a requested review of D90794: [mlir] Move TestDialect and its passes to mlir::test namespace..
Nov 4 2020, 1:18 PM · Restricted Project
pifon2a updated the diff for D90785: [mlir] Move `expand-atomic` to test passes. Enable the pattern in Std2LLVM rewrite..

Fix comments.

Nov 4 2020, 12:29 PM · Restricted Project
pifon2a requested review of D90785: [mlir] Move `expand-atomic` to test passes. Enable the pattern in Std2LLVM rewrite..
Nov 4 2020, 12:27 PM · Restricted Project

Nov 3 2020

pifon2a committed rG992516857691: [mlir] Convert `memref_reshape` to LLVM. (authored by pifon2a).
[mlir] Convert `memref_reshape` to LLVM.
Nov 3 2020, 2:39 AM
pifon2a closed D90377: [mlir] Convert `memref_reshape` to LLVM..
Nov 3 2020, 2:39 AM · Restricted Project
pifon2a updated the diff for D90377: [mlir] Convert `memref_reshape` to LLVM..

Address the remaining comments.

Nov 3 2020, 2:36 AM · Restricted Project

Nov 2 2020

pifon2a added inline comments to D90377: [mlir] Convert `memref_reshape` to LLVM..
Nov 2 2020, 1:18 PM · Restricted Project
pifon2a added inline comments to D90377: [mlir] Convert `memref_reshape` to LLVM..
Nov 2 2020, 1:17 PM · Restricted Project
pifon2a updated the diff for D90377: [mlir] Convert `memref_reshape` to LLVM..

Address all of the comments but one.

Nov 2 2020, 1:14 PM · Restricted Project
pifon2a accepted D90205: [mlir] Add func-bufferize pass..
Nov 2 2020, 1:39 AM · Restricted Project
pifon2a accepted D90037: [MLIR] Added test operations to replace linalg and scf in buffer placement tests..

Much nicer! Thank you!

Nov 2 2020, 1:02 AM · Restricted Project

Oct 30 2020

pifon2a accepted D90449: [MLIR] Use `llvm::is_one_of` in walk templates.
Oct 30 2020, 3:25 AM · Restricted Project

Oct 29 2020

pifon2a accepted D90394: [mlir][Linalg] Make Linalg fusion a test pass.
Oct 29 2020, 7:33 AM · Restricted Project
pifon2a accepted D90379: [MLIR] Support walks over regions and blocks.
Oct 29 2020, 7:33 AM · Restricted Project
pifon2a requested changes to D90037: [MLIR] Added test operations to replace linalg and scf in buffer placement tests..
Oct 29 2020, 7:30 AM · Restricted Project
pifon2a added a comment to D90037: [MLIR] Added test operations to replace linalg and scf in buffer placement tests..

Very well, you're almost there.

Oct 29 2020, 7:29 AM · Restricted Project
pifon2a updated the diff for D90377: [mlir] Convert `memref_reshape` to LLVM..

remove print

Oct 29 2020, 4:06 AM · Restricted Project
pifon2a requested review of D90377: [mlir] Convert `memref_reshape` to LLVM..
Oct 29 2020, 3:19 AM · Restricted Project

Oct 28 2020

pifon2a committed rG67760bb2d68d: [mlir] Use OpBuilderDAG for MemRefReinterpretCastOp. (authored by pifon2a).
[mlir] Use OpBuilderDAG for MemRefReinterpretCastOp.
Oct 28 2020, 1:42 PM
pifon2a committed rG7a996027b984: [mlir] Convert memref_reshape to memref_reinterpret_cast. (authored by pifon2a).
[mlir] Convert memref_reshape to memref_reinterpret_cast.
Oct 28 2020, 1:16 PM
pifon2a closed D90235: [mlir] Convert memref_reshape to memref_reinterpret_cast..
Oct 28 2020, 1:15 PM · Restricted Project
pifon2a added inline comments to D90235: [mlir] Convert memref_reshape to memref_reinterpret_cast..
Oct 28 2020, 1:10 PM · Restricted Project
pifon2a updated the diff for D90235: [mlir] Convert memref_reshape to memref_reinterpret_cast..

Remove tabs

Oct 28 2020, 1:10 PM · Restricted Project
pifon2a updated the diff for D90235: [mlir] Convert memref_reshape to memref_reinterpret_cast..

Address the comments.

Oct 28 2020, 1:06 PM · Restricted Project