Page MenuHomePhabricator

pifon2a (Alexander Belyaev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:48 AM (167 w, 5 d)

Recent Activity

Wed, Mar 22

pifon2a committed rGc8117eb96423: [mlir] Add a pattern to fold tensor.cast into scf.forall. (authored by pifon2a).
[mlir] Add a pattern to fold tensor.cast into scf.forall.
Wed, Mar 22, 5:27 AM · Restricted Project, Restricted Project
pifon2a closed D146558: [mlir] Add a pattern to fold tensor.cast into scf.forall..
Wed, Mar 22, 5:26 AM · Restricted Project, Restricted Project
pifon2a added a comment to D146558: [mlir] Add a pattern to fold tensor.cast into scf.forall..

Thank you!

Wed, Mar 22, 4:56 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D146558: [mlir] Add a pattern to fold tensor.cast into scf.forall..

Address the comments.

Wed, Mar 22, 4:56 AM · Restricted Project, Restricted Project

Tue, Mar 21

pifon2a updated the diff for D146558: [mlir] Add a pattern to fold tensor.cast into scf.forall..

Clean-up

Tue, Mar 21, 1:12 PM · Restricted Project, Restricted Project
pifon2a requested review of D146558: [mlir] Add a pattern to fold tensor.cast into scf.forall..
Tue, Mar 21, 1:10 PM · Restricted Project, Restricted Project
pifon2a committed rG3a8f161a3401: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops. (authored by pifon2a).
[mlir] Add a pattern to fold single- and zero-iteration scf.forall ops.
Tue, Mar 21, 4:00 AM · Restricted Project, Restricted Project
pifon2a closed D145368: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops..
Tue, Mar 21, 3:59 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D145368: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops..

address comments

Tue, Mar 21, 3:56 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D145368: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops..

Address the comments.

Tue, Mar 21, 3:48 AM · Restricted Project, Restricted Project

Mon, Mar 20

pifon2a abandoned D122883: [mlir] Add a pass to print content of memrefs and the related ops IR..
Mon, Mar 20, 12:38 PM · Restricted Project, Restricted Project

Tue, Mar 14

pifon2a accepted D146036: Replace `outs` with `inits` in linalg textual assembly.

Thanks!

Tue, Mar 14, 5:24 AM · Restricted Project, Restricted Project

Mon, Mar 13

pifon2a committed rGe7833c20d835: [mlir] Use splitBlock instread of createBlock in GenericAtomicRMWLowering. (authored by pifon2a).
[mlir] Use splitBlock instread of createBlock in GenericAtomicRMWLowering.
Mon, Mar 13, 10:14 AM · Restricted Project, Restricted Project
pifon2a closed D145901: [mlir] Use splitBlock instread of createBlock in GenericAtomicRMWLowering..
Mon, Mar 13, 10:14 AM · Restricted Project, Restricted Project
pifon2a requested review of D145901: [mlir] Use splitBlock instread of createBlock in GenericAtomicRMWLowering..
Mon, Mar 13, 12:34 AM · Restricted Project, Restricted Project

Sun, Mar 12

pifon2a added inline comments to D145368: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops..
Sun, Mar 12, 8:58 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D145368: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops..

Address the comments.

Sun, Mar 12, 8:58 AM · Restricted Project, Restricted Project

Sat, Mar 11

pifon2a accepted D145523: [MLIR] Add label to print-ir pass.
Sat, Mar 11, 2:08 AM · Restricted Project, Restricted Project

Mon, Mar 6

pifon2a updated the diff for D145368: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops..

update the test.

Mon, Mar 6, 4:40 AM · Restricted Project, Restricted Project
pifon2a requested review of D145368: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops..
Mon, Mar 6, 4:24 AM · Restricted Project, Restricted Project

Thu, Mar 2

pifon2a added inline comments to D145133: [mlir][TilingInterface] Modify `TilingInterface` methods to better return the state of the transformed IR..
Thu, Mar 2, 2:34 AM · Restricted Project, Restricted Project
pifon2a committed rG6f3baf438206: [mlir][nfc] Clean-up ConvertToDestinationStyle.cpp. (authored by pifon2a).
[mlir][nfc] Clean-up ConvertToDestinationStyle.cpp.
Thu, Mar 2, 1:32 AM · Restricted Project, Restricted Project
pifon2a closed D145147: [mlir][nfc] Clean-up ConvertToDestinationStyle.cpp..
Thu, Mar 2, 1:32 AM · Restricted Project, Restricted Project
pifon2a requested review of D145147: [mlir][nfc] Clean-up ConvertToDestinationStyle.cpp..
Thu, Mar 2, 1:27 AM · Restricted Project, Restricted Project

Wed, Mar 1

pifon2a accepted D145133: [mlir][TilingInterface] Modify `TilingInterface` methods to better return the state of the transformed IR..
Wed, Mar 1, 11:33 PM · Restricted Project, Restricted Project
pifon2a accepted D144918: [MLIR] Add `print-ir` pass for debugging purposes.
Wed, Mar 1, 11:29 AM · Restricted Project, Restricted Project
pifon2a accepted D144918: [MLIR] Add `print-ir` pass for debugging purposes.
Wed, Mar 1, 11:19 AM · Restricted Project, Restricted Project

Tue, Feb 28

pifon2a added a comment to D144918: [MLIR] Add `print-ir` pass for debugging purposes.

Is it equivalent to mlir-print-ir-after=pass-name ? https://mlir.llvm.org/docs/PassManagement/#ir-printing

Tue, Feb 28, 11:31 PM · Restricted Project, Restricted Project

Mon, Feb 27

pifon2a committed rG9fa61cbb2e8d: [mlir] Insert tensor.cast only when needed when folding tensor.cast into… (authored by pifon2a).
[mlir] Insert tensor.cast only when needed when folding tensor.cast into…
Mon, Feb 27, 6:18 AM · Restricted Project, Restricted Project
pifon2a closed D144868: [mlir] Insert tensor.cast only when needed when folding tensor.cast into extract_slice..
Mon, Feb 27, 6:18 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D144868: [mlir] Insert tensor.cast only when needed when folding tensor.cast into extract_slice..

Update

Mon, Feb 27, 6:16 AM · Restricted Project, Restricted Project
pifon2a requested review of D144868: [mlir] Insert tensor.cast only when needed when folding tensor.cast into extract_slice..
Mon, Feb 27, 6:01 AM · Restricted Project, Restricted Project

Sun, Feb 26

pifon2a accepted D144738: [MLIR] Add pass to deduplicate functions.
Sun, Feb 26, 11:08 PM · Restricted Project, Restricted Project
pifon2a accepted D144735: [MLIR] Expose region equivalence check through OperationEquivalence.
Sun, Feb 26, 11:03 PM · Restricted Project, Restricted Project

Feb 23 2023

pifon2a committed rGa5cdcf49b2f7: [mlir] Fix folding for scf.for(tensor.cast). (authored by pifon2a).
[mlir] Fix folding for scf.for(tensor.cast).
Feb 23 2023, 2:23 AM · Restricted Project, Restricted Project
pifon2a closed D144577: [mlir] Fix folding for scf.for(tensor.cast)..
Feb 23 2023, 2:23 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D144577: [mlir] Fix folding for scf.for(tensor.cast)..

Add a test.

Feb 23 2023, 2:12 AM · Restricted Project, Restricted Project

Feb 22 2023

pifon2a retitled D144577: [mlir] Fix folding for scf.for(tensor.cast). from [mlir] Fix foling for scf.for(tensor.cast). to [mlir] Fix folding for scf.for(tensor.cast)..
Feb 22 2023, 10:58 AM · Restricted Project, Restricted Project
pifon2a requested review of D144577: [mlir] Fix folding for scf.for(tensor.cast)..
Feb 22 2023, 10:54 AM · Restricted Project, Restricted Project
pifon2a committed rG3bf1f0e7530f: [mlir] Add missing patterns for lowering to Libm. (authored by pifon2a).
[mlir] Add missing patterns for lowering to Libm.
Feb 22 2023, 6:50 AM · Restricted Project, Restricted Project
pifon2a closed D144561: [mlir] Add missing patterns for lowering to Libm..
Feb 22 2023, 6:50 AM · Restricted Project, Restricted Project
pifon2a added a reviewer for D144561: [mlir] Add missing patterns for lowering to Libm.: bkramer.
Feb 22 2023, 6:39 AM · Restricted Project, Restricted Project
pifon2a requested review of D144561: [mlir] Add missing patterns for lowering to Libm..
Feb 22 2023, 6:39 AM · Restricted Project, Restricted Project

Feb 21 2023

pifon2a added a comment to D144450: [mlir] Clean-up math -> libm/llvm conversion..

@pifon2a, this change broke the flang build. Can you please fix it sooner?

Feb 21 2023, 11:05 AM · Restricted Project, Restricted Project
pifon2a abandoned D106066: [mlir] Introduce `linalg.tiled_yield` terminator for `linalg.tiled_loop`..
Feb 21 2023, 10:52 AM · Restricted Project, Restricted Project
pifon2a committed rGd61a3d3a9b95: [flang] Remove parameter for libm mlir::populateMathToLibmConversionPatterns. (authored by pifon2a).
[flang] Remove parameter for libm mlir::populateMathToLibmConversionPatterns.
Feb 21 2023, 10:43 AM · Restricted Project, Restricted Project
pifon2a committed rG25dbf8f3c66b: [mlir] Use foldDynamicIndexList instead of canonicalizeSubViewPart. (authored by pifon2a).
[mlir] Use foldDynamicIndexList instead of canonicalizeSubViewPart.
Feb 21 2023, 10:28 AM · Restricted Project, Restricted Project
pifon2a closed D144452: [mlir] Use foldDynamicIndexList instead of canonicalizeSubViewPart..
Feb 21 2023, 10:28 AM · Restricted Project, Restricted Project
pifon2a committed rG8a9d4895df78: [mlir] Clean-up math -> libm/llvm conversion. (authored by pifon2a).
[mlir] Clean-up math -> libm/llvm conversion.
Feb 21 2023, 10:22 AM · Restricted Project, Restricted Project
pifon2a closed D144450: [mlir] Clean-up math -> libm/llvm conversion..
Feb 21 2023, 10:22 AM · Restricted Project, Restricted Project
pifon2a requested review of D144452: [mlir] Use foldDynamicIndexList instead of canonicalizeSubViewPart..
Feb 21 2023, 12:16 AM · Restricted Project, Restricted Project

Feb 20 2023

pifon2a requested review of D144450: [mlir] Clean-up math -> libm/llvm conversion..
Feb 20 2023, 11:19 PM · Restricted Project, Restricted Project
pifon2a accepted D144389: [mlir][bufferization] Fix crash in EmptyTensorElimination.
Feb 20 2023, 6:38 AM · Restricted Project, Restricted Project

Feb 17 2023

pifon2a committed rGcdf8f064694c: [mlir] Add a folder for lbs, ubs, steps of scf.forall. (authored by pifon2a).
[mlir] Add a folder for lbs, ubs, steps of scf.forall.
Feb 17 2023, 2:05 AM · Restricted Project, Restricted Project
pifon2a closed D144245: [mlir] Add a folder for lbs, ubs, steps of scf.forall..
Feb 17 2023, 2:05 AM · Restricted Project, Restricted Project
pifon2a requested review of D144245: [mlir] Add a folder for lbs, ubs, steps of scf.forall..
Feb 17 2023, 2:01 AM · Restricted Project, Restricted Project
pifon2a committed rGeb2f946e780c: [mlir][scf] Rename ForeachThreadOp->ForallOp, PerformConcurrentlyOp… (authored by pifon2a).
[mlir][scf] Rename ForeachThreadOp->ForallOp, PerformConcurrentlyOp…
Feb 17 2023, 1:02 AM · Restricted Project, Restricted Project
pifon2a closed D144242: [mlir][scf] Rename ForeachThreadOp->ForallOp, PerformConcurrentlyOp->InParallelOp..
Feb 17 2023, 1:02 AM · Restricted Project, Restricted Project
pifon2a added a comment to D144242: [mlir][scf] Rename ForeachThreadOp->ForallOp, PerformConcurrentlyOp->InParallelOp..

I used

Feb 17 2023, 12:36 AM · Restricted Project, Restricted Project
pifon2a updated the summary of D144242: [mlir][scf] Rename ForeachThreadOp->ForallOp, PerformConcurrentlyOp->InParallelOp..
Feb 17 2023, 12:31 AM · Restricted Project, Restricted Project
pifon2a requested review of D144242: [mlir][scf] Rename ForeachThreadOp->ForallOp, PerformConcurrentlyOp->InParallelOp..
Feb 17 2023, 12:31 AM · Restricted Project, Restricted Project

Feb 16 2023

pifon2a committed rG310deca248c8: [mlir] Add loop bounds to scf.foreach_thread. (authored by pifon2a).
[mlir] Add loop bounds to scf.foreach_thread.
Feb 16 2023, 11:58 PM · Restricted Project, Restricted Project
pifon2a closed D144072: [mlir] Add loop bounds to scf.foreach_thread..
Feb 16 2023, 11:58 PM · Restricted Project, Restricted Project
pifon2a updated the diff for D144072: [mlir] Add loop bounds to scf.foreach_thread..

Update tests

Feb 16 2023, 11:55 PM · Restricted Project, Restricted Project
pifon2a updated the diff for D144072: [mlir] Add loop bounds to scf.foreach_thread..

rebase

Feb 16 2023, 11:37 PM · Restricted Project, Restricted Project
pifon2a updated the diff for D144072: [mlir] Add loop bounds to scf.foreach_thread..

remove logging

Feb 16 2023, 11:30 PM · Restricted Project, Restricted Project
pifon2a updated the diff for D144072: [mlir] Add loop bounds to scf.foreach_thread..

Update.

Feb 16 2023, 12:31 PM · Restricted Project, Restricted Project
pifon2a updated the diff for D144072: [mlir] Add loop bounds to scf.foreach_thread..

Introduce mixed form.

Feb 16 2023, 12:29 PM · Restricted Project, Restricted Project

Feb 15 2023

pifon2a retitled D144072: [mlir] Add loop bounds to scf.foreach_thread. from [mlir] Add loop bounds to scf.foreach_thread and rename it to scf.forall. to [mlir] Add loop bounds to scf.foreach_thread..
Feb 15 2023, 6:19 AM · Restricted Project, Restricted Project
pifon2a added a comment to D144072: [mlir] Add loop bounds to scf.foreach_thread..

"Is anybody out there?"

Feb 15 2023, 6:19 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D144072: [mlir] Add loop bounds to scf.foreach_thread..

Revert unchanged file.

Feb 15 2023, 2:38 AM · Restricted Project, Restricted Project
pifon2a added a comment to D144072: [mlir] Add loop bounds to scf.foreach_thread..

Reconsidered :)

Feb 15 2023, 2:37 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D144072: [mlir] Add loop bounds to scf.foreach_thread..

Update.

Feb 15 2023, 2:36 AM · Restricted Project, Restricted Project
pifon2a added a comment to D144072: [mlir] Add loop bounds to scf.foreach_thread..

Would it make sense to split this PR into two: rename and addition of step/lb/ub?

Feb 15 2023, 12:20 AM · Restricted Project, Restricted Project

Feb 14 2023

pifon2a added a reviewer for D144072: [mlir] Add loop bounds to scf.foreach_thread.: chelini.
Feb 14 2023, 11:23 PM · Restricted Project, Restricted Project
pifon2a requested review of D144072: [mlir] Add loop bounds to scf.foreach_thread..
Feb 14 2023, 11:14 PM · Restricted Project, Restricted Project

Feb 1 2023

pifon2a accepted D143063: [mlir][tensor][bufferize] Implement getBufferType for CastOp.
Feb 1 2023, 4:02 AM · Restricted Project, Restricted Project

Jan 30 2023

pifon2a committed rGdc37dc824aab: [mlir] Remove Linalg fusion-on-memrefs. (authored by pifon2a).
[mlir] Remove Linalg fusion-on-memrefs.
Jan 30 2023, 5:42 AM · Restricted Project, Restricted Project
pifon2a closed D141807: [mlir] Remove Linalg fusion-on-memrefs..
Jan 30 2023, 5:42 AM · Restricted Project, Restricted Project
pifon2a updated the diff for D141807: [mlir] Remove Linalg fusion-on-memrefs..

Rebase

Jan 30 2023, 5:04 AM · Restricted Project, Restricted Project

Jan 27 2023

pifon2a accepted D142729: [mlir] provide a base class for transform interpreter passes.

Thank you!

Jan 27 2023, 8:45 AM · Restricted Project, Restricted Project

Jan 26 2023

pifon2a resigned from D142557: [mlir][Linalg] Fix crash when converting rank-reduced tensor.insert_slice.

I think the core logic being fixed here is not something I worked on, so I dont have full context. Adding folks who worked on this as reviewers...

Jan 26 2023, 9:47 AM · Restricted Project, Restricted Project

Jan 20 2023

pifon2a accepted D142056: [MLIR] Remove scf.if builder with explicit result types and callbacks.
Jan 20 2023, 7:47 AM · Restricted Project, Restricted Project
pifon2a accepted D142155: [MLIR] Address post-submit comments on scf.if's InferTypeOpInterface.
Jan 20 2023, 6:25 AM · Restricted Project, Restricted Project

Jan 19 2023

pifon2a added inline comments to D142049: [MLIR] Add InferTypeOpInterface to scf.if op.
Jan 19 2023, 10:31 AM · Restricted Project, Restricted Project
pifon2a added a comment to D141804: [mlir][linalg] Omit printing result types for named ops..

For instance developers often store models/IR in linalg format to be able to work in isolation of the front end. Those kind of changes forces them to regenerate models.

Jan 19 2023, 10:30 AM · Restricted Project, Restricted Project
pifon2a accepted D142131: [Linalg] Don't create complex vectors when vectorizing copies.
Jan 19 2023, 10:13 AM · Restricted Project, Restricted Project
pifon2a accepted D142049: [MLIR] Add InferTypeOpInterface to scf.if op.
Jan 19 2023, 8:13 AM · Restricted Project, Restricted Project

Jan 18 2023

pifon2a accepted D142011: [mlir][linalg][bufferize][NFC] Utilize DestinationStyleOpInterface helper.
Jan 18 2023, 6:10 AM · Restricted Project, Restricted Project

Jan 17 2023

pifon2a added a comment to D141804: [mlir][linalg] Omit printing result types for named ops..

So, it looks like launching a sed command is churn. Comments are not churn, even though they take much more time and effort.

Jan 17 2023, 8:34 AM · Restricted Project, Restricted Project
pifon2a added a comment to D141804: [mlir][linalg] Omit printing result types for named ops..

Interesting, and in this case we cannot infer the result type based on operands? Isn’t the result type always matching the outs tensors?

I think Mehdi has a good point about spending more time on design. I agree clean ups are nice, however I feel like the incremental breaking changes are causing the problem and we shouldn’t take those lightly. I believe there has been several syntax changes proposed to linalg ops in the recent past? Should we make sure we have a syntax that won’t need more change in the near future before make those changes? (Maybe it is worth a quick chat on discourse to make sure we address all the potential syntax problems at once and not continuously break users). What do you think?

Jan 17 2023, 5:59 AM · Restricted Project, Restricted Project
pifon2a added a comment to D141804: [mlir][linalg] Omit printing result types for named ops..

@ThomasRaoux I would really like to do that, but linalg.generic allows the mixed case, when you have memrefs and tensors at the same time and some folks are using it for some reason.

Jan 17 2023, 1:53 AM · Restricted Project, Restricted Project

Jan 16 2023

pifon2a updated the summary of D141804: [mlir][linalg] Omit printing result types for named ops..
Jan 16 2023, 2:29 PM · Restricted Project, Restricted Project
pifon2a retitled D141804: [mlir][linalg] Omit printing result types for named ops. from [mlir] Omit printing result types for named ops. to [mlir][linalg] Omit printing result types for named ops..
Jan 16 2023, 2:29 PM · Restricted Project, Restricted Project
pifon2a added a comment to D141804: [mlir][linalg] Omit printing result types for named ops..

This is an unnecessary change that just causes downstream churn. Not sure it is worth it

Jan 16 2023, 2:57 AM · Restricted Project, Restricted Project

Jan 15 2023

pifon2a added a comment to D141807: [mlir] Remove Linalg fusion-on-memrefs..

Actually when I deleted some similar code I posted a PSA for it (https://discourse.llvm.org/t/psa-retire-tileandfuselinalgops-method/63850). There might be users of this that might be using this in a load-bearing fashion. Better to get community input first.

Jan 15 2023, 11:58 PM · Restricted Project, Restricted Project
pifon2a requested review of D141807: [mlir] Remove Linalg fusion-on-memrefs..
Jan 15 2023, 3:31 PM · Restricted Project, Restricted Project
pifon2a requested review of D141804: [mlir][linalg] Omit printing result types for named ops..
Jan 15 2023, 2:57 PM · Restricted Project, Restricted Project

Jan 14 2023

pifon2a added a comment to D141703: [MLIR] Add `OpFoldResult` builder to tensor.dim op.

Why is this needed? DimOp always takes Value for the dimension index. There is no index attribute, which would allow to fold constants into the dimOp. With the current DimOp it is easier to call getValueOrCreateConstantIndexOp when DimOp::build is called.

Jan 14 2023, 6:22 AM · Restricted Project, Restricted Project

Jan 13 2023

pifon2a abandoned D138298: [mlir][DO-NOT-REVIEW-IT-IS-A-DRAFT] updated getTiledImplementation.
Jan 13 2023, 5:35 AM · Restricted Project, Restricted Project