Page MenuHomePhabricator

pifon2a (Alexander Belyaev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:48 AM (12 w, 6 d)

Recent Activity

Mon, Apr 6

pifon2a committed rGc2d03e4ef141: [MLIR] Change return type of ParallelOp::getInductionVars to ValueRange. (authored by pifon2a).
[MLIR] Change return type of ParallelOp::getInductionVars to ValueRange.
Mon, Apr 6, 1:36 AM
pifon2a closed D77526: [MLIR] Change return type of ParallelOp::getInductionVars to ValueRange..
Mon, Apr 6, 1:36 AM · Restricted Project
pifon2a added a comment to D77526: [MLIR] Change return type of ParallelOp::getInductionVars to ValueRange..

@mehdi_amini done, thanks!

Mon, Apr 6, 1:03 AM · Restricted Project
pifon2a updated the summary of D77526: [MLIR] Change return type of ParallelOp::getInductionVars to ValueRange..
Mon, Apr 6, 1:03 AM · Restricted Project
pifon2a created D77526: [MLIR] Change return type of ParallelOp::getInductionVars to ValueRange..
Mon, Apr 6, 12:29 AM · Restricted Project
pifon2a updated the summary of D77526: [MLIR] Change return type of ParallelOp::getInductionVars to ValueRange..
Mon, Apr 6, 12:29 AM · Restricted Project

Sun, Apr 5

pifon2a committed rG51e3709c2b90: [MLIR] Don't insert YieldOp for non-void loop.for by default. (authored by pifon2a).
[MLIR] Don't insert YieldOp for non-void loop.for by default.
Sun, Apr 5, 3:11 AM
pifon2a abandoned D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default..
Sun, Apr 5, 3:11 AM · Restricted Project
pifon2a added a comment to D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default..

https://github.com/llvm/llvm-project/commit/51e3709c2b9055fe9e6fc83fc7f056bd55b2aaa6

Sun, Apr 5, 3:11 AM · Restricted Project
pifon2a updated the diff for D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default..

Formatting.

Sun, Apr 5, 3:11 AM · Restricted Project

Fri, Apr 3

pifon2a added a comment to D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default..

Commit summary please - even if it's a couple of lines. It's not clear from the title why the 'for' block won't be missing a terminator.

Fri, Apr 3, 9:07 AM · Restricted Project
pifon2a updated the diff for D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default..

Updated docs in .td.

Fri, Apr 3, 9:07 AM · Restricted Project
pifon2a updated the summary of D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default..
Fri, Apr 3, 9:07 AM · Restricted Project
pifon2a updated the diff for D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default..

Improved commit description

Fri, Apr 3, 9:07 AM · Restricted Project
pifon2a updated the diff for D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default..

Reformat.

Fri, Apr 3, 6:56 AM · Restricted Project
pifon2a edited reviewers for D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default., added: ftynse, herhut; removed: nicolasvasilache.
Fri, Apr 3, 6:56 AM · Restricted Project
pifon2a created D77389: [MLIR] Don't insert YieldOp for non-void loop.for by default..
Fri, Apr 3, 6:56 AM · Restricted Project

Wed, Mar 25

pifon2a committed rGdf48e3920a56: [Clang] Fix clang-tidy errors. (authored by pifon2a).
[Clang] Fix clang-tidy errors.
Wed, Mar 25, 12:28 PM

Tue, Mar 24

pifon2a committed rG10bd8422d041: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test. (authored by pifon2a).
[ARM][CMSE] Fix clang/test/Driver/save-temps.c test.
Tue, Mar 24, 7:30 AM
pifon2a closed D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test..
Tue, Mar 24, 7:30 AM · Restricted Project
pifon2a added reviewers for D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.: bkramer, momchil.velikov.
Tue, Mar 24, 7:29 AM · Restricted Project
pifon2a created D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test..
Tue, Mar 24, 7:29 AM · Restricted Project

Mon, Mar 23

pifon2a committed rG564ece93b836: [MLIR] Insert loop.yield to IfOp regions only if it's void. (authored by pifon2a).
[MLIR] Insert loop.yield to IfOp regions only if it's void.
Mon, Mar 23, 3:49 PM
pifon2a closed D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..
Mon, Mar 23, 3:49 PM · Restricted Project
pifon2a updated the diff for D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..

remove more whitespaces

Mon, Mar 23, 3:48 PM · Restricted Project
pifon2a updated the diff for D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..

Fixing stuff.

Mon, Mar 23, 3:16 PM · Restricted Project
pifon2a added a comment to D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..

@nmostafa thank you!

Mon, Mar 23, 2:43 PM · Restricted Project
pifon2a retitled D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void. from [MLIR] Refactor builder of `loop.if` op with support of non-void ops. to [MLIR] Insert loop.yield to IfOp regions only if it's void..
Mon, Mar 23, 2:43 PM · Restricted Project
pifon2a updated the diff for D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..

Remove whitespace.

Mon, Mar 23, 2:43 PM · Restricted Project
pifon2a updated the diff for D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..

Addressed the comments.

Mon, Mar 23, 2:43 PM · Restricted Project
pifon2a edited reviewers for D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void., added: nmostafa; removed: ftynse.
Mon, Mar 23, 1:38 PM · Restricted Project
pifon2a retitled D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void. from [MLIR] Extend builder of `loop.if` op to support non-void ops. to [MLIR] Refactor builder of `loop.if` op with support of non-void ops..
Mon, Mar 23, 1:38 PM · Restricted Project
pifon2a updated the diff for D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..

Resolve merge conflicts.

Mon, Mar 23, 1:38 PM · Restricted Project
pifon2a abandoned D76628: [MLIR] Remove guard for registerTestConvertGPUKernelToCubinPass() def..
Mon, Mar 23, 10:21 AM · Restricted Project
pifon2a edited reviewers for D76628: [MLIR] Remove guard for registerTestConvertGPUKernelToCubinPass() def., added: bkramer; removed: herhut.
Mon, Mar 23, 10:21 AM · Restricted Project
pifon2a created D76628: [MLIR] Remove guard for registerTestConvertGPUKernelToCubinPass() def..
Mon, Mar 23, 10:21 AM · Restricted Project
pifon2a closed D75832: [MLIR] Change custom printer/parser for loop.parallel and loop.reduce..

it was already submitted in https://github.com/llvm/llvm-project/commit/3147342ae7ef9470f879fd62bac6b0786a4f0d65

Mon, Mar 23, 5:26 AM · Restricted Project
pifon2a added a reviewer for D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void.: ftynse.
Mon, Mar 23, 5:26 AM · Restricted Project
pifon2a created D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void..
Mon, Mar 23, 5:26 AM · Restricted Project

Thu, Mar 12

pifon2a committed rG9f5d9bf2470d: [MLIR] Reformat LoopOps.td documentation. (authored by pifon2a).
[MLIR] Reformat LoopOps.td documentation.
Thu, Mar 12, 2:07 PM
pifon2a committed rGc0735b2c210e: [MLIR] Update documentation for loop.reduce. (authored by pifon2a).
[MLIR] Update documentation for loop.reduce.
Thu, Mar 12, 1:37 PM

Mar 9 2020

pifon2a committed rG3147342ae7ef: [MLIR] Change custom printer/parser for loop.parallel and loop.reduce. (authored by pifon2a).
[MLIR] Change custom printer/parser for loop.parallel and loop.reduce.
Mar 9 2020, 7:31 AM
pifon2a updated the diff for D75832: [MLIR] Change custom printer/parser for loop.parallel and loop.reduce..

Addressed the comments.

Mar 9 2020, 7:30 AM · Restricted Project

Mar 8 2020

pifon2a edited reviewers for D75832: [MLIR] Change custom printer/parser for loop.parallel and loop.reduce., added: mehdi_amini, herhut, ftynse; removed: nicolasvasilache.
Mar 8 2020, 3:59 PM · Restricted Project
pifon2a added a comment to D75832: [MLIR] Change custom printer/parser for loop.parallel and loop.reduce..

If it does improve readability, let's change the format.

Mar 8 2020, 3:27 PM · Restricted Project
pifon2a added inline comments to D75206: [MLIR] Add explicit initial values for loop.parallel op..
Mar 8 2020, 3:27 PM · Restricted Project
pifon2a created D75832: [MLIR] Change custom printer/parser for loop.parallel and loop.reduce..
Mar 8 2020, 3:27 PM · Restricted Project
pifon2a accepted D75831: [mlir][Linalg] Revisit 0-D abstraction.

Awesome! Thank you for doing this, @nicolasvasilache!

Mar 8 2020, 1:52 PM · Restricted Project

Mar 4 2020

pifon2a committed rGffcb4923275d: [MLIR] Add a comment to `requiredOperandCount` arg in LoopOps.cpp. (authored by pifon2a).
[MLIR] Add a comment to `requiredOperandCount` arg in LoopOps.cpp.
Mar 4 2020, 7:20 AM
pifon2a closed D75578: [MLIR] Add a comment to `requiredOperandCount` arg in LoopOps.cpp..
Mar 4 2020, 7:20 AM · Restricted Project
pifon2a accepted D75599: [mlir] support conversion of parallel reduction loops to std.

Thank you for doing that!

Mar 4 2020, 6:44 AM · Restricted Project

Mar 3 2020

pifon2a committed rGe0ce85227784: [MLIR] Expose makeCanonicalStridedLayoutExpr in StandardTypes.h. (authored by pifon2a).
[MLIR] Expose makeCanonicalStridedLayoutExpr in StandardTypes.h.
Mar 3 2020, 4:09 PM
pifon2a closed D75575: [MLIR] Expose makeCanonicalStridedLayoutExpr in StandardTypes.h..
Mar 3 2020, 4:09 PM · Restricted Project
pifon2a edited reviewers for D75578: [MLIR] Add a comment to `requiredOperandCount` arg in LoopOps.cpp., added: rriddle; removed: nicolasvasilache.
Mar 3 2020, 4:07 PM · Restricted Project
pifon2a created D75578: [MLIR] Add a comment to `requiredOperandCount` arg in LoopOps.cpp..
Mar 3 2020, 4:07 PM · Restricted Project
pifon2a updated the diff for D75575: [MLIR] Expose makeCanonicalStridedLayoutExpr in StandardTypes.h..

Addressed the comment.

Mar 3 2020, 4:07 PM · Restricted Project
pifon2a created D75575: [MLIR] Expose makeCanonicalStridedLayoutExpr in StandardTypes.h..
Mar 3 2020, 3:00 PM · Restricted Project
pifon2a added a reviewer for D75575: [MLIR] Expose makeCanonicalStridedLayoutExpr in StandardTypes.h.: nicolasvasilache.
Mar 3 2020, 3:00 PM · Restricted Project
pifon2a added a comment to D75206: [MLIR] Add explicit initial values for loop.parallel op..

Addressed the comments.

Mar 3 2020, 6:40 AM · Restricted Project
pifon2a committed rG0145a26c652e: [MLIR] Add explicit initial values for loop.parallel op. (authored by pifon2a).
[MLIR] Add explicit initial values for loop.parallel op.
Mar 3 2020, 6:39 AM
pifon2a closed D75206: [MLIR] Add explicit initial values for loop.parallel op..
Mar 3 2020, 6:38 AM · Restricted Project
pifon2a accepted D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM..
Mar 3 2020, 6:02 AM · Restricted Project

Feb 28 2020

pifon2a abandoned D74544: [MLIR] Add naive fusion of parallel loops..
Feb 28 2020, 8:51 AM · Restricted Project
pifon2a accepted D75309: [mlir] Add reifyReturnShape to shaped type OpInterface.
Feb 28 2020, 8:42 AM · Restricted Project

Feb 27 2020

pifon2a added inline comments to D75309: [mlir] Add reifyReturnShape to shaped type OpInterface.
Feb 27 2020, 4:11 PM · Restricted Project

Feb 26 2020

pifon2a committed rGaff8c045a225: [MLIR] Add `take_back()` to STLExtras.h for completeness. (authored by pifon2a).
[MLIR] Add `take_back()` to STLExtras.h for completeness.
Feb 26 2020, 9:53 PM
pifon2a closed D75208: [MLIR] Add `take_back()` to STLExtras.h for completeness..
Feb 26 2020, 9:53 PM · Restricted Project
pifon2a created D75208: [MLIR] Add `take_back()` to STLExtras.h for completeness..
Feb 26 2020, 12:17 PM · Restricted Project
pifon2a added a reviewer for D75208: [MLIR] Add `take_back()` to STLExtras.h for completeness.: rriddle.
Feb 26 2020, 12:17 PM · Restricted Project
pifon2a added reviewers for D75206: [MLIR] Add explicit initial values for loop.parallel op.: herhut, mehdi_amini.
Feb 26 2020, 12:09 PM · Restricted Project
pifon2a created D75206: [MLIR] Add explicit initial values for loop.parallel op..
Feb 26 2020, 12:08 PM · Restricted Project
pifon2a added a comment to D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp..

@mehdi_amini @nicolasvasilache I am working on a PR that passes initial values to loop.parallel. After that PR this new builder won't be needed.

Feb 26 2020, 9:03 AM · Restricted Project

Feb 19 2020

pifon2a committed rGd8916e58cf1c: Remove debugging artefact. (authored by pifon2a).
Remove debugging artefact.
Feb 19 2020, 11:37 PM
pifon2a committed rG284279ac23a9: [MLIR] Add naive fusion of parallel loops. (authored by pifon2a).
[MLIR] Add naive fusion of parallel loops.
Feb 19 2020, 5:53 AM
pifon2a added inline comments to D74544: [MLIR] Add naive fusion of parallel loops..
Feb 19 2020, 4:42 AM · Restricted Project
pifon2a updated the diff for D74544: [MLIR] Add naive fusion of parallel loops..

Blabla

Feb 19 2020, 4:42 AM · Restricted Project
pifon2a updated the diff for D74544: [MLIR] Add naive fusion of parallel loops..

_

Feb 19 2020, 3:21 AM · Restricted Project
pifon2a updated the diff for D74544: [MLIR] Add naive fusion of parallel loops..

Unify deps check.

Feb 19 2020, 2:13 AM · Restricted Project
pifon2a committed rG9ed920444f66: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp. (authored by pifon2a).
[MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp.
Feb 19 2020, 1:27 AM
pifon2a closed D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp..
Feb 19 2020, 1:27 AM · Restricted Project
pifon2a added inline comments to D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp..
Feb 19 2020, 12:58 AM · Restricted Project
pifon2a updated the diff for D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp..

Doc mod

Feb 19 2020, 12:49 AM · Restricted Project

Feb 18 2020

pifon2a added inline comments to D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp..
Feb 18 2020, 11:10 PM · Restricted Project
pifon2a updated the diff for D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp..

Addressed most comments.

Feb 18 2020, 11:10 PM · Restricted Project
pifon2a updated the diff for D74544: [MLIR] Add naive fusion of parallel loops..

BB

Feb 18 2020, 5:54 AM · Restricted Project
pifon2a updated the diff for D74544: [MLIR] Add naive fusion of parallel loops..

AAAAAAAAAAAAA

Feb 18 2020, 5:00 AM · Restricted Project
pifon2a updated the diff for D74544: [MLIR] Add naive fusion of parallel loops..

Addressed the comments again.

Feb 18 2020, 4:56 AM · Restricted Project
pifon2a added inline comments to D74544: [MLIR] Add naive fusion of parallel loops..
Feb 18 2020, 1:55 AM · Restricted Project
pifon2a updated the diff for D74544: [MLIR] Add naive fusion of parallel loops..

Addressed the comments.

Feb 18 2020, 1:46 AM · Restricted Project

Feb 17 2020

pifon2a created D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp..
Feb 17 2020, 5:39 AM · Restricted Project

Feb 14 2020

pifon2a updated the diff for D74544: [MLIR] Add naive fusion of parallel loops..

Fixed CMake build.

Feb 14 2020, 3:33 AM · Restricted Project

Feb 13 2020

pifon2a added inline comments to D74544: [MLIR] Add naive fusion of parallel loops..
Feb 13 2020, 11:29 PM · Restricted Project
pifon2a added inline comments to D74544: [MLIR] Add naive fusion of parallel loops..
Feb 13 2020, 11:20 PM · Restricted Project
pifon2a updated the diff for D74544: [MLIR] Add naive fusion of parallel loops..

Addressed the comments.

Feb 13 2020, 11:20 PM · Restricted Project
pifon2a committed rG70e6ed1db709: Add '#include <functional>` to PassManager.h. (authored by pifon2a).
Add '#include <functional>` to PassManager.h.
Feb 13 2020, 5:50 AM
pifon2a closed D74469: Add '#include <functional>` to PassManager.h..
Feb 13 2020, 5:50 AM · Restricted Project
pifon2a created D74544: [MLIR] Add naive fusion of parallel loops..
Feb 13 2020, 4:37 AM · Restricted Project

Feb 12 2020

pifon2a updated the summary of D74469: Add '#include <functional>` to PassManager.h..
Feb 12 2020, 10:25 PM · Restricted Project
pifon2a updated the diff for D74469: Add '#include <functional>` to PassManager.h..

Update the description.

Feb 12 2020, 10:25 PM · Restricted Project
pifon2a created D74469: Add '#include <functional>` to PassManager.h..
Feb 12 2020, 1:20 AM · Restricted Project