Page MenuHomePhabricator

pifon2a (Alexander Belyaev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:48 AM (74 w, 2 d)

Recent Activity

Yesterday

pifon2a accepted D104095: [mlir] Refactor ComplexOps.td [NFC].
Fri, Jun 11, 12:50 AM · Restricted Project
pifon2a accepted D104095: [mlir] Refactor ComplexOps.td [NFC].

Nice! Thanks!

Fri, Jun 11, 12:42 AM · Restricted Project

Mon, Jun 7

pifon2a accepted D103826: [mlir] fix integer type mismatch in alloc conversion to LLVM.
Mon, Jun 7, 9:39 AM · Restricted Project

Thu, Jun 3

pifon2a committed rG89df483d30bb: [mlir] Fix warnings. (authored by pifon2a).
[mlir] Fix warnings.
Thu, Jun 3, 8:09 AM
pifon2a committed rG485c21be8ac3: [mlir] Split linalg reshape ops into expand/collapse. (authored by pifon2a).
[mlir] Split linalg reshape ops into expand/collapse.
Thu, Jun 3, 2:40 AM
pifon2a closed D103548: [mlir] Split linalg reshape ops into expand/collapse..
Thu, Jun 3, 2:40 AM · Restricted Project
pifon2a updated the diff for D103548: [mlir] Split linalg reshape ops into expand/collapse..

Rebase

Thu, Jun 3, 2:34 AM · Restricted Project

Wed, Jun 2

pifon2a requested review of D103548: [mlir] Split linalg reshape ops into expand/collapse..
Wed, Jun 2, 11:57 AM · Restricted Project
pifon2a accepted D103507: [mlir] Add DivOp lowering from Complex dialect to Standard/Math dialect..

Thank you, Adrian!

Wed, Jun 2, 1:44 AM · Restricted Project

Mon, May 31

pifon2a accepted D103403: [MLIR][Shape] Remove duplicate operands of `shape.assuming_all` op.
Mon, May 31, 5:15 AM · Restricted Project

Thu, May 27

pifon2a committed rG62686a47a448: [mlir] Add TestLinalgDistribution.cpp to cmake build. (authored by pifon2a).
[mlir] Add TestLinalgDistribution.cpp to cmake build.
Thu, May 27, 12:00 AM

Wed, May 26

pifon2a committed rG281ee4291110: [mlir] Add a pass to distribute linalg::TiledLoopOp. (authored by pifon2a).
[mlir] Add a pass to distribute linalg::TiledLoopOp.
Wed, May 26, 11:46 PM
pifon2a closed D103194: [mlir] Add a pass to distribute linalg::TiledLoopOp..
Wed, May 26, 11:45 PM · Restricted Project
pifon2a requested review of D103194: [mlir] Add a pass to distribute linalg::TiledLoopOp..
Wed, May 26, 11:23 AM · Restricted Project
pifon2a accepted D103187: [mlir] Make StripDebugInfo strip out block arguments locs.
Wed, May 26, 11:02 AM · Restricted Project
pifon2a committed rG74a89cba8ced: [mlir] Add `distributionTypes` to LinalgTilingOptions. (authored by pifon2a).
[mlir] Add `distributionTypes` to LinalgTilingOptions.
Wed, May 26, 8:52 AM
pifon2a closed D103161: [mlir] Add `distributionTypes` to LinalgTilingOptions..
Wed, May 26, 8:51 AM · Restricted Project
pifon2a requested review of D103161: [mlir] Add `distributionTypes` to LinalgTilingOptions..
Wed, May 26, 5:36 AM · Restricted Project
pifon2a accepted D103148: [mlir] Fold complex.create(complex.re(op), complex.im(op)).
Wed, May 26, 4:55 AM · Restricted Project
pifon2a accepted D103141: [mlir] Fold complex.re(complex.create) and complex.im(complex.create).
Wed, May 26, 1:51 AM · Restricted Project

Tue, May 25

pifon2a committed rG2ea6e13bf818: [mlir] Add an optional distributionTypes attribute to TiledLoopOp. (authored by pifon2a).
[mlir] Add an optional distributionTypes attribute to TiledLoopOp.
Tue, May 25, 11:05 AM
pifon2a closed D103104: [mlir] Add an optional distributionTypes attribute to TiledLoopOp..
Tue, May 25, 11:05 AM · Restricted Project
pifon2a requested review of D103104: [mlir] Add an optional distributionTypes attribute to TiledLoopOp..
Tue, May 25, 10:53 AM · Restricted Project
pifon2a closed D102838: [mlir] Add EqualOp and NotEqualOp to complex dialect..

https://github.com/llvm/llvm-project/commit/a28fe17d7315f72b802b4ac4b4bc1603ffe7a23b

Tue, May 25, 5:37 AM · Restricted Project

Fri, May 21

pifon2a committed rG335fa1802854: [mlir] NFC: Expose tiled_loop->scf pattern. (authored by pifon2a).
[mlir] NFC: Expose tiled_loop->scf pattern.
Fri, May 21, 9:19 AM
pifon2a closed D102921: [mlir] NFC: Expose tiled_loop->scf pattern..
Fri, May 21, 9:19 AM · Restricted Project
pifon2a committed rG9ecc8178d720: [mlir] Add support for fusion into TiledLoopOp. (authored by pifon2a).
[mlir] Add support for fusion into TiledLoopOp.
Fri, May 21, 9:14 AM
pifon2a closed D102722: [mlir] Add support for fusion into TiledLoopOp..
Fri, May 21, 9:14 AM · Restricted Project
pifon2a updated the diff for D102722: [mlir] Add support for fusion into TiledLoopOp..

Rebase

Fri, May 21, 9:13 AM · Restricted Project
pifon2a added inline comments to D102722: [mlir] Add support for fusion into TiledLoopOp..
Fri, May 21, 8:58 AM · Restricted Project
pifon2a updated the diff for D102722: [mlir] Add support for fusion into TiledLoopOp..

Remove empty line

Fri, May 21, 8:57 AM · Restricted Project
pifon2a updated the diff for D102722: [mlir] Add support for fusion into TiledLoopOp..

Address the comments.

Fri, May 21, 8:54 AM · Restricted Project
pifon2a added a reviewer for D102921: [mlir] NFC: Expose tiled_loop->scf pattern.: gysit.
Fri, May 21, 8:54 AM · Restricted Project
pifon2a requested review of D102921: [mlir] NFC: Expose tiled_loop->scf pattern..
Fri, May 21, 8:00 AM · Restricted Project
pifon2a added reviewers for D102722: [mlir] Add support for fusion into TiledLoopOp.: gysit, springerm.
Fri, May 21, 7:26 AM · Restricted Project
pifon2a accepted D102905: [mlir] Add convenience builders for EqualOp and NotEqualOp..

Thank you, Adrian!

Fri, May 21, 2:31 AM · Restricted Project
pifon2a accepted D102902: [mlir] Add conversion from Complex to Standard dialect for NotEqualOp..
Fri, May 21, 12:35 AM · Restricted Project

Thu, May 20

pifon2a accepted D102840: [mlir] Add conversion from complex to standard dialect for EqualOp..
Thu, May 20, 5:24 AM · Restricted Project
pifon2a accepted D102838: [mlir] Add EqualOp and NotEqualOp to complex dialect..
Thu, May 20, 4:04 AM · Restricted Project

Tue, May 18

pifon2a requested review of D102722: [mlir] Add support for fusion into TiledLoopOp..
Tue, May 18, 1:31 PM · Restricted Project
pifon2a accepted D102616: [mlir] Add folder for complex.ReOp and complex.ImOp..
Tue, May 18, 1:27 AM · Restricted Project

Mon, May 17

pifon2a accepted D102609: [mlir] Add folder for complex.ReOp and complex.ImOp..
Mon, May 17, 4:33 AM · Restricted Project
pifon2a accepted D102608: [mlir][memref] Mark memref.buffer_cast as NoSideEffect.
Mon, May 17, 4:33 AM · Restricted Project

Fri, May 14

pifon2a accepted D102417: [mlir][Linalg] Add support for subtensor_insert comprehensive bufferization (3/n).
Fri, May 14, 10:38 AM · Restricted Project
pifon2a accepted D102420: [mlir][Linalg] NFC - More gracefully degrade lookup into failure furing comprehensive bufferization (4/n).
Fri, May 14, 10:37 AM · Restricted Project

May 12 2021

pifon2a accepted D102301: [mlir][Linalg] Add interface methods to get lhs and rhs of contraction op..
May 12 2021, 10:07 AM · Restricted Project

May 11 2021

pifon2a accepted D102232: [mlir] Use static shape knowledge when lowering memref.reshape.

Thanks, Ben!

May 11 2021, 5:19 AM · Restricted Project

May 10 2021

pifon2a accepted D102176: [mlir][linalg] Remove IndexedGenericOp support from Tiling....

Awesome

May 10 2021, 10:28 AM · Restricted Project

May 7 2021

pifon2a committed rG3444996b4c45: [mlir] Add a pattern to bufferize std.index_cast. (authored by pifon2a).
[mlir] Add a pattern to bufferize std.index_cast.
May 7 2021, 12:33 PM
pifon2a closed D102088: [mlir] Add a pattern to bufferize std.index_cast..
May 7 2021, 12:33 PM · Restricted Project
pifon2a committed rGa3f22d020b27: [mlir] Add a pattern to bufferize linalg.tensor_reshape. (authored by pifon2a).
[mlir] Add a pattern to bufferize linalg.tensor_reshape.
May 7 2021, 12:31 PM
pifon2a closed D102089: [mlir] Add a pattern to bufferize linalg.tensor_reshape..
May 7 2021, 12:31 PM · Restricted Project
pifon2a requested review of D102089: [mlir] Add a pattern to bufferize linalg.tensor_reshape..
May 7 2021, 12:22 PM · Restricted Project
pifon2a requested review of D102088: [mlir] Add a pattern to bufferize std.index_cast..
May 7 2021, 12:21 PM · Restricted Project

May 6 2021

pifon2a accepted D101612: [mlir][linalg] Add IndexedGenericOp to GenericOp canonicalization..
May 6 2021, 9:24 AM · Restricted Project

May 5 2021

pifon2a committed rG2865d114f953: [mlir] Use ReassociationIndices instead of affine maps in linalg.reshape. (authored by pifon2a).
[mlir] Use ReassociationIndices instead of affine maps in linalg.reshape.
May 5 2021, 4:00 AM
pifon2a closed D101861: [mlir] Use ReassociationIndices instead of affine maps in linalg.reshape..
May 5 2021, 4:00 AM · Restricted Project
pifon2a added a comment to D101861: [mlir] Use ReassociationIndices instead of affine maps in linalg.reshape..

Looks good (if Nicolas signed off on this before he went on vacation)

May 5 2021, 2:14 AM · Restricted Project
pifon2a updated the summary of D101861: [mlir] Use ReassociationIndices instead of affine maps in linalg.reshape..
May 5 2021, 2:14 AM · Restricted Project
pifon2a updated the diff for D101861: [mlir] Use ReassociationIndices instead of affine maps in linalg.reshape..

Update.

May 5 2021, 2:02 AM · Restricted Project
pifon2a accepted D101887: [mlir][linalg] Fix bug in the fusion on tensors index op handling..

Thank you, Tobias!

May 5 2021, 1:53 AM · Restricted Project

May 4 2021

pifon2a requested review of D101861: [mlir] Use ReassociationIndices instead of affine maps in linalg.reshape..
May 4 2021, 2:27 PM · Restricted Project

May 3 2021

pifon2a accepted D101768: [MLIR][Linalg] Lower `linalg.tiled_loop` in a separate pass.
May 3 2021, 10:43 AM · Restricted Project
pifon2a abandoned D101749: [mlir] Remove CHECKs from the roundtrip test in Linalg..

Ok.

I am missing the rationale for this one. Maybe "roundtrip" is a bad name, but we have these tests for all dialects and the point has always been to check that MLIR prints what you expect. Without the checks, you only test that MLIR can parse back what it printed, but you lose the consistency check. Back when we had to write parsers manually, I remember having caught several cases where an ill-written parser would accept A and B keywords, but construct an op always with A; so it would be printed with A instead of B and parsed back successfully (thus passing the trimmed-down test) but would contain an error.

Not all dialects have this and with the now auto-generated parser/printer pairs using assemblyFormat I am not convinced of the value of these tests. They do create work when evolving syntax. On the other hand, as we have them, unless there is a change to syntax, we can also keep them.

I checked, and all upstream dialects do have those. Some just call the file ops.mlir, which I personally consider a cargo cult of the prehistorical MLIR version that had core-ops.mlir for testing the syntax of currently Affine+Standard+Math+Memref ops. Many dialects also check attribute and type syntax there.

While I do agree that it creates churn to have these tests if the printers/parsers are generated, Linalg printers and parsers are not!

May 3 2021, 5:13 AM · Restricted Project
pifon2a requested review of D101749: [mlir] Remove CHECKs from the roundtrip test in Linalg..
May 3 2021, 3:44 AM · Restricted Project
pifon2a accepted D101747: [MLIR][Linalg] Lower `linalg.tiled_loop` to `scf` loops.

We might need a separate pass that lowers only TiledLoopOp and not the linalg ops inside its region. But for now it should be fine. Thanks!

May 3 2021, 2:31 AM · Restricted Project

Apr 28 2021

pifon2a committed rGfa0d044c4499: [mlir] Fix canonicalization of tiled_loop if not all opresults fold. (authored by pifon2a).
[mlir] Fix canonicalization of tiled_loop if not all opresults fold.
Apr 28 2021, 11:04 AM
pifon2a committed rG9a66d334522d: [mlir] Fix the postsubmit comments in https://reviews.llvm.org/D101445 (authored by pifon2a).
[mlir] Fix the postsubmit comments in https://reviews.llvm.org/D101445
Apr 28 2021, 5:58 AM
pifon2a committed rG29dbac0ae295: [mlir] Add folding for tensor inputs and memref.cast in linalg.tiled_loop. (authored by pifon2a).
[mlir] Add folding for tensor inputs and memref.cast in linalg.tiled_loop.
Apr 28 2021, 5:37 AM
pifon2a closed D101445: [mlir] Add folding for tensor inputs and memref.cast in linalg.tiled_loop..
Apr 28 2021, 5:36 AM · Restricted Project
pifon2a requested review of D101445: [mlir] Add folding for tensor inputs and memref.cast in linalg.tiled_loop..
Apr 28 2021, 5:17 AM · Restricted Project
pifon2a accepted D101442: [MLIR] Add ComplexToStandard conversion pass..
Apr 28 2021, 5:02 AM · Restricted Project

Apr 27 2021

pifon2a accepted D101377: [MLIR][Shape] Concretize broadcast result type if possible.
Apr 27 2021, 9:26 AM · Restricted Project
pifon2a accepted D101376: [MLIR][Shape] Canonicalize casted extent tensor operands.
Apr 27 2021, 9:24 AM · Restricted Project
pifon2a committed rG4b13b7581db5: [mlir] Add a pass to tile Linalg ops using `linalg.tiled_loop`. (authored by pifon2a).
[mlir] Add a pass to tile Linalg ops using `linalg.tiled_loop`.
Apr 27 2021, 3:34 AM
pifon2a closed D101084: [mlir] Add a pass to tile Linalg ops using `linalg.tiled_loop`..
Apr 27 2021, 3:33 AM · Restricted Project
pifon2a accepted D101350: [MLIR][Shape] Replace single operand broadcasts with appropriate cast.

Why do we create single-operand bcasts at all?

Apr 27 2021, 3:33 AM · Restricted Project
pifon2a updated the diff for D101084: [mlir] Add a pass to tile Linalg ops using `linalg.tiled_loop`..

Fix lowering to Affine loops.

Apr 27 2021, 3:27 AM · Restricted Project
pifon2a accepted D101351: [MLIR][Shape] Remove empty extent tensor operands.
Apr 27 2021, 3:19 AM · Restricted Project

Apr 26 2021

pifon2a accepted D101301: [MLIR][Linalg] Generalize splat constant folding.

Nice, thanks!

Apr 26 2021, 9:59 AM · Restricted Project

Apr 23 2021

pifon2a committed rG5291a7a3c70c: [mlir] Add block arguments for input/output operands of 'linalg.tiled_loop`. (authored by pifon2a).
[mlir] Add block arguments for input/output operands of 'linalg.tiled_loop`.
Apr 23 2021, 11:55 AM
pifon2a closed D101186: [mlir] Add block arguments for input/output operands of 'linalg.tiled_loop`..
Apr 23 2021, 11:55 AM · Restricted Project
pifon2a added a comment to D101186: [mlir] Add block arguments for input/output operands of 'linalg.tiled_loop`..

@ThomasRaoux Yes, this is dangerous, if the "inner" builder was created without rewriter.getListener() passed to it.

Apr 23 2021, 11:06 AM · Restricted Project
pifon2a requested review of D101186: [mlir] Add block arguments for input/output operands of 'linalg.tiled_loop`..
Apr 23 2021, 10:48 AM · Restricted Project

Apr 22 2021

pifon2a added a reviewer for D101084: [mlir] Add a pass to tile Linalg ops using `linalg.tiled_loop`.: ThomasRaoux.
Apr 22 2021, 10:19 AM · Restricted Project
pifon2a requested review of D101084: [mlir] Add a pass to tile Linalg ops using `linalg.tiled_loop`..
Apr 22 2021, 10:18 AM · Restricted Project
pifon2a committed rG0724911d2a7b: [mlir] Add `tensor.reshape`. (authored by pifon2a).
[mlir] Add `tensor.reshape`.
Apr 22 2021, 5:53 AM
pifon2a closed D100971: [mlir] Add `tensor.reshape`..
Apr 22 2021, 5:53 AM · Restricted Project
pifon2a updated the diff for D100971: [mlir] Add `tensor.reshape`..

More comments.

Apr 22 2021, 5:51 AM · Restricted Project
pifon2a updated the diff for D100971: [mlir] Add `tensor.reshape`..

Address the comments.

Apr 22 2021, 4:47 AM · Restricted Project

Apr 21 2021

pifon2a requested review of D100971: [mlir] Add `tensor.reshape`..
Apr 21 2021, 9:50 AM · Restricted Project
pifon2a accepted D100950: [mlir] Move memref-tests from standard to memref folder..

Thank you for cleaning this up, Thomas!

Apr 21 2021, 8:34 AM · Restricted Project

Apr 15 2021

pifon2a committed rGcf761904a276: [mlir] Add verification for `linalg.tiled_loop` op. (authored by pifon2a).
[mlir] Add verification for `linalg.tiled_loop` op.
Apr 15 2021, 11:51 AM
pifon2a closed D100555: [mlir] Add verification for `linalg.tiled_loop` op..
Apr 15 2021, 11:50 AM · Restricted Project
pifon2a committed rG67f60bcc75a3: [mlir] Expose `updateBoundsForCyclicDistribution` in Linalg/Utils.h. (authored by pifon2a).
[mlir] Expose `updateBoundsForCyclicDistribution` in Linalg/Utils.h.
Apr 15 2021, 11:48 AM
pifon2a closed D100580: [mlir] Expose `updateBoundsForCyclicDistribution` in Linalg/Utils.h..
Apr 15 2021, 11:47 AM · Restricted Project
pifon2a committed rG3c982a6e54cf: [mlir] Add helpers to set lbs, ubs, steps for linalg.tiled_loop. (authored by pifon2a).
[mlir] Add helpers to set lbs, ubs, steps for linalg.tiled_loop.
Apr 15 2021, 11:45 AM
pifon2a closed D100579: [mlir] Add helpers to set lbs, ubs, steps for linalg.tiled_loop..
Apr 15 2021, 11:45 AM · Restricted Project
pifon2a requested review of D100580: [mlir] Expose `updateBoundsForCyclicDistribution` in Linalg/Utils.h..
Apr 15 2021, 10:50 AM · Restricted Project
pifon2a requested review of D100579: [mlir] Add helpers to set lbs, ubs, steps for linalg.tiled_loop..
Apr 15 2021, 10:49 AM · Restricted Project