Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D145696

[mlir][Arith] Add ValueBoundsOpInterface impls
ClosedPublic
Actions

Authored by springerm on Mar 9 2023, 8:19 AM.

Details

Reviewers
dcaballe
hanchung
nicolasvasilache
Commits
rG3fecf9a5c3c3: [mlir][arith] Add ValueBoundsOpInterface impls
Summary

These ops are useful for unit testing. (They do not fold/canonicalize with affine.apply etc.)

Depends On: D145695

Diff Detail

Event Timeline

springerm created this revision.Mar 9 2023, 8:19 AM
Herald added a reviewer: hanchung. · View Herald TranscriptMar 9 2023, 8:19 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hanchung, Moerafaat, bzcheeseman and 24 others. · View Herald Transcript
springerm requested review of this revision.Mar 9 2023, 8:19 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 9 2023, 8:19 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
springerm added a parent revision: D145695: [mlir][MemRef] Add ValueBoundsOpInterface impls.Mar 9 2023, 8:19 AM
Harbormaster completed remote builds in B218403: Diff 503782.Mar 9 2023, 8:57 AM
springerm mentioned this in D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.Mar 10 2023, 5:50 AM
springerm added a child revision: D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.Mar 10 2023, 5:50 AM
springerm mentioned this in D145796: [mlir][affine][analysis] Fix `getClosedUB` handling in `getSliceBounds`.Mar 10 2023, 7:41 AM
springerm added a child revision: D145796: [mlir][affine][analysis] Fix `getClosedUB` handling in `getSliceBounds`.Mar 10 2023, 7:41 AM
springerm removed a child revision: D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.
springerm updated this revision to Diff 505814.Mar 16 2023, 8:13 AM

rebase

springerm retitled this revision from [mlir][linalg] ValueBoundsOpInterface: Add a few arith ops to [mlir][Arith] Add ValueBoundsOpInterface impls.Mar 16 2023, 8:16 AM
Herald added a subscriber: zero9178. · View Herald TranscriptMar 16 2023, 8:16 AM
Harbormaster completed remote builds in B219874: Diff 505814.Mar 16 2023, 9:06 AM
springerm updated this revision to Diff 506071.Mar 17 2023, 6:37 AM

rebase

Harbormaster completed remote builds in B220056: Diff 506071.Mar 17 2023, 7:26 AM
springerm added a child revision: D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.Mar 17 2023, 9:17 AM
springerm updated this revision to Diff 506948.Mar 21 2023, 6:32 AM

rebase

Harbormaster completed remote builds in B220701: Diff 506948.Mar 21 2023, 7:37 AM
springerm updated this revision to Diff 509965.Mar 31 2023, 3:29 AM

update API

Harbormaster completed remote builds in B222961: Diff 509965.Mar 31 2023, 5:33 AM
dcaballe accepted this revision.Apr 5 2023, 5:53 PM
This revision is now accepted and ready to land.Apr 5 2023, 5:53 PM
Closed by commit rG3fecf9a5c3c3: [mlir][arith] Add ValueBoundsOpInterface impls (authored by springerm). · Explain WhyApr 5 2023, 6:53 PM
This revision was automatically updated to reflect the committed changes.
springerm added a commit: rG3fecf9a5c3c3: [mlir][arith] Add ValueBoundsOpInterface impls.
sylvestre.ledru added a subscriber: sylvestre.ledru.Apr 6 2023, 5:07 AM

@springerm seems that https://github.com/llvm/llvm-project/issues/61979 is caused because of this (or the other).
Could you please revert it ? or fix it quickly
thanks

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Arith/
IR/
20 lines
2 lines
lib/
Dialect/
Arith/
IR/
21 lines
81 lines
test/
Dialect/
Arith/
54 lines
lib/
Dialect/
Affine/
4 lines
utils/
bazel/
llvm-project-overlay/
mlir/
24 lines

Diff 511252

View Options

mlir/include/mlir/Dialect/Arith/IR/ValueBoundsOpInterfaceImpl.h

Loading...
View Options

mlir/include/mlir/InitAllDialects.h

Loading...
View Options

mlir/lib/Dialect/Arith/IR/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/Arith/IR/ValueBoundsOpInterfaceImpl.cpp

Loading...
View Options

mlir/test/Dialect/Arith/value-bounds-op-interface-impl.mlir

Loading...
View Options

mlir/test/lib/Dialect/Affine/TestReifyValueBounds.cpp

Loading...
View Options

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

Loading...