Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D145796

[mlir][affine][analysis] Fix `getClosedUB` handling in `getSliceBounds`
ClosedPublic
Actions

Authored by springerm on Mar 10 2023, 7:41 AM.

Details

Reviewers
bondhugula
nicolasvasilache
dcaballe
Commits
rGdab077cae7b0: [mlir][affine][analysis] Fix `closedUB` handling in `getSliceBounds`
Summary

There were cases in which ubAdjustment was not applied to the resulting UB.

Depends On: D145696

Diff Detail

Event Timeline

springerm created this revision.Mar 10 2023, 7:41 AM
Herald added a reviewer: bondhugula. · View Herald TranscriptMar 10 2023, 7:41 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, bzcheeseman, arjunp and 23 others. · View Herald Transcript
springerm requested review of this revision.Mar 10 2023, 7:41 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 10 2023, 7:41 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
springerm added a parent revision: D145696: [mlir][Arith] Add ValueBoundsOpInterface impls.Mar 10 2023, 7:41 AM
Herald added a subscriber: jsetoain. · View Herald TranscriptMar 10 2023, 7:41 AM
springerm mentioned this in D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.Mar 10 2023, 7:42 AM
springerm added a child revision: D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.
Harbormaster completed remote builds in B218685: Diff 504148.Mar 10 2023, 10:26 AM
bondhugula accepted this revision.Mar 10 2023, 4:21 PM
bondhugula added inline comments.
mlir/include/mlir/Dialect/Affine/Analysis/AffineStructures.h
228

The option can be simply named closedUb.

248

If closedUb is true, the upper bound is closed.

mlir/lib/Dialect/Affine/Analysis/AffineStructures.cpp
1145

get suffix can be dropped; it's implied and should be omitted to be consistent with such options throughout the codebase.

This revision is now accepted and ready to land.Mar 10 2023, 4:21 PM
Closed by commit rGdab077cae7b0: [mlir][affine][analysis] Fix `closedUB` handling in `getSliceBounds` (authored by springerm). · Explain WhyMar 13 2023, 1:03 AM
This revision was automatically updated to reflect the committed changes.
springerm marked 3 inline comments as done.
springerm added a commit: rGdab077cae7b0: [mlir][affine][analysis] Fix `closedUB` handling in `getSliceBounds`.
springerm removed a child revision: D145787: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.Mar 17 2023, 9:17 AM

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Affine/
Analysis/
14 lines
lib/
Dialect/
Affine/
Analysis/
14 lines

Diff 504533

View Options

mlir/include/mlir/Dialect/Affine/Analysis/AffineStructures.h

Loading...
View Options

mlir/lib/Dialect/Affine/Analysis/AffineStructures.cpp

Loading...