Page MenuHomePhabricator
Differential D145695

[mlir][MemRef] Add ValueBoundsOpInterface impls
ClosedPublic
Actions

Authored by springerm on Mar 9 2023, 8:15 AM.

Details

Reviewers
dcaballe
hanchung
nicolasvasilache
Commits
rG6510fa90a0c1: [mlir][memref] Add ValueBoundsOpInterface impls
Summary

Depends On: D145694

Diff Detail

Event Timeline

springerm created this revision.Mar 9 2023, 8:15 AM
Herald added a reviewer: hanchung. · View Herald TranscriptMar 9 2023, 8:15 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hanchung, Moerafaat, bzcheeseman and 23 others. · View Herald Transcript
springerm requested review of this revision.Mar 9 2023, 8:15 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 9 2023, 8:15 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
springerm added a parent revision: D145694: [mlir][Affine] Add ValueBoundsOpInterface for affine.apply.Mar 9 2023, 8:15 AM
springerm mentioned this in D145696: [mlir][Arith] Add ValueBoundsOpInterface impls.Mar 9 2023, 8:19 AM
springerm added a child revision: D145696: [mlir][Arith] Add ValueBoundsOpInterface impls.Mar 9 2023, 8:19 AM
Harbormaster completed remote builds in B218402: Diff 503779.Mar 9 2023, 8:43 AM
springerm updated this revision to Diff 505813.Mar 16 2023, 8:12 AM

rebase

springerm retitled this revision from [mlir][linalg] ValueBoundsOpInterface: Add memref ops to [mlir][MemRef] Add ValueBoundsOpInterface impls.Mar 16 2023, 8:15 AM
Harbormaster completed remote builds in B219872: Diff 505813.Mar 16 2023, 9:06 AM
springerm updated this revision to Diff 506070.Mar 17 2023, 6:36 AM

rebase

Harbormaster completed remote builds in B220055: Diff 506070.Mar 17 2023, 7:24 AM
springerm updated this revision to Diff 506947.Mar 21 2023, 6:32 AM

rebase

Harbormaster completed remote builds in B220700: Diff 506947.Mar 21 2023, 7:38 AM
springerm updated this revision to Diff 509964.Mar 31 2023, 3:28 AM

update API

Harbormaster completed remote builds in B222960: Diff 509964.Mar 31 2023, 5:06 AM
dcaballe accepted this revision.Mar 31 2023, 12:17 PM
dcaballe added inline comments.
mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
108

-> i =0, end = getType().getRank()

mlir/lib/Dialect/MemRef/IR/ValueBoundsOpInterfaceImpl.cpp
30

ok, this seems to be common so I'm guessing the operator == is overloaded?

This revision is now accepted and ready to land.Mar 31 2023, 12:17 PM
springerm marked 2 inline comments as done.Apr 5 2023, 6:33 PM
springerm added inline comments.
mlir/lib/Dialect/MemRef/IR/ValueBoundsOpInterfaceImpl.cpp
30

Yes, this is the new API that jpienaar suggested.

Closed by commit rG6510fa90a0c1: [mlir][memref] Add ValueBoundsOpInterface impls (authored by springerm). · Explain WhyApr 5 2023, 6:40 PM
This revision was automatically updated to reflect the committed changes.
springerm marked an inline comment as done.
springerm added a commit: rG6510fa90a0c1: [mlir][memref] Add ValueBoundsOpInterface impls.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
MemRef/
IR/
14 lines
20 lines
2 lines
lib/
Dialect/
MemRef/
IR/
2 lines
129 lines
test/
Dialect/
MemRef/
86 lines
utils/
bazel/
llvm-project-overlay/
mlir/
2 lines

Diff 511250

View Options

mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td

Loading...
View Options

mlir/include/mlir/Dialect/MemRef/IR/ValueBoundsOpInterfaceImpl.h

Loading...
View Options

mlir/include/mlir/InitAllDialects.h

Loading...
View Options

mlir/lib/Dialect/MemRef/IR/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/MemRef/IR/ValueBoundsOpInterfaceImpl.cpp

Loading...
View Options

mlir/test/Dialect/MemRef/value-bounds-op-interface-impl.mlir

Loading...
View Options

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

Loading...