Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D145787

[mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds
ClosedPublic
Actions

Authored by springerm on Mar 10 2023, 5:50 AM.

Details

Reviewers
dcaballe
hanchung
nicolasvasilache
bondhugula
Commits
rG041bc485bf21: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds
Summary

This change also adds support for affine.min and affine.max ops.

Depends On: D145696

Diff Detail

Event Timeline

springerm created this revision.Mar 10 2023, 5:50 AM
Herald added a reviewer: hanchung. · View Herald TranscriptMar 10 2023, 5:50 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hanchung, Moerafaat, bzcheeseman and 24 others. · View Herald Transcript
springerm requested review of this revision.Mar 10 2023, 5:50 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 10 2023, 5:50 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
springerm added a parent revision: D145696: [mlir][Arith] Add ValueBoundsOpInterface impls.Mar 10 2023, 5:50 AM
Harbormaster completed remote builds in B218662: Diff 504115.Mar 10 2023, 6:18 AM
springerm edited the summary of this revision. (Show Details)Mar 10 2023, 7:42 AM
springerm edited the summary of this revision. (Show Details)
springerm edited the summary of this revision. (Show Details)
springerm edited parent revisions, added: D145796: [mlir][affine][analysis] Fix `getClosedUB` handling in `getSliceBounds`; removed: D145696: [mlir][Arith] Add ValueBoundsOpInterface impls.
springerm updated this revision to Diff 504149.Mar 10 2023, 7:45 AM

rebase

springerm mentioned this in D145804: [mlir][SCF] Add ValueBoundsOpInterface impl for scf.for.Mar 10 2023, 9:02 AM
springerm added a child revision: D145804: [mlir][SCF] Add ValueBoundsOpInterface impl for scf.for.Mar 10 2023, 9:02 AM
Harbormaster completed remote builds in B218686: Diff 504149.Mar 10 2023, 10:27 AM
springerm updated this revision to Diff 505815.Mar 16 2023, 8:14 AM

rebase

Herald added a reviewer: bondhugula. · View Herald TranscriptMar 16 2023, 8:14 AM
springerm retitled this revision from [mlir][linalg] ValueBoundsOpInterface: Support LB and UB bounds to [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.Mar 16 2023, 8:16 AM
Herald added a subscriber: zero9178. · View Herald TranscriptMar 16 2023, 8:16 AM
Harbormaster completed remote builds in B219875: Diff 505815.Mar 16 2023, 8:27 AM
springerm updated this revision to Diff 506073.Mar 17 2023, 6:37 AM

rebase

Harbormaster completed remote builds in B220057: Diff 506073.Mar 17 2023, 7:37 AM
springerm edited the summary of this revision. (Show Details)Mar 17 2023, 9:17 AM
springerm edited parent revisions, added: D145696: [mlir][Arith] Add ValueBoundsOpInterface impls; removed: D145796: [mlir][affine][analysis] Fix `getClosedUB` handling in `getSliceBounds`.
springerm updated this revision to Diff 506111.Mar 17 2023, 9:24 AM

rebase

Harbormaster completed remote builds in B220086: Diff 506111.Mar 17 2023, 9:56 AM
springerm updated this revision to Diff 506949.Mar 21 2023, 6:32 AM

rebase

Harbormaster completed remote builds in B220702: Diff 506949.Mar 21 2023, 7:29 AM
springerm mentioned this in D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.Mar 30 2023, 9:22 AM
springerm updated this revision to Diff 509966.Mar 31 2023, 3:29 AM

update API

Harbormaster completed remote builds in B222962: Diff 509966.Mar 31 2023, 6:43 AM
springerm added inline comments.Apr 5 2023, 6:52 PM
mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
262–267

Note: FlatLinearConstraints sometimes returns an affine_map with multiple results when requesting LB/UB bounds. These cases are not yet supported, so we just assert for now. We can add support when needed. (It won't be difficult, we just have to emit an affine.min/affine.max instead of affine.apply.)

dcaballe accepted this revision.Apr 6 2023, 1:24 PM
dcaballe added inline comments.
mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
262–267

Thanks for anticipating my questions! This makes sense.

This revision is now accepted and ready to land.Apr 6 2023, 1:24 PM
Herald added a subscriber: bviyer. · View Herald TranscriptApr 6 2023, 1:24 PM
Closed by commit rG041bc485bf21: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds (authored by springerm). · Explain WhyApr 6 2023, 6:53 PM
This revision was automatically updated to reflect the committed changes.
springerm added a commit: rG041bc485bf21: [mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Affine/
Transforms/
5 lines
lib/
Dialect/
Affine/
IR/
44 lines
Interfaces/
40 lines
test/
Dialect/
Affine/
46 lines
lib/
Dialect/
Affine/
31 lines

Diff 511586

View Options

mlir/include/mlir/Dialect/Affine/Transforms/Transforms.h

Loading...
View Options

mlir/lib/Dialect/Affine/IR/ValueBoundsOpInterfaceImpl.cpp

Loading...
View Options

mlir/lib/Interfaces/ValueBoundsOpInterface.cpp

Loading...
View Options

mlir/test/Dialect/Affine/value-bounds-op-interface-impl.mlir

Loading...
View Options

mlir/test/lib/Dialect/Affine/TestReifyValueBounds.cpp

Loading...