This is an archive of the discontinued LLVM Phabricator instance.

Differential D145387

[llvm-c] Remove PassManagerBuilder APIs
ClosedPublic

Authored by nikic on Mar 6 2023, 7:59 AM.

Details

Reviewers
aeubanks
deadalnix
Commits
rG0aac9a2875ba: [llvm-c] Remove PassManagerBuilder APIs
Summary

The legacy PM is only supported for codegen, and PassManagerBuilder is exclusively about the middle-end optimization pipeline. Drop it.

Diff Detail

Event Timeline

nikic created this revision.Mar 6 2023, 7:59 AM
Herald added a reviewer: deadalnix. · View Herald TranscriptMar 6 2023, 7:59 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: ormris, StephenFan, hiraditya. · View Herald Transcript
nikic requested review of this revision.Mar 6 2023, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2023, 7:59 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks accepted this revision.Mar 6 2023, 8:36 AM
This revision is now accepted and ready to land.Mar 6 2023, 8:36 AM
Harbormaster completed remote builds in B217587: Diff 502655.Mar 6 2023, 10:02 AM
This revision was landed with ongoing or failed builds.Mar 9 2023, 12:59 AM
Closed by commit rG0aac9a2875ba: [llvm-c] Remove PassManagerBuilder APIs (authored by nikic). · Explain Why
This revision was automatically updated to reflect the committed changes.
nikic added a commit: rG0aac9a2875ba: [llvm-c] Remove PassManagerBuilder APIs.

Revision Contents

PathSize
llvm/
docs/
2 lines
include/
llvm-c/
Transforms/
llvm/
Transforms/
IPO/
9 lines
lib/
Transforms/
IPO/
66 lines
tools/
llvm-c-test/
1 line

Diff 503673

llvm/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 141 Lines • ▼ Show 20 Lines
Changes to the C API Changes to the C API
-------------------- --------------------
* ``LLVMContextSetOpaquePointers``, a temporary API to pin to legacy typed * ``LLVMContextSetOpaquePointers``, a temporary API to pin to legacy typed
pointer, has been removed. pointer, has been removed.
* Functions for adding legacy passes like ``LLVMAddInstructionCombiningPass`` * Functions for adding legacy passes like ``LLVMAddInstructionCombiningPass``
have been removed. have been removed.
* Removed ``LLVMPassManagerBuilderRef`` and functions interacting with it.
These belonged to the no longer supported legacy pass manager.
Changes to the FastISel infrastructure Changes to the FastISel infrastructure
-------------------------------------- --------------------------------------
* ... * ...
Changes to the DAG infrastructure Changes to the DAG infrastructure
--------------------------------- ---------------------------------
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines

llvm/include/llvm-c/Transforms/PassManagerBuilder.h

  • This file was deleted.
/*===-- llvm-c/Transform/PassManagerBuilder.h - PMB C Interface ---*- C -*-===*\
|* *|
|* Part of the LLVM Project, under the Apache License v2.0 with LLVM *|
|* Exceptions. *|
|* See https://llvm.org/LICENSE.txt for license information. *|
|* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception *|
|* *|
|*===----------------------------------------------------------------------===*|
|* *|
|* This header declares the C interface to the PassManagerBuilder class. *|
|* *|
\*===----------------------------------------------------------------------===*/
#ifndef LLVM_C_TRANSFORMS_PASSMANAGERBUILDER_H
#define LLVM_C_TRANSFORMS_PASSMANAGERBUILDER_H
#include "llvm-c/ExternC.h"
#include "llvm-c/Types.h"
typedef struct LLVMOpaquePassManagerBuilder *LLVMPassManagerBuilderRef;
LLVM_C_EXTERN_C_BEGIN
/**
* @defgroup LLVMCTransformsPassManagerBuilder Pass manager builder
* @ingroup LLVMCTransforms
*
* @{
*/
/** See llvm::PassManagerBuilder. */
LLVMPassManagerBuilderRef LLVMPassManagerBuilderCreate(void);
void LLVMPassManagerBuilderDispose(LLVMPassManagerBuilderRef PMB);
/** See llvm::PassManagerBuilder::OptLevel. */
void
LLVMPassManagerBuilderSetOptLevel(LLVMPassManagerBuilderRef PMB,
unsigned OptLevel);
/** See llvm::PassManagerBuilder::SizeLevel. */
void
LLVMPassManagerBuilderSetSizeLevel(LLVMPassManagerBuilderRef PMB,
unsigned SizeLevel);
/** See llvm::PassManagerBuilder::DisableUnitAtATime. */
void
LLVMPassManagerBuilderSetDisableUnitAtATime(LLVMPassManagerBuilderRef PMB,
LLVMBool Value);
/** See llvm::PassManagerBuilder::DisableUnrollLoops. */
void
LLVMPassManagerBuilderSetDisableUnrollLoops(LLVMPassManagerBuilderRef PMB,
LLVMBool Value);
/** See llvm::PassManagerBuilder::DisableSimplifyLibCalls */
void
LLVMPassManagerBuilderSetDisableSimplifyLibCalls(LLVMPassManagerBuilderRef PMB,
LLVMBool Value);
/** See llvm::PassManagerBuilder::Inliner. */
void
LLVMPassManagerBuilderUseInlinerWithThreshold(LLVMPassManagerBuilderRef PMB,
unsigned Threshold);
/** See llvm::PassManagerBuilder::populateFunctionPassManager. */
void
LLVMPassManagerBuilderPopulateFunctionPassManager(LLVMPassManagerBuilderRef PMB,
LLVMPassManagerRef PM);
/** See llvm::PassManagerBuilder::populateModulePassManager. */
void
LLVMPassManagerBuilderPopulateModulePassManager(LLVMPassManagerBuilderRef PMB,
LLVMPassManagerRef PM);
/**
* @}
*/
LLVM_C_EXTERN_C_END
#endif

llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h

// llvm/Transforms/IPO/PassManagerBuilder.h - Build Standard Pass -*- C++ -*-=// // llvm/Transforms/IPO/PassManagerBuilder.h - Build Standard Pass -*- C++ -*-=//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// This file defines the PassManagerBuilder class, which is used to set up a // This file defines the PassManagerBuilder class, which is used to set up a
// "standard" optimization sequence suitable for languages like C and C++. // "standard" optimization sequence suitable for languages like C and C++.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_TRANSFORMS_IPO_PASSMANAGERBUILDER_H #ifndef LLVM_TRANSFORMS_IPO_PASSMANAGERBUILDER_H
#define LLVM_TRANSFORMS_IPO_PASSMANAGERBUILDER_H #define LLVM_TRANSFORMS_IPO_PASSMANAGERBUILDER_H
#include "llvm-c/Transforms/PassManagerBuilder.h"
#include <functional> #include <functional>
#include <string> #include <string>
#include <vector> #include <vector>
namespace llvm { namespace llvm {
class ModuleSummaryIndex; class ModuleSummaryIndex;
class Pass; class Pass;
class TargetLibraryInfoImpl; class TargetLibraryInfoImpl;
▲ Show 20 Lines • Show All 91 Lines • ▼ Show 20 Linespublic:
/// which is expected to be run on each function immediately as it is /// which is expected to be run on each function immediately as it is
/// generated. The idea is to reduce the size of the IR in memory. /// generated. The idea is to reduce the size of the IR in memory.
void populateFunctionPassManager(legacy::FunctionPassManager &FPM); void populateFunctionPassManager(legacy::FunctionPassManager &FPM);
/// populateModulePassManager - This sets up the primary pass manager. /// populateModulePassManager - This sets up the primary pass manager.
void populateModulePassManager(legacy::PassManagerBase &MPM); void populateModulePassManager(legacy::PassManagerBase &MPM);
}; };
inline PassManagerBuilder *unwrap(LLVMPassManagerBuilderRef P) {
return reinterpret_cast<PassManagerBuilder*>(P);
}
inline LLVMPassManagerBuilderRef wrap(PassManagerBuilder *P) {
return reinterpret_cast<LLVMPassManagerBuilderRef>(P);
}
} // end namespace llvm } // end namespace llvm
#endif #endif

llvm/lib/Transforms/IPO/PassManagerBuilder.cpp

//===- PassManagerBuilder.cpp - Build Standard Pass -----------------------===// //===- PassManagerBuilder.cpp - Build Standard Pass -----------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// This file defines the PassManagerBuilder class, which is used to set up a // This file defines the PassManagerBuilder class, which is used to set up a
// "standard" optimization sequence suitable for languages like C and C++. // "standard" optimization sequence suitable for languages like C and C++.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "llvm/Transforms/IPO/PassManagerBuilder.h" #include "llvm/Transforms/IPO/PassManagerBuilder.h"
#include "llvm-c/Transforms/PassManagerBuilder.h"
#include "llvm/ADT/STLExtras.h" #include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/SmallVector.h" #include "llvm/ADT/SmallVector.h"
#include "llvm/Analysis/GlobalsModRef.h" #include "llvm/Analysis/GlobalsModRef.h"
#include "llvm/Analysis/ScopedNoAliasAA.h" #include "llvm/Analysis/ScopedNoAliasAA.h"
#include "llvm/Analysis/TargetLibraryInfo.h" #include "llvm/Analysis/TargetLibraryInfo.h"
#include "llvm/Analysis/TypeBasedAliasAnalysis.h" #include "llvm/Analysis/TypeBasedAliasAnalysis.h"
#include "llvm/IR/LegacyPassManager.h" #include "llvm/IR/LegacyPassManager.h"
#include "llvm/Support/CommandLine.h" #include "llvm/Support/CommandLine.h"
▲ Show 20 Lines • Show All 332 Lines • ▼ Show 20 Linesvoid PassManagerBuilder::populateModulePassManager(
// Get rid of LCSSA nodes. // Get rid of LCSSA nodes.
MPM.add(createInstSimplifyLegacyPass()); MPM.add(createInstSimplifyLegacyPass());
// LoopSink (and other loop passes since the last simplifyCFG) might have // LoopSink (and other loop passes since the last simplifyCFG) might have
// resulted in single-entry-single-exit or empty blocks. Clean up the CFG. // resulted in single-entry-single-exit or empty blocks. Clean up the CFG.
MPM.add(createCFGSimplificationPass( MPM.add(createCFGSimplificationPass(
SimplifyCFGOptions().convertSwitchRangeToICmp(true))); SimplifyCFGOptions().convertSwitchRangeToICmp(true)));
} }
LLVMPassManagerBuilderRef LLVMPassManagerBuilderCreate() {
PassManagerBuilder *PMB = new PassManagerBuilder();
return wrap(PMB);
}
void LLVMPassManagerBuilderDispose(LLVMPassManagerBuilderRef PMB) {
PassManagerBuilder *Builder = unwrap(PMB);
delete Builder;
}
void
LLVMPassManagerBuilderSetOptLevel(LLVMPassManagerBuilderRef PMB,
unsigned OptLevel) {
PassManagerBuilder *Builder = unwrap(PMB);
Builder->OptLevel = OptLevel;
}
void
LLVMPassManagerBuilderSetSizeLevel(LLVMPassManagerBuilderRef PMB,
unsigned SizeLevel) {
PassManagerBuilder *Builder = unwrap(PMB);
Builder->SizeLevel = SizeLevel;
}
void
LLVMPassManagerBuilderSetDisableUnitAtATime(LLVMPassManagerBuilderRef PMB,
LLVMBool Value) {
// NOTE: The DisableUnitAtATime switch has been removed.
}
void
LLVMPassManagerBuilderSetDisableUnrollLoops(LLVMPassManagerBuilderRef PMB,
LLVMBool Value) {
PassManagerBuilder *Builder = unwrap(PMB);
Builder->DisableUnrollLoops = Value;
}
void
LLVMPassManagerBuilderSetDisableSimplifyLibCalls(LLVMPassManagerBuilderRef PMB,
LLVMBool Value) {
// NOTE: The simplify-libcalls pass has been removed.
}
void
LLVMPassManagerBuilderUseInlinerWithThreshold(LLVMPassManagerBuilderRef PMB,
unsigned Threshold) {
// TODO: remove this
}
void
LLVMPassManagerBuilderPopulateFunctionPassManager(LLVMPassManagerBuilderRef PMB,
LLVMPassManagerRef PM) {
PassManagerBuilder *Builder = unwrap(PMB);
legacy::FunctionPassManager *FPM = unwrap<legacy::FunctionPassManager>(PM);
Builder->populateFunctionPassManager(*FPM);
}
void
LLVMPassManagerBuilderPopulateModulePassManager(LLVMPassManagerBuilderRef PMB,
LLVMPassManagerRef PM) {
PassManagerBuilder *Builder = unwrap(PMB);
legacy::PassManagerBase *MPM = unwrap(PM);
Builder->populateModulePassManager(*MPM);
}

llvm/tools/llvm-c-test/include-all.c

Show All 30 Lines
#include "llvm-c/Linker.h" #include "llvm-c/Linker.h"
#include "llvm-c/Object.h" #include "llvm-c/Object.h"
#include "llvm-c/Orc.h" #include "llvm-c/Orc.h"
#include "llvm-c/Remarks.h" #include "llvm-c/Remarks.h"
#include "llvm-c/Support.h" #include "llvm-c/Support.h"
#include "llvm-c/Target.h" #include "llvm-c/Target.h"
#include "llvm-c/TargetMachine.h" #include "llvm-c/TargetMachine.h"
#include "llvm-c/Transforms/PassBuilder.h" #include "llvm-c/Transforms/PassBuilder.h"
#include "llvm-c/Transforms/PassManagerBuilder.h"
#include "llvm-c/Types.h" #include "llvm-c/Types.h"
#include "llvm-c/lto.h" #include "llvm-c/lto.h"
llvm/docs/ReleaseNotes.rst