This is an archive of the discontinued LLVM Phabricator instance.

Recommit "[X86] Add `TuningPreferShiftShuffle` for when Shifts are preferable to shuffles." (2nd Try)
AbandonedPublic

Authored by goldstein.w.n on Mar 1 2023, 4:56 PM.

Details

Summary

Move the opcode checks to after we have already verified we found a
valid shift instruction (0 < ShiftAmt) in matchUnaryPermuteShuffle
and lowerShuffleAsShift.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Mar 1 2023, 4:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 4:56 PM
goldstein.w.n requested review of this revision.Mar 1 2023, 4:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 4:56 PM

Cover second case

rupprecht accepted this revision.Mar 1 2023, 5:42 PM

Thanks! This seems to fix all the errors I was seeing before.

This revision is now accepted and ready to land.Mar 1 2023, 5:42 PM

Make full recommit

goldstein.w.n retitled this revision from [X86] Fix undefined access in `matchUnaryPermuteShuffle` to Recommit "[X86] Add `TuningPreferShiftShuffle` for when Shifts are preferable to shuffles." (2nd Try).Mar 1 2023, 10:43 PM
goldstein.w.n edited the summary of this revision. (Show Details)
pengfei accepted this revision.Mar 1 2023, 11:53 PM
pengfei requested changes to this revision.Mar 1 2023, 11:59 PM

I'm confused. Isn't the patch identical to D143786?

This revision now requires changes to proceed.Mar 1 2023, 11:59 PM
goldstein.w.n abandoned this revision.Mar 2 2023, 12:11 AM