Page MenuHomePhabricator

[VPlan] Replace InvariantCond field from VPWidenSelectRecipe.
ClosedPublic

Authored by fhahn on Tue, Feb 21, 7:31 AM.

Details

Summary

There is no need to store information about invariance in the recipe.
Replace the fields with checks of the operands using
isDefinedOutsideVectorRegions.

Diff Detail

Event Timeline

fhahn created this revision.Tue, Feb 21, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Feb 21, 7:31 AM
fhahn requested review of this revision.Tue, Feb 21, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Feb 21, 7:31 AM
Ayal accepted this revision.Wed, Mar 8, 1:55 AM

Nice cleanup! Indicate patch is [NFC]?

llvm/lib/Transforms/Vectorize/VPlan.h
965

nit: public: here is now redundant given that class became struct?

966

nit: worth adding getCond() to VPWidenSelectRecipe? (Independent of this patch.)

nit: better place isInvariantCond() method below, after con/destructor?

This revision is now accepted and ready to land.Wed, Mar 8, 1:55 AM
This revision was landed with ongoing or failed builds.Fri, Mar 10, 6:30 AM
This revision was automatically updated to reflect the committed changes.
fhahn marked an inline comment as done.Fri, Mar 10, 8:57 AM
fhahn added inline comments.
llvm/lib/Transforms/Vectorize/VPlan.h
965

Done in the committed version, thanks!

966

nit: worth adding getCond() to VPWidenSelectRecipe? (Independent of this patch.)

Done in 9be8d90e62a1

nit: better place isInvariantCond() method below, after con/destructor?

Done in the committed version, thanks!