Page MenuHomePhabricator
Differential D144487

[VPlan] Replace invariance fields from VPWidenGEPRecipe.
ClosedPublic
Actions

Authored by fhahn on Tue, Feb 21, 7:11 AM.

Details

Reviewers
Ayal
gilr
rengolin
Commits
rGa8adb38a96d3: [VPlan] Replace invariance fields from VPWidenGEPRecipe.
Summary

There is no need to store information about invariance in the recipe.
Replace the fields with checks of the operands using
isDefinedOutsideVectorRegions.

Diff Detail

Event Timeline

fhahn created this revision.Tue, Feb 21, 7:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Feb 21, 7:11 AM
Herald added subscribers: StephenFan, tschuett, psnobl and 3 others. · View Herald Transcript
fhahn requested review of this revision.Tue, Feb 21, 7:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Feb 21, 7:11 AM
Herald added subscribers: pcwang-thead, vkmr. · View Herald Transcript
Harbormaster completed remote builds in B215016: Diff 499162.Tue, Feb 21, 8:18 AM
fhahn added a comment.Sun, Mar 5, 3:21 AM

ping :)

Ayal accepted this revision.Wed, Mar 8, 2:07 AM

Nice cleanup!

llvm/lib/Transforms/Vectorize/VPlan.h
994

nit: worth adding getPointer() to VPWidenGEPRecipe?

This revision is now accepted and ready to land.Wed, Mar 8, 2:07 AM
This revision was landed with ongoing or failed builds.Thu, Mar 9, 8:52 AM
Closed by commit rGa8adb38a96d3: [VPlan] Replace invariance fields from VPWidenGEPRecipe. (authored by fhahn). · Explain Why
This revision was automatically updated to reflect the committed changes.
fhahn added a commit: rGa8adb38a96d3: [VPlan] Replace invariance fields from VPWidenGEPRecipe..

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Vectorize/
2 lines
28 lines
13 lines
4 lines

Diff 503799

View Options

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

Loading...
View Options

llvm/lib/Transforms/Vectorize/VPlan.h

Loading...
View Options

llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp

Loading...
View Options

llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp

Loading...