This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] extend loop emitter and optimize lattices with the awareness of slice based iteration
ClosedPublic

Authored by Peiming on Jan 30 2023, 1:27 PM.

Diff Detail

Event Timeline

Peiming created this revision.Jan 30 2023, 1:27 PM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Jan 30 2023, 1:27 PM
Peiming updated this revision to Diff 505318.Mar 14 2023, 4:29 PM

fix rebase errors..

Peiming updated this revision to Diff 505927.Mar 16 2023, 2:14 PM

fix rebase error.

Peiming updated this revision to Diff 506136.Mar 17 2023, 10:37 AM

code movement.

Peiming updated this revision to Diff 506182.Mar 17 2023, 1:00 PM

add comments,

Peiming updated this revision to Diff 506644.Mar 20 2023, 10:40 AM

code cleanup.

Peiming updated this revision to Diff 506648.Mar 20 2023, 10:53 AM

fix rebase mistakes.

aartbik added inline comments.Mar 20 2023, 2:10 PM
mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
410

note that these two functions were "touching" since they had the same function doc comment initially.
so if you split them, give L412 version its own doc too

mlir/lib/Dialect/SparseTensor/Transforms/CodegenEnv.cpp
31

"appear in the same order" -> sort?

(and yes, I realize it is moved code, but I just noticed the comment ;-)

mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
1565

why is this 4 to the right suddenly?
lint?

Peiming marked an inline comment as done.Mar 20 2023, 2:12 PM
Peiming added inline comments.
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
1565

Idk :-(, done by clang-format automatically\.

Peiming updated this revision to Diff 506731.Mar 20 2023, 2:31 PM
Peiming marked 3 inline comments as done.

address comments.

Peiming updated this revision to Diff 506732.Mar 20 2023, 2:41 PM

address comments.

aartbik accepted this revision.Mar 20 2023, 2:41 PM
aartbik added inline comments.
mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
410

Oh, the split is fine, just add a comment

mlir/lib/Dialect/SparseTensor/Transforms/CodegenEnv.cpp
31

sorted as -> sorted according to... ? or something of the sort [pun intended ;-)]

This revision is now accepted and ready to land.Mar 20 2023, 2:41 PM
Peiming updated this revision to Diff 506734.Mar 20 2023, 2:43 PM
Peiming marked 2 inline comments as done.

fix comments.

This revision was landed with ongoing or failed builds.Mar 20 2023, 3:20 PM
This revision was automatically updated to reflect the committed changes.