This is an archive of the discontinued LLVM Phabricator instance.

[TypePromotion] NewPM support.
ClosedPublic

Authored by samparker on Jan 3 2023, 6:00 AM.

Details

Summary

Addressing https://github.com/llvm/llvm-project/issues/59385

First time that I've added a pass to the NPM, so may have missed something.

Diff Detail

Event Timeline

samparker created this revision.Jan 3 2023, 6:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 6:00 AM
samparker requested review of this revision.Jan 3 2023, 6:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 6:00 AM

Thank you!

llvm/tools/opt/opt.cpp
469–470

Please drop this, remove "type-promotion" from shouldPinPassToLegacyPM(),
and adjust the run lines in newly-failing tests.

samparker updated this revision to Diff 485983.Jan 3 2023, 6:41 AM

Updated opt and the test runs.

samparker updated this revision to Diff 485984.Jan 3 2023, 6:43 AM

Fixed typo.

lebedev.ri accepted this revision.EditedJan 3 2023, 6:52 AM

Assuming that *all* tests that used to call this pass now pass, LG.
Thank you! (other "codegen" IR->IR passes need similar treatment)

llvm/tools/opt/opt.cpp
366

Please precommit this clang-format

This revision is now accepted and ready to land.Jan 3 2023, 6:52 AM

Thanks for the quick review! I will be porting hardware-loops and mve-tail-predication as well.

This revision was landed with ongoing or failed builds.Jan 3 2023, 7:12 AM
This revision was automatically updated to reflect the committed changes.

hi . bbot failure related to this patch https://lab.llvm.org/buildbot/#/builders/193/builds/24271

Should be as simple as renaming the inititialize, or even dropping it in our code. Someone is verifying that now and we'll patch OpenMP.

it does look simple :-) i pushed in a fix a while ago, (hour or so)

arsenm added a subscriber: arsenm.Jan 3 2023, 10:25 AM

it does look simple :-) i pushed in a fix a while ago, (hour or so)

The bot is failing since it also included a printf change, should revert

sorry about that, reverted.
will push a different fix now.