Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/Headers/avx512vlbwintrin.h | ||
---|---|---|
2806–2814 | Do we need such comments? |
clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c | ||
---|---|---|
2 | Sorry, I referred to the backend file. Please ignore. |
Address comments.
clang/test/CodeGen/X86/avx512vlbw-reduceMinMaxIntrin.c | ||
---|---|---|
1 ↗ | (On Diff #484759) | Agree |
clang/docs/ReleaseNotes.rst | ||
---|---|---|
806 | This is not clear to me, try sth like "mm*_reduce_(add|and|max)_epi" and put the name in a code-block like the previous lines. | |
clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c | ||
1 | drop "-apple-darwin"? | |
115 | char has different meaning on different platforms. Should we use "signed char" or "unsigned char" explicitly? |
clang/lib/Headers/avx512vlbwintrin.h | ||
---|---|---|
2997 | Should we update here too? |
clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c | ||
---|---|---|
115 |
Sorry, I think you misuderstood. It's a question, not a request. I already saw _mm_mask_set1_epi8 (__m128i __O, __mmask16 __M, char __A) _mm_maskz_set1_epi8 (__mmask16 __M, char __A) _mm256_mask_set1_epi8 (__m256i __O, __mmask32 __M, char __A) _mm256_maskz_set1_epi8 (__mmask32 __M, char __A) in this file, but I am not if using "char" is appropriate. |
Address comments.
clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c | ||
---|---|---|
115 | After investigating, I think we should use signed char and _v\d+qs instead of _v\d+qi for new intrinsic here for 2 reasons:
And intrinsics not fitting two conditions above don't need to use explictly signed char. |
clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c | ||
---|---|---|
115 | Make sense |
This is not clear to me, try sth like "mm*_reduce_(add|and|max)_epi" and put the name in a code-block like the previous lines.