This is an archive of the discontinued LLVM Phabricator instance.

[DWARFv4][DWARFv5][DWARFLinker] support debug_macinfo/debug_macro tables.
ClosedPublic

Authored by avl on Dec 16 2022, 8:22 AM.

Details

Summary

This patch adds handling of debug_macinfo/debug_macro tables to the DWARFLinker.
It uses already existing code for reading tables from DWARFDebugMacro.h.
It adds new code writing tables into the DwarfStreamer::emitMacroTables.

Diff Detail

Event Timeline

avl created this revision.Dec 16 2022, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2022, 8:22 AM
avl requested review of this revision.Dec 16 2022, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2022, 8:22 AM
aprantl accepted this revision.Dec 16 2022, 10:54 AM

Looks reasonable to me. @JDevlieghere ?

llvm/lib/DWARFLinker/DWARFStreamer.cpp
991

missing . :-)

This revision is now accepted and ready to land.Dec 16 2022, 10:54 AM
aprantl added inline comments.Dec 16 2022, 10:54 AM
llvm/lib/DWARFLinker/DWARFLinker.cpp
1250

stray ;

llvm/test/tools/llvm-dwarfutil/ELF/X86/dwarf5-macro.test