This is an archive of the discontinued LLVM Phabricator instance.

Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address
ClosedPublic

Authored by adriandole on Dec 7 2022, 12:33 PM.

Details

Diff Detail

Event Timeline

adriandole created this revision.Dec 7 2022, 12:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 12:33 PM
adriandole requested review of this revision.Dec 7 2022, 12:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 12:33 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
cjdb accepted this revision.Dec 7 2022, 2:12 PM
cjdb added a subscriber: cjdb.

LGTM

This revision is now accepted and ready to land.Dec 7 2022, 2:12 PM
adriandole edited the summary of this revision. (Show Details)Dec 7 2022, 2:23 PM

LGTM as far as the functional changes go, but this should have a release note and a test.

adriandole updated this revision to Diff 486980.Jan 6 2023, 1:46 PM

Add test and release note.

aaron.ballman accepted this revision.Jan 12 2023, 9:53 AM

LGTM! Do you need someone to commit this on your behalf? If so, what name and email address would you like for patch attribution?

This revision was landed with ongoing or failed builds.Jan 12 2023, 10:25 AM
This revision was automatically updated to reflect the committed changes.