User Details
User Details
- User Since
- Aug 7 2020, 6:10 PM (138 w, 8 h)
Jan 19 2023
Jan 19 2023
adriandole updated the diff for D141310: [clang] add -Wcompare-function-pointers.
Only trigger this warning when comparing function pointers of the same type, since comparing distinct types is already an error.
Jan 18 2023
Jan 18 2023
adriandole added a comment to D141310: [clang] add -Wcompare-function-pointers.
@dblaikie, we would use this warning in Chrome OS. We use icf=all and have encountered bugs caused by function pointer comparisons.
Jan 13 2023
Jan 13 2023
adriandole updated the diff for D141310: [clang] add -Wcompare-function-pointers.
- More helpful diagnostic message.
- Check variable and type names are printed in tests.
- Enable -Wordered-function-pointer-comparison when this warning is enabled.
adriandole added inline comments to D141310: [clang] add -Wcompare-function-pointers.
Jan 12 2023
Jan 12 2023
adriandole updated the diff for D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address.
Rebase
Jan 11 2023
Jan 11 2023
adriandole added inline comments to D141310: [clang] add -Wcompare-function-pointers.
adriandole added inline comments to D141310: [clang] add -Wcompare-function-pointers.
Jan 9 2023
Jan 9 2023
adriandole updated the diff for D141310: [clang] add -Wcompare-function-pointers.
Release note.
adriandole added reviewers for D141310: [clang] add -Wcompare-function-pointers: cjdb, aaron.ballman.
adriandole requested review of D141310: [clang] add -Wcompare-function-pointers.
Jan 6 2023
Jan 6 2023
adriandole updated the diff for D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address.
Add test and release note.
Dec 7 2022
Dec 7 2022
adriandole updated the summary of D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address.
adriandole requested review of D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address.