This is an archive of the discontinued LLVM Phabricator instance.

[clang] Mention -Werror changes revived for Clang 16
ClosedPublic

Authored by thesamesam on Oct 9 2022, 3:44 PM.

Details

Summary

-Wimplicit-function-declaration and -Wimplicit-int become errors
by default in Clang 16 (originally in 15, but we reverted it in 15.0.1).

Mention it in the release notes like we did originally for Clang 15.

See https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213 for more context.

Diff Detail

Event Timeline

thesamesam created this revision.Oct 9 2022, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2022, 3:44 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
thesamesam requested review of this revision.Oct 9 2022, 3:44 PM

I could use identical phrasing to -Wincompatible-function-pointer-types below (reference how to downgrade the error) but I don't think there's a need.

aaron.ballman accepted this revision.Oct 10 2022, 11:44 AM

Whoops, I thought I had already added those release notes, but I didn't! Thank you for catching that! LGTM

This revision is now accepted and ready to land.Oct 10 2022, 11:44 AM
mgorny accepted this revision.Oct 10 2022, 12:36 PM

Thanks for doing this.

This revision was automatically updated to reflect the committed changes.