Gentoo developer. Does various bits.
- User Since
- Sep 19 2021, 7:41 PM (106 w, 1 d)
Sat, Sep 30
Tue, Sep 19
a5e5eb17fd9743ea39de35f2779c6dc10729cf9f doesn't really explain the rationale here. Anyway, we picked up that _ENABLE_ASSERTIONS was deprecated thanks to this warning during the RCs (https://bugs.gentoo.org/912223). This change reverting to the old behaviour wasn't in any of the RCs and have now become "experimental" again.
Tue, Sep 5
Aug 31 2023
Aug 28 2023
Aug 22 2023
Aug 15 2023
This seems right. I'd normally prefer for Michael to take a look but I'll merge it to unbreak the build. We can revert it later if needed.
Aug 13 2023
Aug 7 2023
Jul 26 2023
Jul 11 2023
During our regular snapshot testing, we've hit this in Gentoo on 32-bit Linux x86: https://github.com/llvm/llvm-project/issues/63704#issuecomment-1631791518.
Jul 2 2023
Jun 18 2023
Jun 15 2023
Jun 14 2023
Jun 12 2023
Yes, it's a transitive include which just happened to work before.
Jun 11 2023
lgtm, but not a member of llvm-libc
Jun 10 2023
Jun 5 2023
Jun 4 2023
Add some additional cases
Tweak commit message
May 22 2023
May 21 2023
This looks fine, thank you! I'll land it later today if nobody objects, given the bug has been open for a while and 16.x is broken as a result.
May 20 2023
May 18 2023
This is just a draft which I've only briefly tested so far. I'm wondering if this is the right place to put the option, as i've not had to write anything in tablegen before.
I think we've had a similar set of changes like this before but I can't find them right now...
May 17 2023
The counterpoint would be that _we're_ adding this flag (LLVM needs it) so it makes sense for us to swallow it, i.e. it's not an arbitrary user-defined flag.
Thanks for explaining. @xry111 Are you taking a look or shall I?
I think we can get away with doing that. We already do it with plenty of other GCC args..
May 15 2023
Sure & thanks.
(I even struggled to find docs for the fix we used for clang-tidy, although it obviously works.)
May 14 2023
Phew. Thank you again both.
May 13 2023
Reverted for now to avoid confusing other people. I'll look into this more later today if @xry111 doesn't beat me to it.
I can only reproduce it with a GCC-built LLVM.
@dyung Sure, I'll take a look now. If I can't fix it tonight, I'll revert it to keep the bots green.
Apologies - I got the attribution wrong (I forgot that arc doesn't preserve it by default) so I reverted and reapplied with the correct git author.
May 12 2023
May 11 2023
Adding to the concerns raised above, I don't think we're there yet. See https://bugs.gentoo.org/buglist.cgi?quicksearch=enum-constexpr-conversion&list_id=6843355 and keep in mind that a bunch of stuff isn't buildable with Clang 16 yet anyway so I expect a bunch more to be broken on top of that.
May 4 2023
Apr 27 2023
This loses us coverage on musl and other libcs, unfortunately. musl will be keeping crypt indefinitely, although it does "support" overriding/interposition as well w/ libxcrypt (even if it's somewhat discouraged). But I'm also not sure how we can actually prevent that, so right now, sanitizing crypt at all is dangerous (c.f. the bugs @fweimer shared).
Apr 26 2023
Given glibc plans to remove its crypt() anyway, this seems fine.
Apr 24 2023
Apr 16 2023
Yes, please. Obviously we want to fix it properly but right now it's a known issue and it's noise when checking for regressions weekly.
Apr 12 2023
Would it be possible to revert the original changes then reland them with the improvements mentioned above?
Apr 11 2023
You should be able to use the mechanism from https://github.com/llvm/llvm-project/commit/fa981b541365190ae646d2dce575706cd0626cf7 instead for both the original change here and any future changes?
Mar 27 2023
Mar 24 2023
The atomic changes look fine.