Page MenuHomePhabricator

thesamesam (Sam James)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 19 2021, 7:41 PM (53 w, 8 h)

Gentoo developer. Does various bits.

Recent Activity

Wed, Sep 14

Herald added a project to D85044: Add __atomic_is_lock_free to compiler-rt: Restricted Project.
Wed, Sep 14, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 13

thesamesam added a comment to D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX.

So the basic idea here is that the default can be specified by a configuration file and thus we don't need any configure-time variable for it? But then why do we need other configuration macros like default stdlib or default linker? Mostly trying to understand what the rule of thumb is for when something should be a configure macro and when something should be left to a configuration file instead.

Tue, Sep 13, 2:48 PM · Restricted Project, Restricted Project, Restricted Project
thesamesam added inline comments to D133771: Add a "Potentially Breaking Changes" section to the Clang release notes.
Tue, Sep 13, 2:46 PM · Restricted Project, Restricted Project
Herald added a project to D106577: [clang] Define __STDC_ISO_10646__: Restricted Project.
Tue, Sep 13, 2:14 PM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D34158: For Linux/gnu compatibility, preinclude <stdc-predef.h> if the file is available : Restricted Project.
Tue, Sep 13, 2:13 PM · Restricted Project
thesamesam accepted D133771: Add a "Potentially Breaking Changes" section to the Clang release notes.

Thanks!

Tue, Sep 13, 7:17 AM · Restricted Project, Restricted Project

Jul 31 2022

Herald added a project to D118021: [Driver] Use libatomic for 32-bit SPARC atomics support: Restricted Project.
Jul 31 2022, 10:25 PM · Restricted Project, Restricted Project, Restricted Project

Jul 25 2022

thesamesam updated subscribers of rG8e218026f8d5: [clang] [MinGW] Fix paths on Gentoo.
Jul 25 2022, 12:15 AM · Restricted Project, Restricted Project
thesamesam updated subscribers of rG8e218026f8d5: [clang] [MinGW] Fix paths on Gentoo.
Jul 25 2022, 12:14 AM · Restricted Project, Restricted Project

Feb 24 2022

thesamesam accepted D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON.

Been running with this for some time now (before we added the option). We should address the tests but they look sorted now.

Feb 24 2022, 2:37 PM · Restricted Project, Restricted Project, Restricted Project

Feb 5 2022

thesamesam retitled D119068: [libunwind] Define _Unwind_Backtrace for powerpc, sparc from [libunwind] [sparc] Define _Unwind_Backtrace to [libunwind] Define _Unwind_Backtrace for powerpc, sparc.
Feb 5 2022, 11:04 PM · Restricted Project, Restricted Project
thesamesam updated the diff for D119068: [libunwind] Define _Unwind_Backtrace for powerpc, sparc.

Fix similar issue for PPC32.

Feb 5 2022, 11:03 PM · Restricted Project, Restricted Project
thesamesam requested review of D119068: [libunwind] Define _Unwind_Backtrace for powerpc, sparc.
Feb 5 2022, 9:15 PM · Restricted Project, Restricted Project

Jan 31 2022

thesamesam accepted D116857: [libunwind] [sparc] Add SPARCv9 support.

Thank you for your work and responsiveness!

Jan 31 2022, 12:28 PM · Restricted Project, Restricted Project

Jan 28 2022

thesamesam added a comment to D116857: [libunwind] [sparc] Add SPARCv9 support.

Thanks for doing the work on this and @kettenis for working on it originally too. I'd love to see this landed.

I've tested this on sparc64 on Gentoo and it doesn't seem to build for me right now at commit bddc814b442ae9f30d62e2f881274d6255411225.

Seems like this is because I forgot to add the .register directives before saving %g2, %g3, %g6, and %g7, and GCC doesn't like it.
I've added the directives, can you please check if it builds there too? Thanks a lot!

Jan 28 2022, 8:46 PM · Restricted Project, Restricted Project

Jan 27 2022

thesamesam abandoned D118411: [msan] Fix build on musl.

Now I understand. I'd missed 5869ea6c6254d848382f22f82b02b698d9c53260 which was added 2 weeks ago!

Jan 27 2022, 6:01 PM · Restricted Project
thesamesam added inline comments to D118411: [msan] Fix build on musl.
Jan 27 2022, 5:25 PM · Restricted Project
thesamesam added a comment to D116857: [libunwind] [sparc] Add SPARCv9 support.

Thanks for doing the work on this and @kettenis for working on it originally too. I'd love to see this landed.

Jan 27 2022, 4:49 PM · Restricted Project, Restricted Project
thesamesam added inline comments to D118411: [msan] Fix build on musl.
Jan 27 2022, 4:15 PM · Restricted Project
thesamesam added inline comments to D118411: [msan] Fix build on musl.
Jan 27 2022, 4:00 PM · Restricted Project
thesamesam requested review of D118411: [msan] Fix build on musl.
Jan 27 2022, 3:44 PM · Restricted Project
thesamesam updated the diff for D118320: [libunwind] build fix for GCC on PPC32.
Jan 27 2022, 12:30 PM · Restricted Project, Restricted Project
thesamesam updated the summary of D118320: [libunwind] build fix for GCC on PPC32.
Jan 27 2022, 12:17 PM · Restricted Project, Restricted Project
thesamesam updated the diff for D118320: [libunwind] build fix for GCC on PPC32.
Jan 27 2022, 12:17 PM · Restricted Project, Restricted Project

Jan 26 2022

thesamesam updated the diff for D118320: [libunwind] build fix for GCC on PPC32.
Jan 26 2022, 11:46 PM · Restricted Project, Restricted Project
thesamesam requested review of D118320: [libunwind] build fix for GCC on PPC32.
Jan 26 2022, 11:36 PM · Restricted Project, Restricted Project

Jan 12 2022

thesamesam accepted D116843: [Driver][Gnu] -r: imply -nostdlib like GCC.

Looks good, although the documentation for -r and other driver options could be better (not your fault though).

Jan 12 2022, 9:18 PM · Restricted Project

Dec 20 2021

thesamesam accepted D116017: [ELF] #undef PPC to support GCC powerpc32 build.

Thanks. I don't see where PPC is reserved and I'm not even sure why GCC is setting it, but it is what it is, so this is the easiest way forward.

Dec 20 2021, 1:35 AM · Restricted Project

Dec 1 2021

thesamesam accepted D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie.

This is working well here on Gentoo.

Dec 1 2021, 11:28 AM · Restricted Project, Restricted Project

Nov 7 2021

thesamesam updated thesamesam.
Nov 7 2021, 2:42 PM