Page MenuHomePhabricator

[ISel] Fix crash in new FMA DAG combine
ClosedPublic

Authored by foad on Oct 4 2022, 5:10 AM.

Details

Summary

Fix a crash in the FMA combine added by D132837 and amended by D134810.
In cases where the newly created node could be folded, the combiner
would fail this assertion:

llc: DAGCombiner.cpp:268: void (anonymous namespace)::DAGCombiner::AddToWorklist(llvm::SDNode *): Assertion `N->getOpcode() != ISD::DELETED_NODE && "Deleted Node added to Worklist"' failed.

Diff Detail

Event Timeline

foad created this revision.Oct 4 2022, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 5:10 AM
foad requested review of this revision.Oct 4 2022, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2022, 5:10 AM
foad added reviewers: Restricted Project, tsymalla, dstuttard, piotr, spatel, lebedev.ri.Oct 4 2022, 5:11 AM
foad added a reviewer: critson.
tsymalla accepted this revision.Oct 4 2022, 5:33 AM
This revision is now accepted and ready to land.Oct 4 2022, 5:33 AM
This revision was landed with ongoing or failed builds.Oct 4 2022, 7:19 AM
This revision was automatically updated to reflect the committed changes.