Page MenuHomePhabricator

tsymalla (Thomas Symalla)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2020, 7:16 AM (102 w, 2 d)

Recent Activity

Yesterday

tsymalla committed rG851176c7f760: [AMDGPU] Remove AMDGPUISelDAGToDAG::isKnownNeverNaN (authored by tsymalla).
[AMDGPU] Remove AMDGPUISelDAGToDAG::isKnownNeverNaN
Tue, Nov 29, 10:58 PM · Restricted Project, Restricted Project
tsymalla closed D138938: [AMDGPU] Remove AMDGPUISelDAGToDAG::isKnownNeverNaN.
Tue, Nov 29, 10:58 PM · Restricted Project, Restricted Project
tsymalla updated the diff for D138938: [AMDGPU] Remove AMDGPUISelDAGToDAG::isKnownNeverNaN.

Remove linter message

Tue, Nov 29, 12:06 PM · Restricted Project, Restricted Project
tsymalla requested review of D138938: [AMDGPU] Remove AMDGPUISelDAGToDAG::isKnownNeverNaN.
Tue, Nov 29, 12:05 PM · Restricted Project, Restricted Project
tsymalla updated the diff for D136432: [AMDGPU] Combine BFI instructions..

Added test to show the isDivergence behavior (copied from another test).
Changed run line to not test a specific architecture. This adds a few
s_movs to the lit tests, but shows the behavior of the isDivergence test
(the GFX10 behavior would be different).

Tue, Nov 29, 4:11 AM · Restricted Project, Restricted Project
tsymalla committed rG5f77ee4011e6: [NFC][AMDGPU] Pre-commit tests for D136432 (authored by tsymalla).
[NFC][AMDGPU] Pre-commit tests for D136432
Tue, Nov 29, 3:58 AM · Restricted Project, Restricted Project

Tue, Nov 22

tsymalla committed rG470aea5ed403: [InstCombine] Fold extractelt with select of constants (authored by tsymalla).
[InstCombine] Fold extractelt with select of constants
Tue, Nov 22, 5:07 AM · Restricted Project, Restricted Project
tsymalla closed D137934: [InstCombine] Fold extractelt with select of constants.
Tue, Nov 22, 5:07 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Made comments more concise.

Tue, Nov 22, 12:09 AM · Restricted Project, Restricted Project

Mon, Nov 21

tsymalla updated the summary of D137934: [InstCombine] Fold extractelt with select of constants.
Mon, Nov 21, 11:51 PM · Restricted Project, Restricted Project
tsymalla added inline comments to D137934: [InstCombine] Fold extractelt with select of constants.
Mon, Nov 21, 11:33 PM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Moving constant check to visitExtractElementInst

Mon, Nov 21, 12:04 PM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Addressed review comments.

Mon, Nov 21, 8:00 AM · Restricted Project, Restricted Project
tsymalla committed rG9ab2969ec7af: [NFC][InstCombine] Pre-commit tests for D137934 (authored by tsymalla).
[NFC][InstCombine] Pre-commit tests for D137934
Mon, Nov 21, 7:05 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Don't access unreachable path when trying to constant-fold an extractelement with a select as index operand.

Mon, Nov 21, 3:42 AM · Restricted Project, Restricted Project

Fri, Nov 18

tsymalla added a comment to D137934: [InstCombine] Fold extractelt with select of constants.

@spatel Thanks for adding these tests. These work in general, except the case where the second operand of the ExtractElement instruction is not a constant. The reason is that currently constantFoldOperationIntoSelectOperand expects both operands to be either the original select or a constant, but not an additional select, so a new extractelement instruction can be created to extract the actual value. If one of the operands is another select, it could be obvious that the sequence shows OOB behavior:

%e = select i1 %c, i32 3, i32 4
%s = select i1 %c, <3 x i32> <i32 2, i32 3, i32 4>, <3 x i32> <i32 5, i32 6, i32 7>
%r = extractelement <3 x i32> %s, i32 %e
ret i32 %r

Even if I know how to make the regular case work, I'll wrap my head around that particular issue.

Just bail out if the extract index value is not an immediate constant? The case where the index value is a select-of-constants that can be reduced might be another patch, but that doesn't seem like a common pattern.

Fri, Nov 18, 7:05 AM · Restricted Project, Restricted Project

Tue, Nov 15

tsymalla added a comment to D137934: [InstCombine] Fold extractelt with select of constants.

@spatel Thanks for adding these tests. These work in general, except the case where the second operand of the ExtractElement instruction is not a constant. The reason is that currently constantFoldOperationIntoSelectOperand expects both operands to be either the original select or a constant, but not an additional select, so a new extractelement instruction can be created to extract the actual value. If one of the operands is another select, it could be obvious that the sequence shows OOB behavior:

Tue, Nov 15, 2:21 PM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Fix assertion failures

Tue, Nov 15, 6:19 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Removed the whole custom implementation as InstCombine is already able
to do the constant folding, but the Visitor for extractelement needs an
additional check to prevent folding the constants into select operands
when the select uses a condition vector.

Tue, Nov 15, 3:30 AM · Restricted Project, Restricted Project
tsymalla added a comment to D137934: [InstCombine] Fold extractelt with select of constants.

You don't need your new function FoldExtractElementSelectConstVector at all. All you should need to do is to call FoldOpIntoSelect from visitExtractElementInst, and add (trivial) support for ExtractElementInst in foldOperationIntoSelectOperand. For example: https://reviews.llvm.org/differential/diff/475368/

Tue, Nov 15, 3:07 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Remove superfluous dyn_cast for getAggregateElement.

Tue, Nov 15, 2:24 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Remove OOB logic. Simple cases will be handled earlier, so the relevant code
path will not be visited.

Tue, Nov 15, 12:13 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D137934: [InstCombine] Fold extractelt with select of constants.
Tue, Nov 15, 12:06 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D137934: [InstCombine] Fold extractelt with select of constants.
Tue, Nov 15, 12:03 AM · Restricted Project, Restricted Project

Mon, Nov 14

tsymalla added inline comments to D137934: [InstCombine] Fold extractelt with select of constants.
Mon, Nov 14, 11:27 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Update lit tests.

Mon, Nov 14, 10:59 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.

Add additional test to show folding for other types.
Use Constants instead of ConstantInt.
Conditions must be Integer types, no vector types.

Mon, Nov 14, 10:51 AM · Restricted Project, Restricted Project
tsymalla added a comment to D137934: [InstCombine] Fold extractelt with select of constants.

This is missing at least one critical pattern-matching constraint (and regression test - because this will crash):

define i32 @extelt_vecselect_const_operand_vector(<3 x i1> %c) {
  %s = select <3 x i1> %c, <3 x i32> <i32 2, i32 3, i32 4>, <3 x i32> <i32 5, i32 6, i32 7>
  %r = extractelement <3 x i32> %s, i32 2
  ret i32 %r
}
Mon, Nov 14, 8:33 AM · Restricted Project, Restricted Project
tsymalla updated the summary of D137934: [InstCombine] Fold extractelt with select of constants.
Mon, Nov 14, 7:57 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D137934: [InstCombine] Fold extractelt with select of constants.
  • Move logic to FoldOpIntoSelect.
  • Remove superfluous use check for the extractelt instruction.
  • Make use of early returns.
  • Add more / fix existing comments.
Mon, Nov 14, 7:55 AM · Restricted Project, Restricted Project
tsymalla added a comment to D137934: [InstCombine] Fold extractelt with select of constants.

extractelt (select %cond, <vec1>, <vec2>), %c1, %c2 ->
select %cond, <vec1>[c1], <vec2>[c2]

What are %c1 and %c2? Surely these is only one index?

Also your description does not make it clear that you are only doing this for constant vectors. For general vectors it could be: extractelt (select %cond, <vec1>, <vec2>), %c -> select %cond, (extractelt <vec1>, %c), (extractelt <vec2>, %c)

Mon, Nov 14, 6:42 AM · Restricted Project, Restricted Project
tsymalla added a comment to D137934: [InstCombine] Fold extractelt with select of constants.

Can we extend FoldOpIntoSelect to handle this instead?

Mon, Nov 14, 6:41 AM · Restricted Project, Restricted Project
tsymalla added a reviewer for D137934: [InstCombine] Fold extractelt with select of constants: foad.
Mon, Nov 14, 4:16 AM · Restricted Project, Restricted Project
tsymalla requested review of D137934: [InstCombine] Fold extractelt with select of constants.
Mon, Nov 14, 4:11 AM · Restricted Project, Restricted Project
tsymalla committed rG034df6f7323a: [InstCombine][NFC] Add extractelement tests (authored by tsymalla).
[InstCombine][NFC] Add extractelement tests
Mon, Nov 14, 3:56 AM · Restricted Project, Restricted Project

Thu, Nov 10

tsymalla updated the diff for D136432: [AMDGPU] Combine BFI instructions..

Fixed error on Windows build and whitespace issues.

Thu, Nov 10, 6:45 AM · Restricted Project, Restricted Project

Wed, Nov 9

tsymalla updated the diff for D136432: [AMDGPU] Combine BFI instructions..

This change handles most of the tree structures, but not
all of them, because this would add way more complexity.

Wed, Nov 9, 4:12 AM · Restricted Project, Restricted Project
tsymalla committed rGd0133bf86dbc: [NFC][AMDGPU] Pre-commit tests for D136432. (authored by tsymalla).
[NFC][AMDGPU] Pre-commit tests for D136432.
Wed, Nov 9, 2:24 AM · Restricted Project, Restricted Project

Wed, Nov 2

tsymalla added inline comments to D136432: [AMDGPU] Combine BFI instructions..
Wed, Nov 2, 5:42 AM · Restricted Project, Restricted Project

Oct 31 2022

tsymalla updated the diff for D136432: [AMDGPU] Combine BFI instructions..

Re-structure loop once again.
Operands can now be on arbitrary positions.

Oct 31 2022, 12:33 AM · Restricted Project, Restricted Project

Oct 28 2022

tsymalla added inline comments to D136432: [AMDGPU] Combine BFI instructions..
Oct 28 2022, 9:55 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D136432: [AMDGPU] Combine BFI instructions..
Oct 28 2022, 8:07 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D136432: [AMDGPU] Combine BFI instructions..
Oct 28 2022, 7:48 AM · Restricted Project, Restricted Project

Oct 27 2022

tsymalla added inline comments to D136432: [AMDGPU] Combine BFI instructions..
Oct 27 2022, 2:54 AM · Restricted Project, Restricted Project

Oct 26 2022

tsymalla updated the diff for D136432: [AMDGPU] Combine BFI instructions..

Fix the lit tests.
The restructuring of the main loop caused issues, because now it was
also possible that the the top-level OR (the one passed to selectV_BFI)
is matched, which is not intended here.

Oct 26 2022, 9:00 AM · Restricted Project, Restricted Project

Oct 25 2022

tsymalla updated the diff for D136432: [AMDGPU] Combine BFI instructions..

Change the structure of the main fetching loop.

Oct 25 2022, 4:58 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D136432: [AMDGPU] Combine BFI instructions..
Oct 25 2022, 3:17 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D136432: [AMDGPU] Combine BFI instructions..

Only require single uses on nested ORs

Oct 25 2022, 2:01 AM · Restricted Project, Restricted Project
tsymalla committed rG1f23cf4e5038: [NFC][AMDGPU] Pre-commit test for D136432 (authored by tsymalla).
[NFC][AMDGPU] Pre-commit test for D136432
Oct 25 2022, 1:53 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D136432: [AMDGPU] Combine BFI instructions..
Oct 25 2022, 1:46 AM · Restricted Project, Restricted Project

Oct 24 2022

tsymalla added inline comments to D136432: [AMDGPU] Combine BFI instructions..
Oct 24 2022, 10:12 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D136432: [AMDGPU] Combine BFI instructions..

Add use checks.

Oct 24 2022, 10:12 AM · Restricted Project, Restricted Project

Oct 22 2022

tsymalla updated the diff for D136432: [AMDGPU] Combine BFI instructions..

Addressed review comments.
Simplified code and fixed comments.

Oct 22 2022, 7:26 AM · Restricted Project, Restricted Project
tsymalla committed rGfc26a75280c5: [NFC] Fixed several misspellings of "Splitter" in Scalarizer (authored by tsymalla).
[NFC] Fixed several misspellings of "Splitter" in Scalarizer
Oct 22 2022, 6:15 AM · Restricted Project, Restricted Project

Oct 21 2022

tsymalla added a comment to D136432: [AMDGPU] Combine BFI instructions..

I see, thanks!

So Select_BFI just implements special case handling of BFI matching with more complicated expressions that we can still work with (because selectors are constants), and the default case is handled elsewhere.
Maybe we should rename Select_BFI to reflect that?

Oct 21 2022, 3:08 AM · Restricted Project, Restricted Project
tsymalla added a comment to D136432: [AMDGPU] Combine BFI instructions..

As such case cannot be combined into a BFI instruction, I guess it's relatively straight-forwardly translated into something like this:

Why can't we, isn't this essentially the definition of BFI?

Oct 21 2022, 2:37 AM · Restricted Project, Restricted Project
tsymalla added a comment to D136432: [AMDGPU] Combine BFI instructions..

One inline comment on a comment :).

Slightly related: How do we handle (X1 & Y) | (X2 & ~Y) where Y is a variable?

Oct 21 2022, 2:20 AM · Restricted Project, Restricted Project
tsymalla requested review of D136432: [AMDGPU] Combine BFI instructions..
Oct 21 2022, 1:50 AM · Restricted Project, Restricted Project

Oct 18 2022

tsymalla committed rG09fbdde42cc1: [NFC][AMDGPU] Add tests for dependent v_bfi instructions. (authored by tsymalla).
[NFC][AMDGPU] Add tests for dependent v_bfi instructions.
Oct 18 2022, 7:58 AM · Restricted Project, Restricted Project

Oct 6 2022

tsymalla abandoned D134418: [AMDGPU] Improve ISel for v_bfi instructions..

In this specific example, visitMaskedMerge for xor InstCombine tries to combine the xor, and, xor pattern as long as both xor instruction use the same operand. This works for the first xor, and, xor sequence, but changes the IR in such way that the second xor, and, xor sequence (which depends on the result of the first one) cannot be matched anymore even if it could before. This prevents the second v_bfi from being generated.
I will abandon this change and try to generate the canonical form earlier.

Oct 6 2022, 5:11 AM · Restricted Project, Restricted Project

Oct 4 2022

tsymalla added a comment to D134418: [AMDGPU] Improve ISel for v_bfi instructions..

I don't immediately see how shifts are relevant.

For the basic case of nested bitfield inserts, perhaps you could create tests for the cases you want to handle. For example, IR equivalents of:

  1. (x & y) | (~x & z) // single insert
  2. (x & y | (~x & ((u & v) | (~u & z))) // nested insert
  3. (x & ((u & v) | (~u & y))) | (~x & z) // nested insert

For the nested inserts we might want separate test cases depending on whether the "select" arguments x and u are known to be disjoint or not. E.g. 0x0F and 0xF0 are disjoint, 0xFF0 and 0x0FF overlap, and for non-constant values we don't know whether they overlap or not.

Oct 4 2022, 7:17 AM · Restricted Project, Restricted Project
tsymalla updated the summary of D134418: [AMDGPU] Improve ISel for v_bfi instructions..
Oct 4 2022, 6:05 AM · Restricted Project, Restricted Project
tsymalla updated the summary of D134418: [AMDGPU] Improve ISel for v_bfi instructions..
Oct 4 2022, 6:05 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D134418: [AMDGPU] Improve ISel for v_bfi instructions..

Update pattern matching to include a shl instruction.
Describe a case where such pattern can occur.

Oct 4 2022, 6:04 AM · Restricted Project, Restricted Project
tsymalla committed rG82cac65dd286: [NFC][AMDGPU] Pre-commit test for D134418. (authored by tsymalla).
[NFC][AMDGPU] Pre-commit test for D134418.
Oct 4 2022, 5:44 AM · Restricted Project, Restricted Project
tsymalla accepted D135150: [ISel] Fix crash in new FMA DAG combine.
Oct 4 2022, 5:33 AM · Restricted Project, Restricted Project

Sep 29 2022

tsymalla committed rGa41dde2c625e: [AMDGPU] Add use check in v_fma combine. (authored by tsymalla).
[AMDGPU] Add use check in v_fma combine.
Sep 29 2022, 3:25 AM · Restricted Project, Restricted Project
tsymalla closed D134856: [AMDGPU] Add use check in v_fma combine..
Sep 29 2022, 3:25 AM · Restricted Project, Restricted Project
tsymalla requested review of D134856: [AMDGPU] Add use check in v_fma combine..
Sep 29 2022, 12:59 AM · Restricted Project, Restricted Project
tsymalla committed rGa41764810f80: [NFC][AMDGPU] Pre-commit FMA test. (authored by tsymalla).
[NFC][AMDGPU] Pre-commit FMA test.
Sep 29 2022, 12:54 AM · Restricted Project, Restricted Project

Sep 28 2022

tsymalla accepted D134810: [ISel] Fix DAG divergence after new FMA combine.
Sep 28 2022, 10:20 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D134418: [AMDGPU] Improve ISel for v_bfi instructions..
Sep 28 2022, 6:33 AM · Restricted Project, Restricted Project

Sep 23 2022

tsymalla added inline comments to D134418: [AMDGPU] Improve ISel for v_bfi instructions..
Sep 23 2022, 1:18 AM · Restricted Project, Restricted Project

Sep 22 2022

tsymalla updated the summary of D134418: [AMDGPU] Improve ISel for v_bfi instructions..
Sep 22 2022, 11:16 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D134418: [AMDGPU] Improve ISel for v_bfi instructions..

Added DivergentBinFrag class to outermost node.
Fixed comment.

Sep 22 2022, 10:56 AM · Restricted Project, Restricted Project
tsymalla requested review of D134418: [AMDGPU] Improve ISel for v_bfi instructions..
Sep 22 2022, 1:41 AM · Restricted Project, Restricted Project

Sep 21 2022

tsymalla committed rG1f4d3c681c95: [NFC][AMDGPU] Add new v_bfi Codegen test. (authored by tsymalla).
[NFC][AMDGPU] Add new v_bfi Codegen test.
Sep 21 2022, 10:03 AM · Restricted Project, Restricted Project
tsymalla added a comment to D132837: [ISel] Enable generating more fma instructions..

LGTM, thanks!

Sep 21 2022, 3:09 AM · Restricted Project, Restricted Project
tsymalla committed rGc98a46fee6f4: [ISel] Enable generating more fma instructions. (authored by tsymalla).
[ISel] Enable generating more fma instructions.
Sep 21 2022, 3:03 AM · Restricted Project, Restricted Project
tsymalla closed D132837: [ISel] Enable generating more fma instructions..
Sep 21 2022, 3:03 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D132837: [ISel] Enable generating more fma instructions..

Remove TmpFMA check, add additional test.

Sep 21 2022, 2:02 AM · Restricted Project, Restricted Project
tsymalla updated the summary of D132837: [ISel] Enable generating more fma instructions..
Sep 21 2022, 2:00 AM · Restricted Project, Restricted Project
tsymalla committed rG053df6ccafbb: [NFC][AMDGPU] Pre-commit test for D132837. (authored by tsymalla).
[NFC][AMDGPU] Pre-commit test for D132837.
Sep 21 2022, 1:17 AM · Restricted Project, Restricted Project

Sep 17 2022

tsymalla updated the diff for D132837: [ISel] Enable generating more fma instructions..

Once more, change the algorithm to keep the operands in order
Use node morphing instead of updating the node operands.

Sep 17 2022, 2:18 AM · Restricted Project, Restricted Project

Sep 16 2022

tsymalla added inline comments to D132837: [ISel] Enable generating more fma instructions..
Sep 16 2022, 8:48 PM · Restricted Project, Restricted Project
tsymalla added inline comments to D132837: [ISel] Enable generating more fma instructions..
Sep 16 2022, 8:48 PM · Restricted Project, Restricted Project
tsymalla updated the diff for D132837: [ISel] Enable generating more fma instructions..

Addressed comments, added a few comments and updated X86, AArch64, PowerPC
tests.y

Sep 16 2022, 1:35 AM · Restricted Project, Restricted Project
tsymalla added inline comments to D132837: [ISel] Enable generating more fma instructions..
Sep 16 2022, 12:33 AM · Restricted Project, Restricted Project

Sep 14 2022

tsymalla added inline comments to D132837: [ISel] Enable generating more fma instructions..
Sep 14 2022, 8:19 AM · Restricted Project, Restricted Project

Sep 9 2022

tsymalla added a comment to D132837: [ISel] Enable generating more fma instructions..

Did not update the lit tests for other targets yet (CodeGen/AArch64/fadd-combines.ll, CodeGen/PowerPC/fma-assoc.ll, CodeGen/PowerPC/machine-combiner.ll, CodeGen/X86/fma_patterns.ll) because I wanted to get some opinion on the change in the operand order first.

Sep 9 2022, 7:03 AM · Restricted Project, Restricted Project
tsymalla updated the summary of D132837: [ISel] Enable generating more fma instructions..
Sep 9 2022, 5:59 AM · Restricted Project, Restricted Project
tsymalla updated the diff for D132837: [ISel] Enable generating more fma instructions..

This changes a FADD / FMUL => FMA ISel pattern implemented
in D80801 so that it peeks through more than one FMA. This also
changes the order of the operands, which can help with eliminating
a final COPY.

Sep 9 2022, 5:59 AM · Restricted Project, Restricted Project
tsymalla committed rG72730c3f0e20: [NFC][AMDGPU] Pre-commit test for D132837. (authored by tsymalla).
[NFC][AMDGPU] Pre-commit test for D132837.
Sep 9 2022, 5:10 AM · Restricted Project, Restricted Project

Aug 30 2022

tsymalla updated the diff for D132837: [ISel] Enable generating more fma instructions..

Rebase.

Aug 30 2022, 5:30 AM · Restricted Project, Restricted Project
tsymalla committed rGd26dd37149b4: [NFC][AMDGPU] Pre-commit tests for D132837. (authored by tsymalla).
[NFC][AMDGPU] Pre-commit tests for D132837.
Aug 30 2022, 4:56 AM · Restricted Project, Restricted Project
tsymalla closed D132930: [NFC][AMDGPU] Pre-commit tests for D132837..
Aug 30 2022, 4:55 AM · Restricted Project, Restricted Project
tsymalla requested review of D132930: [NFC][AMDGPU] Pre-commit tests for D132837..
Aug 30 2022, 4:52 AM · Restricted Project, Restricted Project

Aug 29 2022

tsymalla requested review of D132837: [ISel] Enable generating more fma instructions..
Aug 29 2022, 2:02 AM · Restricted Project, Restricted Project

Aug 23 2022

tsymalla committed rG5ee0fb7ed234: [NFC][AMDGPU] Some cleanups in the SIOptimizeExecMasking pass. (authored by tsymalla).
[NFC][AMDGPU] Some cleanups in the SIOptimizeExecMasking pass.
Aug 23 2022, 9:17 AM · Restricted Project, Restricted Project
tsymalla closed D132292: [NFC][AMDGPU] Some cleanups in the SIOptimizeExecMasking pass..
Aug 23 2022, 9:17 AM · Restricted Project, Restricted Project