Page MenuHomePhabricator

[OpenMP] Remove use of removed '-f[no-]openmp-new-driver' flag
ClosedPublic

Authored by jhuber6 on Sep 6 2022, 10:58 AM.

Details

Summary

The changes in D130020 removed all support for the old method of
compiling OpenMP offloading programs. This means that
-fopenmp-new-driver has no effect and -fno-openmp-new-driver does
not work. This patch removes the use and documentation of this flag.
Note that the --offload-new-driver flag still exists for using the new
driver optionally with CUDA and HIP.

Diff Detail

Event Timeline

jhuber6 created this revision.Sep 6 2022, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 10:58 AM
jhuber6 requested review of this revision.Sep 6 2022, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2022, 10:58 AM
tra added inline comments.Sep 6 2022, 11:12 AM
clang/lib/Driver/Driver.cpp
3906

The option still exists in the Options.td file. Should it be removed?

jhuber6 added inline comments.Sep 6 2022, 11:23 AM
clang/lib/Driver/Driver.cpp
3906

Generally we don't remove the options once they've been defined (between releases), as this would result in some applications failing to compile after switching from LLVM 15 to LLVM 16 for example. If we just leave it there then it will exist as a warning saying that the flag was unused.

tra accepted this revision.Sep 6 2022, 11:30 AM
tra added inline comments.
clang/lib/Driver/Driver.cpp
3906

SGTM.

This revision is now accepted and ready to land.Sep 6 2022, 11:30 AM