Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[clang] fix missing initialization of original number of expansions
ClosedPublic
Actions

Authored by mizvekov on Aug 12 2022, 12:59 PM.

Details

Reviewers

rsmith
shafik
aaron.ballman
erichkeane

Group Reviewers

Restricted Project

Commits

rGb8a1b698afb2: [clang] fix missing initialization of original number of expansions

Summary

When expanding undeclared function parameters, we should initialize
the original number of expansions, if known, before trying to expand
them, otherwise a length mismatch with an outer pack might not be
diagnosed.

Fixes PR56094.

Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mizvekov created this revision.Aug 12 2022, 12:59 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 12 2022, 12:59 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

mizvekov requested review of this revision.Aug 12 2022, 12:59 PM

mizvekov added a parent revision: D111509: [clang] use getCommonSugar in an assortment of places.Aug 12 2022, 1:08 PM

Harbormaster completed remote builds in B180980: Diff 452281.Aug 12 2022, 2:30 PM

mizvekov retitled this revision from WIP: [clang] fix missing initialization of original number of expansions to [clang] fix missing initialization of original number of expansions.Aug 12 2022, 2:31 PM

mizvekov edited the summary of this revision. (Show Details)

mizvekov added reviewers: rsmith, Restricted Project, shafik, aaron.ballman, erichkeane.

mizvekov added a child revision: D128095: [clang] Improve diagnostics for expansion length mismatch.Aug 12 2022, 2:33 PM

mizvekov mentioned this in D128095: [clang] Improve diagnostics for expansion length mismatch.Aug 12 2022, 2:37 PM

This looks reasonable to me, but I leave it to others to do the final sign-off. Please be sure to add a release note for the fix though.

erichkeane accepted this revision.Aug 15 2022, 6:00 AM

This revision is now accepted and ready to land.Aug 15 2022, 6:00 AM

Closed by commit rGb8a1b698afb2: [clang] fix missing initialization of original number of expansions (authored by mizvekov). · Explain WhyAug 15 2022, 8:40 AM

This revision was automatically updated to reflect the committed changes.

mizvekov added a commit: rGb8a1b698afb2: [clang] fix missing initialization of original number of expansions.

mizvekov removed a child revision: D128095: [clang] Improve diagnostics for expansion length mismatch.Aug 15 2022, 8:45 AM

mizvekov removed a parent revision: D111509: [clang] use getCommonSugar in an assortment of places.Sep 3 2022, 2:35 PM