This is an archive of the discontinued LLVM Phabricator instance.

[mlir][flang] Make use of the new `GEPArg` builder of GEP Op to simplify code.
ClosedPublic

Authored by zero9178 on Jul 28 2022, 2:17 PM.

Details

Summary

This is the follow up on https://reviews.llvm.org/D130730 which goes through upstream code and removes creating constant values in favour of using the constant indices in GEP directly. This leads to less and more readable code and more compact IR as well.

Diff Detail

Event Timeline

zero9178 created this revision.Jul 28 2022, 2:17 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
zero9178 requested review of this revision.Jul 28 2022, 2:17 PM
zero9178 updated this revision to Diff 448466.Jul 28 2022, 4:01 PM

clang-format

Mogball accepted this revision.Aug 1 2022, 7:58 AM
This revision is now accepted and ready to land.Aug 1 2022, 7:58 AM

Thanks for working on this @zero9178 ! Looks like flang-aarch64-latest-gcc is failing after this change, could you take a look?

Thanks for working on this @zero9178 ! Looks like flang-aarch64-latest-gcc is failing after this change, could you take a look?

Apologies, I was testing locally with clang and seemed to have missed the bots email. I'll take a look right away. Feel free to revert to green if it takes too long.