Page MenuHomePhabricator

wsmoses (William Moses)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2017, 5:22 PM (301 w, 6 h)

Recent Activity

Thu, Nov 10

wsmoses added inline comments to D115218: [CodeExtractor] Refactor extractCodeRegion, fix parameter index confusion..
Thu, Nov 10, 1:23 PM · Restricted Project, Restricted Project

Sep 21 2022

wsmoses committed rGf9211330f6be: [MLIR] Set default NVIDIA GPU version (authored by ivanradanov).
[MLIR] Set default NVIDIA GPU version
Sep 21 2022, 3:15 PM · Restricted Project, Restricted Project
wsmoses committed rG2f7a774ed77a: [MLIR] Add a create function for mlir::SerializeToCubinPass (authored by ivanradanov).
[MLIR] Add a create function for mlir::SerializeToCubinPass
Sep 21 2022, 3:03 PM · Restricted Project, Restricted Project
wsmoses closed D134153: Add a create function for mlir::SerializeToCubinPass.
Sep 21 2022, 3:03 PM · Restricted Project, Restricted Project

May 3 2022

wsmoses added a comment to D120575: avoid constructing an incomplete TTI in InlineCostAnnotationPrinterPass.

Since you say it's possible to get the wrong cost, is it possible to create a test case that highlights this?

May 3 2022, 1:23 PM · Restricted Project, Restricted Project

Apr 28 2022

wsmoses added a comment to D119965: [LICM][PhaseOrder] Don't speculate in LICM until after running loop rotate.

Since I feel like this recent conversation is distinct from the PR, I think it deserves its own issue for visibility and tracking.

Apr 28 2022, 9:41 PM · Restricted Project, Restricted Project

Apr 15 2022

wsmoses committed rG0df963e8170d: [MLIR][ClonePass] Attempt fix for anonymous pass name (authored by wsmoses).
[MLIR][ClonePass] Attempt fix for anonymous pass name
Apr 15 2022, 12:14 PM · Restricted Project, Restricted Project
wsmoses added a comment to D122531: [MLIR] Fix operation clone.

You likely didn’t rebase for a while and the CI may not do it itself

Apr 15 2022, 12:13 PM · Restricted Project, Restricted Project
wsmoses added a comment to D122531: [MLIR] Fix operation clone.

I posted this on the commit, sorry! Meant to do it here.
This appears to have broken a number of tests on the Windows buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/19731

LLVM ERROR: TypeID::get<`anonymous-namespace'::ClonePass>(): Using TypeID on a class with an anonymous namespace requires an explicit TypeID definition. The implicit fallback uses string name, which does not guarantee uniqueness in anonymous contexts. Define an explicit TypeID instantiation for this type using `MLIR_DECLARE_EXPLICIT_TYPE_ID`/`MLIR_DEFINE_EXPLICIT_TYPE_ID` or `DEFINE_EXPLICIT_PRIVATE_INLINE_TYPE_ID`.
Apr 15 2022, 12:06 PM · Restricted Project, Restricted Project
wsmoses added a comment to D122531: [MLIR] Fix operation clone.

Uh, this transitive mapping seems wrong to me, isn't it? If it is: should we fix this instead?

Apr 15 2022, 11:41 AM · Restricted Project, Restricted Project
wsmoses committed rG9a8bb4bc635d: [NFC] Update comments (authored by wsmoses).
[NFC] Update comments
Apr 15 2022, 11:33 AM · Restricted Project, Restricted Project
wsmoses committed rGed499ddcdaa6: [MLIR] Fix operation clone (authored by wsmoses).
[MLIR] Fix operation clone
Apr 15 2022, 10:09 AM · Restricted Project, Restricted Project
wsmoses closed D122531: [MLIR] Fix operation clone.
Apr 15 2022, 10:09 AM · Restricted Project, Restricted Project
wsmoses updated the summary of D122531: [MLIR] Fix operation clone.
Apr 15 2022, 9:45 AM · Restricted Project, Restricted Project

Apr 14 2022

wsmoses added a comment to D122531: [MLIR] Fix operation clone.

I didn't quite follow the description of the unroll logic, but can you add a test? It may be easier to figure it out then.

Apr 14 2022, 7:37 PM · Restricted Project, Restricted Project
wsmoses accepted D123792: [mlir] Support opaque types in LLVM IR -> MLIR translation.
Apr 14 2022, 2:26 PM · Restricted Project, Restricted Project
wsmoses updated the diff for D122531: [MLIR] Fix operation clone.

Fix linking

Apr 14 2022, 1:55 PM · Restricted Project, Restricted Project
wsmoses updated the diff for D122531: [MLIR] Fix operation clone.

Fix format

Apr 14 2022, 1:50 PM · Restricted Project, Restricted Project
wsmoses updated the diff for D122531: [MLIR] Fix operation clone.

Add simple clone test

Apr 14 2022, 1:50 PM · Restricted Project, Restricted Project
wsmoses added inline comments to D123792: [mlir] Support opaque types in LLVM IR -> MLIR translation.
Apr 14 2022, 9:48 AM · Restricted Project, Restricted Project

Apr 13 2022

wsmoses accepted D123310: [mlir] initial support for opaque pointers in the LLVM dialect.
Apr 13 2022, 9:35 AM · Restricted Project, Restricted Project
wsmoses added inline comments to D123310: [mlir] initial support for opaque pointers in the LLVM dialect.
Apr 13 2022, 8:26 AM · Restricted Project, Restricted Project
wsmoses accepted D123315: [mlir] Split intrinsics out of LLVMOps.td.
Apr 13 2022, 8:13 AM · Restricted Project, Restricted Project

Apr 10 2022

wsmoses added a comment to D122531: [MLIR] Fix operation clone.

This needs a standalone test that must not depend on any affine stuff. It can be implemented as a simple pass defined in test/lib/IR, there's already a bunch of such passes.

However, I am not convinced the standalone test can be constructed. Looking at the semantics of the change, it moves the addition of the operation results to mapper to be performed after cloning the regions of this operation rather than before. In valid IR, SSACFG regions of an operation cannot use its results, so the presence of these results in the mapper should not have any effect on the contents of the cloned regions. Maybe the IR that Operation::clone is being called on is already invalid. Maybe a nastier thing happens: Value is essentially a pointer, so if the operation defining it is erased without also updating the mapper and another operation is created, the pointer may get reused to point to an irrelevant value. In any case, I suspect it's the unroll pass that needs a fix.

Apr 10 2022, 9:51 PM · Restricted Project, Restricted Project

Mar 28 2022

wsmoses committed rGcd331af06d35: [MLIR][LLVM] Mark read/write behavior of memcpy/memset/memmove (authored by wsmoses).
[MLIR][LLVM] Mark read/write behavior of memcpy/memset/memmove
Mar 28 2022, 10:57 AM · Restricted Project, Restricted Project
wsmoses closed D122552: [MLIR][LLVM] Mark read/write behavior of memcpy/memset/memmove.
Mar 28 2022, 10:57 AM · Restricted Project, Restricted Project

Mar 27 2022

wsmoses updated the diff for D122552: [MLIR][LLVM] Mark read/write behavior of memcpy/memset/memmove.

Remove unnecessary change

Mar 27 2022, 7:02 PM · Restricted Project, Restricted Project
wsmoses requested review of D122552: [MLIR][LLVM] Mark read/write behavior of memcpy/memset/memmove.
Mar 27 2022, 7:00 PM · Restricted Project, Restricted Project

Mar 26 2022

wsmoses requested review of D122531: [MLIR] Fix operation clone.
Mar 26 2022, 11:49 AM · Restricted Project, Restricted Project

Mar 25 2022

wsmoses committed rG89525cbf283f: [Clang] Add helper method to determine if a nonvirtual base has an entry in the… (authored by wsmoses).
[Clang] Add helper method to determine if a nonvirtual base has an entry in the…
Mar 25 2022, 1:32 PM · Restricted Project, Restricted Project
wsmoses closed D122502: [Clang] Add helper method to determine if a nonvirtual base has an entry in the LLVM struct.
Mar 25 2022, 1:32 PM · Restricted Project, Restricted Project
wsmoses added a comment to D122502: [Clang] Add helper method to determine if a nonvirtual base has an entry in the LLVM struct.

Polygeist is a (hopefully soon to be LLVM incubator project: https://discourse.llvm.org/t/rfc-polygeist-llvm-incubator-proposal/60890), that, among other things, is a Clang-based C/C++ frontend for MLIR. As such, we kind of expect to be built alongside clang and borrow the header. As the project gets closer to upstream, hopefully the include sharing will actually be more explicit (and will be made an upstream PR regardless after some other technical debt and paper deadlines).

Mar 25 2022, 1:04 PM · Restricted Project, Restricted Project
wsmoses requested review of D122502: [Clang] Add helper method to determine if a nonvirtual base has an entry in the LLVM struct.
Mar 25 2022, 12:42 PM · Restricted Project, Restricted Project
wsmoses added a comment to D119965: [LICM][PhaseOrder] Don't speculate in LICM until after running loop rotate.

What precisely is the regression and the origin of it? This patch essentially aims to restore the information which was lost during a prior Phase Ordering change in https://reviews.llvm.org/D99249 which caused a large number of performance regressions. What is the behavior of your code prior to https://reviews.llvm.org/D99249 landing?

Mar 25 2022, 11:22 AM · Restricted Project, Restricted Project

Mar 23 2022

wsmoses committed rWf625346ad672: [GSOC] Add Enzyme projects (authored by wsmoses).
[GSOC] Add Enzyme projects
Mar 23 2022, 9:44 PM · Restricted Project

Mar 21 2022

wsmoses committed rG195de3dd6c86: [MLIR][SCF] Fix nested if merging bug (authored by wsmoses).
[MLIR][SCF] Fix nested if merging bug
Mar 21 2022, 8:42 AM · Restricted Project
wsmoses closed D122108: [MLIR][SCF] Fix nested if merging bug.
Mar 21 2022, 8:42 AM · Restricted Project, Restricted Project

Mar 20 2022

wsmoses requested review of D122108: [MLIR][SCF] Fix nested if merging bug.
Mar 20 2022, 5:36 PM · Restricted Project, Restricted Project

Mar 18 2022

wsmoses committed rGd8a6a696bfa1: [MLIR][SCF] Place hoisted scf.if->select prior to the remaining if (authored by wsmoses).
[MLIR][SCF] Place hoisted scf.if->select prior to the remaining if
Mar 18 2022, 7:14 PM · Restricted Project
wsmoses closed D122027: [MLIR][SCF] Place hoisted scf.if->select prior to the remaining if.
Mar 18 2022, 7:14 PM · Restricted Project, Restricted Project
wsmoses requested review of D122027: [MLIR][SCF] Place hoisted scf.if->select prior to the remaining if.
Mar 18 2022, 12:16 PM · Restricted Project, Restricted Project
wsmoses committed rGd144cf5a9873: [MLIR][MemRef] Nested allocation scope inlining (authored by wsmoses).
[MLIR][MemRef] Nested allocation scope inlining
Mar 18 2022, 10:04 AM · Restricted Project
wsmoses closed D121981: [MLIR][MemRef] Nested allocation scope inlining.
Mar 18 2022, 10:04 AM · Restricted Project, Restricted Project
wsmoses committed rGdbe96c8da021: [MLIR][SCF] Combine nested ifs with yields (authored by wsmoses).
[MLIR][SCF] Combine nested ifs with yields
Mar 18 2022, 10:00 AM · Restricted Project
wsmoses closed D121923: [MLIR][SCF] Combine nested ifs with yields.
Mar 18 2022, 10:00 AM · Restricted Project, Restricted Project
wsmoses updated the diff for D121981: [MLIR][MemRef] Nested allocation scope inlining.

Address comments and fix formatting

Mar 18 2022, 9:37 AM · Restricted Project, Restricted Project
wsmoses added inline comments to D121923: [MLIR][SCF] Combine nested ifs with yields.
Mar 18 2022, 8:59 AM · Restricted Project, Restricted Project
wsmoses updated the diff for D121923: [MLIR][SCF] Combine nested ifs with yields.

Address comments and add test without else

Mar 18 2022, 8:59 AM · Restricted Project, Restricted Project
wsmoses committed rG5a31403b513d: [MLIR][SCF] Create selects from if yield results which are not defined in the… (authored by wsmoses).
[MLIR][SCF] Create selects from if yield results which are not defined in the…
Mar 18 2022, 8:39 AM · Restricted Project
wsmoses closed D121943: [MLIR][SCF] Create selects from if yield results which are not defined in the body.
Mar 18 2022, 8:38 AM · Restricted Project, Restricted Project

Mar 17 2022

wsmoses requested review of D121981: [MLIR][MemRef] Nested allocation scope inlining.
Mar 17 2022, 11:54 PM · Restricted Project, Restricted Project
wsmoses accepted D121980: [mlir][Math] Add constant folder for sqrt..
Mar 17 2022, 11:47 PM · Restricted Project, Restricted Project
wsmoses requested review of D121943: [MLIR][SCF] Create selects from if yield results which are not defined in the body.
Mar 17 2022, 12:32 PM · Restricted Project, Restricted Project
wsmoses committed rG164c7afaf5cb: [MLIR][Math] Add constant folder for powf (authored by wsmoses).
[MLIR][Math] Add constant folder for powf
Mar 17 2022, 11:20 AM · Restricted Project
wsmoses closed D121845: [MLIR][Math] Add constant folder for powf.
Mar 17 2022, 11:20 AM · Restricted Project, Restricted Project
wsmoses added inline comments to D121845: [MLIR][Math] Add constant folder for powf.
Mar 17 2022, 10:46 AM · Restricted Project, Restricted Project
wsmoses requested review of D121923: [MLIR][SCF] Combine nested ifs with yields.
Mar 17 2022, 10:02 AM · Restricted Project, Restricted Project

Mar 16 2022

wsmoses committed rG57f72ad91da1: [NFC][MLIR][Affine] Add todo for adding affine namespace (authored by wsmoses).
[NFC][MLIR][Affine] Add todo for adding affine namespace
Mar 16 2022, 8:45 PM · Restricted Project
wsmoses committed rG86706561705d: [MLIR][Affine] Expose region-based isTopLevelValue (authored by wsmoses).
[MLIR][Affine] Expose region-based isTopLevelValue
Mar 16 2022, 8:43 PM · Restricted Project
wsmoses closed D121877: [MLIR][Affine] Expose region-based isTopLevelValue.
Mar 16 2022, 8:43 PM · Restricted Project, Restricted Project
wsmoses requested review of D121877: [MLIR][Affine] Expose region-based isTopLevelValue.
Mar 16 2022, 8:30 PM · Restricted Project, Restricted Project
wsmoses committed rG97eedc74439c: [MLIR][Affine] Expose getAffineScope as a utility function (authored by wsmoses).
[MLIR][Affine] Expose getAffineScope as a utility function
Mar 16 2022, 8:26 PM · Restricted Project
wsmoses closed D121827: [MLIR][Affine] Expose getAffineScope as a utility function.
Mar 16 2022, 8:26 PM · Restricted Project, Restricted Project
wsmoses requested review of D121845: [MLIR][Math] Add constant folder for powf.
Mar 16 2022, 1:51 PM · Restricted Project, Restricted Project
wsmoses updated the diff for D121827: [MLIR][Affine] Expose getAffineScope as a utility function.

Fix build

Mar 16 2022, 11:14 AM · Restricted Project, Restricted Project
wsmoses updated the diff for D121827: [MLIR][Affine] Expose getAffineScope as a utility function.

Fix format

Mar 16 2022, 10:01 AM · Restricted Project, Restricted Project
wsmoses requested review of D121827: [MLIR][Affine] Expose getAffineScope as a utility function.
Mar 16 2022, 9:59 AM · Restricted Project, Restricted Project

Mar 9 2022

wsmoses added inline comments to D121274: [MLIR] Strengthen affine scalar replacement's findUnusedStore.
Mar 9 2022, 8:07 AM · Restricted Project, Restricted Project

Mar 6 2022

wsmoses committed rG87ec6f41bba6: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel (authored by wsmoses).
[OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel
Mar 6 2022, 3:34 PM · Restricted Project
wsmoses closed D121061: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel.
Mar 6 2022, 3:34 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
wsmoses updated the diff for D121061: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel.

Fix clang test

Mar 6 2022, 12:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 5 2022

wsmoses updated the diff for D121061: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel.

Add test file

Mar 5 2022, 3:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
wsmoses requested review of D121061: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel.
Mar 5 2022, 3:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 4 2022

wsmoses committed rG62f84c73d23a: [MLIR][SCF] Allow combining subsequent if statements that yield & negated… (authored by wsmoses).
[MLIR][SCF] Allow combining subsequent if statements that yield & negated…
Mar 4 2022, 9:08 AM · Restricted Project
wsmoses closed D120924: [MLIR][SCF] Allow combining subsequent if statements that yield & negated condition.
Mar 4 2022, 9:07 AM · Restricted Project, Restricted Project
wsmoses committed rG1d1791572cf2: [MLIR][MemRef] Ensure alloca_scope is inlined with no allocating ops (authored by wsmoses).
[MLIR][MemRef] Ensure alloca_scope is inlined with no allocating ops
Mar 4 2022, 8:59 AM · Restricted Project
wsmoses closed D120841: [MLIR][MemRef] Ensure alloca_scope is inlined with no allocating ops.
Mar 4 2022, 8:59 AM · Restricted Project, Restricted Project
wsmoses updated the diff for D120841: [MLIR][MemRef] Ensure alloca_scope is inlined with no allocating ops.

Remove scope from name

Mar 4 2022, 8:55 AM · Restricted Project, Restricted Project
wsmoses updated the diff for D120841: [MLIR][MemRef] Ensure alloca_scope is inlined with no allocating ops.

Change name/docs

Mar 4 2022, 8:22 AM · Restricted Project, Restricted Project
wsmoses updated the diff for D120924: [MLIR][SCF] Allow combining subsequent if statements that yield & negated condition.

Fix test

Mar 4 2022, 8:17 AM · Restricted Project, Restricted Project
wsmoses added inline comments to D120924: [MLIR][SCF] Allow combining subsequent if statements that yield & negated condition.
Mar 4 2022, 8:11 AM · Restricted Project, Restricted Project
wsmoses committed rG4a94a33ca6cb: [MLIR][LLVM] Fold extractvalue to ignore insertvalue at distinct index (authored by wsmoses).
[MLIR][LLVM] Fold extractvalue to ignore insertvalue at distinct index
Mar 4 2022, 8:03 AM · Restricted Project
wsmoses closed D120915: [MLIR][LLVM] Fold extractvalue to ignore insertvalue at distinct index.
Mar 4 2022, 8:03 AM · Restricted Project, Restricted Project

Mar 3 2022

wsmoses committed rGae5a70f2c21b: [MLIR][OpenMP] Mark openmp.parallel and omp.wsloop as having recursive side… (authored by wsmoses).
[MLIR][OpenMP] Mark openmp.parallel and omp.wsloop as having recursive side…
Mar 3 2022, 7:37 PM · Restricted Project
wsmoses closed D120853: [MLIR][OpenMP] Mark openmp.parallel and omp.wsloop as having recursive side effects.
Mar 3 2022, 7:37 PM · Restricted Project, Restricted Project
wsmoses added a comment to D120853: [MLIR][OpenMP] Mark openmp.parallel and omp.wsloop as having recursive side effects.

Can you please add a commit summary with a one-liner rationale here?

Mar 3 2022, 5:07 PM · Restricted Project, Restricted Project
wsmoses updated the summary of D120853: [MLIR][OpenMP] Mark openmp.parallel and omp.wsloop as having recursive side effects.
Mar 3 2022, 5:06 PM · Restricted Project, Restricted Project
wsmoses retitled D120924: [MLIR][SCF] Allow combining subsequent if statements that yield & negated condition from [MLIR][SCF] Allow combining subsequent if statements where the first if statement returns a value to [MLIR][SCF] Allow combining subsequent if statements that yield & negated condition.
Mar 3 2022, 12:08 PM · Restricted Project, Restricted Project
wsmoses updated the diff for D120924: [MLIR][SCF] Allow combining subsequent if statements that yield & negated condition.

Add support for negated conditions

Mar 3 2022, 12:07 PM · Restricted Project, Restricted Project
wsmoses requested review of D120924: [MLIR][SCF] Allow combining subsequent if statements that yield & negated condition.
Mar 3 2022, 11:04 AM · Restricted Project, Restricted Project
wsmoses updated the diff for D120915: [MLIR][LLVM] Fold extractvalue to ignore insertvalue at distinct index.

Fix rebase

Mar 3 2022, 9:47 AM · Restricted Project, Restricted Project
wsmoses requested review of D120915: [MLIR][LLVM] Fold extractvalue to ignore insertvalue at distinct index.
Mar 3 2022, 9:33 AM · Restricted Project, Restricted Project

Mar 2 2022

wsmoses requested review of D120853: [MLIR][OpenMP] Mark openmp.parallel and omp.wsloop as having recursive side effects.
Mar 2 2022, 3:58 PM · Restricted Project, Restricted Project
wsmoses updated the diff for D120841: [MLIR][MemRef] Ensure alloca_scope is inlined with no allocating ops.

Add recursive side effects

Mar 2 2022, 2:22 PM · Restricted Project, Restricted Project
wsmoses requested review of D120841: [MLIR][MemRef] Ensure alloca_scope is inlined with no allocating ops.
Mar 2 2022, 12:13 PM · Restricted Project, Restricted Project
wsmoses committed rG758ddba38113: [MLIR] Use Datalayout defaults when importing LLVM (authored by wsmoses).
[MLIR] Use Datalayout defaults when importing LLVM
Mar 2 2022, 10:01 AM · Restricted Project
wsmoses closed D120832: [MLIR] Use Datalayout defaults when importing LLVM.
Mar 2 2022, 10:01 AM · Restricted Project, Restricted Project
wsmoses committed rGbf6477ebebf8: [MLIR][OpenMP] Place alloca scope within wsloop in scf.parallel to omp lowering (authored by wsmoses).
[MLIR][OpenMP] Place alloca scope within wsloop in scf.parallel to omp lowering
Mar 2 2022, 9:47 AM · Restricted Project
wsmoses closed D120772: [MLIR][OpenMP] Place alloca scope within wsloop in scf.parallel to omp lowering.
Mar 2 2022, 9:47 AM · Restricted Project, Restricted Project
wsmoses requested review of D120832: [MLIR] Use Datalayout defaults when importing LLVM.
Mar 2 2022, 9:41 AM · Restricted Project, Restricted Project