The DAG Combiner unnecessarily restricts commutative CSE
to nodes with a single result value. This commit removes
that restriction.
Signed-off-by: Itay Bookstein <ibookstein@gmail.com>
Paths
| Differential D129666
[SDAG] Remove single-result restriction on commutative CSE ClosedPublic Authored by ibookstein on Jul 13 2022, 10:36 AM.
Details Summary The DAG Combiner unnecessarily restricts commutative CSE Signed-off-by: Itay Bookstein <ibookstein@gmail.com>
Diff Detail
Unit TestsFailed
Event Timeline
barannikov88 added inline comments.
ibookstein added a parent revision: D129905: [SDAG] Add test for DAGCombiner multiple result commutative CSE.Jul 15 2022, 2:22 PM ibookstein removed a parent revision: D129905: [SDAG] Add test for DAGCombiner multiple result commutative CSE. ibookstein added a child revision: D129905: [SDAG] Add test for DAGCombiner multiple result commutative CSE. ibookstein removed a child revision: D129905: [SDAG] Add test for DAGCombiner multiple result commutative CSE.Jul 15 2022, 2:29 PM ibookstein added a parent revision: D129905: [SDAG] Add test for DAGCombiner multiple result commutative CSE. This revision is now accepted and ready to land.Jul 18 2022, 1:54 AM This revision was landed with ongoing or failed builds.Jul 18 2022, 9:19 AM Closed by commit rG2570f226d154: [SDAG] Remove single-result restriction on commutative CSE (authored by ibookstein). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 445132 llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
llvm/test/CodeGen/X86/dagcombine-cse.ll
llvm/test/CodeGen/X86/smul-with-overflow.ll
llvm/test/CodeGen/X86/smulo-128-legalisation-lowering.ll
|
Do we know why this limit was here in the first place?