This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Support ELFCOMPRESS_ZSTD input
ClosedPublic

Authored by MaskRay on Jul 8 2022, 3:47 PM.

Details

Summary

so that lld accepts relocatable object files produced by clang -c -g -gz=zstd.

We don't want to increase the size of InputSection, so do redundant but cheap
ch_type checks instead.

Diff Detail

Event Timeline

MaskRay created this revision.Jul 8 2022, 3:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 3:47 PM
MaskRay updated this revision to Diff 458800.Sep 8 2022, 11:02 AM
MaskRay retitled this revision from WIP [ELF] Support ELFCOMPRESS_ZSTD input to [ELF] Support ELFCOMPRESS_ZSTD input.

Fix gdb-index

MaskRay published this revision for review.Sep 8 2022, 11:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2022, 11:02 AM
MaskRay updated this revision to Diff 458802.Sep 8 2022, 11:07 AM
MaskRay edited the summary of this revision. (Show Details)

add release note

MaskRay updated this revision to Diff 458936.Sep 8 2022, 6:26 PM

simplify test

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2022, 10:25 AM
This revision was automatically updated to reflect the committed changes.

Looks like this didn't get reviewed?

MaskRay added a comment.EditedSep 9 2022, 11:16 AM

Looks like this didn't get reviewed?

Happy to address changes if @ikudrin or @peter.smith has any suggestion.
The changes are pretty mechanical and a dependent was accepted.

Looks like this didn't get reviewed?

Happy to address changes if @ikudrin or @peter.smith has any suggestion.
The changes are pretty mechanical and a dependent was accepted.

The LLVM review process is that if something's sent for review it should not be committed until that review is completed ( https://llvm.org/docs/CodeReview.html#code-review-workflow "Specifically, once a patch is sent out for review, it needs an explicit approval before it is committed. Do not assume silent approval, or solicit objections to a patch with a deadline." ) . (we don't want to encourage people to send things for review that they believe needs review, then commit due to lack of feedback in the time they'd like to receive it)