Page MenuHomePhabricator

ikudrin (Igor Kudrin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2015, 10:51 PM (211 w, 5 h)

Recent Activity

Tue, Sep 10

ikudrin committed rGbc48588f764a: Reland [DWARF] Add a unit test for DWARFUnit::getLength(). (authored by ikudrin).
Reland [DWARF] Add a unit test for DWARFUnit::getLength().
Tue, Sep 10, 4:56 AM
ikudrin committed rL371510: Reland [DWARF] Add a unit test for DWARFUnit::getLength()..
Reland [DWARF] Add a unit test for DWARFUnit::getLength().
Tue, Sep 10, 4:55 AM
ikudrin committed rGc27af19280ac: Revert "[DWARF] Add a unit test for DWARFUnit::getLength()" because it broke… (authored by ikudrin).
Revert "[DWARF] Add a unit test for DWARFUnit::getLength()" because it broke…
Tue, Sep 10, 3:18 AM
ikudrin committed rL371505: Revert "[DWARF] Add a unit test for DWARFUnit::getLength()" because it broke….
Revert "[DWARF] Add a unit test for DWARFUnit::getLength()" because it broke…
Tue, Sep 10, 3:17 AM
ikudrin committed rG3565c6b15c54: [DWARF] Add a unit test for DWARFUnit::getLength(). (authored by ikudrin).
[DWARF] Add a unit test for DWARFUnit::getLength().
Tue, Sep 10, 2:04 AM
ikudrin committed rL371499: [DWARF] Add a unit test for DWARFUnit::getLength()..
[DWARF] Add a unit test for DWARFUnit::getLength().
Tue, Sep 10, 2:04 AM
ikudrin closed D67276: [DWARF] Add a unit test for DWARFUnit::getLength()..
Tue, Sep 10, 2:04 AM · Restricted Project, debug-info

Fri, Sep 6

ikudrin added a comment to D67097: [DWARF] Check for format mismatch between CU and Range List Table..

Sorry to intervene, but what about the patch itself? Is it OK to land with the latest changes or should I improve it somehow?

Fri, Sep 6, 9:05 PM · Restricted Project, debug-info
ikudrin added inline comments to D67276: [DWARF] Add a unit test for DWARFUnit::getLength()..
Fri, Sep 6, 9:00 PM · Restricted Project, debug-info
ikudrin created D67276: [DWARF] Add a unit test for DWARFUnit::getLength()..
Fri, Sep 6, 7:18 AM · Restricted Project, debug-info

Thu, Sep 5

ikudrin removed a parent revision for D67097: [DWARF] Check for format mismatch between CU and Range List Table.: D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Thu, Sep 5, 12:14 AM · Restricted Project, debug-info
ikudrin removed a child revision for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader.: D67097: [DWARF] Check for format mismatch between CU and Range List Table..
Thu, Sep 5, 12:14 AM · Restricted Project, debug-info
ikudrin updated the diff for D67097: [DWARF] Check for format mismatch between CU and Range List Table..
  • Rebase on the current tip.
Thu, Sep 5, 12:11 AM · Restricted Project, debug-info
ikudrin committed rGe46639620d32: [DWARF] Fix referencing Range List Tables from CUs for DWARF64. (authored by ikudrin).
[DWARF] Fix referencing Range List Tables from CUs for DWARF64.
Thu, Sep 5, 12:05 AM
ikudrin committed rL371016: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
[DWARF] Fix referencing Range List Tables from CUs for DWARF64.
Thu, Sep 5, 12:05 AM
ikudrin closed D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
Thu, Sep 5, 12:05 AM · Restricted Project, debug-info

Wed, Sep 4

ikudrin committed rG991f0fb149a3: [DWARF] Support DWARF64 in DWARFListTableHeader. (authored by ikudrin).
[DWARF] Support DWARF64 in DWARFListTableHeader.
Wed, Sep 4, 11:49 PM
ikudrin committed rL371014: [DWARF] Support DWARF64 in DWARFListTableHeader..
[DWARF] Support DWARF64 in DWARFListTableHeader.
Wed, Sep 4, 11:49 PM
ikudrin closed D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Wed, Sep 4, 11:49 PM · Restricted Project, debug-info
ikudrin updated the diff for D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
  • Remove redundant log files. Thanks, @MaskRay!
Wed, Sep 4, 11:34 PM · Restricted Project, debug-info
ikudrin updated the diff for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
  • Use --implicit-check-not=error.
Wed, Sep 4, 11:32 PM · Restricted Project, debug-info
ikudrin added a comment to D67097: [DWARF] Check for format mismatch between CU and Range List Table..

This update didn't seem to touch a test case - is this untested?

Wed, Sep 4, 8:54 PM · Restricted Project, debug-info
ikudrin updated the diff for D67097: [DWARF] Check for format mismatch between CU and Range List Table..
  • Print the adjusted offset which points to the start of the header.
Wed, Sep 4, 3:14 AM · Restricted Project, debug-info

Tue, Sep 3

ikudrin added a comment to D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..

Ping.

Tue, Sep 3, 10:30 PM · Restricted Project, debug-info
ikudrin added a comment to D67097: [DWARF] Check for format mismatch between CU and Range List Table..

I'm not sure if using "OffsetIn" in the diagnostic is the right thing to do.

Tue, Sep 3, 10:30 PM · Restricted Project, debug-info
ikudrin added inline comments to D67097: [DWARF] Check for format mismatch between CU and Range List Table..
Tue, Sep 3, 7:53 AM · Restricted Project, debug-info
ikudrin added a child revision for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader.: D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
Tue, Sep 3, 7:24 AM · Restricted Project, debug-info
ikudrin added a parent revision for D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64.: D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Tue, Sep 3, 7:24 AM · Restricted Project, debug-info
ikudrin created D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
Tue, Sep 3, 7:24 AM · Restricted Project, debug-info
ikudrin created D67097: [DWARF] Check for format mismatch between CU and Range List Table..
Tue, Sep 3, 7:13 AM · Restricted Project, debug-info
ikudrin added a parent revision for D67097: [DWARF] Check for format mismatch between CU and Range List Table.: D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Tue, Sep 3, 7:13 AM · Restricted Project, debug-info
ikudrin added a child revision for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader.: D67097: [DWARF] Check for format mismatch between CU and Range List Table..
Tue, Sep 3, 7:13 AM · Restricted Project, debug-info

Thu, Aug 29

ikudrin updated the diff for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
  • Added a check for reserved values of the length field.
Thu, Aug 29, 8:09 AM · Restricted Project, debug-info

Aug 23 2019

ikudrin created D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Aug 23 2019, 5:06 AM · Restricted Project, debug-info

Aug 21 2019

ikudrin committed rGed413074f206: [DWARF] Adjust return type of DWARFUnit::getLength(). (authored by ikudrin).
[DWARF] Adjust return type of DWARFUnit::getLength().
Aug 21 2019, 7:11 AM
ikudrin committed rL369529: [DWARF] Adjust return type of DWARFUnit::getLength()..
[DWARF] Adjust return type of DWARFUnit::getLength().
Aug 21 2019, 7:11 AM
ikudrin closed D66472: [DWARF] Adjust return type of DWARFUnit::getLength()..
Aug 21 2019, 7:11 AM · Restricted Project
ikudrin added a watcher for debug-info: ikudrin.
Aug 21 2019, 6:31 AM

Aug 20 2019

ikudrin added a comment to D66472: [DWARF] Adjust return type of DWARFUnit::getLength()..

For the record, there are only a few places where DWARFUnit::getLength() is used:

  • DWARFCompileUnit::dump() -- fixed
  • DWARFTypeUnit::dump() -- fixed
  • dumpDebugInfo() in tools/obj2yaml/dwarf2yaml.cpp -- already accepts uint64_t; looks like already supports DWARF64 but worth reviewing.
  • readCuList() in lld/ELF/SyntheticSections.cpp -- already accepts uint64_t; probably supports only DWARF32 for now.
Aug 20 2019, 11:26 PM · Restricted Project
ikudrin added a comment to D66472: [DWARF] Adjust return type of DWARFUnit::getLength()..

Thanks! All other places I found already use the length as uint64_t. I noticed only one suspicious place in lld which I investigate deeper a bit later.

Aug 20 2019, 7:33 AM · Restricted Project
ikudrin updated the summary of D66472: [DWARF] Adjust return type of DWARFUnit::getLength()..
Aug 20 2019, 7:33 AM · Restricted Project
ikudrin added a reviewer for D66472: [DWARF] Adjust return type of DWARFUnit::getLength().: probinson.
Aug 20 2019, 7:14 AM · Restricted Project
ikudrin created D66472: [DWARF] Adjust return type of DWARFUnit::getLength()..
Aug 20 2019, 6:05 AM · Restricted Project
ikudrin committed rG59d5abaa71b5: [DWARF] Fix reading 64-bit DWARF type units. (authored by ikudrin).
[DWARF] Fix reading 64-bit DWARF type units.
Aug 20 2019, 5:59 AM
ikudrin committed rL369378: [DWARF] Fix reading 64-bit DWARF type units..
[DWARF] Fix reading 64-bit DWARF type units.
Aug 20 2019, 5:51 AM
ikudrin closed D66465: [DWARF] Fix reading 64-bit DWARF type units..
Aug 20 2019, 5:51 AM · Restricted Project
ikudrin created D66465: [DWARF] Fix reading 64-bit DWARF type units..
Aug 20 2019, 3:46 AM · Restricted Project
ikudrin committed rGe64af75745ae: [DWARF] Fix DWARFUnit::getDebugInfoSize() for 64-bit DWARF. (authored by ikudrin).
[DWARF] Fix DWARFUnit::getDebugInfoSize() for 64-bit DWARF.
Aug 20 2019, 2:53 AM
ikudrin committed rL369356: [DWARF] Fix DWARFUnit::getDebugInfoSize() for 64-bit DWARF..
[DWARF] Fix DWARFUnit::getDebugInfoSize() for 64-bit DWARF.
Aug 20 2019, 2:50 AM
ikudrin closed D66421: [DWARF] Fix DWARFUnit::getDebugInfoSize() for 64-bit DWARF..
Aug 20 2019, 2:50 AM · Restricted Project

Aug 19 2019

ikudrin created D66421: [DWARF] Fix DWARFUnit::getDebugInfoSize() for 64-bit DWARF..
Aug 19 2019, 8:54 AM · Restricted Project

Aug 15 2019

ikudrin committed rGa33004aca708: Remove the temporary code. NFC. (authored by ikudrin).
Remove the temporary code. NFC.
Aug 15 2019, 8:40 PM
ikudrin committed rL369082: Remove the temporary code. NFC..
Remove the temporary code. NFC.
Aug 15 2019, 8:40 PM

Aug 9 2019

ikudrin committed rGb65016ddac32: [ELF] For VS-style diagnostics, prefer printing full paths in the header. (authored by ikudrin).
[ELF] For VS-style diagnostics, prefer printing full paths in the header.
Aug 9 2019, 1:31 AM
ikudrin committed rL368409: [ELF] For VS-style diagnostics, prefer printing full paths in the header..
[ELF] For VS-style diagnostics, prefer printing full paths in the header.
Aug 9 2019, 1:28 AM
ikudrin closed D65875: [ELF] For VS-style diagnostics, prefer using the full path..
Aug 9 2019, 1:28 AM · Restricted Project, lld

Aug 8 2019

ikudrin added a comment to D65875: [ELF] For VS-style diagnostics, prefer using the full path..

Well, I have checked the patch on Windows. All tests pass.

Aug 8 2019, 6:31 AM · Restricted Project, lld
ikudrin added a comment to D65875: [ELF] For VS-style diagnostics, prefer using the full path..

We had that issue with D65810 (rL368153), windows build bots complained about different path separators. That was fixed in rL368169. Thus, I made similar adjustments in this patch.

Aug 8 2019, 3:39 AM · Restricted Project, lld

Aug 7 2019

ikudrin created D65875: [ELF] For VS-style diagnostics, prefer using the full path..
Aug 7 2019, 7:53 AM · Restricted Project, lld
ikudrin committed rG0e1fea675407: Try to fix windows build bots after r368153. (authored by ikudrin).
Try to fix windows build bots after r368153.
Aug 7 2019, 6:24 AM
ikudrin committed rL368169: Try to fix windows build bots after r368153..
Try to fix windows build bots after r368153.
Aug 7 2019, 6:24 AM
ikudrin committed rG45ee93323ba6: Remove support for 32-bit offsets in utility classes (5/5) (authored by ikudrin).
Remove support for 32-bit offsets in utility classes (5/5)
Aug 7 2019, 4:45 AM
ikudrin committed rL368156: Remove support for 32-bit offsets in utility classes (5/5).
Remove support for 32-bit offsets in utility classes (5/5)
Aug 7 2019, 4:44 AM
ikudrin closed D65641: Remove support for 32-bit offsets in utility classes (5/5).
Aug 7 2019, 4:44 AM · Restricted Project
ikudrin added a comment to D65638: Switch LLVM to use 64-bit offsets (2/5).

Thanks! I'll remove that code in the cleanup patch.

Aug 7 2019, 4:39 AM · Restricted Project
ikudrin committed rGda41e2107e3f: [ELF] Fix splitting messages for duplicate symbols. (authored by ikudrin).
[ELF] Fix splitting messages for duplicate symbols.
Aug 7 2019, 4:34 AM
ikudrin committed rL368153: [ELF] Fix splitting messages for duplicate symbols..
[ELF] Fix splitting messages for duplicate symbols.
Aug 7 2019, 4:34 AM
ikudrin closed D65810: [ELF] Fix splitting messages for duplicate symbols..
Aug 7 2019, 4:33 AM · Restricted Project, lld

Aug 6 2019

ikudrin updated the diff for D65810: [ELF] Fix splitting messages for duplicate symbols..
  • Removed Inputs/vs-diagnostics-duplicate-split.s
  • Updated the test accordingly.
Aug 6 2019, 11:56 PM · Restricted Project, lld
ikudrin created D65810: [ELF] Fix splitting messages for duplicate symbols..
Aug 6 2019, 8:36 AM · Restricted Project, lld
ikudrin committed rG0be738895c93: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5) (authored by ikudrin).
Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5)
Aug 6 2019, 6:42 AM
ikudrin committed rG5978c9249bbf: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5) (authored by ikudrin).
[MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5)
Aug 6 2019, 6:41 AM
ikudrin committed rL368033: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5).
Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5)
Aug 6 2019, 6:41 AM
ikudrin closed D65640: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5).
Aug 6 2019, 6:41 AM · Restricted Project, Restricted Project
ikudrin committed rL368032: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).
[MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5)
Aug 6 2019, 6:37 AM
ikudrin closed D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).
Aug 6 2019, 6:36 AM · Restricted Project, lld
ikudrin committed rG2836cf0b72aa: Try to unbreak buildbots after r368014 (authored by ikudrin).
Try to unbreak buildbots after r368014
Aug 6 2019, 4:13 AM
ikudrin committed rL368018: Try to unbreak buildbots after r368014.
Try to unbreak buildbots after r368014
Aug 6 2019, 4:11 AM
ikudrin committed rGf26a70a5e7b7: Switch LLVM to use 64-bit offsets (2/5) (authored by ikudrin).
Switch LLVM to use 64-bit offsets (2/5)
Aug 6 2019, 3:50 AM
ikudrin committed rL368014: Switch LLVM to use 64-bit offsets (2/5).
Switch LLVM to use 64-bit offsets (2/5)
Aug 6 2019, 3:50 AM
ikudrin closed D65638: Switch LLVM to use 64-bit offsets (2/5).
Aug 6 2019, 3:49 AM · Restricted Project
ikudrin committed rGf5f35c5cd110: Support 64-bit offsets in utility classes (1/5) (authored by ikudrin).
Support 64-bit offsets in utility classes (1/5)
Aug 6 2019, 3:49 AM
ikudrin committed rL368013: Support 64-bit offsets in utility classes (1/5).
Support 64-bit offsets in utility classes (1/5)
Aug 6 2019, 3:49 AM
ikudrin closed D64006: Support 64-bit offsets in utility classes (1/5).
Aug 6 2019, 3:49 AM · Restricted Project

Aug 2 2019

ikudrin added parent revisions for D65641: Remove support for 32-bit offsets in utility classes (5/5): D65640: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5), D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).
Aug 2 2019, 2:15 AM · Restricted Project
ikudrin added a child revision for D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5): D65641: Remove support for 32-bit offsets in utility classes (5/5).
Aug 2 2019, 2:15 AM · Restricted Project, lld
ikudrin added a child revision for D65640: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5): D65641: Remove support for 32-bit offsets in utility classes (5/5).
Aug 2 2019, 2:15 AM · Restricted Project, Restricted Project
ikudrin created D65641: Remove support for 32-bit offsets in utility classes (5/5).
Aug 2 2019, 2:15 AM · Restricted Project
ikudrin removed a child revision for D64006: Support 64-bit offsets in utility classes (1/5): D64209: [DWARF] Make DWARFDataExtractor possible to be used with both 32- and 64-bit offsets..
Aug 2 2019, 2:13 AM · Restricted Project
ikudrin removed a parent revision for D64209: [DWARF] Make DWARFDataExtractor possible to be used with both 32- and 64-bit offsets.: D64006: Support 64-bit offsets in utility classes (1/5).
Aug 2 2019, 2:13 AM · Restricted Project
ikudrin added a parent revision for D65640: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5): D65638: Switch LLVM to use 64-bit offsets (2/5).
Aug 2 2019, 2:13 AM · Restricted Project, Restricted Project
ikudrin added a child revision for D65638: Switch LLVM to use 64-bit offsets (2/5): D65640: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5).
Aug 2 2019, 2:13 AM · Restricted Project
ikudrin created D65640: Update LLDB to follow changes in llvm::DWARFDebugNames::NameIndex (4/5).
Aug 2 2019, 2:13 AM · Restricted Project, Restricted Project
ikudrin added a parent revision for D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5): D65638: Switch LLVM to use 64-bit offsets (2/5).
Aug 2 2019, 2:07 AM · Restricted Project, lld
ikudrin added a child revision for D65638: Switch LLVM to use 64-bit offsets (2/5): D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).
Aug 2 2019, 2:07 AM · Restricted Project
ikudrin created D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).
Aug 2 2019, 2:07 AM · Restricted Project, lld
ikudrin added a comment to D65638: Switch LLVM to use 64-bit offsets (2/5).

I know this is huge. Locally, I have 20+ separate patches covering that, but I am not sure if it is simpler to look at one big patch or lots of smaller patches.

Aug 2 2019, 2:05 AM · Restricted Project
ikudrin added a parent revision for D65638: Switch LLVM to use 64-bit offsets (2/5): D64006: Support 64-bit offsets in utility classes (1/5).
Aug 2 2019, 1:58 AM · Restricted Project
ikudrin added a child revision for D64006: Support 64-bit offsets in utility classes (1/5): D65638: Switch LLVM to use 64-bit offsets (2/5).
Aug 2 2019, 1:58 AM · Restricted Project
ikudrin created D65638: Switch LLVM to use 64-bit offsets (2/5).
Aug 2 2019, 1:58 AM · Restricted Project