Page MenuHomePhabricator

ikudrin (Igor Kudrin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2015, 10:51 PM (202 w, 5 h)

Recent Activity

Sat, Jul 20

ikudrin created D65039: [DWARF] Add named constants for reserved values of an initial length field..
Sat, Jul 20, 5:47 AM · Restricted Project

Tue, Jul 16

ikudrin committed rGf48bc0181232: [DWARF] Fix the reserved values for unit length in DWARFDebugLine. (authored by ikudrin).
[DWARF] Fix the reserved values for unit length in DWARFDebugLine.
Tue, Jul 16, 12:02 AM
ikudrin committed rL366190: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..
[DWARF] Fix the reserved values for unit length in DWARFDebugLine.
Tue, Jul 16, 12:01 AM
ikudrin closed D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..
Tue, Jul 16, 12:00 AM · Restricted Project

Mon, Jul 15

ikudrin committed rG74c350af2181: [DWARF] Fix an incorrect format specifier. (authored by ikudrin).
[DWARF] Fix an incorrect format specifier.
Mon, Jul 15, 11:57 PM
ikudrin committed rL366189: [DWARF] Fix an incorrect format specifier..
[DWARF] Fix an incorrect format specifier.
Mon, Jul 15, 11:56 PM
ikudrin closed D64620: [DWARF] Fix an incorrect format specifier..
Mon, Jul 15, 11:56 PM · Restricted Project
ikudrin committed rG860f7ec05871: [DWARF] Simplify DWARFAttribute. NFC. (authored by ikudrin).
[DWARF] Simplify DWARFAttribute. NFC.
Mon, Jul 15, 11:54 PM
ikudrin committed rL366188: [DWARF] Simplify DWARFAttribute. NFC..
[DWARF] Simplify DWARFAttribute. NFC.
Mon, Jul 15, 11:53 PM
ikudrin closed D64407: [DWARF] Simplify DWARFAttribute. NFC..
Mon, Jul 15, 11:53 PM · Restricted Project
ikudrin added a comment to D64407: [DWARF] Simplify DWARFAttribute. NFC..

Ping.

Mon, Jul 15, 9:16 PM · Restricted Project
ikudrin added a comment to D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..

Thanks! I'll prepare a patch to symbolize these magic numbers a bit later.

Mon, Jul 15, 8:24 AM · Restricted Project
ikudrin added a comment to D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..

I see that there are no tests verifying that DWARFDebugLine handles the invalid length correctly (assuming you ran the tests and none failed), so please add one.

Mon, Jul 15, 8:12 AM · Restricted Project

Fri, Jul 12

ikudrin added a comment to D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..

I mean, the purposes for the patches are different. This one fixes an existing flaw while your suggestion improves code quality. It is usually better not to intermix such different aims in one patch, no?

Fri, Jul 12, 6:58 PM · Restricted Project
ikudrin added a comment to D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..

Right, but maybe that worths another patch?

Fri, Jul 12, 11:06 AM · Restricted Project
ikudrin created D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..
Fri, Jul 12, 2:30 AM · Restricted Project
ikudrin created D64620: [DWARF] Fix an incorrect format specifier..
Fri, Jul 12, 2:15 AM · Restricted Project

Wed, Jul 10

ikudrin added inline comments to D64407: [DWARF] Simplify DWARFAttribute. NFC..
Wed, Jul 10, 8:19 PM · Restricted Project
ikudrin updated the diff for D64407: [DWARF] Simplify DWARFAttribute. NFC..
  • Removed explicit initialization of Value.
Wed, Jul 10, 8:18 PM · Restricted Project
ikudrin updated the diff for D64407: [DWARF] Simplify DWARFAttribute. NFC..
  • Adjusted the initializer for Value.
  • Removed the constructor.
  • Removed the method clear() and replaced the only usage with AttrValue = {}.
Wed, Jul 10, 2:45 AM · Restricted Project

Tue, Jul 9

ikudrin added inline comments to D64407: [DWARF] Simplify DWARFAttribute. NFC..
Tue, Jul 9, 7:04 AM · Restricted Project
ikudrin updated the diff for D64407: [DWARF] Simplify DWARFAttribute. NFC..
  • Removed AttrValue from the member initializer list of the constructor of DWARFDie::attribute_iterator.
Tue, Jul 9, 7:03 AM · Restricted Project
ikudrin created D64407: [DWARF] Simplify DWARFAttribute. NFC..
Tue, Jul 9, 5:47 AM · Restricted Project
ikudrin added inline comments to D64396: [DWARF] Dump .gdb_index of version 8.
Tue, Jul 9, 4:27 AM · Restricted Project

Thu, Jul 4

ikudrin added a comment to D64006: [Support] Support 64-bit offsets in DataExtractor..

In that case, what do you think about templates?

They help, for sure - though I I'm not sure it's probably necessary to have even that complexity (having DataExtractor templated on an integer type for the cursor), at least I don't see it yet, maybe with better understanding I might - but for now it really sounds like we would've built this with uint64_t only if we started from scratch.

Thu, Jul 4, 8:06 AM · Restricted Project
ikudrin added a parent revision for D64209: [DWARF] Make DWARFDataExtractor possible to be used with both 32- and 64-bit offsets.: D64006: [Support] Support 64-bit offsets in DataExtractor..
Thu, Jul 4, 8:03 AM · Restricted Project
ikudrin created D64209: [DWARF] Make DWARFDataExtractor possible to be used with both 32- and 64-bit offsets..
Thu, Jul 4, 8:03 AM · Restricted Project
ikudrin added a child revision for D64006: [Support] Support 64-bit offsets in DataExtractor.: D64209: [DWARF] Make DWARFDataExtractor possible to be used with both 32- and 64-bit offsets..
Thu, Jul 4, 8:03 AM · Restricted Project
ikudrin abandoned D64059: [DO NOT SUBMIT] Switch DataExtractor to 64-bit offsets.
Thu, Jul 4, 7:54 AM

Wed, Jul 3

ikudrin added a comment to D64006: [Support] Support 64-bit offsets in DataExtractor..

I think the main one is code duplication - write once/fix once/etc is valuable.

Wed, Jul 3, 11:05 AM · Restricted Project
ikudrin added a comment to D64006: [Support] Support 64-bit offsets in DataExtractor..

...in places where it likely won't be needed any time soon, such as 64-bit DWARF parsing support.

In fact, I am going to implement 64-bit DWARF support. I started from DataExtractor because changing it seems inevitable for that anyway.

Wed, Jul 3, 12:53 AM · Restricted Project

Tue, Jul 2

ikudrin committed rGc310b1aaed65: [DWARF] Simplify dumping of a .debug_addr section. (authored by ikudrin).
[DWARF] Simplify dumping of a .debug_addr section.
Tue, Jul 2, 2:59 AM
ikudrin committed rL364896: [DWARF] Simplify dumping of a .debug_addr section..
[DWARF] Simplify dumping of a .debug_addr section.
Tue, Jul 2, 2:59 AM
ikudrin closed D64020: [DWARF] Simplify dumping of a .debug_addr section..
Tue, Jul 2, 2:59 AM · Restricted Project

Mon, Jul 1

ikudrin added a comment to D64006: [Support] Support 64-bit offsets in DataExtractor..

Initially, I tried to replace uint32_t offsets to uint64_t. Unfortunately, that is not as mechanical, as you might expect. Please look at D64059, which is my current progress with that approach. It is far to be complete and it is already overwhelmingly complex.

Mon, Jul 1, 10:08 PM · Restricted Project
ikudrin created D64059: [DO NOT SUBMIT] Switch DataExtractor to 64-bit offsets.
Mon, Jul 1, 9:31 PM
ikudrin added a comment to D64020: [DWARF] Simplify dumping of a .debug_addr section..

The similar code might be found in DWARFListTable, I guess that it might accidentally come from there.

Mon, Jul 1, 10:40 AM · Restricted Project
ikudrin created D64020: [DWARF] Simplify dumping of a .debug_addr section..
Mon, Jul 1, 10:35 AM · Restricted Project
ikudrin added inline comments to D64006: [Support] Support 64-bit offsets in DataExtractor..
Mon, Jul 1, 10:19 AM · Restricted Project
ikudrin created D64006: [Support] Support 64-bit offsets in DataExtractor..
Mon, Jul 1, 6:18 AM · Restricted Project
ikudrin added a comment to D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..

I am not sure what you mean by "break". Can you share a reproducer?

Mon, Jul 1, 4:39 AM · Restricted Project

Fri, Jun 28

ikudrin committed rGfd0ad4b24d65: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty. (authored by ikudrin).
[ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty.
Fri, Jun 28, 3:17 AM
ikudrin committed rL364639: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty..
[ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty.
Fri, Jun 28, 3:16 AM
ikudrin closed D63869: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty..
Fri, Jun 28, 3:16 AM · Restricted Project, lld
ikudrin updated the diff for D63869: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty..
  • Extended the test and moved it into the linkerscript folder.
Fri, Jun 28, 12:54 AM · Restricted Project, lld

Thu, Jun 27

ikudrin added inline comments to D63869: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty..
Thu, Jun 27, 4:55 AM · Restricted Project, lld
ikudrin updated the diff for D63869: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty..
  • Reworked the test.

I am not sure about moving it into linkerscript, though, because it does not test the support for linker scripts per se. Moreover, there are lots of tests in the main test folder which also use linker scripts.

Thu, Jun 27, 4:50 AM · Restricted Project, lld
ikudrin added a comment to D63869: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty..

On Linux, the issue can be reproduced in the following way:

Thu, Jun 27, 4:20 AM · Restricted Project, lld
ikudrin created D63869: [ELF] Do not produce DT_JMPREL and DT_PLTGOT if .rela.plt is empty..
Thu, Jun 27, 4:11 AM · Restricted Project, lld

Tue, Jun 25

ikudrin accepted D63651: [docs][llvm-symbolizer] Improve llvm-symbolizer documentation.

Thanks!

Tue, Jun 25, 10:08 PM · Restricted Project

Mon, Jun 24

ikudrin added inline comments to D63651: [docs][llvm-symbolizer] Improve llvm-symbolizer documentation.
Mon, Jun 24, 10:55 PM · Restricted Project

Jun 19 2019

ikudrin accepted D63537: [llvm-dwarfdump] --gdb-index: fix uninitialized TuListOffset.

LGTM. Thanks!

Jun 19 2019, 6:40 AM · Restricted Project
ikudrin added a comment to D63537: [llvm-dwarfdump] --gdb-index: fix uninitialized TuListOffset.

Yes, I saw the same lines in lld.

Jun 19 2019, 3:14 AM · Restricted Project
ikudrin added a comment to D63537: [llvm-dwarfdump] --gdb-index: fix uninitialized TuListOffset.

I don't know a way to create that list, too. lld definitely does not create it. Maybe, gold can help?

Jun 19 2019, 2:50 AM · Restricted Project

Jun 4 2019

ikudrin accepted D62371: [llvm-symbolizer] Flush output on bad input.

LGTM

Jun 4 2019, 7:51 AM · Restricted Project

Jun 3 2019

ikudrin added inline comments to D62371: [llvm-symbolizer] Flush output on bad input.
Jun 3 2019, 4:37 AM · Restricted Project

May 27 2019

ikudrin added inline comments to D62371: [llvm-symbolizer] Flush output on bad input.
May 27 2019, 8:13 AM · Restricted Project

May 24 2019

ikudrin added a comment to D62371: [llvm-symbolizer] Flush output on bad input.

I am a bit worried about the test which may, potentially, hang. Don't you think there should be any kind of a watchdog?

May 24 2019, 5:17 AM · Restricted Project

May 23 2019

ikudrin committed rG0de4e935bb59: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on… (authored by ikudrin).
Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on…
May 23 2019, 9:44 PM
ikudrin committed rL361598: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on….
Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on…
May 23 2019, 9:43 PM
ikudrin committed rC361598: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on….
Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on…
May 23 2019, 9:43 PM
ikudrin closed D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
May 23 2019, 9:43 PM · Restricted Project

May 22 2019

ikudrin updated the diff for D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..

Added a comment explaining the differences in the implementations. I would really appreciate any corrections.

May 22 2019, 8:11 AM · Restricted Project

May 20 2019

ikudrin updated the diff for D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
  • Made the patch affect only -fdiagnostics-absolute-paths option.
May 20 2019, 4:35 AM · Restricted Project

May 16 2019

ikudrin committed rG261a1bc129e7: Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test. (authored by ikudrin).
Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test.
May 16 2019, 2:05 AM
ikudrin committed rLLD360866: Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test..
Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test.
May 16 2019, 2:04 AM
ikudrin committed rL360866: Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test..
Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test.
May 16 2019, 2:04 AM

May 15 2019

ikudrin committed rG4669cf27508b: [LTO] Improve readability of module IDs (authored by ikudrin).
[LTO] Improve readability of module IDs
May 15 2019, 10:22 PM
ikudrin committed rG1ff8b7bdf108: [IRMover] Improve diagnostic messages for conflicting metadata (authored by ikudrin).
[IRMover] Improve diagnostic messages for conflicting metadata
May 15 2019, 10:22 PM
ikudrin committed rL360858: [LTO] Improve readability of module IDs.
[LTO] Improve readability of module IDs
May 15 2019, 10:22 PM
ikudrin committed rLLD360858: [LTO] Improve readability of module IDs.
[LTO] Improve readability of module IDs
May 15 2019, 10:22 PM
ikudrin closed D61857: [LTO] Improve readability of module IDs.
May 15 2019, 10:22 PM · Restricted Project
ikudrin committed rL360857: [IRMover] Improve diagnostic messages for conflicting metadata.
[IRMover] Improve diagnostic messages for conflicting metadata
May 15 2019, 10:22 PM
ikudrin closed D61880: [IRMover] Improve diagnostic messages for conflicting metadata.
May 15 2019, 10:22 PM · Restricted Project
ikudrin updated the diff for D61857: [LTO] Improve readability of module IDs.
  • Changed the format to <archive name>(<object name> at <offset>);
  • Changed "if" to "?:";
  • Simplified a check in the tests.
May 15 2019, 4:58 AM · Restricted Project

May 13 2019

ikudrin created D61880: [IRMover] Improve diagnostic messages for conflicting metadata.
May 13 2019, 10:15 PM · Restricted Project
ikudrin created D61857: [LTO] Improve readability of module IDs.
May 13 2019, 9:08 AM · Restricted Project

May 2 2019

ikudrin committed rGd2c82e8ad0af: [docs] Add support for Markdown documentation when creating man pages (authored by ikudrin).
[docs] Add support for Markdown documentation when creating man pages
May 2 2019, 10:11 PM
ikudrin committed rL359860: [docs] Add support for Markdown documentation when creating man pages.
[docs] Add support for Markdown documentation when creating man pages
May 2 2019, 10:11 PM
ikudrin closed D60964: [docs] Add support for Markdown documentation when creating man pages.
May 2 2019, 10:11 PM · Restricted Project

May 1 2019

ikudrin updated the diff for D60964: [docs] Add support for Markdown documentation when creating man pages.
  • Updated according to @MaskRay's comments.
May 1 2019, 5:17 AM · Restricted Project
ikudrin added a comment to D60964: [docs] Add support for Markdown documentation when creating man pages.

LGTM, I think (not verified the regex though).

May 1 2019, 5:02 AM · Restricted Project
ikudrin updated the diff for D60964: [docs] Add support for Markdown documentation when creating man pages.
  • Simplified print statements.
  • Added escaping in the regex string.
May 1 2019, 4:25 AM · Restricted Project

Apr 22 2019

ikudrin created D60964: [docs] Add support for Markdown documentation when creating man pages.
Apr 22 2019, 6:18 AM · Restricted Project

Apr 19 2019

ikudrin committed rG99f641ccadca: [llvm-symbolizer] Add llvm-addr2line (authored by ikudrin).
[llvm-symbolizer] Add llvm-addr2line
Apr 19 2019, 3:18 AM
ikudrin committed rL358749: [llvm-symbolizer] Add llvm-addr2line.
[llvm-symbolizer] Add llvm-addr2line
Apr 19 2019, 3:16 AM
ikudrin closed D60067: [llvm-symbolizer] Add llvm-addr2line.
Apr 19 2019, 3:16 AM · Restricted Project
ikudrin committed rG1b71b7f3b886: [llvm-symbolizer] Unhide and document the "-output-style" option (authored by ikudrin).
[llvm-symbolizer] Unhide and document the "-output-style" option
Apr 19 2019, 3:16 AM
ikudrin committed rL358748: [llvm-symbolizer] Unhide and document the "-output-style" option.
[llvm-symbolizer] Unhide and document the "-output-style" option
Apr 19 2019, 3:15 AM
ikudrin closed D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.
Apr 19 2019, 3:15 AM · Restricted Project
ikudrin committed rG4bc29cbf6b39: [llvm-symbolizer] Make the output with -output-style=GNU closer to addr2line's (authored by ikudrin).
[llvm-symbolizer] Make the output with -output-style=GNU closer to addr2line's
Apr 19 2019, 3:15 AM
ikudrin committed rL358747: [llvm-symbolizer] Make the output with -output-style=GNU closer to addr2line's.
[llvm-symbolizer] Make the output with -output-style=GNU closer to addr2line's
Apr 19 2019, 3:15 AM
ikudrin closed D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
Apr 19 2019, 3:15 AM · Restricted Project

Apr 17 2019

ikudrin updated the diff for D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.

Thanks!

Apr 17 2019, 5:44 AM · Restricted Project
ikudrin added a child revision for D60816: [llvm-symbolizer] Unhide and document the '-output-style' option: D60067: [llvm-symbolizer] Add llvm-addr2line.
Apr 17 2019, 5:15 AM · Restricted Project
ikudrin added a parent revision for D60067: [llvm-symbolizer] Add llvm-addr2line: D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.
Apr 17 2019, 5:15 AM · Restricted Project
ikudrin updated the diff for D60067: [llvm-symbolizer] Add llvm-addr2line.
  • Rebased on top of D60816; updated the documentation accordingly.
Apr 17 2019, 5:15 AM · Restricted Project
ikudrin updated the diff for D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.
  • Extended an example for the --output-style option.
Apr 17 2019, 5:02 AM · Restricted Project
ikudrin added a parent revision for D60816: [llvm-symbolizer] Unhide and document the '-output-style' option: D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
Apr 17 2019, 4:30 AM · Restricted Project
ikudrin added a child revision for D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's: D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.
Apr 17 2019, 4:30 AM · Restricted Project