User Details
- User Since
- Sep 6 2015, 10:51 PM (350 w, 11 h)
Tue, Apr 26
Mon, Apr 25
- Extract an NFCI part into D124388
Apr 22 2022
Unfortunatelly, I do not have access to SPEC tests. I checked with 7zip-benchmark and found that Compressing speed is slightly improved with this patch while Decompressing is slightly degraded. But I have to note that compared to a Release build, PGO one is worse even without the patch.
Apr 21 2022
- Update the comment.
- Remove checking for !UnrollPeelMaxCount because a similar condition is anyway checked in line 397.
Apr 15 2022
Our test was for AArch64, so there should be no effects like loop alignment, if I understand you right. I couldn't find a benchmark to test the change against, so I prepared an artificial one based on LLVM test suite/SingleSource/Benchmarks/Adobe-C++/loop-unroll.cpp. I saw the performance gain 10%-30% depending on the iterations count (on x86_64). But I understand that that test is probably biased, so if you recommend some commonly recognized public benchmark that might be suitable for the case, I would try it. As for a more deep analysis, could you share some examples so I can grab some ideas from them?
A bit of the context. After D71990, we noticed that one of our tests became slower and did not benefit from PGO. The test has a loop that is executed exactly 8 times, and, before the patch, it was (partially) unrolled but after the patch, the loop is preserved in the compact form.
Mar 29 2022
LGTM
Mar 28 2022
LGTM then
If I understand it right, --fortran-common is useful in rare scenarios but can slow down linking when handling COMMON symbols, and it also hinders implementing the parallel symbol resolution. If that is true, I agree with the change.
Mar 22 2022
Mar 21 2022
I like the idea and don't see real drawbacks, so LGTM.
Mar 18 2022
Mar 15 2022
Mar 14 2022
LGTM
- Removed llvm::
- Update the test
Mar 13 2022
- Fixed a formatting issue
- Updated the test
Mar 11 2022
Mar 10 2022
Mar 7 2022
LGTM
Feb 24 2022
Thanks for the update! LGTM.
Feb 22 2022
LGTM.
Feb 21 2022
It looks like the patch was somehow intermixed with D119909. git cannot apply it on ToT.
Feb 17 2022
Feb 16 2022
Feb 9 2022
Hi @beanz! The right tag should be default_triple, not _target. Right now, all these tests are effectively disabled.
Feb 4 2022
Feb 1 2022
LGTM
Jan 24 2022
No objections from me too.
Jan 23 2022
LGTM. Thanks!
Jan 20 2022
Jan 18 2022
Thanks for the suggestions!
Hi @peter.smith! The tests arm-combined-dynrel.s and arm-combined-dynrel-ifunc.s do not run because of inaccurate REQUIRES. Could you fix them, please?
Jan 17 2022
The patch aims to improve the compatibility, right.
The change looks safe. If it eventually helps us to move towards a parallel reading of input files, I am in favor of it.
Jan 13 2022
Jan 12 2022
Changes in LinkerScript.cpp and discard-section-err.s should be committed separately.
- Add comments
- Dump only required information in the test
Jan 11 2022
- Add .o in the test
- Swap then and else branches in InputSection::relocateNonAlloc()
Jan 10 2022
LGTM
LGTM
The output of --why-extract looks useful indeed, but does the map file without output sections make much sense?
Dec 24 2021
LGTM
Dec 22 2021
Dec 21 2021
LGTM