Page MenuHomePhabricator

ikudrin (Igor Kudrin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2015, 10:51 PM (193 w, 1 d)

Recent Activity

Yesterday

ikudrin updated the diff for D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
  • Made the patch affect only -fdiagnostics-absolute-paths option.
Mon, May 20, 4:35 AM · Restricted Project

Thu, May 16

ikudrin committed rG261a1bc129e7: Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test. (authored by ikudrin).
Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test.
Thu, May 16, 2:05 AM
ikudrin committed rLLD360866: Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test..
Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test.
Thu, May 16, 2:04 AM
ikudrin committed rL360866: Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test..
Add missing "REQUIRES: x86" to the lto/irmover-warning.ll test.
Thu, May 16, 2:04 AM

Wed, May 15

ikudrin committed rG4669cf27508b: [LTO] Improve readability of module IDs (authored by ikudrin).
[LTO] Improve readability of module IDs
Wed, May 15, 10:22 PM
ikudrin committed rG1ff8b7bdf108: [IRMover] Improve diagnostic messages for conflicting metadata (authored by ikudrin).
[IRMover] Improve diagnostic messages for conflicting metadata
Wed, May 15, 10:22 PM
ikudrin committed rL360858: [LTO] Improve readability of module IDs.
[LTO] Improve readability of module IDs
Wed, May 15, 10:22 PM
ikudrin committed rLLD360858: [LTO] Improve readability of module IDs.
[LTO] Improve readability of module IDs
Wed, May 15, 10:22 PM
ikudrin closed D61857: [LTO] Improve readability of module IDs.
Wed, May 15, 10:22 PM · Restricted Project
ikudrin committed rL360857: [IRMover] Improve diagnostic messages for conflicting metadata.
[IRMover] Improve diagnostic messages for conflicting metadata
Wed, May 15, 10:22 PM
ikudrin closed D61880: [IRMover] Improve diagnostic messages for conflicting metadata.
Wed, May 15, 10:22 PM · Restricted Project
ikudrin updated the diff for D61857: [LTO] Improve readability of module IDs.
  • Changed the format to <archive name>(<object name> at <offset>);
  • Changed "if" to "?:";
  • Simplified a check in the tests.
Wed, May 15, 4:58 AM · Restricted Project

Mon, May 13

ikudrin created D61880: [IRMover] Improve diagnostic messages for conflicting metadata.
Mon, May 13, 10:15 PM · Restricted Project
ikudrin created D61857: [LTO] Improve readability of module IDs.
Mon, May 13, 9:08 AM · Restricted Project

Thu, May 2

ikudrin committed rGd2c82e8ad0af: [docs] Add support for Markdown documentation when creating man pages (authored by ikudrin).
[docs] Add support for Markdown documentation when creating man pages
Thu, May 2, 10:11 PM
ikudrin committed rL359860: [docs] Add support for Markdown documentation when creating man pages.
[docs] Add support for Markdown documentation when creating man pages
Thu, May 2, 10:11 PM
ikudrin closed D60964: [docs] Add support for Markdown documentation when creating man pages.
Thu, May 2, 10:11 PM · Restricted Project

Wed, May 1

ikudrin updated the diff for D60964: [docs] Add support for Markdown documentation when creating man pages.
  • Updated according to @MaskRay's comments.
Wed, May 1, 5:17 AM · Restricted Project
ikudrin added a comment to D60964: [docs] Add support for Markdown documentation when creating man pages.

LGTM, I think (not verified the regex though).

Wed, May 1, 5:02 AM · Restricted Project
ikudrin updated the diff for D60964: [docs] Add support for Markdown documentation when creating man pages.
  • Simplified print statements.
  • Added escaping in the regex string.
Wed, May 1, 4:25 AM · Restricted Project

Mon, Apr 22

ikudrin created D60964: [docs] Add support for Markdown documentation when creating man pages.
Mon, Apr 22, 6:18 AM · Restricted Project

Apr 19 2019

ikudrin committed rG99f641ccadca: [llvm-symbolizer] Add llvm-addr2line (authored by ikudrin).
[llvm-symbolizer] Add llvm-addr2line
Apr 19 2019, 3:18 AM
ikudrin committed rL358749: [llvm-symbolizer] Add llvm-addr2line.
[llvm-symbolizer] Add llvm-addr2line
Apr 19 2019, 3:16 AM
ikudrin closed D60067: [llvm-symbolizer] Add llvm-addr2line.
Apr 19 2019, 3:16 AM · Restricted Project
ikudrin committed rG1b71b7f3b886: [llvm-symbolizer] Unhide and document the "-output-style" option (authored by ikudrin).
[llvm-symbolizer] Unhide and document the "-output-style" option
Apr 19 2019, 3:16 AM
ikudrin committed rL358748: [llvm-symbolizer] Unhide and document the "-output-style" option.
[llvm-symbolizer] Unhide and document the "-output-style" option
Apr 19 2019, 3:15 AM
ikudrin closed D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.
Apr 19 2019, 3:15 AM · Restricted Project
ikudrin committed rG4bc29cbf6b39: [llvm-symbolizer] Make the output with -output-style=GNU closer to addr2line's (authored by ikudrin).
[llvm-symbolizer] Make the output with -output-style=GNU closer to addr2line's
Apr 19 2019, 3:15 AM
ikudrin committed rL358747: [llvm-symbolizer] Make the output with -output-style=GNU closer to addr2line's.
[llvm-symbolizer] Make the output with -output-style=GNU closer to addr2line's
Apr 19 2019, 3:15 AM
ikudrin closed D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
Apr 19 2019, 3:15 AM · Restricted Project

Apr 17 2019

ikudrin updated the diff for D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.

Thanks!

Apr 17 2019, 5:44 AM · Restricted Project
ikudrin added a child revision for D60816: [llvm-symbolizer] Unhide and document the '-output-style' option: D60067: [llvm-symbolizer] Add llvm-addr2line.
Apr 17 2019, 5:15 AM · Restricted Project
ikudrin added a parent revision for D60067: [llvm-symbolizer] Add llvm-addr2line: D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.
Apr 17 2019, 5:15 AM · Restricted Project
ikudrin updated the diff for D60067: [llvm-symbolizer] Add llvm-addr2line.
  • Rebased on top of D60816; updated the documentation accordingly.
Apr 17 2019, 5:15 AM · Restricted Project
ikudrin updated the diff for D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.
  • Extended an example for the --output-style option.
Apr 17 2019, 5:02 AM · Restricted Project
ikudrin added a parent revision for D60816: [llvm-symbolizer] Unhide and document the '-output-style' option: D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
Apr 17 2019, 4:30 AM · Restricted Project
ikudrin added a child revision for D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's: D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.
Apr 17 2019, 4:30 AM · Restricted Project
ikudrin created D60816: [llvm-symbolizer] Unhide and document the '-output-style' option.
Apr 17 2019, 4:30 AM · Restricted Project
ikudrin updated the diff for D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
  • Added --implicit-check-not=main and --implicit-check-not=inctwo to the checks in output-style-inlined.test. I added the similar option to the other two checks so that all the checks in the test follow the same pattern.
Apr 17 2019, 4:08 AM · Restricted Project
ikudrin added inline comments to D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
Apr 17 2019, 2:22 AM · Restricted Project
ikudrin added a comment to D60067: [llvm-symbolizer] Add llvm-addr2line.

Code all looks good, but you should talk about the effect of --output-style on the output for both llvm-symbolizer and llvm-addr2line as appropriate.

Apr 17 2019, 12:10 AM · Restricted Project

Apr 16 2019

ikudrin updated the diff for D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
  • Simplified tests.
Apr 16 2019, 11:57 PM · Restricted Project
ikudrin added inline comments to D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
Apr 16 2019, 11:53 PM · Restricted Project
ikudrin added a parent revision for D60067: [llvm-symbolizer] Add llvm-addr2line: D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
Apr 16 2019, 5:12 AM · Restricted Project
ikudrin added a child revision for D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's: D60067: [llvm-symbolizer] Add llvm-addr2line.
Apr 16 2019, 5:12 AM · Restricted Project
ikudrin updated the diff for D60067: [llvm-symbolizer] Add llvm-addr2line.
  • Extracted the changes for --output-style into a separate patch, D60770.
Apr 16 2019, 5:11 AM · Restricted Project
ikudrin created D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's.
Apr 16 2019, 4:57 AM · Restricted Project

Apr 15 2019

ikudrin added a comment to D60067: [llvm-symbolizer] Add llvm-addr2line.

It looks like the changes for --output-style should go into a separate patch with the corresponding tests.

Apr 15 2019, 9:04 AM · Restricted Project
ikudrin updated the diff for D60067: [llvm-symbolizer] Add llvm-addr2line.

OK, let be it.

Apr 15 2019, 5:59 AM · Restricted Project
ikudrin added inline comments to D60067: [llvm-symbolizer] Add llvm-addr2line.
Apr 15 2019, 4:42 AM · Restricted Project
ikudrin updated the diff for D60067: [llvm-symbolizer] Add llvm-addr2line.
  • rst -> md.
  • Made printing of an empty line depend on the -output-style option instead of the tool name.
Apr 15 2019, 4:29 AM · Restricted Project

Apr 12 2019

ikudrin updated the diff for D60067: [llvm-symbolizer] Add llvm-addr2line.
  • Fixed a typo.
Apr 12 2019, 5:44 AM · Restricted Project
ikudrin updated the diff for D60067: [llvm-symbolizer] Add llvm-addr2line.
  • Added a doc page for llvm-addr2line. I'll really appreciate any corrections.
  • Addressed other review comments.
Apr 12 2019, 5:39 AM · Restricted Project

Apr 11 2019

ikudrin updated the diff for D60067: [llvm-symbolizer] Add llvm-addr2line.
  • Rebased the patch to the current tip;
  • Moved the code which handles differences in printing source positions in llvm-symbolizer.cpp;
  • Reworked tests.
Apr 11 2019, 8:10 AM · Restricted Project

Apr 8 2019

ikudrin added a comment to D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..

Please note, that, in contrary to POSIX OSes, on Windows a path like dir1\<junction point>\.. refers to dir1. That's why we do not need to ask the system for the fully expanded path and can do all calculations internally.

Apr 8 2019, 11:16 PM · Restricted Project

Apr 4 2019

ikudrin committed rG734a2bc73784: [llvm-symbolizer] Allow more flexible usage of -e. (authored by ikudrin).
[llvm-symbolizer] Allow more flexible usage of -e.
Apr 4 2019, 1:44 AM
ikudrin committed rL357676: [llvm-symbolizer] Allow more flexible usage of -e..
[llvm-symbolizer] Allow more flexible usage of -e.
Apr 4 2019, 1:44 AM
ikudrin closed D60196: [llvm-symbolizer] Allow more flexible usage of -e.
Apr 4 2019, 1:44 AM · Restricted Project
ikudrin committed rG0fed7b056480: [llvm-symbolizer] Add `--output-style` switch. (authored by ikudrin).
[llvm-symbolizer] Add `--output-style` switch.
Apr 4 2019, 1:41 AM
ikudrin committed rL357675: [llvm-symbolizer] Add `--output-style` switch..
[llvm-symbolizer] Add `--output-style` switch.
Apr 4 2019, 1:40 AM
ikudrin closed D60190: [llvm-symbolizer] Add `--output-style` switch..
Apr 4 2019, 1:40 AM · Restricted Project

Apr 3 2019

ikudrin added a comment to D60196: [llvm-symbolizer] Allow more flexible usage of -e.

It looks like I've just forgotten to enable a prefix form for the switch. Does that resolve the doubts?

Apr 3 2019, 8:02 AM · Restricted Project
ikudrin updated the diff for D60196: [llvm-symbolizer] Allow more flexible usage of -e.
Apr 3 2019, 8:02 AM · Restricted Project
ikudrin added a comment to D60196: [llvm-symbolizer] Allow more flexible usage of -e.

Do you think it's worth testing the behaviour of -e in the middle of a group of options e.g. "-Cefi"?

Apr 3 2019, 7:08 AM · Restricted Project
ikudrin added a comment to D60190: [llvm-symbolizer] Add `--output-style` switch..

Thanks! I believe you are right. I'll put explicit addresses on commit.

Apr 3 2019, 5:29 AM · Restricted Project
ikudrin created D60196: [llvm-symbolizer] Allow more flexible usage of -e.
Apr 3 2019, 5:18 AM · Restricted Project
ikudrin created D60190: [llvm-symbolizer] Add `--output-style` switch..
Apr 3 2019, 3:15 AM · Restricted Project

Apr 1 2019

ikudrin created D60067: [llvm-symbolizer] Add llvm-addr2line.
Apr 1 2019, 7:07 AM · Restricted Project

Mar 21 2019

ikudrin accepted D59618: [llvm-objdump] Support llvm-objdump -sj.foo.

LGTM.

Mar 21 2019, 4:43 AM · Restricted Project

Mar 19 2019

ikudrin added inline comments to D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
Mar 19 2019, 12:05 AM · Restricted Project

Mar 18 2019

ikudrin abandoned D50560: [LLD] Enable Visual Studio compatible diagnostics..
Mar 18 2019, 11:42 PM · Restricted Project, lld
ikudrin added inline comments to D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
Mar 18 2019, 4:50 AM · Restricted Project

Mar 15 2019

ikudrin created D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
Mar 15 2019, 8:01 AM · Restricted Project
ikudrin added a reverting change for D46942: Add vfs::FileSystem::getRealPath: D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
Mar 15 2019, 8:01 AM

Mar 1 2019

ikudrin committed rGa38432cefb08: [CommandLine] Allow grouping options which can have values. (authored by ikudrin).
[CommandLine] Allow grouping options which can have values.
Mar 1 2019, 1:22 AM
ikudrin committed rL355185: [CommandLine] Allow grouping options which can have values..
[CommandLine] Allow grouping options which can have values.
Mar 1 2019, 1:22 AM
ikudrin closed D58711: [CommandLine] Allow grouping options which can have values..
Mar 1 2019, 1:22 AM · Restricted Project
ikudrin committed rG875f05828d95: [CommandLine] Do not crash if an option has both ValueRequired and Grouping. (authored by ikudrin).
[CommandLine] Do not crash if an option has both ValueRequired and Grouping.
Mar 1 2019, 1:22 AM
ikudrin committed rL355184: [CommandLine] Do not crash if an option has both ValueRequired and Grouping..
[CommandLine] Do not crash if an option has both ValueRequired and Grouping.
Mar 1 2019, 1:22 AM
ikudrin closed D58499: [CommandLine] Do not crash if an option has both ValueRequired and Grouping..
Mar 1 2019, 1:22 AM · Restricted Project

Feb 28 2019

ikudrin added a comment to D58711: [CommandLine] Allow grouping options which can have values..

By the way, we have some inconsistency in how cl::Prefix and cl::AlwaysPrefix options work in case of -opt=val form. The former takes only val, while the latter keeps =. Moreover, prefix grouping options in GNU's binutils, like -j in objdump, work partially as ours cl::AlwaysPrefix, because they preserve =, and partially as cl::Prefix, because they allow passing the value in a separate argument. Thus, we still cannot fully reproduce that behavior.

Feb 28 2019, 3:00 AM · Restricted Project
ikudrin updated the diff for D58711: [CommandLine] Allow grouping options which can have values..
  • Fixed grammar and formatting issues.
  • Added test cases to check prefix options when their values are textually equal to another option.
Feb 28 2019, 2:36 AM · Restricted Project

Feb 27 2019

ikudrin created D58711: [CommandLine] Allow grouping options which can have values..
Feb 27 2019, 4:06 AM · Restricted Project

Feb 26 2019

ikudrin committed rG2d3faad706c8: [llvm-objdump] Implement -Mreg-names-raw/-std options. (authored by ikudrin).
[llvm-objdump] Implement -Mreg-names-raw/-std options.
Feb 26 2019, 4:17 AM
ikudrin committed rL354870: [llvm-objdump] Implement -Mreg-names-raw/-std options..
[llvm-objdump] Implement -Mreg-names-raw/-std options.
Feb 26 2019, 4:17 AM
ikudrin closed D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..
Feb 26 2019, 4:17 AM · Restricted Project

Feb 25 2019

ikudrin added a comment to D58499: [CommandLine] Do not crash if an option has both ValueRequired and Grouping..

LGTM.

Thanks!

Feb 25 2019, 3:22 AM · Restricted Project

Feb 22 2019

ikudrin added a comment to D58499: [CommandLine] Do not crash if an option has both ValueRequired and Grouping..

What happens for ValueOptional? I want to make sure that it doesn't treat the other grouped letters after it as the option's value.

Feb 22 2019, 9:07 AM · Restricted Project
ikudrin updated the diff for D58499: [CommandLine] Do not crash if an option has both ValueRequired and Grouping..
  • Updated the documentation (feel free to correct my wording).
  • Amended a comment in the test.
Feb 22 2019, 9:01 AM · Restricted Project
ikudrin added a comment to D58484: [DO NOT SUBMIT] Add -vs-diagnostics..

For me, the code should be, above all, reliable. You can trust it only in that case; otherwise, you never know, when and how it is going to be broken and produce an unexpected result.

Feb 22 2019, 6:26 AM · Restricted Project

Feb 21 2019

ikudrin created D58499: [CommandLine] Do not crash if an option has both ValueRequired and Grouping..
Feb 21 2019, 3:34 AM · Restricted Project
ikudrin added a comment to D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..

Thanks! I'll wait a bit, but not very long. I believe the patch is safe because the default behavior is not changed.

Feb 21 2019, 2:55 AM · Restricted Project

Feb 20 2019

ikudrin updated the diff for D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..

Updated the test.

Feb 20 2019, 6:54 AM · Restricted Project
ikudrin added inline comments to D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..
Feb 20 2019, 1:29 AM · Restricted Project
ikudrin updated the diff for D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..
  • Made DefaultAltIdx private.
  • Extended the test.
  • Addressed other review comments.
Feb 20 2019, 1:23 AM · Restricted Project

Feb 11 2019

ikudrin added a comment to D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..

Ping.

Feb 11 2019, 12:44 AM · Restricted Project

Feb 6 2019

ikudrin added inline comments to D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..
Feb 6 2019, 9:17 AM · Restricted Project

Feb 5 2019

ikudrin added inline comments to D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..
Feb 5 2019, 4:20 AM · Restricted Project
ikudrin updated the diff for D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..

Addressed review comments.

Feb 5 2019, 4:17 AM · Restricted Project

Feb 4 2019

ikudrin created D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..
Feb 4 2019, 4:55 AM · Restricted Project