Page MenuHomePhabricator

ikudrin (Igor Kudrin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2015, 10:51 PM (239 w, 1 d)

Recent Activity

Yesterday

ikudrin created D77552: [DebugInfo] Fix reading DWARFv5 type units in DWP..
Mon, Apr 6, 8:05 AM · debug-info, Restricted Project
ikudrin accepted D72828: [DWARF5] Added support for emission of debug_macro section..

LGTM.

Mon, Apr 6, 5:22 AM · Restricted Project, debug-info
ikudrin added inline comments to D72828: [DWARF5] Added support for emission of debug_macro section..
Mon, Apr 6, 3:13 AM · Restricted Project, debug-info
ikudrin committed rG5125685e915a: [llvm-dwp] Fix a possible out of bound access. (authored by ikudrin).
[llvm-dwp] Fix a possible out of bound access.
Mon, Apr 6, 1:04 AM
ikudrin closed D76543: [llvm-dwp] Fix a possible out of bound access..
Mon, Apr 6, 1:03 AM · debug-info, Restricted Project
ikudrin committed rG35819ff3cf4c: [DebugInfo] Fix reading range lists of v5 units in DWP. (authored by ikudrin).
[DebugInfo] Fix reading range lists of v5 units in DWP.
Mon, Apr 6, 12:30 AM
ikudrin committed rGa93b77b97f10: [DebugInfo] Fix reading location tables headers of v5 units in DWP. (authored by ikudrin).
[DebugInfo] Fix reading location tables headers of v5 units in DWP.
Mon, Apr 6, 12:30 AM
ikudrin committed rG714324b79ae2: [DebugInfo] Support DWARFv5 index sections. (authored by ikudrin).
[DebugInfo] Support DWARFv5 index sections.
Mon, Apr 6, 12:30 AM
ikudrin committed rG49737df76793: [DebugInfo] Fix reading location tables of v5 units in DWP. (authored by ikudrin).
[DebugInfo] Fix reading location tables of v5 units in DWP.
Mon, Apr 6, 12:30 AM
ikudrin closed D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP..
Mon, Apr 6, 12:30 AM · debug-info, Restricted Project
ikudrin closed D77401: [DebugInfo] Fix reading range lists of v5 units in DWP..
Mon, Apr 6, 12:30 AM · debug-info, Restricted Project
ikudrin committed rGa0249fe91c7b: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC. (authored by ikudrin).
[DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC.
Mon, Apr 6, 12:30 AM
ikudrin committed rGf9cd90837bdc: [llvm-dwp] Refactor handling of section identifiers. NFCI. (authored by ikudrin).
[llvm-dwp] Refactor handling of section identifiers. NFCI.
Mon, Apr 6, 12:30 AM
ikudrin closed D77145: [DebugInfo] Fix reading location tables of v5 units in DWP..
Mon, Apr 6, 12:30 AM · debug-info, Restricted Project
ikudrin closed D75929: [DebugInfo] Support DWARFv5 index sections..
Mon, Apr 6, 12:30 AM · Restricted Project, debug-info, Restricted Project
ikudrin closed D77141: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC..
Mon, Apr 6, 12:30 AM · Restricted Project, debug-info, Restricted Project
ikudrin closed D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI..
Mon, Apr 6, 12:29 AM · debug-info, Restricted Project

Fri, Apr 3

ikudrin added a parent revision for D77401: [DebugInfo] Fix reading range lists of v5 units in DWP.: D75929: [DebugInfo] Support DWARFv5 index sections..
Fri, Apr 3, 8:34 AM · debug-info, Restricted Project
ikudrin added a child revision for D75929: [DebugInfo] Support DWARFv5 index sections.: D77401: [DebugInfo] Fix reading range lists of v5 units in DWP..
Fri, Apr 3, 8:34 AM · Restricted Project, debug-info, Restricted Project
ikudrin updated subscribers of D77401: [DebugInfo] Fix reading range lists of v5 units in DWP..
Fri, Apr 3, 8:34 AM · debug-info, Restricted Project
ikudrin created D77401: [DebugInfo] Fix reading range lists of v5 units in DWP..
Fri, Apr 3, 8:34 AM · debug-info, Restricted Project
ikudrin updated the diff for D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP..
  • Rebase to the tip.
  • const auto *Contrib -> auto *Contrib.
Fri, Apr 3, 8:02 AM · debug-info, Restricted Project
ikudrin updated the diff for D77145: [DebugInfo] Fix reading location tables of v5 units in DWP..
  • Rebase to the tip.
Fri, Apr 3, 8:02 AM · debug-info, Restricted Project
ikudrin updated the diff for D77141: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC..
  • Rebased to the tip.
Fri, Apr 3, 8:02 AM · Restricted Project, debug-info, Restricted Project
ikudrin added a comment to D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI..

Ping.

Fri, Apr 3, 8:02 AM · debug-info, Restricted Project
ikudrin updated the diff for D76543: [llvm-dwp] Fix a possible out of bound access..
  • Extended the test.
Fri, Apr 3, 4:15 AM · debug-info, Restricted Project
ikudrin added inline comments to D76543: [llvm-dwp] Fix a possible out of bound access..
Fri, Apr 3, 1:34 AM · debug-info, Restricted Project
ikudrin committed rGf13ce15d4410: [DebugInfo] Rename getOffset() to getContribution(). NFC. (authored by ikudrin).
[DebugInfo] Rename getOffset() to getContribution(). NFC.
Fri, Apr 3, 12:30 AM
ikudrin closed D77302: [DebugInfo] Rename getOffset() to getContribution(). NFC..
Fri, Apr 3, 12:30 AM · Restricted Project, debug-info, Restricted Project

Thu, Apr 2

ikudrin added inline comments to D76543: [llvm-dwp] Fix a possible out of bound access..
Thu, Apr 2, 10:45 PM · debug-info, Restricted Project
ikudrin updated the diff for D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP..

I've created D77302 for renaming getOffset functions.

Thu, Apr 2, 7:01 AM · debug-info, Restricted Project
ikudrin created D77302: [DebugInfo] Rename getOffset() to getContribution(). NFC..
Thu, Apr 2, 7:01 AM · Restricted Project, debug-info, Restricted Project
ikudrin updated the diff for D77143: [llvm-dwp] Refuse DWARFv5 input DWP files..
  • Added reporting the version of an unsupported index.
  • Added a test for the unsupported TU index version case.
  • Removed the actual CU in the test for the CU index version because it is not necessary.
Thu, Apr 2, 3:13 AM · debug-info, Restricted Project

Wed, Apr 1

ikudrin committed rGb0b1f451ae69: [LLD][ELF] Follow the common pattern in a message about an undefined vtable… (authored by ikudrin).
[LLD][ELF] Follow the common pattern in a message about an undefined vtable…
Wed, Apr 1, 9:47 PM
ikudrin closed D77132: [LLD][ELF] Follow the common pattern in a message about an undefined vtable symbol..
Wed, Apr 1, 9:46 PM · Restricted Project, lld
ikudrin added inline comments to D77143: [llvm-dwp] Refuse DWARFv5 input DWP files..
Wed, Apr 1, 8:27 AM · debug-info, Restricted Project
ikudrin updated the diff for D75929: [DebugInfo] Support DWARFv5 index sections..
  • Added a helper function isKnownV5SectionID().
Wed, Apr 1, 8:14 AM · Restricted Project, debug-info, Restricted Project
ikudrin added a comment to D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP..

Looks good to me, although I'm not fully up to speed on .debug_loclists to be 100% certain, so might be worth a second opinion.

Thanks!

Wed, Apr 1, 1:36 AM · debug-info, Restricted Project

Tue, Mar 31

ikudrin added a parent revision for D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP.: D77145: [DebugInfo] Fix reading location tables of v5 units in DWP..
Tue, Mar 31, 7:44 AM · debug-info, Restricted Project
ikudrin added a child revision for D77145: [DebugInfo] Fix reading location tables of v5 units in DWP.: D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP..
Tue, Mar 31, 7:44 AM · debug-info, Restricted Project
ikudrin created D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP..
Tue, Mar 31, 7:44 AM · debug-info, Restricted Project
ikudrin added a parent revision for D77145: [DebugInfo] Fix reading location tables of v5 units in DWP.: D75929: [DebugInfo] Support DWARFv5 index sections..
Tue, Mar 31, 7:44 AM · debug-info, Restricted Project
ikudrin added a child revision for D75929: [DebugInfo] Support DWARFv5 index sections.: D77145: [DebugInfo] Fix reading location tables of v5 units in DWP..
Tue, Mar 31, 7:44 AM · Restricted Project, debug-info, Restricted Project
ikudrin created D77145: [DebugInfo] Fix reading location tables of v5 units in DWP..
Tue, Mar 31, 7:44 AM · debug-info, Restricted Project
ikudrin added a parent revision for D77143: [llvm-dwp] Refuse DWARFv5 input DWP files.: D75929: [DebugInfo] Support DWARFv5 index sections..
Tue, Mar 31, 7:44 AM · debug-info, Restricted Project
ikudrin created D77143: [llvm-dwp] Refuse DWARFv5 input DWP files..
Tue, Mar 31, 7:44 AM · debug-info, Restricted Project
ikudrin added a child revision for D75929: [DebugInfo] Support DWARFv5 index sections.: D77143: [llvm-dwp] Refuse DWARFv5 input DWP files..
Tue, Mar 31, 7:44 AM · Restricted Project, debug-info, Restricted Project
ikudrin updated the diff for D75929: [DebugInfo] Support DWARFv5 index sections..
  • Removed DWARFUnitIndex::getVersion() as it is related to the other patch.
Tue, Mar 31, 7:44 AM · Restricted Project, debug-info, Restricted Project
ikudrin edited parent revisions for D75929: [DebugInfo] Support DWARFv5 index sections., added: 1; removed: 1.
Tue, Mar 31, 7:44 AM · Restricted Project, debug-info, Restricted Project
ikudrin added a child revision for D77141: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC.: D75929: [DebugInfo] Support DWARFv5 index sections..
Tue, Mar 31, 7:44 AM · Restricted Project, debug-info, Restricted Project
ikudrin removed a child revision for D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI.: D75929: [DebugInfo] Support DWARFv5 index sections..
Tue, Mar 31, 7:44 AM · debug-info, Restricted Project
ikudrin updated the diff for D75929: [DebugInfo] Support DWARFv5 index sections..
  • Updated the comment for DWARFSectionKind.
  • Simplified the storing of raw section identifiers.
  • Moved independent changes into separate patches.
Tue, Mar 31, 7:44 AM · Restricted Project, debug-info, Restricted Project
ikudrin added a parent revision for D77141: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC.: D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI..
Tue, Mar 31, 7:09 AM · Restricted Project, debug-info, Restricted Project
ikudrin added a child revision for D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI.: D77141: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC..
Tue, Mar 31, 7:09 AM · debug-info, Restricted Project
ikudrin created D77141: [DebugInfo] Rename section identifiers which are deprecated in DWARFv5. NFC..
Tue, Mar 31, 7:09 AM · Restricted Project, debug-info, Restricted Project
ikudrin updated the diff for D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI..
  • Use a named constant DW_SECT_INFO in the translation function instead of a numeric constant 1.
  • Rename the functions.
Tue, Mar 31, 7:09 AM · debug-info, Restricted Project
ikudrin created D77132: [LLD][ELF] Follow the common pattern in a message about an undefined vtable symbol..
Tue, Mar 31, 4:23 AM · Restricted Project, lld

Mon, Mar 30

ikudrin accepted D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..

LGTM. Please wait for the comments from @jhenderson and @dblaikie.

Mon, Mar 30, 3:44 AM · Restricted Project, debug-info
ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Mon, Mar 30, 2:40 AM · Restricted Project, debug-info
ikudrin updated the diff for D76543: [llvm-dwp] Fix a possible out of bound access..
  • Extended the test by adding an unknown ID which is greater than DW_SECT_MACRO.
Mon, Mar 30, 2:07 AM · debug-info, Restricted Project
ikudrin added inline comments to D76543: [llvm-dwp] Fix a possible out of bound access..
Mon, Mar 30, 2:07 AM · debug-info, Restricted Project
ikudrin updated the diff for D76543: [llvm-dwp] Fix a possible out of bound access..
  • The test was extended to add a TU index case.
  • Added a comment to the test that the additional sections are required to reach the test points in the code.
Mon, Mar 30, 1:02 AM · debug-info, Restricted Project

Sat, Mar 28

ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Sat, Mar 28, 9:28 PM · Restricted Project, debug-info
ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Sat, Mar 28, 3:46 AM · Restricted Project, debug-info

Thu, Mar 26

ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Thu, Mar 26, 7:35 PM · Restricted Project, debug-info
ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Thu, Mar 26, 5:23 AM · Restricted Project, debug-info

Sat, Mar 21

ikudrin created D76543: [llvm-dwp] Fix a possible out of bound access..
Sat, Mar 21, 4:47 AM · debug-info, Restricted Project

Thu, Mar 19

ikudrin committed rGb1c8a378f78b: [llvm-dwp] Start error messages with a lowercase letter. (authored by ikudrin).
[llvm-dwp] Start error messages with a lowercase letter.
Thu, Mar 19, 5:55 AM
ikudrin closed D76277: [llvm-dwp] Start error messages with lowercase letters..
Thu, Mar 19, 5:55 AM · debug-info, Restricted Project

Wed, Mar 18

ikudrin added inline comments to D75929: [DebugInfo] Support DWARFv5 index sections..
Wed, Mar 18, 10:47 PM · Restricted Project, debug-info, Restricted Project
ikudrin added a comment to D75929: [DebugInfo] Support DWARFv5 index sections..

(btw, is there a test case for the "unknown column" code path?)

Wed, Mar 18, 7:36 AM · Restricted Project, debug-info, Restricted Project

Tue, Mar 17

ikudrin added inline comments to D75929: [DebugInfo] Support DWARFv5 index sections..
Tue, Mar 17, 5:43 AM · Restricted Project, debug-info, Restricted Project
ikudrin created D76277: [llvm-dwp] Start error messages with lowercase letters..
Tue, Mar 17, 5:43 AM · debug-info, Restricted Project
ikudrin updated the diff for D75929: [DebugInfo] Support DWARFv5 index sections..
  • Fixed messages in llvm-dwp.cpp.
  • Fixed comments in the tests.
Tue, Mar 17, 5:43 AM · Restricted Project, debug-info, Restricted Project
ikudrin added a comment to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..

I am mostly OK with the changes at the moment. Please reach the consent with @jhenderson about code duplication and other topics he mentioned.

Tue, Mar 17, 4:27 AM · Restricted Project, debug-info

Mon, Mar 16

ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Mon, Mar 16, 7:35 AM · Restricted Project, debug-info
ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Mon, Mar 16, 7:35 AM · Restricted Project, debug-info
ikudrin added inline comments to D75929: [DebugInfo] Support DWARFv5 index sections..
Mon, Mar 16, 6:26 AM · Restricted Project, debug-info, Restricted Project
ikudrin updated the diff for D75929: [DebugInfo] Support DWARFv5 index sections..

@jhenderson, thank you for the comments!

Mon, Mar 16, 6:26 AM · Restricted Project, debug-info, Restricted Project

Fri, Mar 13

ikudrin added a comment to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..

We are almost there.

Fri, Mar 13, 4:24 AM · Restricted Project, debug-info

Thu, Mar 12

ikudrin added a comment to D75929: [DebugInfo] Support DWARFv5 index sections..

This is almost what you are doing right now -- the only difference is that the "internal" enum would no longer be internal -- it would actually match the on-disk format of a v5 index. This v5 enum would contain the official DWARFv5 constants as well as the new extensions we want to introduce for mixed 5+4 indices.

Yep, this would be the direction I would suggest/encourage. It seems that if the goal is to have one index in a DWP file (which seems reasonable) then all future index versions will have to support column indexes all previous DWARF sections - the DWARFvN enum can then be used to describe all the previous versions as well.

Thu, Mar 12, 6:20 PM · Restricted Project, debug-info, Restricted Project
ikudrin added a parent revision for D75929: [DebugInfo] Support DWARFv5 index sections.: D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI..
Thu, Mar 12, 8:40 AM · Restricted Project, debug-info, Restricted Project
ikudrin updated the diff for D75929: [DebugInfo] Support DWARFv5 index sections..
  • Use values for clashing identifiers proposed by @dblaikie.
  • Convert all unknown section identifiers into a special value, DW_SECT_EXT_unknown; Use an optional parallel array to keep the raw values of unknown identifiers.
  • Split the refactoring part in llvm-dwp.cpp into a separate patch, D76067.
Thu, Mar 12, 8:40 AM · Restricted Project, debug-info, Restricted Project
ikudrin added a child revision for D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI.: D75929: [DebugInfo] Support DWARFv5 index sections..
Thu, Mar 12, 8:40 AM · debug-info, Restricted Project
ikudrin created D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI..
Thu, Mar 12, 8:08 AM · debug-info, Restricted Project

Wed, Mar 11

ikudrin added a comment to D75929: [DebugInfo] Support DWARFv5 index sections..

I believe that this patch is more or less compatible with any approach which might be taken. The idea is that there is a set of constants for internal use and functions to translate them to/from external representation and both constants and translation functions might be adjusted when needed. In any case, the general design remains the same.

That's true, but I'm not sure it is really the best solution.

Wed, Mar 11, 6:17 AM · Restricted Project, debug-info, Restricted Project

Tue, Mar 10

ikudrin added a comment to D75929: [DebugInfo] Support DWARFv5 index sections..

Thanks for the links! What a coincidence...

Tue, Mar 10, 7:11 PM · Restricted Project, debug-info, Restricted Project
ikudrin created D75929: [DebugInfo] Support DWARFv5 index sections..
Tue, Mar 10, 9:12 AM · Restricted Project, debug-info, Restricted Project
ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Tue, Mar 10, 4:34 AM · Restricted Project, debug-info

Mon, Mar 9

ikudrin added inline comments to D75485: Support DW_FORM_strx* in llvm-dwp..
Mon, Mar 9, 10:38 PM · Restricted Project

Sun, Mar 8

ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Sun, Mar 8, 11:25 PM · Restricted Project, debug-info
ikudrin added inline comments to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..
Sun, Mar 8, 10:23 PM · Restricted Project, debug-info

Mar 7 2020

ikudrin added a comment to D72828: [DWARF5] Added support for emission of debug_macro section..

In my understanding, this should still depend on D73086 because this revision requires the dumper for the test(s).

Mar 7 2020, 2:10 AM · Restricted Project, debug-info

Mar 6 2020

ikudrin committed rG3a1bc41a8948: [DebugInfo] Print the actual value of an unknown section identifier. (authored by ikudrin).
[DebugInfo] Print the actual value of an unknown section identifier.
Mar 6 2020, 7:10 AM
ikudrin closed D75668: [DebugInfo] Print the actual value of an unknown section identifier..
Mar 6 2020, 7:09 AM · debug-info, Restricted Project
ikudrin added inline comments to D75668: [DebugInfo] Print the actual value of an unknown section identifier..
Mar 6 2020, 2:46 AM · debug-info, Restricted Project

Mar 5 2020

ikudrin added a comment to D72828: [DWARF5] Added support for emission of debug_macro section..

While this can be applied to master cleanly, it cannot be built, because it requires D73086; it applies after D73086 with some conflicts. Please, prepare a diff which will be applied after D73086 cleanly and add D73086 as a parent revision to show the dependency.

Mar 5 2020, 7:40 AM · Restricted Project, debug-info
ikudrin added a comment to D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump..

The test should be extended to use all supported kinds of entries. There should also be another macro unit without the debug_line_offset field. There should be tests for other combinations of flags in the header to show that the correct diagnostics for unsupported flags are generated.

Mar 5 2020, 7:40 AM · Restricted Project, debug-info
ikudrin committed rG6e9c10f6948a: Fix typos in comment marks. (authored by ikudrin).
Fix typos in comment marks.
Mar 5 2020, 5:30 AM
ikudrin committed rGcada5b881b66: [DebugInfo] Do not truncate 64-bit values when dumping CIEs and FDEs. (authored by ikudrin).
[DebugInfo] Do not truncate 64-bit values when dumping CIEs and FDEs.
Mar 5 2020, 3:19 AM