Page MenuHomePhabricator

ikudrin (Igor Kudrin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2015, 10:51 PM (227 w, 5 d)

Recent Activity

Yesterday

ikudrin added a comment to D71932: [DWARF] Better detect errors in Address Range Tables..

Thanks for the review!

Fri, Jan 17, 5:05 PM · Restricted Project, debug-info

Thu, Jan 16

ikudrin added a comment to D71932: [DWARF] Better detect errors in Address Range Tables..

Ping.

Thu, Jan 16, 11:49 PM · Restricted Project, debug-info
ikudrin created D72900: [DebugInfo] Support 64-bit DWARF for .debug_names..
Thu, Jan 16, 11:40 PM · Restricted Project, debug-info

Wed, Jan 15

ikudrin committed rGafb22d7c33a2: [DebugInfo] Simplify the constructor of DWARFDebugAranges::Range. NFC. (authored by ikudrin).
[DebugInfo] Simplify the constructor of DWARFDebugAranges::Range. NFC.
Wed, Jan 15, 10:09 PM
ikudrin closed D72757: [DebugInfo] Simplify the constructor of DWARFDebugAranges::Range. NFC..
Wed, Jan 15, 10:09 PM · Restricted Project, debug-info
ikudrin added a comment to D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..

But removing the default values is also seems to be out of the scope of the patch.

Okay, but could you please prepare a follow-up patch that does this?

Wed, Jan 15, 3:33 AM · Restricted Project, debug-info
ikudrin created D72757: [DebugInfo] Simplify the constructor of DWARFDebugAranges::Range. NFC..
Wed, Jan 15, 3:33 AM · Restricted Project, debug-info
ikudrin committed rG2142e20f5095: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets. (authored by ikudrin).
[DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets.
Wed, Jan 15, 2:28 AM
ikudrin closed D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..
Wed, Jan 15, 2:28 AM · Restricted Project, debug-info
ikudrin committed rGfcc08aa835de: [MachO] Add a test for detecting reserved unit length. (authored by ikudrin).
[MachO] Add a test for detecting reserved unit length.
Wed, Jan 15, 2:00 AM
ikudrin closed D72695: [MachO] Add a test for detecting reserved unit length..
Wed, Jan 15, 2:00 AM · Restricted Project, lld

Tue, Jan 14

ikudrin added a comment to D71546: [MachO] Fix detecting malformed DWARF..

Was this fixing an existing buildbot/test failure? (if not, it should probably have a test? If it did fix an existing failure - could you mention what that failure was?)

Tue, Jan 14, 5:26 AM · Restricted Project, lld
ikudrin created D72695: [MachO] Add a test for detecting reserved unit length..
Tue, Jan 14, 5:16 AM · Restricted Project, lld
ikudrin updated the diff for D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
  • Used curly brackets for the while loop in dumping .debug_aranges in DWARFContext::dump().
  • Removed else branch after break.
Tue, Jan 14, 3:30 AM · Restricted Project, debug-info
ikudrin added inline comments to D71931: [DWARF] Allow empty address range tables..
Tue, Jan 14, 3:15 AM · Restricted Project, debug-info
ikudrin added inline comments to D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..
Tue, Jan 14, 2:57 AM · Restricted Project, debug-info
ikudrin updated the diff for D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..

Another 1U is changed to 1ULL. Thanks, @aprantl!

Tue, Jan 14, 2:52 AM · Restricted Project, debug-info

Mon, Jan 13

ikudrin added a comment to D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..

Ping.

Mon, Jan 13, 7:06 AM · Restricted Project, debug-info
ikudrin accepted D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.

LGTM. Sorry for the delay.

Mon, Jan 13, 7:06 AM · Restricted Project
ikudrin added a comment to D71932: [DWARF] Better detect errors in Address Range Tables..

Could these tests all be in one run? (ie: even though the length is "invalid" in terms of parsing the contents of the section - but valid enough to jump to the next contribution and parse that - except, I guess, at an invalid 64 bit length perhaps, because that might be too long to be bothered testing - so perhaps that could be the last test case in the file)

Mon, Jan 13, 7:06 AM · Restricted Project, debug-info
ikudrin updated the diff for D71932: [DWARF] Better detect errors in Address Range Tables..
  • Made the diagnostic a bit more distinct.
  • Moved the tests to a gtest-based suite.
Mon, Jan 13, 7:06 AM · Restricted Project, debug-info
ikudrin added inline comments to D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet..
Mon, Jan 13, 6:54 AM · Restricted Project, debug-info
ikudrin added inline comments to D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
Mon, Jan 13, 6:44 AM · Restricted Project, debug-info
ikudrin updated the diff for D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet..
  • Hardcode paddings.
  • Move some tests to the gtest-based suite.
Mon, Jan 13, 6:44 AM · Restricted Project, debug-info
ikudrin updated the diff for D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
  • Update wordings.
  • Replace most of the lit tests to check error cases with gtest-based ones.
  • Do not silently absorb the error messages.
  • Update existing tests and add new ones to reflect the changes.
Mon, Jan 13, 6:26 AM · Restricted Project, debug-info
ikudrin updated the diff for D71931: [DWARF] Allow empty address range tables..
  • Use hardcoded padding.
Mon, Jan 13, 6:16 AM · Restricted Project, debug-info

Thu, Jan 9

ikudrin added inline comments to D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.
Thu, Jan 9, 4:52 AM · Restricted Project
ikudrin updated the diff for D71931: [DWARF] Allow empty address range tables..
  • Add a macro and an explanation comment for the padding wizardry in the test. Hope it is more clear now.
Thu, Jan 9, 3:26 AM · Restricted Project, debug-info

Fri, Dec 27

ikudrin added a comment to D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..

Thanks for the suggestions, @dblaikie! I've added D71931 and D71932 with corresponding patches.

Fri, Dec 27, 8:26 AM · Restricted Project, debug-info
ikudrin added a parent revision for D71932: [DWARF] Better detect errors in Address Range Tables.: D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet..
Fri, Dec 27, 8:22 AM · Restricted Project, debug-info
ikudrin added a child revision for D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet.: D71932: [DWARF] Better detect errors in Address Range Tables..
Fri, Dec 27, 8:22 AM · Restricted Project, debug-info
ikudrin created D71932: [DWARF] Better detect errors in Address Range Tables..
Fri, Dec 27, 8:22 AM · Restricted Project, debug-info
ikudrin updated the diff for D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet..
  • Updated as the parent patch is changed;
  • Added more tests.
Fri, Dec 27, 8:22 AM · Restricted Project, debug-info
ikudrin updated the summary of D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
Fri, Dec 27, 8:17 AM · Restricted Project, debug-info
ikudrin added a parent revision for D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract().: D71931: [DWARF] Allow empty address range tables..
Fri, Dec 27, 8:17 AM · Restricted Project, debug-info
ikudrin added a child revision for D71931: [DWARF] Allow empty address range tables.: D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
Fri, Dec 27, 8:17 AM · Restricted Project, debug-info
ikudrin updated the diff for D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
  • "!x" -> "x == 0";
  • Improved error messages wordings;
  • Added more tests;
  • Fixed checking the value of the Length field.
Fri, Dec 27, 8:17 AM · Restricted Project, debug-info
ikudrin created D71931: [DWARF] Allow empty address range tables..
Fri, Dec 27, 8:03 AM · Restricted Project, debug-info

Thu, Dec 26

ikudrin added a comment to D67097: [DWARF] Check for format mismatch between CU and Range List Table..

Actually, I've discovered that we parse range list table headers for every unit, including type units, even if they do not reference them. Thus, this patch creates more problems than solves; it should be postponed until we make extracting range list tables lazy and do it only for compilation units which actually reference the tables.

Thu, Dec 26, 8:05 PM · Restricted Project, debug-info

Wed, Dec 25

ikudrin added a parent revision for D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet.: D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
Wed, Dec 25, 4:18 AM · Restricted Project, debug-info
ikudrin added a child revision for D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract().: D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet..
Wed, Dec 25, 4:18 AM · Restricted Project, debug-info
ikudrin created D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet..
Wed, Dec 25, 4:18 AM · Restricted Project, debug-info
ikudrin created D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract()..
Wed, Dec 25, 4:12 AM · Restricted Project, debug-info

Tue, Dec 24

ikudrin added inline comments to D59381: Change CompileUnit and ARanges interfaces to propagate errors.
Tue, Dec 24, 3:56 AM · Restricted Project

Mon, Dec 23

ikudrin committed rG6f635f90929d: [DWARF] Check that all fields of a Unit Header are read. (authored by ikudrin).
[DWARF] Check that all fields of a Unit Header are read.
Mon, Dec 23, 6:40 PM
ikudrin closed D71704: [DWARF] Check that all fields of a Unit Header are read..
Mon, Dec 23, 6:40 PM · debug-info, Restricted Project
ikudrin updated the diff for D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..
Mon, Dec 23, 6:30 AM · Restricted Project, debug-info
ikudrin created D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets..
Mon, Dec 23, 4:21 AM · Restricted Project, debug-info

Fri, Dec 20

ikudrin updated the diff for D67097: [DWARF] Check for format mismatch between CU and Range List Table..
  • Rebase to the tip.
  • Add reporting the offset of a compilation unit which format is taken as a reference.
Fri, Dec 20, 5:58 AM · Restricted Project, debug-info
ikudrin updated the diff for D71704: [DWARF] Check that all fields of a Unit Header are read..
  • Add a test for a CU with missing fields which was considered valid before the patch.
Fri, Dec 20, 2:49 AM · debug-info, Restricted Project

Thu, Dec 19

ikudrin added a comment to D71702: [DebugInfo] Relax some checking in the debug line parser.

It looks like lld/test/ELF/undef.s comes here by accident, right?

Thu, Dec 19, 6:53 AM · Restricted Project
ikudrin created D71704: [DWARF] Check that all fields of a Unit Header are read..
Thu, Dec 19, 6:45 AM · debug-info, Restricted Project

Dec 17 2019

ikudrin committed rGa57adc7a0b0d: [sanitizer] Construct InternalMmapVector without memory allocation. (authored by ikudrin).
[sanitizer] Construct InternalMmapVector without memory allocation.
Dec 17 2019, 12:09 AM
ikudrin committed rG5279f96577af: [MachO] Fix detecting malformed DWARF. (authored by ikudrin).
[MachO] Fix detecting malformed DWARF.
Dec 17 2019, 12:09 AM
ikudrin closed D71342: [sanitizer] Construct InternalMmapVector without memory allocation..
Dec 17 2019, 12:09 AM · Restricted Project, Restricted Project
ikudrin closed D71546: [MachO] Fix detecting malformed DWARF..
Dec 17 2019, 12:09 AM · Restricted Project, lld

Dec 16 2019

ikudrin created D71546: [MachO] Fix detecting malformed DWARF..
Dec 16 2019, 6:35 AM · Restricted Project, lld
ikudrin added a comment to D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths.

Personally, I would prefer to see the file name and path to be changed as little as possible because that would help to recognize the files better. We cannot use remove_dots() on POSIX OSes to simplify paths, because it may return an invalid path; thus we have to use getRealPath(). If I understand it right, there is no similar problem with the file name itself.

Dec 16 2019, 3:34 AM · Restricted Project

Dec 15 2019

ikudrin added a comment to D71342: [sanitizer] Construct InternalMmapVector without memory allocation..

I'd like to note that this is not a purely theoretical issue. It can be observed, for example, in Symbolizer::ModuleNameOwner on a 64-bit platform with 4K memory pages. The default constructor for storage_ allocates one memory page, which is immediately replaced by a new allocation in the call to reserve() for 1000 elements, which requires 8 * 1000 = 8000 bytes, or two pages.

Dec 15 2019, 7:53 PM · Restricted Project, Restricted Project

Dec 11 2019

ikudrin created D71342: [sanitizer] Construct InternalMmapVector without memory allocation..
Dec 11 2019, 3:14 AM · Restricted Project, Restricted Project

Dec 10 2019

ikudrin committed rG3a713ae5fa64: [SanitizerCommon] Reduce wasting memory in LowLevelAllocator. (authored by ikudrin).
[SanitizerCommon] Reduce wasting memory in LowLevelAllocator.
Dec 10 2019, 9:55 PM
ikudrin closed D71275: [SanitizerCommon] Reduce wasting memory in LowLevelAllocator..
Dec 10 2019, 9:55 PM · Restricted Project, Restricted Project
ikudrin retitled D71275: [SanitizerCommon] Reduce wasting memory in LowLevelAllocator. from [SanitizerCommon] Avoid wasting memory in LowLevelAllocator to [SanitizerCommon] Reduce wasting memory in LowLevelAllocator..
Dec 10 2019, 7:56 AM · Restricted Project, Restricted Project
ikudrin created D71275: [SanitizerCommon] Reduce wasting memory in LowLevelAllocator..
Dec 10 2019, 7:46 AM · Restricted Project, Restricted Project

Oct 18 2019

ikudrin committed rL375227: Request commit access for ikudrin.
Request commit access for ikudrin
Oct 18 2019, 5:19 AM

Sep 10 2019

ikudrin committed rGbc48588f764a: Reland [DWARF] Add a unit test for DWARFUnit::getLength(). (authored by ikudrin).
Reland [DWARF] Add a unit test for DWARFUnit::getLength().
Sep 10 2019, 4:56 AM
ikudrin committed rL371510: Reland [DWARF] Add a unit test for DWARFUnit::getLength()..
Reland [DWARF] Add a unit test for DWARFUnit::getLength().
Sep 10 2019, 4:55 AM
ikudrin committed rGc27af19280ac: Revert "[DWARF] Add a unit test for DWARFUnit::getLength()" because it broke… (authored by ikudrin).
Revert "[DWARF] Add a unit test for DWARFUnit::getLength()" because it broke…
Sep 10 2019, 3:18 AM
ikudrin committed rL371505: Revert "[DWARF] Add a unit test for DWARFUnit::getLength()" because it broke….
Revert "[DWARF] Add a unit test for DWARFUnit::getLength()" because it broke…
Sep 10 2019, 3:17 AM
ikudrin committed rG3565c6b15c54: [DWARF] Add a unit test for DWARFUnit::getLength(). (authored by ikudrin).
[DWARF] Add a unit test for DWARFUnit::getLength().
Sep 10 2019, 2:04 AM
ikudrin committed rL371499: [DWARF] Add a unit test for DWARFUnit::getLength()..
[DWARF] Add a unit test for DWARFUnit::getLength().
Sep 10 2019, 2:04 AM
ikudrin closed D67276: [DWARF] Add a unit test for DWARFUnit::getLength()..
Sep 10 2019, 2:04 AM · Restricted Project, debug-info

Sep 6 2019

ikudrin added a comment to D67097: [DWARF] Check for format mismatch between CU and Range List Table..

Sorry to intervene, but what about the patch itself? Is it OK to land with the latest changes or should I improve it somehow?

Sep 6 2019, 9:05 PM · Restricted Project, debug-info
ikudrin added inline comments to D67276: [DWARF] Add a unit test for DWARFUnit::getLength()..
Sep 6 2019, 9:00 PM · Restricted Project, debug-info
ikudrin created D67276: [DWARF] Add a unit test for DWARFUnit::getLength()..
Sep 6 2019, 7:18 AM · Restricted Project, debug-info

Sep 5 2019

ikudrin removed a parent revision for D67097: [DWARF] Check for format mismatch between CU and Range List Table.: D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Sep 5 2019, 12:14 AM · Restricted Project, debug-info
ikudrin removed a child revision for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader.: D67097: [DWARF] Check for format mismatch between CU and Range List Table..
Sep 5 2019, 12:14 AM · Restricted Project, debug-info
ikudrin updated the diff for D67097: [DWARF] Check for format mismatch between CU and Range List Table..
  • Rebase on the current tip.
Sep 5 2019, 12:11 AM · Restricted Project, debug-info
ikudrin committed rGe46639620d32: [DWARF] Fix referencing Range List Tables from CUs for DWARF64. (authored by ikudrin).
[DWARF] Fix referencing Range List Tables from CUs for DWARF64.
Sep 5 2019, 12:05 AM
ikudrin committed rL371016: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
[DWARF] Fix referencing Range List Tables from CUs for DWARF64.
Sep 5 2019, 12:05 AM
ikudrin closed D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
Sep 5 2019, 12:05 AM · Restricted Project, debug-info

Sep 4 2019

ikudrin committed rG991f0fb149a3: [DWARF] Support DWARF64 in DWARFListTableHeader. (authored by ikudrin).
[DWARF] Support DWARF64 in DWARFListTableHeader.
Sep 4 2019, 11:49 PM
ikudrin committed rL371014: [DWARF] Support DWARF64 in DWARFListTableHeader..
[DWARF] Support DWARF64 in DWARFListTableHeader.
Sep 4 2019, 11:49 PM
ikudrin closed D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Sep 4 2019, 11:49 PM · Restricted Project, debug-info
ikudrin updated the diff for D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
  • Remove redundant log files. Thanks, @MaskRay!
Sep 4 2019, 11:34 PM · Restricted Project, debug-info
ikudrin updated the diff for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
  • Use --implicit-check-not=error.
Sep 4 2019, 11:32 PM · Restricted Project, debug-info
ikudrin added a comment to D67097: [DWARF] Check for format mismatch between CU and Range List Table..

This update didn't seem to touch a test case - is this untested?

Sep 4 2019, 8:54 PM · Restricted Project, debug-info
ikudrin updated the diff for D67097: [DWARF] Check for format mismatch between CU and Range List Table..
  • Print the adjusted offset which points to the start of the header.
Sep 4 2019, 3:14 AM · Restricted Project, debug-info

Sep 3 2019

ikudrin added a comment to D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..

Ping.

Sep 3 2019, 10:30 PM · Restricted Project, debug-info
ikudrin added a comment to D67097: [DWARF] Check for format mismatch between CU and Range List Table..

I'm not sure if using "OffsetIn" in the diagnostic is the right thing to do.

Sep 3 2019, 10:30 PM · Restricted Project, debug-info
ikudrin added inline comments to D67097: [DWARF] Check for format mismatch between CU and Range List Table..
Sep 3 2019, 7:53 AM · Restricted Project, debug-info
ikudrin added a child revision for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader.: D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
Sep 3 2019, 7:24 AM · Restricted Project, debug-info
ikudrin added a parent revision for D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64.: D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Sep 3 2019, 7:24 AM · Restricted Project, debug-info
ikudrin created D67098: [DWARF] Fix referencing Range List Tables from CUs for DWARF64..
Sep 3 2019, 7:24 AM · Restricted Project, debug-info
ikudrin created D67097: [DWARF] Check for format mismatch between CU and Range List Table..
Sep 3 2019, 7:13 AM · Restricted Project, debug-info
ikudrin added a parent revision for D67097: [DWARF] Check for format mismatch between CU and Range List Table.: D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Sep 3 2019, 7:13 AM · Restricted Project, debug-info
ikudrin added a child revision for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader.: D67097: [DWARF] Check for format mismatch between CU and Range List Table..
Sep 3 2019, 7:13 AM · Restricted Project, debug-info

Aug 29 2019

ikudrin updated the diff for D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
  • Added a check for reserved values of the length field.
Aug 29 2019, 8:09 AM · Restricted Project, debug-info

Aug 23 2019

ikudrin created D66643: [DWARF] Support DWARF64 in DWARFListTableHeader..
Aug 23 2019, 5:06 AM · Restricted Project, debug-info

Aug 21 2019

ikudrin committed rGed413074f206: [DWARF] Adjust return type of DWARFUnit::getLength(). (authored by ikudrin).
[DWARF] Adjust return type of DWARFUnit::getLength().
Aug 21 2019, 7:11 AM