Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Thanks for the update! Just a few comments with regard to the test.
LGTM, with the suggested cleanup for the test. It would also be good to pre-commit the test and then have the diff only show the change caused by the patch.
llvm/test/Transforms/LoopVectorize/RISCV/force-vect-msg.ll | ||
---|---|---|
14 ↗ | (On Diff #440607) | Given that the LLVM IR is very compact I don't think the C code adds much and IMO it would be better to not include it. |
27 ↗ | (On Diff #440607) | Keep the comment next to the check? |
34 ↗ | (On Diff #440607) | this should not be needed, you can branch directly to either %for.body.preheader or %for.body. |
40 ↗ | (On Diff #440607) | IMO the test is easier to read if this exit block is at the end of the function |
clang-format not found in user’s local PATH; not linting file.